[01:37] <mup> PR snapd#9852 opened: gadget: enable multi-volume uc20 gadgets in  LaidOutVolumeFromGadget; rename too <Bug> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9852>
[01:42] <mup> PR snapd#9847 closed: cgroup-support.c: fix link to CGROUP DELEGATION <Simple 😃> <Skip spread> <Created by jonasdn> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9847>
[07:53] <mwhudson> is snapcraft release going to support releasing more that one revision at some point?
[08:05] <mborzecki> morning
[08:05] <mborzecki> pstolowski: hey
[08:05] <pstolowski> hey mborzecki
[08:09] <mup> PR snapd#9840 closed: interfaces/builtin: Allow DBus property access on org.freedesktop.Notifications <Created by kbroulik> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9840>
[08:59] <mup> PR snapd#9849 closed: tests/main/snap-network-errors: skip flushing dns cache on centos-7 <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9849>
[09:59] <mup> PR snapcraft#3425 opened: schema: add support for activates-on app property to schema <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3425>
[12:49] <ijohnson> hey mborzecki
[12:49] <mborzecki> ijohnson: hey
[12:49] <ijohnson> do you have thoughts on whether the sector size for i.e. uc20 should be dynamically determined at runtime or if we should just have the gadget specify it per-volume ?
[12:50] <ijohnson> having it specified in the gadget is potentially easier but also potentially requires more design input and so could take longer than just figuring it out ourselves when we need it
[12:50] <mborzecki> ijohnson: the problem you observed yesterday happened when installing uc20 on internal emmc right?
[12:50] <ijohnson> mborzecki: yes
[12:52] <mborzecki> ijohnson: hm it's not only that, if we increase block size, the size of journal will increase as well, so there will be less free space in ubuntu-save
[12:52] <mborzecki> s/free/usable free/
[12:52] <ijohnson> yeah I was wondering about that as well, but my initial patch just moves the block size up to the sector size if the sector size is specified
[12:52] <ijohnson> so for example on amd64 devices you wouldn't see any change
[12:53] <ijohnson> but on a device that has a sector size that is larger than 1024 (i.e. 4096 like this device) then we would set the block size
[12:54] <mborzecki> ijohnson: yeah, i suppose we could it this way
[12:54] <mborzecki> ijohnson: maybe we should have a check for some about of free space in ubuntu-save too
[12:54] <mborzecki> ijohnson: since the adjustment would happen at runtime, we should check it at that time too
[12:54] <ijohnson> yeah we could add some validation that is like "if sector size > 1024 && size < 10M" or something like that
[12:55] <ijohnson> mborzecki: what were your thoughts on dynamically detecting the sector size? I seem to recall something with using ioctl or something like that and it being racy?
[12:55] <mborzecki> ijohnson: iirc it's worse than that, with 4k block size journal is at least 4M, if you add encryption on top, maybe you'll have 5M of free space on 10MB partition
[12:56] <ijohnson> mborzecki: yeah I just meant whatever numbers make sense, I don't know what numbers make sense for such a check :-)
[12:56] <mborzecki> ijohnson: there was an ioctl you could use, but I don't think it's exposed in to go
[12:57] <mborzecki> just a sec, it was in the e2fsprogs code i linked yesterday
[12:58] <mborzecki> ijohnson: BLKSSZGET
[12:59] <ijohnson> cool
[13:01] <mborzecki> now we only need to device on the amount of free space we expect in ubuntu-save
[13:03] <ijohnson> mborzecki: seems that `sudo blockdev --getbsz /dev/sda` works and blockdev is in the core20 snap
[13:04] <mborzecki> ijohnson: ah, that's nice, can you also check what sfdisk reports for that block device?
[13:04] <ijohnson> sfdisk doesn't show the block size do you just want the sfdisk json ?
[13:04] <ijohnson> err s/block size/sector size/
[13:04] <ijohnson> https://www.irccloud.com/pastebin/EzSaIHf3/
[13:04] <mborzecki> ijohnson: both --dump and --json
[13:04] <ijohnson> ^
[13:05] <mborzecki> ijohnson: and --dump? :P
[13:05] <ijohnson> seems the same?
[13:05] <ijohnson> https://www.irccloud.com/pastebin/zNXzZeLf/
[13:06] <ijohnson> I ran `sudo sfdisk --dump --json /dev/sda`
[13:06] <mborzecki> ijohnson: just `sfdisk --dump`
[13:06] <ijohnson> ah I see what you mean
[13:07] <mborzecki> ijohnson: and if there's parted, please run `parted <dev> p` too
[13:07] <ijohnson> https://www.irccloud.com/pastebin/GgwC8Q30/
[13:07] <ijohnson> no parted, let me see if I can quick whip that into a devmode snap
[13:08] <mborzecki> ijohnson: funny how sfdisk doesn't even include sector size, maybe it's an older version, cause i see it in the output locally
[13:11] <ijohnson> yeah seems odd to me, the version of sfdisk I have in groovy outputs the sector-size as well
[13:11] <ijohnson> wait wat
[13:11] <ijohnson> ```
[13:11] <ijohnson> sfdisk: mutually exclusive arguments: --list-free --json --dump
[13:11] <ijohnson> ```
[13:19] <ijohnson> mborzecki: I got parted to run if you are curious
[13:19] <ijohnson> https://www.irccloud.com/pastebin/QSXfTkc4/
[13:19] <mborzecki> ha, nice
[13:19] <mborzecki> ijohnson: can you run `parted <dev> unit s p` ?
[13:20] <ijohnson> https://www.irccloud.com/pastebin/GKAlsL6o/
[13:21] <mborzecki> ijohnson: hah
[13:21] <mborzecki> ijohnson: so, sfdisk reports the sizes in units of 4096
[13:21] <mborzecki> ijohnson: and offsets too for that matter
[13:22] <ijohnson> right
[13:25] <mborzecki> ijohnson: are the partition sizes correct, do they match the gadget?
[13:25] <ijohnson> let me double check but yes they should be, since I just s/512/4096/ for all the sector sizes in snapd to get this board to install :-)
[13:27] <ijohnson> mborzecki: yeah it all lines up
[13:29] <mborzecki> hahah
[13:29] <mborzecki> wow, it's a bummer though that sfdisk does not report sector size it's using
[13:30] <ijohnson> yeah really sad, but I think using the blockdev command I showed above is probably good enough
[13:30] <mborzecki> and it's apparently the logical sector size that matters, parted and sfdisk show correct info on my 512/4096 disk
[14:31] <mborzecki> winter is so much fun, -25C on tuesday, +5C right now
[14:35] <pstolowski> indeed
[15:01]  * cachio lunch
[15:40] <zyga> good afternoon
[15:41]  * zyga was AFK for good part of the day
[15:41] <ijohnson> hey zyga
[15:41] <zyga> ijohnson, hey, I'll tar that up today, sorry, I had to be in the office all morning
[15:41] <ijohnson> no worries
[15:55] <mup> PR snapcraft#3426 opened: Ensure PYTHONPATH is properly set for gnome-3-34 builds <Created by kenvandine> <https://github.com/snapcore/snapcraft/pull/3426>