| mborzecki | morning | 07:11 |
|---|---|---|
| pstolowski | morning | 08:03 |
| mvo | good morning pstolowski | 08:13 |
| mborzecki | mvo: pstolowski: morning | 08:16 |
| mup | PR snapd#9864 closed: gadget/gadget.go: rename ubuntu-* to system-* in doc-comment <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9864> | 08:18 |
| mborzecki | mvo: i've restarted https://github.com/snapcore/snapd/pull/9771 beacuse of some random unrelated failures, if it fails again, it'd be great to use your superpowers and land it | 08:28 |
| mup | PR #9771: boot: boot config update & reseal <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9771> | 08:28 |
| mvo | mborzecki: sure | 08:34 |
| mup | PR snapd#9817 closed: cmd/snapd-generator: don't create mount overrides for snap-try snaps inside lxc <Bug> <Security-High> <Squash-merge> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9817> | 08:38 |
| pstolowski | yay | 08:39 |
| mvo | pstolowski: do you think you could have a look at 9844 should be simple | 08:43 |
| mvo | pstolowski: and yes, YAY :) | 08:43 |
| pstolowski | yay^2 re snapshots PR | 08:43 |
| pstolowski | mvo: sure will take a look | 08:43 |
| mup | PR snapd#9820 closed: o/snapshotstate: handle conflicts between snapshot forget, export and import <Squash-merge> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9820> | 08:43 |
| mup | PR snapd#9866 closed: osutil/stat.go: add RegularFileExists <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9866> | 08:43 |
| mvo | pstolowski: yeah, yay for finishing the snapshots, really nice, thanks again | 08:43 |
| pstolowski | mvo: i hope there are no more surprises there :} | 08:47 |
| pstolowski | mvo: one question to 9844 | 08:56 |
| mvo | pstolowski: thanks, looking | 08:56 |
| mborzecki | mvo: if amurray gets a chance to look at https://github.com/snapcore/snapd/pull/9865 soonish and it lands, maybe we could cherry pick that to 2.49? | 08:58 |
| mup | PR #9865: interfaces/browser-support: allow sched_setaffinity with browser-sandbox: true <Bug> <Needs security review> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9865> | 08:58 |
| mvo | mborzecki: +1 - I think it has 2.49 already | 09:01 |
| mborzecki | yeah, added the milestone there | 09:01 |
| mborzecki | pstolowski: replied under https://github.com/snapcore/snapd/pull/9844#pullrequestreview-577107365 | 09:20 |
| mup | PR #9844: cmd: make string/error code more robust against errno leaking <Created by mvo5> <https://github.com/snapcore/snapd/pull/9844> | 09:20 |
| mborzecki | mvo: meh, failed again, can you land https://github.com/snapcore/snapd/pull/9771 ? | 09:27 |
| mup | PR #9771: boot: boot config update & reseal <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9771> | 09:27 |
| pedronis | pstolowski: hi, is #9234 in your queue to look at again? | 09:29 |
| mup | PR #9234: systemd/systemd.go: support journald JSON messages with arrays for values <Bug> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9234> | 09:29 |
| pstolowski | pedronis: it escaped me, will look soon | 09:44 |
| === alan_g_ is now known as alan_g | ||
| mup | PR snapd#9771 closed: boot: boot config update & reseal <Run nested> <UC20> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9771> | 10:24 |
| mup | PR snapd#9862 closed: github, run-checks: do not collect coverage data on subsequent test runs <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9862> | 11:24 |
| cachio | ijohnson, hi | 11:46 |
| cachio | dis you see the failure again? | 11:46 |
| cachio | the one you reported yesterday | 11:46 |
| cachio | do you have a link? | 11:46 |
| mvo | pedronis, mborzecki we discussed reworking how we resolve the kernel refs internally yesterday and the idea of something like LaidOutContent came up, it seems we could/should use LaidOutContnet (and maybe rename), a draft is here http://paste.ubuntu.com/p/nTMkM84W86/ but I want to double check with you first as there will be quite a bit of work updating the tests etc. I think it's a nice route. I decided to not create ResolvedContent in parallel | 11:58 |
| mvo | to LaidOutContent as we will also want to resolve kernel refs for raw content so it seems like using the struct for both is ok. but happy to change my mind, doing two different structures has some other upsides too. no rush, I have lunch now :) but thoughts would be great | 11:58 |
| mvo | mborzecki, pedronis maybe a quick chat after the standup or so | 11:58 |
| amurray | mborzecki mvo: security review done on PR #9865 :) | 11:58 |
| mup | PR #9865: interfaces/browser-support: allow sched_setaffinity with browser-sandbox: true <Bug> <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9865> | 11:58 |
| * mvo hugs amurray | 11:58 | |
| mvo | amurray: thank you! | 11:58 |
| mborzecki | thanks amurray ! | 11:59 |
| amurray | well that was an easy one - I wish all <needs security review> were as straight forward :) | 11:59 |
| mup | PR snapd#9867 opened: overlord/devicestate: task for updating boot configs, spread test <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9867> | 12:29 |
| mborzecki | mvo: can you land https://github.com/snapcore/snapd/pull/9844 ? the failures on centos and arch are unrelated | 12:40 |
| mup | PR #9844: cmd: make string/error code more robust against errno leaking <Created by mvo5> <https://github.com/snapcore/snapd/pull/9844> | 12:40 |
| cachio | ijohnson, there?= | 12:42 |
| ijohnson | hey cachio I'll be around a bit later | 12:46 |
| cachio | ijohnson, ok, thanks | 12:51 |
| cachio | I'll ping you later | 12:51 |
| mup | PR snapd#9844 closed: cmd: make string/error code more robust against errno leaking <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9844> | 12:59 |
| * pstolowski bbiab | 13:17 | |
| mup | PR snapd#9868 opened: tests: fix umount for snapd snap on fsck-on-boot test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9868> | 13:40 |
| mup | PR snapd#9869 opened: cmd: make string/error code more robust against errno leaking (2.49) <Created by mvo5> <https://github.com/snapcore/snapd/pull/9869> | 13:45 |
| pstolowski | re | 13:50 |
| mup | PR snapd#9234 closed: systemd/systemd.go: support journald JSON messages with arrays for values <Bug> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9234> | 13:55 |
| mvo | pedronis: I pushed a PR with the go-tpm2 update | 15:49 |
| mup | PR snapd#9870 opened: vendor: update go-tpm2 to latest version <Created by mvo5> <https://github.com/snapcore/snapd/pull/9870> | 15:50 |
| * cachio lunch | 15:57 | |
| mup | PR snapd#9871 opened: daemon: move query /snaps/<name> tests to api_snaps_test.go <Cleanup :broom:> <Skip spread> <Created by pedronis> <https://github.com/snapcore/snapd/pull/9871> | 16:20 |
| mup | PR snapd#9858 closed: cmd/snap-repair/runner.go: add SNAP_SYSTEM_MODE to env of repair runner <Simple 😃> <UC20> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9858> | 16:30 |
| mup | PR snapd#9871 closed: daemon: move query /snaps/<name> tests to api_snaps_test.go <Cleanup :broom:> <Skip spread> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9871> | 17:21 |
| === strohalm is now known as strohi | ||
| pedronis | ijohnson: I commented again/asked a question on https://github.com/snapcore/snapd/pull/9784/files#r565499762 | 17:33 |
| mup | PR #9784: interfaces/builtin/network-setup-{control,observe}: allow using netplan directly <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9784> | 17:33 |
| ijohnson | pedronis: ack I'll have a look | 17:33 |
| mup | PR snapcraft#3415 closed: cli: enable SNAPCRAFT_TARGET_ARCH envvar matching --target-arch <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3415> | 17:54 |
| mup | PR snapcraft#3267 closed: ci: re-enable appveyor artifact collection <tooling> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3267> | 17:59 |
| hardwire | How doth one go about utilizing snap when building docker images? I'm trying to get chromedriver installed and it is only available via snap which is messing with automation a bit. | 18:30 |
| mup | PR snapcraft#3432 opened: spread tests: remove legacy plugin tests <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3432> | 18:39 |
| mup | PR snapcraft#3433 opened: Allow revoking validation assertions (LP: #1912332) <Created by nessita> <https://github.com/snapcore/snapcraft/pull/3433> | 20:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!