=== Kamilion|ZNC is now known as Kamilion
=== Wouter01000 is now known as Wouter0100
[06:38] <mborzecki> morning
[07:17] <zyga> good morning
[07:31] <mborzecki> school run
[07:59] <mborzecki> re
[08:03] <zyga> debian is in freeze mode
[08:03] <zyga> hey mvo
[08:03] <mvo> good morning zyga
[08:06] <pstolowski> morning
[08:06] <mvo> good morning pstolowski
[08:09] <mborzecki> mvo: pstolowski: hey
[08:09] <mvo> hey mborzecki !
[08:10] <zyga> hey pstolowski
[08:10] <zyga> long time no see
[08:10] <pstolowski> hey zyga, indeed
[08:55] <mup> PR snapd#9877 closed: tests: run unit tests in Focal instead of Xenial <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9877>
[10:00] <mup> PR snapd#9856 closed: gadget,overlord: pass kernelRoot to install.Run() <UC20> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9856>
[11:31] <mborzecki> mvo: i've pushed one more commit to https://github.com/snapcore/snapd/pull/9744 with some links to nvidia documentation (or scraps thereof)
[11:31] <mup> PR #9744: OpenGL interface: Support more Tegra libs <Squash-merge> <Created by om26er> <https://github.com/snapcore/snapd/pull/9744>
[11:41] <mvo> mborzecki: nice, thanks!
[11:46] <mup> PR snapd#9881 opened: tests/unit/go: drop unused environment variables, skip coverage <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9881>
[11:48] <mborzecki> pstolowski: mvo: can you take a look? ^^ should be a trivial one
[11:49] <mvo> ta
[11:52] <pstolowski> mborzecki: a question there
[12:24]  * pstolowski lunch
[12:26] <mup> PR snapd#9874 closed: gadget: remove resolvedSource from VolumeContent <UC20> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/9874>
[13:21] <mup> PR snapd#9882 opened: spread: use full format when listing processes <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9882>
[14:47] <mup> PR snapd#9744 closed: OpenGL interface: Support more Tegra libs <Squash-merge> <Created by om26er> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9744>
[14:51] <mborzecki> mvo: i think we can land https://github.com/snapcore/snapd/pull/9870
[14:51] <mup> PR #9870: vendor: update go-tpm2/secboot to latest version <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9870>
[14:53]  * cachio lunch
[15:52] <mup> PR snapd#9881 closed: tests/unit/go: drop unused environment variables, skip coverage <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9881>
[16:17] <mup> PR snapd#9883 opened: cmd/snap-preseed: initialize snap.SanitizePlugsSlots for gadget in seeds <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9883>
[16:30] <ijohnson> pstolowski: mvo: I managed to reproduce the services regression with a simple test snap, working on a fix now
[16:31] <pstolowski> ijohnson: that's great, thanks for digging into it!
[16:34] <pstolowski> ijohnson: also, i'll be happy to review
[16:35] <ijohnson> pstolowski: of course :-) I'm trying to get a handle on the issue, it seems to be a corner case of the SortSnapServices function when one list is empty and the other is not
[16:36] <pstolowski> ijohnson: mhm.. yeah i'm keen to see what that is, i'm sure we have *some* tests for snapctl for services
[16:45] <ijohnson> pstolowski: so the issue seems to be when we have a daemon which specifies a before/after and we call `snapctl restart daemon`, what happens is the set of appInfo's that is passed to SortSnapServices references another daemon that is not in the set (i.e. in snap.yaml daemon says `after: daemon2`, but daemon2 is not specified with `snapctl restart daemon`)
[16:46] <ijohnson> I think I have a fix, which is to ignore before/after daemons that are referenced in the set of appInfo's, but not actually present in the set provided to SortSnapServices
[16:46] <ijohnson> then you can still do `snapctl restart daemon daemon2` and have things be ordered correctly I think
[16:47] <pstolowski> ijohnson: hmm ok i see
[16:47] <ijohnson> though actually I wonder if snapctl supports multiple daemons being specified
[16:47] <mup> PR snapd#9879 closed: osutil/many: make all test pkgs osutil_test instead of "osutil" <Cleanup :broom:> <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9879>
[16:47] <mup> PR snapd#9882 closed: spread: use full format when listing processes <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9882>
[16:50] <pstolowski> ijohnson: looking at ctlcmd/*.go, it does
[16:50] <ijohnson> right
[17:21] <pstolowski> i hope we do test it somewhere
[20:16] <ijohnson> hey cachio could you share instructions on how to run the external uc20-recovery test again ?
[20:20] <cachio> hey
[20:21] <cachio> export SPREAD_EXTERNAL_ADDRESS=<IP>
[20:22] <cachio> ./tests/lib/external/prepare-ssh.sh <IP> <PORT> <LP_ID>
[20:23] <cachio> spread external:ubuntu-core-20-64:tests/core/uc20-recovery
[20:23] <cachio> that should be enough
[20:23] <cachio> I need to go out now
[20:24] <cachio> I'll be here in 10 minutes
[20:24] <cachio> ijohnson, ~
[20:24]  * cachio afk
[20:24] <ijohnson> thanks cachio
[20:24] <cachio> ijohnson, np
[20:28] <mup> PR snapd#9884 opened: tests/main/snap-repair: test running repair assertion w/ fakestore  <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9884>
[21:08] <mup> PR snapd#9885 opened: snap/info.go: ignore unknown daemons in SortSnapServices <Bug> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9885>
=== King_InuYasha is now known as Conan_Kudo
=== Conan_Kudo is now known as King_InuYasha
=== King_InuYasha is now known as Conan_Kudo
=== Conan_Kudo is now known as King_InuYasha