| otubo | smoser: blackboxsw hey guys, was busy last week but was able to update the PR#721, can take a quick look at it if it's missing anything else? Thanks a lot :) | 09:34 |
|---|---|---|
| === cpaelzer__ is now known as cpaelzer | ||
| oshoval | Hi, NetworkData is always performed before UserData ? in other words, if UserData did the last line of it, i can be sure that NetworkData was already finished ? Thanks | 15:01 |
| oshoval | (without looking on boot-finished) | 15:02 |
| Odd_Bloke | oshoval: User data is applied to the system by various config modules (https://cloudinit.readthedocs.io/en/latest/topics/modules.html is the full list). These run at different points in boot for a variety of reasons; one important one you've identified is that some require networking whereas others don't. The modules that run in the `init` stage will run before networking is up. The modules which run | 15:06 |
| Odd_Bloke | in the init stage are configured in /etc/cloud/cloud.cfg; you can see the template used to generate that file upstream here (with the appropriate lines highlighted): https://github.com/canonical/cloud-init/blob/master/config/cloud.cfg.tmpl#L55-L82 | 15:06 |
| Odd_Bloke | oshoval: So: no, network configuration is not always performed before user-data is processed. :) | 15:06 |
| oshoval | Odd_Bloke: Thanks :) | 15:09 |
| Odd_Bloke | :) | 15:18 |
| rharper | focal daily ppa isn't happy: Reading package lists... | 16:49 |
| rharper | W: GPG error: http://ppa.launchpad.net/cloud-init-dev/daily/ubuntu focal InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 083D06FBE4D304DF | 16:49 |
| rharper | E: The repository 'http://ppa.launchpad.net/cloud-init-dev/daily/ubuntu focal InRelease' is not signed. | 16:49 |
| Odd_Bloke | rharper: A rebuild earlier fixed that, I think. | 17:03 |
| rharper | Ah, ok; thanks | 17:04 |
| minimal | hi folks. is the release going ahead today? | 17:12 |
| Odd_Bloke | minimal: Yep, we're lining up a couple of last things to perhaps land currently. | 17:23 |
| minimal | Odd_Bloke: any chance you could look at #817? Its minor so no fuss if it doesn't make this releases - equally as its minor it would be easy to slip into the release :-) | 17:27 |
| meena | ah, it's time for my birthday release, and i didn't even do anything for it. | 17:27 |
| Odd_Bloke | minimal: I think it's going to miss, I'm afraid; I recall conversations around modifying that output before and IIRC there were concerns about changing that logger name. We probably _can_ do it, but I think we'll regret slipping it in before getting to the bottom of that. | 17:30 |
| minimal | Odd_Bloke: no problem. Just noticed your comment on #811. Don't actually think they're compilimentary - there's no need to add a new config to disable the output completely when it can be achieved using existing config if #817 is applied. | 17:33 |
| minimal | perhaps add a new value for ssh_fp_console_blacklist and ssh_key_console_blacklist of "all" then? | 17:35 |
| Odd_Bloke | minimal: I'm not super-keen on having a magic string (albeit a fairly straighforward one); YAML has a boolean type, which more closely matches what we want here. We'd also need to consider special handling so that people passing `ssh_fp_console_blacklist: all` don't end up disabling "a", "l" and "l" (and therefore, of course, disabling nothing). | 17:57 |
| Odd_Bloke | Oh, let me reply on the PR. | 17:59 |
| minimal | Odd_Bloke: Thanks. Your call, just though that "all" was a logical case of a "which keys do you want to blacklist" setting | 17:59 |
| Odd_Bloke | minimal: Your input is much appreciated. :) You can reserve the right to say I told you so. ;)# | 18:03 |
| minimal | Odd_Bloke: you get paid the big bucks to make the important decisions ;-) | 18:04 |
| Odd_Bloke | falcojr: I've pushed integration tests to https://github.com/canonical/cloud-init/pull/811; could you take another look? | 19:03 |
| falcojr | Odd_Bloke: approved with nit | 19:14 |
| Odd_Bloke | Thanks! | 19:22 |
| Odd_Bloke | falcojr: I'm seeing one of those integration tests on #800 fail for me locally, I'm investigating. | 20:26 |
| falcojr | Odd_Bloke: I had to build a deb and set it as CLOUD_INI_SOURCE first | 20:31 |
| falcojr | *CLOUD_INIT_SOURCE | 20:31 |
| Odd_Bloke | Yep, have done that. | 20:31 |
| Odd_Bloke | (_Both_ fail if you don't. :p) | 20:32 |
| falcojr | heh, good point | 20:32 |
| Odd_Bloke | I'm also not seeing /tmp/cloud_init_logs populated for these tests. | 20:33 |
| falcojr | hmmm, yeah, that's part of the client fixture...we should probably move that somewhere else | 20:35 |
| Odd_Bloke | Aha, right, that'd explain it. | 20:38 |
| Odd_Bloke | We probably need to spend a bit of time working out what the interface for non-client-fixture tests look like: we have a good selection to consider now. | 20:38 |
| Odd_Bloke | (`setup_image` being the other rough edge.) | 20:39 |
| falcojr | yep...we kind of YOLOed it as we went | 20:39 |
| Odd_Bloke | falcojr: Remember how there's a pycloudlib change required for these tests. *facepalm* | 20:40 |
| falcojr | hah, was gonna mention that at first but didn't think one would pass without it | 20:41 |
| falcojr | Odd_Bloke: wait before running a new test | 20:41 |
| falcojr | about to push a commit that adds looking for devices/mounts | 20:41 |
| Odd_Bloke | falcojr: Will do; yeah, the hardcoded instance type works for one of them. | 20:42 |
| falcojr | Odd_Bloke: commit pushed, please review too :) | 20:43 |
| Odd_Bloke | falcojr: Reviewed. :) | 20:48 |
| * falcojr puts on regex hat | 20:49 | |
| Odd_Bloke | falcojr: `readlink` may be your friend for this? | 20:49 |
| Odd_Bloke | Or maybe `realpath` is better, according to readlink's manpage. | 20:50 |
| falcojr | ah yeah, that will be. Thanks! | 20:50 |
| === bswinnerton8 is now known as bswinnerton | ||
| hggdh | folks, CX has finally approved posting the cloud-init logs on bug 1913354 | 21:20 |
| ubot5 | Error: Launchpad bug 1913354 could not be found | 21:20 |
| falcojr | Odd_Bloke: updated | 21:37 |
| Odd_Bloke | falcojr: Your review of https://github.com/canonical/cloud-init/pull/820/ for would be great; I think we probably also want blackboxsw to take a look too, given that this is my first time driving the process. | 22:14 |
| Odd_Bloke | "for would" forsooth | 22:15 |
| Odd_Bloke | falcojr: https://github.com/canonical/uss-tableflip/blob/master/doc/upstream_release_process.md is the process I've followed, to review I'd expect you to do the same and confirm that the output looks as I've pushed (modulo the described manual modifications). | 22:16 |
| falcojr | will do | 22:17 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!