| mup | PR snapd#9965 opened: sysconfig, o/configstate/configcore: first step to image build pi-config application <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9965> | 00:06 |
|---|---|---|
| mup | PR snapd#9955 closed: .github/workflows/labeler.yaml: try work-around to not sync labels <Run nested> <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9955> | 00:21 |
| mup | PR snapd#9966 opened: many: fix new ineffassign warnings <Simple 😃> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9966> | 00:21 |
| mup | PR snapd#9967 opened: tests: use a pre built govendor dependencies for opensuse tumbleweed <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9967> | 01:11 |
| jamesh | looks like https://github.com/gordonklaus/ineffassign got an update that catches some new ineffective assignments in our code, breaking CI | 02:31 |
| jamesh | and anonymouse64 already has a fix :-) | 02:39 |
| ijohnson | :-) | 02:39 |
| jamesh | do we need to wait for someone else to wake up before merging it? | 02:41 |
| ijohnson | jamesh: the PR is green so I will tag it critical and make sure that EU folks merge it first thing in their morning, I generally try not to merge things that don't have 2 +1's unless it's really critical to land other things | 03:45 |
| jamesh | ijohnson: fair enough | 03:45 |
| ijohnson | jamesh: are you blocked on trying to merge something ? | 03:46 |
| jamesh | ijohnson: more wanting to see CI results on one of my own PRs. I guess I could just merge your change though. | 03:46 |
| ijohnson | jamesh: ah ok, I guess this should be safe to merge, I will merge it now then | 03:47 |
| ijohnson | jamesh: ok merged, that's it for me tonight, ttyl | 03:49 |
| jamesh | ijohnson: thanks! | 03:49 |
| mup | PR snapd#9966 closed: many: fix new ineffassign warnings <Simple 😃> <Skip spread> <⚠Critical> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9966> | 03:52 |
| mup | PR snapd#9968 opened: cmd/snap-bootstrap/triggerwatch: fix returning wrong errors <Created by tsunghanliu> <https://github.com/snapcore/snapd/pull/9968> | 06:47 |
| zyga | good morning | 07:02 |
| zyga | mvo, good morning | 09:01 |
| jamesh | mvo: fyi: we merged https://github.com/snapcore/snapd/pull/9966 with only one review earlier today: there was an ineffassign update that started catching some new cases in the code base, causing all CI runs to fail | 09:04 |
| mup | PR #9966: many: fix new ineffassign warnings <Simple 😃> <Skip spread> <⚠Critical> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9966> | 09:04 |
| mvo | jamesh: yeah, thanks for unblocking master! I will cherry pick to 2.49 as well | 09:05 |
| jamesh | mvo: thank ijohnson -- he'd submitted the PR before I'd started work. | 09:07 |
| jamesh | (was half way through making my own PR) | 09:07 |
| mup | PR snapd#9961 closed: mkversion: check that version from changelog is set before overriding the output version <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9961> | 09:13 |
| mup | PR snapd#9917 closed: interfaces: opengl: add Xilinx zocl bits <Created by alfonsosanchezbeato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9917> | 09:18 |
| pedronis | mvo: I reviewed #9907, I think some detail doesnt' quite much yet what we discussed | 09:31 |
| mup | PR #9907: gadget,devicestate: perform kernel asset update for $kernel: style refs <UC20> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9907> | 09:31 |
| pedronis | s/much/match/ | 09:31 |
| mvo | pedronis: sorry for that, thanks for the review, I check it out | 09:32 |
| pedronis | mvo: is #9914 ready for review or you still working on it? | 09:32 |
| mup | PR #9914: image: write resolved-content from snap prepare-image <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9914> | 09:32 |
| mvo | pedronis: this is ready now I think, ian played with it and it's doing what he needs it seems | 09:32 |
| pedronis | ok | 09:33 |
| pedronis | let me know if you have questions about 9907 | 09:34 |
| mvo | pedronis: thanks, 9907 is fine, your comments make sense, it's not doing the new things we discussed yet, I wanted to do that in a followup to keep things managable, it's already 800 lines :) but indeed, next step will do the checks we discussed | 09:48 |
| pedronis | mvo: reviewed #9914, mostly minor comments | 11:12 |
| mup | PR #9914: image: write resolved-content from snap prepare-image <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9914> | 11:12 |
| mvo | \o/ thanks | 11:16 |
| * cachio afk | 12:25 | |
| mup | PR snapd#9876 closed: interfaces: add allegro-vcu and media-control interfaces <Squash-merge> <Created by alfonsosanchezbeato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9876> | 12:29 |
| zyga | mvo, is gif in 10 minutes or in an hour and ten minutes? | 13:52 |
| mvo | zyga: 1h10min | 13:52 |
| zyga | mvo, cool, I'll grab some food then | 13:54 |
| zyga | :-) | 13:54 |
| zyga | see you there | 13:54 |
| mvo | zyga: see you | 13:55 |
| * cachio lunch | 15:05 | |
| === ijohnson is now known as ijohnson|lunch | ||
| === ijohnson|lunch is now known as ijohnson | ||
| mup | PR snapd#9969 opened: interfaces/wayland: mv Xwayland Xauth file access to x11 slot <Needs security review> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9969> | 21:56 |
| mup | PR snapcraft#3451 opened: python v2 plugin: fix multiple python parts with staged python <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3451> | 22:10 |
| mup | PR pc-amd64-gadget#52 opened: hopefully make this snap buildable in and out of launchpad <Created by xnox> <https://github.com/snapcore/pc-amd64-gadget/pull/52> | 22:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!