[00:45] <mup> PR snapcraft#3455 opened: python v2 plugin: filter set options to reduce output noise <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3455>
[00:55] <mup> PR snapcraft#3456 opened: python v2 plugin: reduce noise by replacing for-loop with xargs <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3456>
[03:05] <mup> PR snapd#9975 opened: tests: fix new tumbleweed image <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9975>
[07:01] <pstolowski> morning
[07:04] <mborzecki> morning
[07:22] <dot-tobias> morning
[07:22] <zyga-mbp> good morning
[07:22]  * zyga-mbp will make a snapd patch today
[07:39] <pstolowski> hey zyga-mbp
[07:40] <zyga-mbp> hey pstolowski :)
[07:54] <zyga-mbp> mvo good morning
[07:54] <zyga-mbp> mvo do you remember the nfs home and special workarounds
[07:54] <zyga-mbp> there's another case of that with nsswitch and ldap and home directory being defined by a ldap entry
[07:55] <zyga-mbp> mvo would it be okay to enable the nfs workaround when nsswitch has an ldap entry?
[07:55] <zyga-mbp> I can provide the patch
[08:01] <mup> PR snapd#9957 closed: ovelord/snapshotstate: keep a few of the last line tar prints before failing <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9957>
[08:03] <mvo> zyga-mbp: oh, interessting. what exactly was it we did for nfs homes? I vaguely remember
[08:03] <mvo> zyga-mbp: fwiw, I think it makes sense, without this the user can't use snaps at all, yes?
[08:03] <zyga-mbp> mvo: there are two components, we use some heuristics to detect that nfs home is likely to be used by looking at /etc/fstab and the mount table
[08:03] <zyga-mbp> mvo and when that is detected we update the apparmor profile of all snaps and helper tools
[08:04] <zyga-mbp> mvo: without this they get network errors on all snaps, apparmor has a bug where it exposes the fact that something uses nfs as network traffic on behalf of the process
[08:04] <zyga-mbp> this is bug https://bugs.launchpad.net/snapd/+bug/1917348
[08:04] <mup> Bug #1917348: NFS access not permitted for snap's on LDAP autofs system <snapd:In Progress by zyga> <https://launchpad.net/bugs/1917348>
[08:05] <zyga-mbp> I wanted to chat before spending more time on it
[08:08] <mborzecki> zyga-mbp: iirc we did some workarounds in the s-c profile? is this you're referring to?
[08:08] <mborzecki> mvo: hey
[08:08] <zyga-mbp> it's both snap-confine and actual snaps
[08:09] <zyga-mbp> the workaround is okay and doesn't need changes
[08:09] <zyga-mbp> only the heuristics needs to grow to check for ldap
[08:09] <mvo> hey mborzecki
[08:09] <mvo> zyga-mbp: yeah, I think the reporter has a point
[08:11] <zyga-mbp> mvo okay, I'll send a patch either tonight or tomorrow
[08:11] <zyga-mbp> thanks!
[08:12] <mvo> thank you!
[08:18] <mborzecki> mvo: can you merge #9962, the failure on 20.04 is unrelated?
[08:18] <mup> PR #9962: asserts: include the assertion timestamp in error message when outside of signing key validity range <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9962>
[08:18] <mvo> mborzecki: sure
[08:18] <mborzecki> thanks!
[08:21] <mup> PR snapd#9962 closed: asserts: include the assertion timestamp in error message when outside of signing key validity range <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9962>
[08:21] <mup> PR snapd#9972 closed: daemon: move the last api_foo_test.go to daemon_test <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9972>
=== pedronis_ is now known as pedronis
[08:33] <zyga-mbp> another day, another small spread patch
[08:34] <zyga-mbp> niemeyer_ do you have a moment to look at https://github.com/snapcore/spread/pull/112
[08:34] <mup> PR spread#112: Bump base version of go to 1.13 <Created by zyga> <https://github.com/snapcore/spread/pull/112>
[08:34] <zyga-mbp> niemeyer_ it will unblock some other patches
[09:01] <mup> PR snapd#9976 opened: tests/unit/go: use tests.session wrapper for running tests as a user <Simple 😃> <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9976>
[09:28] <mborzecki> mvo: little tweaks in https://github.com/snapcore/snapd/pull/9970#pullrequestreview-601601464
[09:28] <mup> PR #9970: packaging: drop 99-snapd.conf via dpkg-maintscript-helper <Created by mvo5> <https://github.com/snapcore/snapd/pull/9970>
[10:01] <mup> PR snapd#9977 opened: bootloader/lkenv: add recovery systems related variables <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9977>
[10:34] <pstolowski> pedronis: #9930 is green, any preference for squash-merging or not?
[10:34] <mup> PR #9930: asserts: pool changes for validation-sets <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9930>
[11:05] <pedronis> pstolowski: as you prefer, if you think history is too messy I'm fine if you want to squash-merge it
[11:08] <pstolowski> pedronis: ok thanks
[11:12] <mup> PR snapd#9930 closed: asserts: pool changes for validation-sets <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9930>
[12:25] <pedronis> pstolowski: did you squash the other one? maybe now you need to rebase the follow-ups
[12:26] <pstolowski> pedronis: i didn't, you're right i probably need to rebase -i
[12:45] <pstolowski> pedronis: it turned out too messy, i reopened as #9978
[12:45] <mup> PR #9978: asserts: use Fetcher in AddSequenceToUpdate <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9978>
[12:46] <mup> PR snapcraft#3456 closed: python v2 plugin: reduce noise by replacing for-loop with xargs <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3456>
[12:46] <pedronis> pstolowski: ok
[12:47] <mup> PR snapd#9964 closed: asserts: use Fetcher in AddSequenceToUpdate <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/9964>
[12:47] <mup> PR snapd#9978 opened: asserts: use Fetcher in AddSequenceToUpdate <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9978>
[12:47] <pedronis> pstolowski: would it be too hard to do two commits? one with the other changes, and one with the new functionality
[12:48] <pstolowski> pedronis: probably not, let me try
[12:48] <pedronis> thx
[13:07] <mup> PR snapd#9942 closed: boot: helper for checking and marking tried recovery system status from initramfs <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/9942>
[13:10] <pstolowski> pedronis: done
[13:12] <pstolowski> nb. git add -p <file> is pretty useful for that in case that helps anyone in the future
[13:12] <mborzecki> pedronis: now that 9942 landed, i've pushed an update to #9940 and it needs reviews
[13:12] <mup> PR #9940:  boot: cmd/snap-bootstrap: handle a candidate recovery system v2 <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9940>
[13:12] <mborzecki> pstolowski: magit ftw ;)
[13:14] <pstolowski> :)
[13:40] <pedronis> mborzecki: ok, what's the state of #9921, I forgot?
[13:40] <mup> PR #9921: boot: helper for setting up a try recover system  <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9921>
[13:48] <mborzecki> pedronis: i've just pushed an update there
[14:21] <mup> PR snapcraft#3457 opened: porting conda plugin from v1 to v2 so we can use it in core20 <Created by ycheng> <https://github.com/snapcore/snapcraft/pull/3457>
[14:31] <mup> PR snapcraft#3455 closed: python v2 plugin: filter set options to reduce output noise <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3455>
[14:46] <ijohnson> pstolowski: I approved #9978
[14:46] <mup> PR #9978: asserts: use Fetcher in AddSequenceToUpdate <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9978>
[14:49]  * cachio lunch
[15:12] <mup> PR snapd#9910 closed: client, o/servicestate: expose enabled state of user daemons <Needs Samuele review> <Created by jhenstridge> <Merged by jhenstridge> <https://github.com/snapcore/snapd/pull/9910>
[15:37] <mup> PR snapd#9971 closed: daemon,o/c/configcore: introduce users.create.automatic <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/9971>
[15:43] <pstolowski> ijohnson: thank you!
[16:46] <pedronis> pstolowski: I made a code org comment in #9559, if I remember correctly how things were meant to be structured
[16:46] <mup> PR #9559: client, daemon, cmd/snap: cleanups from #9489 + more unit tests <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/9559>
[16:46] <ijohnson> you ok mup ?
[16:46] <ijohnson> that pr was merged 4 months ago
[16:47] <ijohnson> oh I see must have been wrong pr number from pedronis comment
[16:47] <pedronis> yes, I meant #9959
[16:47] <mup> PR #9959: o/snapstate: update validation sets assertions with auto-refresh <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9959>
[16:47] <pstolowski> pedronis: thanks
[16:47] <pedronis> sorry
[16:48] <ijohnson> no worries, I just got a notification about a mention from mup and was very confused since it says I merged that PR and I didn't recall merging any pr's today
[16:53] <mup> PR snapd#9979 opened: packaging/ubuntu-16.04/rules: turn modules off explicitly <Simple 😃> <⚠ Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9979>
[16:55] <ijohnson> ^ should fix hirsute spread test runs, which are currently entirely broken
[17:08] <mup> PR snapd#9980 opened: o/devicestate: test that users.create.automatic is configured early <Created by pedronis> <https://github.com/snapcore/snapd/pull/9980>
[17:23] <mup> PR snapd#9981 opened: gadget: policy for gadget/kernel refreshes <Created by mvo5> <https://github.com/snapcore/snapd/pull/9981>
[17:23] <mvo> pedronis: fwiw, I pushed a draft with the refresh policy for gadget/kernel (9981), needs the second part still but let me know if it heads into the wrong direction or if I misunderstood anything. there is a comment in update.go with the checks we need to do
[17:29] <pedronis> mvo: I looked at the comment (only) and it matches what we discussed
=== ijohnson is now known as ijohnson|lunch
[19:25] <mvo> pedronis: 9981 now has the gadget part of the policy and a manager test that tests going from the old to the new world end-to-end. still some unit tests missing but it should be ok for a first look, especially the manager test. the first auto-refresh will error on the kernel but the subsequent auto-refresh will pull it in
[19:26] <mvo> pedronis: anyway, not urgent but some progress at least :)
[19:53] <mup> PR snapd#9967 closed: tests: use a pre built govendor dependencies for opensuse tumbleweed <⛔ Blocked> <Created by sergiocazzolato> <Closed by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9967>
[20:00]  * cachio afk
=== ijohnson|lunch is now known as ijohnson
[21:44] <mup> PR snapd#9983 opened: tests: use new commands of os.query tool on tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9983>
[21:53] <mup> PR snapcraft#3458 opened: requirements: pip freeze <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3458>
[21:58] <mup> PR snapcraft#3459 opened: repo: account for arch & version when filtering stage packages <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3459>
[22:49] <mup> PR snapd#9984 opened: boot/flags.go: add SetNextBootFlags, NextBootFlags for snapd_next_boot_flags bootenv <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9984>