[07:07] <mborzecki> morning
[07:09] <zyga> good morning
[07:10] <zyga> hey mborzecki, mvo
[07:10] <zyga> Friday :)
[07:10] <mvo> zyga, mborzecki good morning!
[07:10] <mborzecki> hey guys
[07:10] <mborzecki> yeah, friday finally
[07:11] <zyga> mborzecki I spent some time on DCO checks recently
[07:11] <zyga> developer certificate of origin
[07:12] <zyga> sent some patches to https://github.com/christophebedard/dco-check/ which seems like a nice solution in _any_ CI
[07:13] <zyga> today is hopefully a slower day, I want to send some stuff to Debian for review / sponsorship
[07:13] <zyga> mostly python stuff related to REUSE
[07:13] <zyga> but I can check if spread is ready as well
[07:13] <zyga> (in the sense of dependencies)
[07:15] <mborzecki> zyga: hm it checks for signed-off-by in all commits?
[07:16] <zyga> in the relevant range
[07:16] <zyga> so new pushes
[07:16] <zyga> or what's in the MR
[07:16] <zyga> yeah
[07:16] <zyga> it's fairly nice and supports github and gitlab natively
[07:16] <zyga> (as in getting relevant information about the context before asking git anything)
[07:16] <mup> PR snapd#9998 closed: tests: turn modules off explicitly in spread go unti test (2.49) <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9998>
[07:16] <zyga> I've prepared a Debian package, fixed some things and maintain a minimal container
[07:17] <zyga> one of the things to upstream, but I think the last big bug needs fixing, and one more release is needed if you want to use it on a non-free gitlab instance with all the PR features it offers
[07:21] <mvo> mborzecki: 9976 has a conflict now
[07:21] <mup> PR snapd#9983 closed: tests: use new commands of os.query tool on tests <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9983>
[07:21] <mup> PR snapd#9990 closed: tests: fix tumbleweed spread tests part 2 <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9990>
[07:21] <mup> PR snapd#9993 closed: tests/lib/prepare.sh: use /etc/group and friends from the core20 snap  <Simple 😃> <Test Robustness> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9993>
[07:22] <mborzecki> mvo: ah, the tweak from ian landed, that's fine it should be a quick update
[07:23] <mvo> mborzecki: thank you! I want to push the PR count below 70 again today :)
[07:27] <mborzecki> mvo: and pushed
[07:48] <mborzecki> mvo: we should be able to land 2 more of my prs when the tests finish
[07:50] <mvo> mborzecki: yeah and a bunch of sergios stuff is relatively easy to review/land
[08:05] <pstolowski> morning
[08:12] <mup> PR snapd#10003 opened: configstate: add config options for systemd-networkd and systemd-resolved <Created by woodrow-shen> <https://github.com/snapcore/snapd/pull/10003>
[08:12] <mvo> good morning pstolowski
[08:17] <mup> PR snapd#10002 closed: gadget: simplify filterUpdate (thanks to Maciej) <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10002>
[08:19] <mborzecki> mvo: some comments in https://github.com/snapcore/snapd/pull/10000
[08:19] <mup> PR #10000: client: protect against reading too much data from stdin <Created by mvo5> <https://github.com/snapcore/snapd/pull/10000>
[08:19] <mborzecki> and wow, what a nice round PR #
[08:19] <mborzecki> pstolowski: hey
[08:26] <mborzecki> hmm our tests queue is a bit long atm apparently
[08:37] <zyga> mborzecki spawn more overlords, er... workers
[08:40] <zyga> mvo I plan to EOD early for day job today and look at https://github.com/snapcore/snapd/pull/9999
[08:40] <mup> PR #9999: snapstate: add "kernel-assets" to featureSet <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9999>
[08:40] <zyga> is this something I can test in practice or are some other pieces still unalinged?
[08:41] <mvo> zyga: we have no kernel/gadget yet but it's on my list for today
[08:41] <zyga> I would love to do a "field" upgrade of the broken PI
[08:41] <zyga> to all-new set
[08:41] <mvo> zyga: I plan to create updated gadget/kernel and then also update ubuntu-image
[08:41] <zyga> do we know if it will work in one reboot "hop??
[08:41] <zyga> "?
[08:41] <zyga> oh
[08:41] <mvo> zyga: it will require two updates
[08:41] <zyga> right, more pieces
[08:42] <zyga> mvo two reboots or two updates?
[08:42] <mvo> zyga: but I think the gadget is a non-reboot one
[08:42] <mvo> zyga: so I *think* it's just one reboot
[08:42] <zyga> the reason I'm asking is that for everythting to work it has to be in sync with the kernel
[08:42] <zyga> now IIRC gadget/kernel update is that last element breaking pi
[08:42] <zyga> core18 is updating fine now
[08:42] <zyga> mvo anyway, I'm happy to have a look
[08:42] <zyga> I will try to EOD in 2-3 hours
[08:42] <zyga> need to record some demos today
[08:43] <mvo> zyga: nice
[08:43] <zyga> I've been working so late recently I have lots of "overtime" to burn
[08:43]  * zyga goes to his standup
[08:43] <zyga> I really really want our standups to be totally public at some point
[08:43] <zyga> being a weird non-business is good
[08:44] <mvo> zyga: heh, yeah, that makes sense
[09:06] <pedronis> pstolowski: hi, did another pass on #9922, looking good but some comments
[09:06] <mup> PR #9922: api: validation sets monitor mode <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9922>
[09:07] <mborzecki> mvo: about https://bugs.launchpad.net/snapd/+bug/1916552 do you think it's some we break? afaict we only stage binaries from squashfs-tools
[09:07] <mup> Bug #1916552: Snapcraft 4.5.1 - cannot pack “/data/prime”: mksquashfs call failed: signal: segmentation fault (core dumped) <snapd:Triaged> <https://launchpad.net/bugs/1916552>
[09:10] <pstolowski> pedronis: thanks
[09:17] <mup> PR snapd#10004 opened: asserts: mode where Database only assumes cur time >= earliest time <Created by pedronis> <https://github.com/snapcore/snapd/pull/10004>
[09:40] <mvo> mborzecki: iirc sergio told me that using a different qemu fixed it but it's still strange
[09:44] <pedronis> mborzecki: I commented a bit on #9940, a bit confused by of the code there though
[09:44] <mup> PR #9940:  boot: cmd/snap-bootstrap: handle a candidate recovery system v2 <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9940>
[09:44] <pedronis> *some of the code
[09:44] <mborzecki> pedronis: thanks, i'll take a look
[11:01] <amurray> hey folks, I want to add some spread tests for the vendored apparmor PR I am working on - and I want these to run against the snapd snap built from my PR itself - is there an existing example of this sort of thing?
[11:02] <mup> PR snapd#9995 closed: tests: improvements for snap-seccomp-syscalls <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9995>
[11:35] <mborzecki> pedronis: i've replied under https://github.com/snapcore/snapd/pull/9940#discussion_r588227927 let me know if that makes sens now, or maybe we should ahve a quick chat
[11:35] <mup> PR #9940:  boot: cmd/snap-bootstrap: handle a candidate recovery system v2 <Run nested> <UC20> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9940>
[11:38] <pedronis> mborzecki: I'm still confused
[11:39] <mborzecki> pedronis: a chat then? :)
[11:39] <pedronis> yes
[11:39] <mborzecki> ok, heading to standup
[11:39] <pedronis> I'm there
=== popey8 is now known as popey
[12:03] <mborzecki> uhh core prepare failed for me: https://paste.ubuntu.com/p/XNXkFgRXV6/
[12:05] <mborzecki> mvo: can you use your superpowers and merge https://github.com/snapcore/snapd/pull/9976 ?
[12:05] <mup> PR #9976: tests/unit/go: use tests.session wrapper for running tests as a user <Simple 😃> <Test Robustness> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9976>
[12:05] <mborzecki> the failures are unrelated afaitc
[12:14] <mborzecki> mvo: thanks!
[12:17] <mup> PR snapd#9976 closed: tests/unit/go: use tests.session wrapper for running tests as a user <Simple 😃> <Test Robustness> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9976>
[12:18] <mvo> yw
[12:23] <mup> PR snapcraft#3464 opened: meta: add support for `kernel.yaml` for kernel snaps <Created by mvo5> <https://github.com/snapcore/snapcraft/pull/3464>
[12:36] <ijohnson> degville: I noticed in the whats new page a bit about the --experimental-gdb-server option, however for 2.50 we renamed that to just --gdbserver option and deprecated --gdb (though it will still be there), so maybe you could point out that in future releases --gdb will be deprecated in favor of the --experimental-gdb-server option (and also that --experimental-gdb-server will become --gdbserver)?
[12:38] <ijohnson> degville: also thanks for the edits to the snap try doc, looks really good to me! (though I fixed one little typo)
[12:48] <mup> PR snapcraft#3458 closed: requirements: pip freeze <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3458>
[13:08] <mup> PR snapcraft#3302 closed: build providers: configure apt according to runtime environment arch <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3302>
[13:11] <degville> ijohnson: thanks for the gdb hint (and for looking over the what's new doc). I'll update the text and gdbserver page. And thanks for the typo fix :)
[13:20] <ijohnson> np, thanks for writing all that too :-)
[13:22] <pedronis> mvo: I proposed the next piece as well, only a draft though because it's missing some unit tests
[13:23] <mup> PR snapd#10005 opened: asserts: ReadSystemEssentialAndBetterEarliestTime <Created by pedronis> <https://github.com/snapcore/snapd/pull/10005>
[13:23] <pedronis> mvo: ^
[13:51] <pedronis> ijohnson: maybe you are aware of this but #9932 isn't blocked just needs reviews
[13:51] <mup> PR #9932: o/configstate/configcore: support snap set system swap.size= <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9932>
[13:52] <ijohnson> pedronis: yes I know I have some updates adding tests locally, I just haven't finished it yet
[13:52] <ijohnson> maybe today I will get to it
[14:06] <diddledan> who wants to make me a cuda-runtime content snap? :-p
[14:10] <diddledan> also, the snap admin pages get gateway timeout a LOT
[14:11] <diddledan> e.g. https://snapcraft.io/fakecam/listing
[14:26] <zyga> mvo is that ldap bug important?
[14:43]  * cachio afk
[14:44] <mvo> zyga: a good question, it seems to be given that it blocks these people from using snaps
[14:48] <zyga> mvo: just curious because you've bumped priority to high from usual medium
[15:23] <mup> PR snapd#10006 opened: [RFC] cmd/snap-bootstrap: refactor handling of ubuntu-save, do not use secboot's implicit fallback <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10006>
=== pedronis_ is now known as pedronis
[15:37] <pedronis> mborzecki: I did a first quick pass on #10006, some initial comments/questions
[15:37] <mup> PR #10006: [RFC] cmd/snap-bootstrap: refactor handling of ubuntu-save, do not use secboot's implicit fallback <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10006>
[15:37] <mup> Bug #10006: python libglade program crashes on load <pygtk (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10006>
[15:43] <mborzecki> the kids are hijacking my desktop, bbiab
[15:47] <zyga> https://git.ostc-eu.org/OSTC/OHOS/components/staging/xts_acts/-/merge_requests/17/diffs#note_6899
[15:47] <zyga> very creative use of HOST:
[15:47] <zyga> cachio ^ :)
[16:24] <cachio> zyga, hey
[16:24] <cachio> you can run any command in HOST
[16:25] <cachio> but first time I see someone use that
[16:25] <zyga> cachio I was thinking of using that more formally
[16:25] <zyga> with a host: section
[16:25] <zyga> that's like execute but runs for each task, before the files are sent, to the host
[16:25] <zyga> and captures errors, unlike $(HOST: )
[16:25] <zyga> I guess it's specific to what we do
[16:26] <zyga> as or images are more embedded than traditional ubuntu
[16:26] <zyga> I wanted to ask for your opinion
[16:26] <zyga> and spread could warn the user that host commands exist
[16:26] <cachio> I think we don't use it
[16:26] <zyga> needing something like --classic
[16:26] <zyga> oh we use it, in spread.yaml
[16:27] <zyga> I wasn't even aware it is supported at the level of task.yaml
[16:27] <cachio> but it should be really usefull to skip tests based on values of variables
[16:27] <zyga> spread --enable-host-commands
[16:27] <zyga> (a bit too long but something of the sort)
[16:27] <cachio> and we don't need to run that in the target machine
[16:27] <zyga> that would then do test selection
[16:27] <zyga> and run host: commands in sub-directory of each test
[16:27] <zyga> e.g. we're using it to mkfs some images
[16:27] <zyga> that the target device mounts
[16:28] <zyga> but has no tools to create
[16:28] <zyga> I'll probably write something like that next week as we're using spread more and more now
[16:28] <cachio> hehehe
[16:29] <cachio> it would be nice to be able to build stuff and send it just to the instance which will run the test
[16:29] <cachio> I need to think possible use cases
[16:29] <zyga> in our case it's a bit weird
[16:29] <cachio> but I think i could be really usefull
[16:29] <zyga> and I agree spread doesn't fully match that
[16:29] <zyga> because the build happens elsewhere
[16:29] <zyga> on another machine
[16:29] <zyga> and we just get the image it produces
[16:29] <zyga> so the host running spread doesn't have bitbake or any related tooling
[16:30] <zyga> so it cannot compile all tests, for example
[16:30] <zyga> but that's fine, I think this is still a good way to use spread and extend it a little to this special-case)
[16:30] <cachio> yes, agree wiht that
[16:48] <pstolowski> mvo: a draft of the fix - https://github.com/snapcore/snapd/pull/10007
[16:48] <mup> PR #10007: o/configstate, o/snapshotstate: fix handling of nil snap config on snapshot restore <Created by stolowski> <https://github.com/snapcore/snapd/pull/10007>
[16:48] <mup> PR snapd#9974 closed: cmd/snap-bootstrap/initramfs-mounts: move time forward using ref files <Bug> <UC20> <⛔ Blocked> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/9974>
[16:48] <mup> PR snapd#10007 opened: o/configstate, o/snapshotstate: fix handling of nil snap config on snapshot restore <Created by stolowski> <https://github.com/snapcore/snapd/pull/10007>
[17:28] <diddledan> is 2.5GB too big to upload to the store?
[17:28] <diddledan> I'm receiving: `There seems to be a network error: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))`
[17:32] <pedronis> mvo: your last comment in #9914 has probably quoting problems
[17:32] <mup> PR #9914: image: write resolved-content from snap prepare-image <Created by mvo5> <https://github.com/snapcore/snapd/pull/9914>
[17:33] <pedronis> mvo: ah, I could fix it (interestingly)
[17:35] <diddledan> aah. getting a bit further on the fourth attempt
[17:44] <diddledan> failed at the last hurdle - 99% then a 504 gateway timeout error
[17:46] <diddledan> related. I've noticed a LOT of gateway timeouts when doing snap maintenance via snapcraft.io publisher's pages
[17:54] <diddledan> posted a thread about timeouts https://forum.snapcraft.io/t/many-504-gateway-timeout-errors/23152
[18:00] <zyga> hey diddledan :)
[18:01] <diddledan> o/
[18:48] <mvo> pedthe the last commit is the gadget.DefaultConstraints, maybe the one before?
[21:08] <mup> PR snapcraft#3427 closed: extensions: make GNOME 3.38 stable <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3427>
[22:05] <mup> PR snapd#9987 closed: tests: improve tests documentation - part 1 <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9987>