| mup | PR snapd#10012 opened: tests: revert os.query usage in spread.yaml <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10012> | 01:50 |
|---|---|---|
| === benfrancis0 is now known as benfrancis | ||
| mup | PR snapd#10013 opened: o/devicestate/handlers_install.go: split makebootable into it's own task <Needs Samuele review> <Run nested> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10013> | 03:05 |
| === jkridner|pd is now known as jkridner_ | ||
| === jkridner_ is now known as jkridner | ||
| === jkridner is now known as jkridner|pd | ||
| === jkridner|pd is now known as beaglebot | ||
| === beaglebot is now known as jkridner | ||
| === probono9 is now known as probono | ||
| mborzecki | morning | 06:44 |
| mup | PR snapd#10000 closed: client: protect against reading too much data from stdin <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10000> | 07:41 |
| mvo | mborzecki: I'm inclined to merge 10008 with only a single review because it fixes master, wdyt? | 07:42 |
| mborzecki | mvo: yes, please ;) | 07:42 |
| mborzecki | mvo: thanks! | 07:46 |
| mup | PR snapd#10008 closed: tests/lib/prepare: fix repacking of the UC20 kernel snap for with ubuntu-core-initramfs 40 <Run nested> <Simple 😃> <⚠Critical> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10008> | 07:46 |
| mvo | mborzecki: Thank *you* for the fix :) | 07:49 |
| mup | PR snapd#10009 closed: boot: export bootAssetsMap as AssetsMap <Simple 😃> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10009> | 07:51 |
| mborzecki | hm hm, snap-store edge is older than stable/candidate/beta? | 07:55 |
| mup | PR snapd#10012 closed: tests: revert os.query usage in spread.yaml <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10012> | 07:57 |
| pstolowski | morning | 08:03 |
| mvo | good morning pstolowski | 08:04 |
| mvo | mborzecki: 9989 seems to fail in unit tests right now, may need an update after the PR from ian about boot.AssertsMap | 08:04 |
| mup | PR snapd#9996 closed: tests: improve sections prepare and restore - part 1 <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9996> | 08:07 |
| mup | PR snapd#9997 closed: tests: update details on task.yaml files <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9997> | 08:07 |
| mborzecki | pstolowski: hey | 08:26 |
| pedronis | pstolowski: hi, it's #9922 ready for re-review? | 09:26 |
| mup | PR #9922: api: validation sets monitor mode <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9922> | 09:26 |
| mup | PR snapd#10014 opened: release: 2.49.1 <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10014> | 09:27 |
| pstolowski | pedronis: hey, i'm pondering about your question re validateAgainstStore; other than that - yes | 09:27 |
| pedronis | mborzecki: hi, should I look at #10006 again? | 09:27 |
| mup | PR #10006: [RFC] cmd/snap-bootstrap: refactor handling of ubuntu-save, do not use secboot's implicit fallback <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10006> | 09:27 |
| mup | Bug #10006: python libglade program crashes on load <pygtk (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10006> | 09:27 |
| mborzecki | pedronis: yes, please do, if it makes sense i'll update the diagrams and poke ian for reviews too | 09:28 |
| mborzecki | pedronis: i mean, unless you didn't finish the review on friday, as i haven't pushed the helper for naming partitions to your secboot | 09:28 |
| mup | PR snapd#9784 closed: interfaces/builtin/network-setup-{control,observe}: allow using netplan directly <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9784> | 09:32 |
| pstolowski | pedronis: i agree with your question about validateAgainstStore; shall i address it in this PR or followup? | 09:43 |
| pedronis | pstolowski: given the PR is already a bit big a follow-up? | 09:50 |
| pstolowski | pedronis: sure, that works for me | 09:50 |
| mborzecki | mvo: can you land #9989? the failures unrelated and mostly in apt-hooks and snap-advise | 09:53 |
| mup | PR #9989: boot: reseal the run key for all recovery systems, but recovery keys only for the good ones <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/9989> | 09:53 |
| === drizztbsd is now known as timothy | ||
| mvo | mborzecki: sure | 10:07 |
| mvo | mborzecki: done | 10:08 |
| mborzecki | mvo: thank you! | 10:08 |
| mup | PR snapd#9989 closed: boot: reseal the run key for all recovery systems, but recovery keys only for the good ones <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9989> | 10:12 |
| mup | PR snapd#9914 closed: image: write resolved-content from snap prepare-image <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9914> | 11:22 |
| mup | PR snapd#10015 opened: boot: simplify systems test setup <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10015> | 12:12 |
| mup | PR snapd#10016 opened: boot: helper for inspecting the outcome of a recovery system try <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10016> | 12:17 |
| ijohnson | morning folks | 13:08 |
| mborzecki | school run, back in 30 | 13:08 |
| pstolowski | hey ijohnson | 13:11 |
| ijohnson | hello pstolowski | 13:11 |
| ogra | oh, wow ... i'm hitting the "fonts show as squares" issue on my 16.04 for the first time ! | 13:14 |
| ogra | (i have never seen that on Ubuntu before) | 13:14 |
| ijohnson | actually pstolowski I was just looking at your bootchart you put in the SU notes, thanks for doing that, where did you get the 248ms number from ? | 13:15 |
| === tomreyn_ is now known as tomreyn | ||
| cachio_ | mborzecki, hi | 13:20 |
| cachio_ | mborzecki, this is just failing on arch https://paste.ubuntu.com/p/S6vJCMtPsQ/ | 13:20 |
| cachio_ | any idea if it is a known issue? | 13:20 |
| mup | PR snapcraft#3468 opened: store: set auth headers when using login --with <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3468> | 13:29 |
| mborzecki | re | 13:31 |
| mborzecki | cachio_: kind of, we've seen it fail on arch quite frequently | 13:32 |
| cachio_ | mborzecki, the problem is that when we remove the snap and the rule | 13:34 |
| cachio_ | the tag is not removed | 13:34 |
| cachio_ | so if in the same machine are executed both variants of the same test | 13:35 |
| cachio_ | the second one fails | 13:35 |
| ijohnson | cachio_: as I think I mentioned yesterday, that test needs to clean up after itself more to avoid the fact that snapd does not entirely clean itself up | 13:35 |
| cachio_ | ijohnson, but it works well in other systems than arch | 13:35 |
| cachio_ | I just can reproduce that on arch | 13:35 |
| ijohnson | cachio_: I think the root cause is the same though, that snapd does not clean up / remove cgroups after the snap is removed, I think we need to add a force cleanup restore section to the test | 13:36 |
| mborzecki | hmm maybe something about incomplete cleanup on arch then | 13:36 |
| ijohnson | are all the store find tests still broken this morning | 13:37 |
| ijohnson | ? | 13:37 |
| cachio_ | ijohnson, you mean to add a new rule to clean the tag? | 13:37 |
| cachio_ | ijohnson, aparently yes :( | 13:37 |
| ijohnson | cachio_: I mean we need to fix the test, can you send me a list of tests that check for this kind of device tagging / cgroup behavior ? | 13:37 |
| ijohnson | :-/ | 13:37 |
| diddledan | snapcraft.io builds are broken for several folk https://forum.snapcraft.io/t/the-specified-repository-is-being-used-by-another-snap/23218/4 | 13:39 |
| mborzecki | cachio_: ijohnson: hmm surprisingly my browsing history lists pages about removig udev tags :/ | 13:41 |
| ijohnson | oh no haha | 13:41 |
| pstolowski | ijohnson: look for mkdir [865]10.9ms, install with 248.5ms is a bit above | 13:50 |
| ijohnson | pstolowski: oh I see I was looking at the other install hook which was calling postgres etc | 13:51 |
| pstolowski | ijohnson: my only guess is that the discrepnancy (248ms from bootchart vs 1500ms from debug timings) is an overhead of snap run/confine which is simply not reflected in bootchart | 13:55 |
| ijohnson | pstolowski: do you know if the number behind the bootchart is system time or wall time? | 13:56 |
| ijohnson | because just glancing at the chart, it seems that the bar for that install task is longer than 1 second, each x axis tick is 1 second and it's at least 1 tick long | 13:57 |
| ijohnson | so I don't wonder if it was stuck waiting on I/O or something else and we are just measuring system time with the boot chart, but wall time with the timings | 13:57 |
| pstolowski | hmm | 13:57 |
| ijohnson | what's also weird is io write is very low there and io read is moderately low, but cpu is 100% and cpu wait is 100% at that time | 13:58 |
| ijohnson | anyways SU now | 13:58 |
| mup | PR snapd#10014 closed: release: 2.49.1 <Simple 😃> <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10014> | 13:58 |
| mup | PR snapd#10015 closed: boot: simplify systems test setup <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10015> | 13:58 |
| zyga | re | 14:37 |
| zyga | so tired today | 14:37 |
| zyga | hey folks, how are things | 14:38 |
| mup | PR snapd#10017 opened: gadget: remove `device-tree{,-origin}` from gadget tests <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10017> | 14:43 |
| ijohnson | tests are sad | 14:52 |
| mvo | ijohnson: oh no | 14:58 |
| mvo | ijohnson: which one in particular? | 14:58 |
| ijohnson | mvo: I just meant that the store tests seem to be sad | 14:58 |
| ijohnson | about find/sections | 14:58 |
| mvo | ijohnson: oh, ok | 14:59 |
| mvo | ijohnson: sorry, misunderstood | 14:59 |
| ijohnson | no worries | 14:59 |
| === cachio_ is now known as cachio | ||
| * cachio lunch | 15:08 | |
| mup | PR snapcraft#3468 closed: store: set auth headers when using login --with <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3468> | 15:30 |
| pstolowski | https://github.com/snapcore/snapd/pull/10007 needs 2nd review | 15:40 |
| mup | PR #10007: o/configstate, o/snapshotstate: fix handling of nil snap config on snapshot restore <Bug> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10007> | 15:40 |
| === oerheks1 is now known as oerheks | ||
| pstolowski | pedronis: thanks for the reviews | 16:18 |
| pedronis | thank you | 16:21 |
| mup | PR snapcraft#3460 closed: repo: introduce DebPackage class to standardize package name parsing <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3460> | 16:25 |
| mup | PR snapcraft#3469 opened: [wip] craft-providers <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3469> | 16:45 |
| cjwatson | diddledan: Launchpad regression, sorry. We're rolling back now | 16:49 |
| cjwatson | diddledan: ... and fixed now | 17:02 |
| diddledan | thanks cjwatson | 17:06 |
| * diddledan wonder what ya'll broke :-p | 17:06 | |
| diddledan | and fix confirmed :-) | 17:07 |
| cjwatson | diddledan: I linked to the (probable) fix in the forum thread | 17:09 |
| cjwatson | SQL bug in a privacy filter | 17:11 |
| diddledan | aha | 17:11 |
| diddledan | SQL keeps winning :-) | 17:11 |
| cjwatson | SQL always wins | 17:14 |
| cjwatson | Somehow | 17:14 |
| diddledan | just like DNS | 17:15 |
| diddledan | it's been 0 days since it was DNS or SQL | 17:15 |
| diddledan | I'm now reading up on what COALESCE does :-p | 17:18 |
| diddledan | aaah, a form of fallback | 17:19 |
| cjwatson | Returns first argument that isn't NULL, yes | 17:22 |
| mup | PR snapd#10010 closed: boot/assets.go: add InstallObserverOptions to allow providing previous assets <UC20> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/10010> | 17:29 |
| mup | PR snapd#10013 closed: o/devicestate/handlers_install.go: split makebootable into it's own task <Needs Samuele review> <Run nested> <UC20> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/10013> | 17:29 |
| mup | PR snapd#10018 opened: boot: revert #10009 <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10018> | 17:29 |
| diddledan | presumably that allows you to update the database with the new column without going through the historical records writing a default value to everything that was already saved | 17:37 |
| diddledan | which on launchpad.net might be a LOT of records to be writing default values to :-) | 17:37 |
| cjwatson | It's not actually that bad for snaps, but that's the general idea | 17:38 |
| cjwatson | Generally best not to rewrite a table as part of a schema migration if it isn't trivial to do so | 17:39 |
| diddledan | aye | 17:39 |
| cjwatson | For something like the Person table this sort of approach would be mandatory | 17:40 |
| cjwatson | We'll backfill it reasonably soon though | 17:40 |
| mup | PR snapd#10019 opened: tests: update documentation and checks for interfaces tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10019> | 18:54 |
| cachio | ijohnson, hey, I updated #9960 based on what you explained today | 19:05 |
| mup | PR #9960: tests: update permission denied message for test-snapd-event on ubuntu 2104 <â›” Blocked> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9960> | 19:05 |
| cachio | could you please take a quick look | 19:06 |
| cachio | feel free to update that if you think either the fix is not correct or it needs more explanation | 19:06 |
| ijohnson | cachio: sure I will take a look at it | 19:45 |
| cachio | tx | 19:45 |
| mup | PR snapd#10020 opened: tests: use fs-state tool in interfaces tests <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10020> | 20:49 |
| mup | PR snapd#10021 opened: uc20: add dtbo partition support for lk boot loader <Created by kubiko> <https://github.com/snapcore/snapd/pull/10021> | 21:55 |
| mup | PR snapcraft#3467 closed: gitignore: sort list <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3467> | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!