[00:01] <mwhudson> ah so v2 plugins just return a list of commands to execute?
[00:02] <mwhudson> probably easier to just write a script and invoke it in override-build or whatever then
[00:17] <mwhudson> (i think this snap predates override-build!)
[01:35] <kenvandine> anyone around that can help with snapcraft.io/build builds and architectures?
[01:36] <kenvandine> https://github.com/kenvandine/super-cool-app/blob/master/snap/snapcraft.yaml
[01:36] <kenvandine> i Added build-on: [ amd64, arm64 ]
[01:36] <kenvandine> and now the automated build is getting the same revision published to the store for both architectures
[01:37] <kenvandine> revision 4 is amd64 built but published for arm64
[01:39] <ijohnson> kenvandine: you need something like this if you just want it to be built for both arches separaetely
[01:39] <ijohnson> architectures:
[01:39] <ijohnson>     - build-on: amd64
[01:39] <ijohnson>     - build-on: arm64
[01:42] <kenvandine> oh!
[01:44] <kenvandine> ijohnson: thanks!
[01:44] <ijohnson> np
=== mup_ is now known as mup
=== jnsgruk08 is now known as jnsgruk0
[06:37] <mborzecki> morning
[06:46] <zyga> good morning
[06:46]  * zyga heads to the office today
[06:46] <zyga> weird how you have tu smuggle boards around still ;-)
[08:08] <pstolowski> morning
[08:22] <mborzecki> pstolowski: hey
[08:38] <mborzecki> pstolowski: got any PRs in need of reviews?
[08:39] <pstolowski> mborzecki: yes! #9922
[08:39] <mup> PR #9922: api: validation sets monitor mode <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/9922>
[08:40] <mborzecki> i'll take a look
[08:49] <pstolowski> ty
[09:17] <mup> PR snapd#10030 opened: daemon: validation sets/api tests cleanup <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10030>
[10:00] <mborzecki> mvo: can you take a look at https://github.com/snapcore/snapd/pull/10016 ?
[10:00] <mup> PR #10016:  boot: helper for inspecting the outcome of a recovery system try  <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10016>
=== apw_ is now known as apw
[10:48] <mup> PR snapcraft#3473 opened: Candid bakery <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3473>
[11:29] <cachio_> mvo, hi
[11:29] <cachio_> I see this error on beta validation
[11:29] <cachio_> https://paste.ubuntu.com/p/qNtknNPhJ6/
[11:30] <cachio_> could be that related to a new change introduced?
[11:30] <cachio_> I am working on reproduce that
[11:40] <mvo> cachio_: that is interessting, I don't think we changed anything in this area
[11:40] <mvo> cachio_: just to double check, this test worked fine with 2.49?
[11:43] <mup> PR snapd#10031 opened: Allow configuring hdmi_timings on pi <Created by sergey-borovkov> <https://github.com/snapcore/snapd/pull/10031>
[11:43] <cachio_> mvo, yes, but I am checking to make sure
[11:43] <mvo> thank you
[11:45] <cachio_> mvo, didnt fail last time
[11:45] <cachio_> https://paste.ubuntu.com/p/WrxrdNGZ7h/
[11:45] <cachio_> line 802
[11:46] <cachio_> I'll try to reproduce it here
[11:48] <mvo> cachio_: it's really odd, we did not change anything in this area, could be a race or something in core20 that changed of course
[11:49] <cachio_> mvo, yes, probably it was already present in 2.49 but didn't fail
[11:49] <cachio_> I'll run in a loop locally to see it it can be reproduced
[11:49] <mvo> ta
[12:42] <pstolowski> i see google:ubuntu-18.04-64:tests/main/snap-seccomp-syscalls started failing
[12:43] <mup> PR snapd#10019 closed: tests: update documentation and checks for interfaces tests <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10019>
[12:48] <cachio_> pstolowski, do you have a link?
[12:49] <pstolowski> cachio_: e.g. https://github.com/snapcore/snapd/pull/10025/checks?check_run_id=2075953751
[12:49] <mup> PR #10025: api: local assertion fallback when it's not in the store <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10025>
[12:49] <mborzecki> pstolowski: hm there was a fix in master that landed yesterday
[12:49] <pstolowski> it seems there is a new syscall?
[12:49] <pstolowski> mborzecki: ah
[12:51] <cachio_> pstolowski, mborzecki the error I see is https://paste.ubuntu.com/p/SvWYqQjjNb/
[12:51] <cachio_>  google:ubuntu-20.04-64:tests/main/nfs-support
[12:51] <cachio_> trying to reproduce it here
[12:52] <mborzecki> uhh
[12:52] <mborzecki> hope it's not something about session cleanup again
[12:52] <mborzecki> that bit runs `su -c ... test`
[12:53] <cachio_> not sure
[12:53] <cachio_> trying to reproduce it
=== Ps1-Jack is now known as Psi-Jack
[13:18] <mup> PR snapd#10007 closed: o/configstate, o/snapshotstate: fix handling of nil snap config on snapshot restore <Bug> <Needs Samuele review> <Squash-merge> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10007>
[13:20] <mborzecki> mvo: thanks!
[13:23] <mup> PR snapd#10016 closed:  boot: helper for inspecting the outcome of a recovery system try  <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10016>
[13:23] <mup> PR snapd#10028 closed: daemon:  move out /v2/login|logout and errToResponse tests from api_test.go <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10028>
[13:48] <mup> PR snapd#10020 closed: tests: use fs-state tool in interfaces tests <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10020>
[14:26] <mborzecki> cachio__: mvo: https://paste.ubuntu.com/p/qGK4yHGNWG/ i think i looked at it already and it seemd we got EBADMSG which isn't even listed in the manpage of mount(2), but there's a catch that there are some filesystem specific errors that can be returned there too
[14:27] <cachio__> mborzecki, could be related to a new image?
[14:28] <cachio__> I am trying to reproduce the error but still no luch
[14:29] <cachio__> luck
[14:29] <mborzecki> cachio__: mvo: and guess what we have in ext4 source code: https://elixir.bootlin.com/linux/latest/source/fs/ext4/ext4.h#L3730 dmesg output would be useful here
[14:30] <mborzecki> afaict ext4_fill_super which is called when mount can throw this
[14:31] <cachio__> mborzecki, I lost the log
[14:32] <cachio__> I'll try to reproduce it
[14:32] <mvo> mborzecki: nice, so bad crc?
[14:32] <mborzecki> cachio__: that's fine, if you can't reproduce it easily, let's just keep an eye on that one, and remember to collect dmesg if possible
[14:32] <cachio__> yes
[14:33] <mborzecki> cachio__: maybe temporarily it's useful to add something like `dmesg | tail -20` in the debug section of that test
[14:33] <cachio__> mborzecki, yes, makes sense
[14:33] <cachio__> I'll add that
[14:42] <cachio__> mborzecki, https://paste.ubuntu.com/p/w2dGX32RFv/
=== cachio__ is now known as cachio
[14:43] <mborzecki> cachio: `[  693.447923] EXT4-fs (loop1p4): error loading journal` hmm
[14:43] <mborzecki> and `[  693.442817] JBD2: journal checksum error` precedes it
[14:43] <cachio> JBD2: journal checksum error
[14:43] <cachio> yes
[14:46] <mborzecki> cachio: do you ahve access to the shell? can you run `blockdev --getss /dev/loop1`?
[14:46] <cachio> 512
[14:47] <cachio> do you want access?
[14:47] <ijohnson> oof whats the issue with sector sizes
[14:47] <ijohnson> (or maybe mborzecki is curious about sector sizes for some other reason)
[14:48] <mborzecki> ijohnson: the uc20-create-partition test fails, ther's an error mounting ubuntu-save, dmesg shows that there's a journal checksum error
[14:48] <ijohnson> ah yes is this the panic with the weird errno ?
[14:48] <mborzecki> yeah
[14:49] <ijohnson> I have seen that before but never understood why it happens, libmount has terrible conventions around returning what went wrong iirc
[14:49] <ijohnson> well terrible == ambigious
[14:50] <mborzecki> ijohnson: afafict EBADMSG translates to EFSBADCRC for ext4
[14:54] <ijohnson> ah ok nice I don't think I actually ever looking that in depth at libmount
[14:56] <mborzecki> heh, it's ubuntu-data that fails
[14:56] <mborzecki> cachio: ijohnson: i can't mount it manually either https://paste.ubuntu.com/p/WjsgGyCfjR/
[14:57] <ijohnson> interesting!~
[14:57] <mborzecki> wtf is that 'Other ext4' in parted
[14:58] <ijohnson> whoops! haha yeah that seems highly suspcious
[14:58] <ijohnson> maybe our math is off somewhere
[14:59] <mborzecki> ha, it's part of the test gadget ;)
[15:01] <mborzecki> hmm the layout looks ok: https://paste.ubuntu.com/p/MHkbhYMvvP/
[15:04] <mborzecki> well debugfs doesn't like it either, `/dev/loop1p5: Can't read a block bitmap while reading allocation bitmaps`
[15:19] <mup> PR snapd#10032 opened: snapstate: adjust update-gadget-assets user visible message <Created by mvo5> <https://github.com/snapcore/snapd/pull/10032>
[16:10]  * cachio lunch
[16:33] <mup> PR snapcraft#3472 closed: storeapi: move http client and auth to http_clients package <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3472>
[17:29] <mup> PR snapd#9922 closed: api: validation sets monitor mode <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/9922>
[17:49] <mup> PR snapd#10033 opened: tests: run the reset.sh helper and check test invariants while the test is restored <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10033>
[20:38] <zyga> ijohnson nice keys
[20:39] <ijohnson> keys?
[20:39] <ijohnson> you mean my new keyboard?
=== ivo_cavalcante_ is now known as ivo_cavalcante