zyga | good mirning | 06:40 |
---|---|---|
zyga | haha | 06:40 |
zyga | morning :) | 06:40 |
mborzecki | morning | 07:01 |
zyga | hey mborzecki | 07:04 |
zyga | Friday, if only the weather was not so rainy | 07:04 |
mborzecki | zyga: forecast for the weekend it's too great either | 07:18 |
zyga | mborzecki oh well, we need to do some house work | 07:42 |
zyga | so manybe finally time | 07:42 |
pstolowski | morning | 08:02 |
mborzecki | pstolowski: hey | 08:11 |
mborzecki | pstolowski: there are some conflicts in https://github.com/snapcore/snapd/pull/10030 now that the other api bits have landed | 08:11 |
mup | PR #10030: daemon: validation sets/api tests cleanup <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10030> | 08:11 |
pstolowski | mborzecki: yep, expected | 08:12 |
pstolowski | mborzecki: btw would you take a look at https://github.com/snapcore/snapd/pull/10025 (which is the next PR after what just landed)? | 08:12 |
mup | PR #10025: api: local assertion fallback when it's not in the store <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10025> | 08:12 |
pstolowski | it's a simple one this tie | 08:12 |
pstolowski | *time | 08:12 |
mborzecki | sure | 08:13 |
pstolowski | ty | 08:23 |
mup | PR snapd#10025 closed: api: local assertion fallback when it's not in the store <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10025> | 09:27 |
pstolowski | mborzecki: https://github.com/snapcore/snapd/pull/10030 is now rebased with master | 09:31 |
mup | PR #10030: daemon: validation sets/api tests cleanup <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10030> | 09:31 |
pstolowski | https://github.com/snapcore/snapd/pull/10030 needs 2nd review (and is simple) | 11:08 |
mup | PR #10030: daemon: validation sets/api tests cleanup <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10030> | 11:08 |
zyga | pstolowski +1 | 12:01 |
pstolowski | zyga: dzieki! | 12:01 |
zyga | :-) | 12:02 |
mup | PR snapd#10001 closed: tests: improve tests self documentation for nested test suite <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10001> | 12:22 |
mborzecki | hmm looks like the uc20-create-partitions* tests could have left some stuff behind, like mounpoints or loopback devices | 12:39 |
mborzecki | as i can't reproduce the checksum problem when running a single test | 12:39 |
mup | PR snapd#10034 opened: tests/main/uc20-create-partitions: fix tests cleanup <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10034> | 13:12 |
mup | PR snapd#10030 closed: daemon: validation sets/api tests cleanup <validation-sets :white_check_mark:> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10030> | 13:47 |
pedronis | mborzecki: I commented here: https://github.com/snapcore/snapd/pull/10006#discussion_r593229255 | 14:50 |
mup | PR #10006: [RFC] cmd/snap-bootstrap: refactor handling of ubuntu-save, do not use secboot's implicit fallback <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10006> | 14:50 |
pedronis | mvo: #9870 is red | 14:58 |
mup | PR #9870: vendor: update go-tpm2/secboot to latest version <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9870> | 14:58 |
mvo | pedronis: thanks, looking | 15:01 |
mborzecki | pedronis: ijohnson: i've updated #10006 and attached a state diagram | 15:33 |
mup | Bug #10006: python libglade program crashes on load <pygtk (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10006> | 15:33 |
mup | PR #10006: [RFC] cmd/snap-bootstrap: refactor handling of ubuntu-save, do not use secboot's implicit fallback <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10006> | 15:33 |
ijohnson | mborzecki: great, thanks I'll take another look today | 15:34 |
mborzecki | ta | 15:35 |
* cachio_ lunch | 15:41 | |
pedronis | mborzecki: did you see my reply to your previous question about the changed test? | 16:33 |
cachio_ | ijohnson, hey | 16:43 |
cachio_ | I see this test failing | 16:43 |
cachio_ | https://paste.ubuntu.com/p/T7M26rFCTr/ | 16:43 |
cachio_ | it is really sporadir | 16:43 |
cachio_ | seems to be a race there | 16:43 |
cachio_ | if I add a sleep after udevadm settle | 16:44 |
cachio_ | then the issue is not reproducible anymore | 16:44 |
cachio_ | do you know what I could check/wait for ? | 16:44 |
cachio_ | instead of using a sleep | 16:44 |
=== King_InuYasha is now known as Conan_Kudo | ||
=== Conan_Kudo is now known as King_InuYasha | ||
mup | PR snapd#10004 closed: asserts: mode where Database only assumes cur time >= earliest time <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10004> | 18:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!