| === wCPO6 is now known as wCPO | ||
| === ItsAGeekThing7 is now known as ItsAGeekThing | ||
| === paride2 is now known as paride | ||
| === waxfire9 is now known as waxfire | ||
| === lachesis_ is now known as lachesis | ||
| smoser | can someone please land https://github.com/canonical/cloud-init/pull/837 ? | 12:46 |
|---|---|---|
| smoser | I'm not sure how really to do it. I hit the 'squash and merge' button, but then i'm not really even sure what I'm supposed to do. we really need a lander and commit-linter | 12:47 |
| falcojr | smoser: Done...when you hit squash and merge, you get two text boxes. The first is the short description. The second is the rest...it usually comes pre-populated with all the commit messages as a list so just clear it out | 16:36 |
| falcojr | it's helpful to keep the PR number in the short description | 16:36 |
| falcojr | e.g., https://imgur.com/a/sNzAoWL | 16:37 |
| smoser | really need a lander. multiple humans are just going to do that inconsistently. | 16:47 |
| smoser | sorry to be a complainer | 16:50 |
| Odd_Bloke | Yeah, agreed, we do. | 16:51 |
| falcojr | humans still need to write the commit message, so what would a lander do for us? | 16:53 |
| Odd_Bloke | Ensure that the written commit message ends up as the commit message on the merge commit. | 16:53 |
| Odd_Bloke | s/merge commit/squash commit/ | 16:53 |
| smoser | and the PR | 16:57 |
| smoser | PR # | 16:57 |
| falcojr | yeah, that makes sense | 16:58 |
| smoser | another thing for future linter | 21:03 |
| smoser | Author: eb3095 <45504889+eb3095@users.noreply.github.com> | 21:03 |
| smoser | Author: James Falcon <TheRealFalcon@users.noreply.github.com> | 21:03 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!