| === ahayzen_ is now known as ahayzen | ||
| callmepk | good morning | 01:54 |
|---|---|---|
| sarnold | hey callmepk :) | 01:56 |
| callmepk | hey sarnold | 02:00 |
| KGB-2 | gnome-shell-extension-appindicator tags 94d5976 Marco Trevisan upstream/35 * Upstream version 35 * https://deb.li/37Rr7 | 02:13 |
| KGB-2 | gnome-shell-extension-appindicator upstream/latest 4e802c0 Marco Trevisan * pushed 86 commits * https://deb.li/7oCg | 02:14 |
| KGB-2 | gnome-shell-extension-appindicator signed tags 5f5694d Marco Trevisan ubuntu/33.1-0ubuntu0.20.04.2 * gnome-shell-extension-appindicator Debian release 33.1-0ubuntu0.20.04.2 * https://deb.li/3rtMl | 02:14 |
| KGB-2 | gnome-shell-extension-appindicator ubuntu/focal e74acce Marco Trevisan * pushed 6 commits (first 5 follow) * https://deb.li/ypGx | 02:14 |
| KGB-2 | gnome-shell-extension-appindicator ubuntu/focal bb04e1d Marco Trevisan (Treviño) debian/patches/ series Register-the-StatusNotifierWatcher-as-soon-as-possible.patch appIndicator-Fix-reduce-padding-for-some-icons.patch appIndicator-Remove-unneeded-padding.patch * debian/patches: Register the StatusNotifierWatcher as soon as possible * https: | 02:14 |
| KGB-2 | shell-extensions//deb.li/3MRjE | 02:14 |
| KGB-2 | gnome-shell-extension-appindicator ubuntu/focal c0c0ac7 Marco Trevisan (Treviño) debian/patches/ series util-Properly-call-logger-static-method.patch * debian/patches: Ensure we call proper method during logging * https://deb.li/IRc4 | 02:14 |
| KGB-2 | gnome-shell-extension-appindicator ubuntu/focal 8b1ea22 Marco Trevisan (Treviño) debian/patches/ series indicatorStatusIcon-Handle-scroll-events-on-label-too-not.patch * debian/patches: Handle scroll events on indicator label * https://deb.li/3eo4D | 02:14 |
| KGB-2 | gnome-shell-extension-appindicator ubuntu/focal f9aa77f Marco Trevisan (Treviño) debian/patches/ series statusNotifierItem-Emit-signals-about-removed-items-on-de.patch statusNotifierWatcher-Emit-the-uniqueId-when-emitting-Un-.patch * https://deb.li/3keyj | 02:15 |
| KGB-2 | debian/patches: Emit expected signals / arguments when (un)registering indicators | 02:15 |
| KGB-2 | gnome-shell-extension-appindicator ubuntu/focal ede5b90 Marco Trevisan (Treviño) debian/changelog * Update changelog * https://deb.li/i7pDR | 02:15 |
| KGB-0 | mutter ubuntu/master Daniel van Vugt * [open] merge request !70: Remove G_PARAM_EXPLICIT_NOTIFY from the "opacity" property * https://deb.li/3jtnn | 02:57 |
| seb128 | goood morning desktopers | 05:30 |
| callmepk | morning seb128 | 06:12 |
| duflu | Morning seb128 | 06:12 |
| duflu | Fun day. New Xwayland release, new Mesa release, new Yaru theme, in hirsute | 06:39 |
| didrocks | good morning | 06:47 |
| === juergh` is now known as juergh | ||
| oSoMoN | good morning desktoppers, happy Friday | 06:58 |
| duflu | Morning didrocks and oSoMoN | 07:03 |
| oSoMoN | hey duflu | 07:03 |
| didrocks | salut oSoMoN, hey duflu | 07:03 |
| oSoMoN | salut didrocks | 07:03 |
| * duflu also gets excited about kernel 5.11 for raspi | 07:15 | |
| jibel | Good morning all | 07:24 |
| oSoMoN | salut jibel | 07:25 |
| jibel | Salut oSoMoN | 07:26 |
| duflu | Morning jibel | 07:28 |
| jibel | Hi duflu | 07:29 |
| didrocks | salut jibel | 08:04 |
| jibel | Salut didrocks | 08:04 |
| marcustomlinson | morning callmepk sarnold seb128 duflu didrocks oSoMoN jibel | 08:18 |
| duflu | Hi marcustomlinson | 08:18 |
| seb128 | hey callmepk oSoMoN duflu didrocks marcustomlinson jibel | 08:20 |
| didrocks | hey marcustomlinson, seb128 | 08:21 |
| jibel | Salut seb128 marcustomlinson | 08:22 |
| oSoMoN | hey marcustomlinson, salut seb128 | 08:39 |
| callmepk | hi marcustomlinson didrocks oSoMoN jibel | 08:57 |
| oSoMoN | hey callmepk | 08:58 |
| Laney | \o \o \o \o \o | 09:04 |
| marcustomlinson | mornin Laney | 09:08 |
| duflu | Hi Laney | 09:10 |
| duflu | Many Laneys | 09:10 |
| marcustomlinson | one Laney, many Lanie | 09:12 |
| Laney | i laney you laney we laney they laney he lanies she lanies | 09:13 |
| Laney | moin marcustomlinson moin duflu | 09:13 |
| Nafallo | morning desktopers! | 09:14 |
| duflu | Morning Nafallo | 09:15 |
| marcustomlinson | hi Nafallo | 09:15 |
| didrocks | hey callmepk | 09:20 |
| callmepk | hey Laney Nafallo | 09:20 |
| didrocks | morning Laney | 09:21 |
| Laney | good day to you Nafallo callmepk and didrocks! | 09:21 |
| Laney | happy friday | 09:21 |
| duflu | (launchpad goes down) | 09:28 |
| duflu | (launchpad comes up) | 09:29 |
| didrocks | up and down! | 09:35 |
| oSoMoN | good morning Laney, Nafallo | 09:37 |
| seb128 | hey Laney, happy friday | 10:20 |
| Laney | hey oSoMoN seb128 | 10:29 |
| Wimpress | Morning o/ | 10:36 |
| seb128 | hey Wimpress, how are you? | 10:37 |
| oSoMoN | hey Wimpress | 10:37 |
| Wimpress | seb128: Very well thanks. Walking every morning for 2 hours and coming home to fresh coffee is working for me :-) | 10:42 |
| Wimpress | How things with all of you? | 10:42 |
| seb128 | it's going alright, busy as usual ;-) | 10:50 |
| seb128 | bah, so github does that CI job super-linter, which is nice. I wonder if I should try to set up locally | 10:56 |
| seb128 | according to the description that basically does pylint flake8 black on the code, which I did locally ... but funny is that some of the tools disagree | 10:58 |
| seb128 | -from metrics.collectors.sponsoring.sponsoring_collector import \ | 10:58 |
| seb128 | - SponsoringMetrics | 10:58 |
| seb128 | +from metrics.collectors.sponsoring.sponsoring_collector import SponsoringMetrics | 10:58 |
| seb128 | isort split that line, black unsplit it 🤔 | 10:59 |
| Laney | I think we have a config file to set a different line length for black | 11:00 |
| Laney | but yeah it would be good to have a script to run all that stuff locally | 11:01 |
| Laney | kind of annoying to make the proposal and then find it fails on some formatting thing | 11:01 |
| seb128 | they provide a docker image to do it locally | 11:01 |
| seb128 | but would be nicer to just have a wrapper using the standard tools installed | 11:02 |
| Laney | yeh | 11:02 |
| Laney | https://github.com/ubuntu/ubuntu-release-metrics/blob/metrics/.github/linters/.python-black so yeah black --line-length 80 might do it? | 11:05 |
| seb128 | https://pipelines.actions.githubusercontent.com/VzBEpiMoNkfpCkgKbaPz3fioQyM3csi6CNcyK9wWpFsSJSikDo/_apis/pipelines/1/runs/29/signedlogcontent/3?urlExpires=2021-03-19T11%3A11%3A18.4456089Z&urlSigningMethod=HMACV1&urlSignature=qTVFeuwgXAwjaSFWfNZJI2EUJ6kAmr3VgXRVWNuVoq0%3D | 11:14 |
| seb128 | 2021-03-19T11:09:16.1567389Z +++ /github/workspace/metrics/collectors/sponsoring/__init__.py:after2021-03-19 11:09:16.129673 | 11:14 |
| seb128 | 2021-03-19T11:09:16.1568243Z @@ -1,4 +1,6 @@ | 11:14 |
| seb128 | 2021-03-19T11:09:16.1569376Z -from metrics.collectors.sponsoring.sponsoring_collector import SponsoringMetrics | 11:14 |
| seb128 | 2021-03-19T11:09:16.1570815Z +from metrics.collectors.sponsoring.sponsoring_collector import ( | 11:14 |
| seb128 | 2021-03-19T11:09:16.1571725Z + SponsoringMetrics, | 11:14 |
| seb128 | 2021-03-19T11:09:16.1572133Z +) | 11:14 |
| seb128 | I'm just going to apply the suggested diff to make CI green | 11:14 |
| seb128 | but it's a bit of a weird syntax to me... | 11:15 |
| seb128 | bah, CI still failing because blake disagrees with the change... | 11:23 |
| sil2100 | seb128: first daily-canary image build sort-of successful! http://cdimage.ubuntu.com/daily-canary/20210319/ | 12:19 |
| sil2100 | Sort of, since I still need to tweak something, but I think it's all good in overall | 12:19 |
| seb128 | sil2100, hey, great, thanks again for getting this resolved! | 12:21 |
| seb128 | I'm curious but what tweaks are needed? | 12:22 |
| KGB-2 | orca pristine-tar a17416f Samuel Thibault orca_40.0.orig.tar.xz.delta orca_40.0.orig.tar.xz.id * pristine-tar data for orca_40.0.orig.tar.xz * https://deb.li/3e3u7 | 12:24 |
| KGB-2 | orca upstream/beta ff02c52 Samuel Thibault * pushed 9 commits (first 5 follow) * https://deb.li/iW7QF | 12:24 |
| KGB-2 | orca upstream/beta 3ec04e1 Joanmarie Diggs README.md configure.ac * Post-release version bump * https://deb.li/3FCa2 | 12:24 |
| KGB-2 | orca upstream/beta 4cbdb43 Marek Černocký help/cs/cs.po * Updated Czech help translation * https://deb.li/a7Ji | 12:25 |
| KGB-2 | orca upstream/beta 04843ab Ask Hjorth Larsen po/da.po * Updated Danish translation * https://deb.li/3uYph | 12:25 |
| KGB-2 | orca upstream/beta b3d9e39 Boyuan Yang po/zh_CN.po * Update Chinese (China) translation * https://deb.li/fYEn | 12:25 |
| KGB-2 | orca upstream/beta 2137a38 Milo Casagrande po/it.po * Update Italian translation * https://deb.li/345mU | 12:25 |
| KGB-2 | orca tags b230892 Samuel Thibault upstream/40.0 * Upstream version 40.0 * https://deb.li/piH1 | 12:25 |
| seb128 | Laney, I would welcome your help on getting that linter issue sorted out, I tried a few variations but CI fails every time since tools disagree :/ | 12:29 |
| Laney | link to the pr? | 12:29 |
| seb128 | Laney, https://github.com/ubuntu/ubuntu-release-metrics/pull/4 | 12:30 |
| seb128 | "tags": {"report": "ubuntu",}, | 12:30 |
| seb128 | in https://pipelines.actions.githubusercontent.com/VzBEpiMoNkfpCkgKbaPz3fioQyM3csi6CNcyK9wWpFsSJSikDo/_apis/pipelines/1/runs/32/signedlogcontent/3?urlExpires=2021-03-19T12%3A30%3A55.3985684Z&urlSigningMethod=HMACV1&urlSignature=ZMXOmmzmf57Zq6%2FiXwOSb8SQI6zQu3yX3m9B%2FiSQfk0%3D | 12:30 |
| seb128 | that failed with | 12:30 |
| seb128 | 2021-03-19T11:16:52.9258162Z /github/workspace/metrics/collectors/sponsoring/sponsoring_collector.py:25:48: E231 missing whitespace after ',' | 12:30 |
| seb128 | I added the whitespace and now https://github.com/ubuntu/ubuntu-release-metrics/runs/2148332859?check_suite_focus=true | 12:31 |
| seb128 | - "tags": {"report": "ubuntu", }, | 12:31 |
| seb128 | + "tags": {"report": "ubuntu",}, | 12:31 |
| seb128 | from black | 12:31 |
| seb128 | similar issue on the import | 12:32 |
| seb128 | those logs have opposite diffs from black who wants a single line and isort who wants to split it | 12:33 |
| seb128 | (I force pushed to not have a ridiculous histore of 'try,revert,try') | 12:34 |
| seb128 | Laney, should https://github.com/github/super-linter/blob/master/TEMPLATES/.isort.cfg be included maybe in .github/linters ? | 12:49 |
| Laney | sec | 12:50 |
| Laney | is that what some documentation says? | 12:50 |
| Laney | it looks like maybe | 12:50 |
| seb128 | Laney, https://github.com/github/super-linter says | 12:54 |
| seb128 | "Copy any or all template rules files from TEMPLATES/ into your repository in the location: .github/linters/ of your repository | 12:54 |
| seb128 | If your repository does not have rules files, they will fall back to defaults in this repository's TEMPLATE folder | 12:54 |
| seb128 | " | 12:54 |
| seb128 | so copying the default config doesn't help | 12:54 |
| seb128 | but maybe we want a isort one with a line_length tweaked as for black | 12:54 |
| seb128 | though doing that locally and using isort --settings-path .github/linters it still wants to wrap the import... | 12:55 |
| seb128 | ah, I misnamed my file | 13:00 |
| seb128 | Laney, k, so yes, adding .github/linters/.isort.cfg with line_length=80 fixes the import conflict | 13:01 |
| Laney | seb128: I think we should be using 79, it seems to be what some of the other tools want and that's isort's default | 13:03 |
| Laney | but I don't mind much, 80 is fine too | 13:03 |
| seb128 | Laney, well we override it with | 13:03 |
| seb128 | $ cat .github/linters/.python-black | 13:03 |
| seb128 | [tool.black] | 13:03 |
| seb128 | line-length = 80 | 13:03 |
| seb128 | so I think we need consistent between the tools? | 13:03 |
| seb128 | +to be | 13:03 |
| Laney | yeah | 13:03 |
| Laney | we fix one or the other one | 13:03 |
| seb128 | removing that one would also wfm | 13:03 |
| Laney | I'll make that say 79, one second | 13:04 |
| Laney | that's funny, the line in question is exactly 80 characters, I guess that's why you got unlucky | 13:04 |
| seb128 | should we just delete it? | 13:04 |
| Laney | no then it'll be 88 | 13:04 |
| seb128 | ah | 13:05 |
| Laney | I dunno why all these tools have a different idea | 13:05 |
| seb128 | Laney, https://github.com/github/super-linter/blob/master/TEMPLATES/.isort.cfg I wonder if that should default to the profile=black , https://github.com/PyCQA/isort/blob/develop/isort/profiles.py#L10 | 13:08 |
| seb128 | seems like a misconfiguration in the default linter templates | 13:09 |
| Laney | could be | 13:09 |
| Laney | maybe that's why I added that black config | 13:10 |
| seb128 | k, the other issue I can resolve by removing the trailing coma | 13:19 |
| seb128 | Laney, do you do the config change or do you want a PR for that? | 13:20 |
| Laney | seb128: https://github.com/ubuntu/ubuntu-release-metrics/pull/5 | 13:23 |
| Laney | you can rebase on that one | 13:23 |
| Laney | assuming it works, I think it will | 13:23 |
| seb128 | Laney, great, thanks! | 13:24 |
| Laney | well hopefully that works for you too | 13:25 |
| Laney | maybe check that before I merge it | 13:25 |
| seb128 | Laney, confirmed, it works (I tried locally), pylint flake black isort are happy now | 13:28 |
| sil2100 | seb128: I still need to make sure the isotracker bits don't die, but that's not really important | 13:28 |
| sil2100 | Rest seems to work as expected | 13:28 |
| seb128 | sil2100, great | 13:28 |
| Laney | seb128: neat, ok, let me merge it then | 13:30 |
| seb128 | Laney, great, I will rebase and do my coma tweaks then | 13:30 |
| Laney | cool | 13:30 |
| * Laney lunch | 13:30 | |
| seb128 | Laney, I've more sponsoring queue stats coming after that but it relies on change to be merged on the report side first | 13:31 |
| seb128 | Laney, enjoy! | 13:31 |
| seb128 | unsure who maintains http://reports.qa.ubuntu.com/reports/ though? I wonder what distro version that has | 13:33 |
| Laney | it's Brian, and I bet something ancient | 13:34 |
| * Laney goes for real | 13:35 | |
| seb128 | bah, I can't contact canonical websites anymore again, already last week was it on friday? | 14:39 |
| seb128 | one day I will learn how to debug those issues :/ | 14:39 |
| hellsworth | good morning desktopers | 14:43 |
| hellsworth | sorry you're having connectivity troubles seb128 :( | 14:43 |
| oSoMoN | hello hellsworth | 14:43 |
| hellsworth | hi oSoMoN | 14:43 |
| seb128 | hey Heather, how are you? | 14:43 |
| hellsworth | i'm pretty good thanks :) | 14:43 |
| hellsworth | i hope you two are well | 14:43 |
| seb128 | yes, just a bit tired but that's usual | 14:44 |
| * hellsworth cheers seb and oSoMoN with my coffee | 14:44 | |
| * oSoMoN cheers back with an empty cup of coffee :) | 14:44 | |
| hellsworth | :) | 14:44 |
| seb128_ | k, in addition nm is being stupid and disconnect from the wifi every minute because the auto VPN connection fails to set up | 14:50 |
| hellsworth | interesting. i wonder if that's true with the snap.. | 14:52 |
| jibel | Laney, https://code.launchpad.net/~jibel/ubiquity/+git/ubiquity-1/+merge/397742 has been updated | 15:37 |
| jibel | Good morning hellsworth | 15:38 |
| hellsworth | hi there jibel | 15:38 |
| ricotz | seb128, thank you for uploading vala 0.48.15-1 :-) , could you sync libgee-0.8 0.20.4-1 and vala 0.48.15-1 from debian? | 15:44 |
| Laney | cheers jibel | 15:47 |
| seb128 | ricotz, hey, np, synced | 15:52 |
| ricotz | seb128, thank you | 16:00 |
| seb128 | yw! | 16:00 |
| === juergh is now known as Guest9645 | ||
| === ijohnson is now known as ijohnson|lunch | ||
| ddstreet | hellsworth hi, quick q, do you know why the network-manager snap has an ancient version in its 'latest' channel? | 17:43 |
| === juergh is now known as Guest21961 | ||
| === Guest21961 is now known as Guest1 | ||
| === Guest1 is now known as juergh | ||
| === ijohnson|lunch is now known as ijohnson | ||
| hellsworth | ddstreet: yes that version in the ":q | 19:19 |
| hellsworth | let me try that agian :) | 19:20 |
| hellsworth | the version that is in latest stable is tied to core16. however if a user installs this from an 18.04 or later system, it defaults to 1.10/stable | 19:20 |
| === oerheks1 is now known as oerheks | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!