| mborzecki | morning | 07:07 |
|---|---|---|
| zyga | good morning | 08:02 |
| pstolowski | morning | 08:07 |
| zyga | hey pstolowski | 08:09 |
| mborzecki | zyga: pstolowski: hey guys | 08:18 |
| mborzecki | heh, so another bunch of rebuilds and had to go retrigger the builds on obs | 09:04 |
| mborzecki | i guess it's time i tweaked those client timeouts | 09:04 |
| mup | PR snapd#10059 opened: cmd/snap: use less aggressive client timeouts in unit tests <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10059> | 09:09 |
| mup | PR snapd#10060 opened: boot: extend set try recovery system unit tests <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10060> | 10:04 |
| pedronis | mborzecki: hi, should we close 100055, as it's replaced by 100056 ? | 10:12 |
| mborzecki | pedronis: yeah, closed 10055 just now | 10:16 |
| pedronis | thx | 10:16 |
| mborzecki | pedronis: shall we sync with mvo/ijohnson about the issue today? | 10:16 |
| pedronis | mvo is still off | 10:16 |
| pedronis | but yes we should sync | 10:16 |
| mborzecki | ah | 10:16 |
| mup | PR snapd#10055 closed: wrappers: launch apps through /usr/lib/snapd/snap on core with snapd snap <â›” Blocked> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/10055> | 10:19 |
| pedronis | mborzecki: we can chat before or after the standup | 10:33 |
| mborzecki | pedronis: let's try before | 10:33 |
| pedronis | pstolowski: hi, maybe you could review https://github.com/snapcore/snapd/pull/10040 ? | 10:34 |
| mup | PR #10040: daemon: switch api_test.go to daemon_test and various other cleanups <Cleanup :broom:> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10040> | 10:34 |
| pstolowski | pedronis: sure | 10:34 |
| mborzecki | pedronis: i've updated https://github.com/snapcore/snapd/pull/10037 | 10:44 |
| mup | PR #10037: boot: export helper for clearing tried system state, add tests <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10037> | 10:44 |
| pedronis | mborzecki: thanks, +1 | 10:53 |
| mborzecki | thanks for the review | 10:53 |
| jamesh | alan_g: I proposed some more fixes to help with #8699 here: https://github.com/MirServer/snapd/pull/5 -- there is still a bit more to address, but this should resolve most of the open threads | 11:11 |
| mup | PR #8699: interfaces/desktop-launch: support confined snaps launching other snaps <Needs Samuele review> <Created by AlanGriffiths> <https://github.com/snapcore/snapd/pull/8699> | 11:11 |
| mup | PR MirServer/snapd#5: usersession/userd: fix some of the review comments for #8699 <Created by jhenstridge> <https://github.com/MirServer/snapd/pull/5> | 11:11 |
| alan_g | jamesh, thanks. Will take a look | 11:12 |
| jamesh | alan_g: I did a merge from master though, which complicates the diff. The changes in usersession/userd should be relatively clean though | 11:14 |
| alan_g | jamesh, Ack. I spotted that already | 11:14 |
| mup | PR snapcraft#3480 opened: ci: spread testing <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3480> | 11:50 |
| * cachio afk | 12:00 | |
| mup | PR snapcraft#3480 closed: ci: spread testing <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3480> | 12:00 |
| pedronis | mborzecki: I scheduled something | 12:02 |
| mborzecki | thanks! | 12:02 |
| mup | PR snapcraft#3481 opened: tests: stub job to get autokpgtest for edge <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3481> | 12:15 |
| === jamesh_ is now known as jamesh | ||
| ijohnson | cachio: hey it seems we may have hit our image limit again, I see `2021-03-22 04:12:51 Cannot allocate google-nested:ubuntu-18.04-64: cannot find any Google image matching "ubuntu-1804-64-virt-enabled" on project "computeengine" or "ubuntu-os-cloud"` | 13:05 |
| ijohnson | can you clean up some images on gCE? | 13:05 |
| cachio | ijohnson, hi | 13:17 |
| cachio | let me check | 13:17 |
| ijohnson | thanks | 13:27 |
| cachio | ijohnson, it is done | 13:28 |
| cachio | try again please | 13:28 |
| ijohnson | great, thanks I will run it again | 13:28 |
| mup | PR snapd#10061 opened: interfaces/pwm: add PWM interface <Created by woodrow-shen> <https://github.com/snapcore/snapd/pull/10061> | 14:20 |
| mup | PR snapcraft#3482 opened: Support install-mode option for apps <Created by cmatsuoka> <https://github.com/snapcore/snapcraft/pull/3482> | 15:10 |
| mborzecki | pedronis , ijohnson : i've pushed the version using findmnt to https://github.com/snapcore/core20/pull/100 | 15:29 |
| mup | PR core20#100: Add a wrapper for invoking the snap binary <Created by bboozzoo> <https://github.com/snapcore/core20/pull/100> | 15:29 |
| ijohnson | mborzecki: great I'll have a look in a bit | 15:31 |
| pedronis | mborzecki: it's better :) | 15:37 |
| mborzecki | pedronis: i'll force push that || -> && | 15:40 |
| pedronis | pstolowski: I did a first on affectedByRefresh PR | 16:17 |
| pedronis | *pass | 16:17 |
| pstolowski | pedronis: thank you | 16:20 |
| mup | PR snapd#10062 opened: tests: validation sets spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10062> | 16:21 |
| mup | PR snapd#10063 opened: o/{device,hook}state: encode fde-setup-request key as base64 string <Bug> <Run nested> <UC20> <âš Critical> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10063> | 16:36 |
| pstolowski | ijohnson: hey, do you have a moment to do 2nd review of https://github.com/snapcore/snapd/pull/10048 ? | 16:42 |
| mup | PR #10048: o/configstate: deal with no longer valid refresh.timer=managed <Bug> <Needs Samuele review> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10048> | 16:42 |
| ijohnson | pstolowski: sure I will add it to my queue | 16:44 |
| pstolowski | thanks | 16:44 |
| === ijohnson is now known as ijohnson|lunch | ||
| cachio | ijohnson|lunch, hi, did you start taking a look to the auto-refresh test? | 18:06 |
| === ijohnson|lunch is now known as ijohnson | ||
| ijohnson | cachio: sorry can you remind me which test? | 18:09 |
| cachio | ijohnson, auto-refresh | 18:09 |
| ijohnson | cachio: you mean tests/main/auto-refresh ? | 18:10 |
| cachio | tes | 18:10 |
| cachio | yes | 18:10 |
| cachio | ijohnson, the snap refresh --time is showind a different output | 18:17 |
| cachio | https://paste.ubuntu.com/p/ykkrp3Xcqc/ | 18:17 |
| cachio | dependening if we run in the first test suite or in the second one | 18:18 |
| cachio | the test suite clean up it messing up something I guess | 18:18 |
| ijohnson | cachio: the test runs ` snap set core refresh.schedule="0:00-23:59"` | 18:19 |
| ijohnson | cachio: the test needs to do in the restore sectoin `snap unset core refresh.schedule` | 18:20 |
| cachio | the problem is before taht | 18:21 |
| cachio | first thing the test does is | 18:22 |
| cachio | echo "Auto refresh information is shown" | 18:22 |
| cachio | output=$(snap refresh --time) | 18:22 |
| cachio | well | 18:22 |
| ijohnson | cachio: but what you are saying is that the `snap refresh --time` fails in the _second_ instance of running the test right ? | 18:22 |
| cachio | ijohnson, no | 18:22 |
| cachio | it fails at the beginning | 18:22 |
| ijohnson | I guess I'm confused how the test is failing then | 18:22 |
| ijohnson | also confused when the test is failing | 18:23 |
| cachio | in fact I shell the test and I see the diferent output | 18:23 |
| cachio | if I run | 18:23 |
| cachio | spread2 -debug -order -single-worker google:arch-linux-64:tests/completion/indirect:funkyfunc google:arch-linux-64:tests/main/auto-refresh:parallel | 18:23 |
| cachio | so then the output for nap refresh --time | 18:23 |
| cachio | contains timer: 00:00~24:00/4 | 18:24 |
| cachio | if I run | 18:24 |
| cachio | spread2 -debug -order -single-worker google:arch-linux-64:tests/completion/indirect:funkyfunc google:arch-linux-64:tests/main/auto-refresh:parallel | 18:24 |
| cachio | spread2 -debug -order -single-worker google:arch-linux-64:tests/main/auto-refresh:parallel | 18:24 |
| cachio | last one | 18:24 |
| cachio | so then the output for nap refresh --time | 18:24 |
| cachio | contains schedule: 00:00-23:59 | 18:24 |
| ijohnson | hmm | 18:25 |
| ijohnson | so the test fails not when the auto-refresh test is run twice, but when any other test is run before it ? | 18:25 |
| cachio | another test in another suite | 18:25 |
| cachio | yes | 18:25 |
| ijohnson | I see | 18:26 |
| cachio | I ran in a loop and the test works well | 18:26 |
| ijohnson | I wonder what the restore logic is doing | 18:26 |
| cachio | any idea what could be affecting this? | 18:26 |
| ijohnson | cachio: where do we have the magical code that resets snapd state that is run after every spread test? | 18:26 |
| cachio | tests/lib/reset.sh | 18:27 |
| cachio | ijohnson, after the last change the reset houldn't be needed | 18:31 |
| cachio | because we reaet after running the last test | 18:31 |
| ijohnson | cachio: when you see the auto-refresh test fail, can you get an output of `snap get system` ? | 18:33 |
| cachio | ijohnson, https://paste.ubuntu.com/p/s7ccZcPHdY/ | 18:33 |
| ijohnson | cachio: sorry `snap get system -d` | 18:35 |
| cachio | ijohnson, https://paste.ubuntu.com/p/pn2MD2FSSR/ | 18:36 |
| ijohnson | cachio: something set `snap set core refresh.hold=...` on that system | 18:36 |
| ijohnson | cachio: can you check what cloud-init scripts / datasources are doing for the system | 18:38 |
| ijohnson | ? | 18:38 |
| ijohnson | maybe someone added to the image something which calls `snap set core refresh.hold=...` | 18:38 |
| cachio | let me check | 18:38 |
| cachio | ijohnson, cloud init is not | 18:45 |
| ijohnson | cachio: you mean cloud-init is not running `snap set core refresh.hold=` ? | 18:48 |
| ijohnson | also cachio can you please review https://github.com/snapcore/snapd/pull/10044 and +1 if it it makes sense to you ? | 18:49 |
| mup | PR #10044: packaging: drop dh-systemd from build-depends on ubuntu-16.04+ <âš Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10044> | 18:49 |
| cachio | ijohnson, sure | 18:50 |
| cachio | ijohnson, cloud init is not setting snap set core refresh.hold= | 18:52 |
| ijohnson | hmm | 18:52 |
| cachio | I'll continue working on this | 18:52 |
| cachio | don't worry | 18:52 |
| ijohnson | ok, thanks I don't have much bandwidth for this auto-refresh thing right now, and I think it's more pressing for me to get you a fix for the uevent spread test instead of debugging this | 18:56 |
| mup | PR snapd#10064 opened: tests: simplify the reset.sh logic by removing not needed command <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10064> | 18:56 |
| ijohnson | but obviously feel free to reach out to others tomorrow morning about auto-refresh maybe someone else has an idea about what is going on | 18:56 |
| cachio | ijohnson, sure, thanks a lot | 19:04 |
| mup | PR snapcraft#3483 opened: requirements: use PyNaCl 1.3.0 and ensure is compiled on linux <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3483> | 20:51 |
| * cachio afk | 21:47 | |
| mup | PR snapcraft#3484 opened: tests: crystal 1.0.0 requires shard.lock <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3484> | 21:51 |
| mup | PR snapd#10065 opened: tests: reset the system while preparing the test suite <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10065> | 21:52 |
| mup | PR snapcraft#3484 closed: tests: crystal 1.0.0 requires shard.lock <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3484> | 22:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!