| otubo | blackboxsw: smoser just pushed an update. At first I put the check inside is_lvm_lv but after some thought I moved to get_pvs_for_lv for it's easier to read I guess | 10:45 |
|---|---|---|
| otubo | blackboxsw: smoser also added a log message to is_lvm_lv, to better track down problems on the log file | 10:46 |
| otubo | blackboxsw: smoser thanks for the review | 10:46 |
| chillysurfer | Odd_Bloke: i have to apologize, i asked a question late yesterday and then disconnected shortly after | 13:27 |
| smoser | otubo: thanks. | 13:28 |
| chillysurfer | Odd_Bloke: i wanted to know if there was any chance for this pr to get a review soon: https://github.com/canonical/cloud-init/pull/780 | 13:28 |
| smoser | I for one would be really happy to have support for "normal" keys in azure. | 13:29 |
| smoser | the platform supports it now i gather? | 13:29 |
| chillysurfer | smoser: was that comment/question aimed at me and the pr? sorry, not sure i'm part of that context :) | 13:41 |
| Odd_Bloke | smoser: This is more about pulling keys from the IMDS instead of the OVF: the original change actually reduced the set of keys that we handle (because we stopped passing them to openssl unconditionally, which it turns out was handling fixing up broken input and key certificates for us), so this is a second attempt to reenable the IMDS codepath only for those keys that we know how to handle. | 13:48 |
| Odd_Bloke | chillysurfer: I'll see if I can get to it today. :) | 13:49 |
| chillysurfer | Odd_Bloke: thanks so much!! let me know if you need anything else from me | 13:50 |
| Odd_Bloke | Will do! | 13:50 |
| === Tahvok_ is now known as Tahvok | ||
| === frickler_ is now known as frickler | ||
| Odd_Bloke | paride: I'm currently chasing down one of the LXD VM failures: it looks like the LXD agent installation is somehow causing the machine to reboot unexpectedly, which of course messes everything up. | 19:51 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!