/srv/irclogs.ubuntu.com/2021/03/25/#snappy.txt

=== jamesh_ is now known as jamesh
=== not_phunyguy is now known as phunyguy
=== not_phunyguy is now known as phunyguy
=== jamesh_ is now known as jamesh
mborzeckimorning07:54
mvogood morning mborzecki07:55
mborzeckimvo: hey07:55
mborzeckimvo: can you land https://github.com/snapcore/snapd/pull/10067 ?07:59
mupPR #10067: overlord/snapstate: make sure that snapd current symlink is not removed during refresh <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10067>07:59
mvomborzecki: sure08:00
mvomborzecki: looking, I'm going over the list of open PRs right now, there are some more that were ready and just failed because of things like snap-advice failing08:01
mupPR # closed: snapd#10035, snapd#10070, snapd#10071, snapd#1007208:02
mvomborzecki: thank you so much for this PR! merged08:03
mvomborzecki: and cherry-picked08:03
mborzeckithanks!08:06
pstolowskimorning08:06
mvopstolowski: good morning!08:06
mborzeckipstolowski: hey08:06
mupPR snapd#10067 closed: overlord/snapstate: make sure that snapd current symlink is not removed during refresh <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10067>08:07
mborzeckipstolowski: can you take a look at https://github.com/snapcore/snapd/pull/10054 ?08:11
mupPR #10054: overlord/snapstate, wrappers: add dependency on usr-lib-snapd.mount for services on core with snapd snap <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10054>08:11
mupPR snapd#10064 closed: tests: simplify the reset.sh logic by removing not needed command <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10064>08:12
mborzeckimvo: pstolowski: i think we can land https://github.com/snapcore/snapd/pull/10062 too, the failures are unrelated afaict08:14
mupPR #10062: tests: validation sets spread test <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10062>08:14
mvomborzecki: sure thing, thank you!08:15
mupPR snapd#10062 closed: tests: validation sets spread test <validation-sets :white_check_mark:> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10062>08:17
pstolowskimborzecki: will do08:19
mborzeckipstolowski: thanks!08:19
zygagood morning guys!08:20
mvohey zyga08:20
zygahey mvo, how are you doing?08:20
mvozyga: good, thank you! how are you? it's getting sunny here again which is super nice08:21
zygaoh, I envy you the sun then :) Here's it's finally getting warmer, it looks like Saturday will be perfect for some time (alone) outside08:21
zygabut it's also bound to be raining so I guess it will be just me and the bike again08:22
zygaso much work lately that I rarely think about stuff like that08:22
zygabut it's the last stretch it seems08:22
mvozyga: yeah, the alone part is the same here, it's a bit annoying08:25
zygamvo: some of our parents got vaccinated already but there's a huge queue and we're not likely to get anything more this year08:26
mvozyga: I'm somewhat hopeful for end-of-summer here but I'm also notouriously optimistic08:26
zygawe had to move our release for three weeks to pick up the documentation work and the website08:27
zygabut after that it looks like some normal time will happen08:27
zygaa week off08:28
zygaand regular feature work08:28
zygaI'm looking forward to having early EODs and warm weather for just doing stuff08:28
pstolowskihey zyga08:35
zygahey :)08:35
mvozyga: sounds great, total +1 on this08:36
mupPR snapd#10058 closed: cla-check: Use has-signed-canonical-cla GitHub Action <Skip spread> <Created by MarcusTomlinson> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10058>08:37
pedronismvo: that fix that you are non finding in Ian's PR, seems to have be done already in the prereq: https://github.com/snapcore/snapd/pull/10035/commits/73e4cb21bf7c7d0f54ba1205beb9ad866c01784508:51
mupPR #10035: o/devicestate: split off ensuring next boot goes to run mode into new task <Simple 😃> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10035>08:51
pedronis*been08:51
pedronismborzecki: hi, related to the snapd fixes, are you also working on the snap-confine profile change?08:53
mvopedronis: nice, thanks08:54
mvopstolowski: looks like 10068 just needs one more small check if we can reuse the same test and then it can go in. nice job there!08:54
pedronismvo: mborzecki: does the caching of spread test results still works as before? I have the impression all tests are re-run now, but maybe I'm just confused08:55
pstolowskimvo: looking08:55
mborzeckipedronis: noticed that too, but did not look into it yet08:55
mupPR snapd#10075 closed: interfaces/udisks2: allow locking /run/mount/utab for udisks 2.8.4 <Needs Samuele review> <Created by knitzsche> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10075>08:57
zyga^ on that last merged PR: one of the files that udisks/libmount wanted to read, not sure if it's that one in /run, was tricky to share09:02
zygabecause that interface (in the libmount sense) is not aware of mount namespaces, udisks would get very confused09:02
mvopedronis, mborzecki if you have an example where you see this I can have a look after my meeting, it should be visible in the logs of the runs what stamp files were used09:06
pstolowskimvo: i preplied, not sure we want to change that without input from Sergio09:06
pstolowski*replied09:07
mupPR snapd#10048 closed: o/configstate: deal with no longer valid refresh.timer=managed <Bug> <Needs Samuele review> <Squash-merge> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10048>09:07
mvopstolowski: thanks, let's make sure we can do a followup, it's not a blocker09:07
pstolowskimvo: ok09:07
pstolowskihmm but it looks the test failed on reboot, that's weird, i'm sure it passed when i run it manually09:10
pstolowskiah we need || ture, weird..09:11
mvopstolowski: I see an error that it can't resolve "ubuntu" which is kind of expected given that we turned off resolving :) but of course annoying09:16
mvopstolowski: I wonder if adding ubuntu to /etc/hosts is enough09:16
pstolowskimvo: yes i saw that (it's from sudo i think)09:16
mvo(but it could/should be there already)09:16
mvopstolowski: yeah, sudo tries to be smart because it can have per-host configuration in sudoers.cfg09:17
pstolowskimvo: this is something we would do on core image I assume?09:25
pstolowski(rather than trying to modify config on writable etc)09:26
mvopstolowski: it's a good question, I can check after my meeting09:28
mupPR snapd#10076 opened: tests: fix snap-advise-command check for 429 <Simple 😃> <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10076>10:02
mvopedronis: ^- this should make your (and other) PRs much more happy10:11
mvopstolowski: ok if I merge 10068 as squash-merge?10:14
pstolowskimvo: yes; let's wait for nested though, i pushed a fix10:15
mvopstolowski: thanks10:15
mvopstolowski: does that work? I mean, sudo complains but it still reboots?10:16
pstolowskimvo: it's an error from ssh dropping connection; we do that in other places10:16
mvopstolowski: aha, makes sense10:16
mvopstolowski: thanks!10:17
pstolowskimvo: i'm not sure why it didn't fail before when i run this test, maybe it's not always reporting an error (?)10:18
mvopstolowski: probably a race10:18
pstolowskicould be10:20
mupPR snapd#9981 closed: gadget: policy for gadget/kernel refreshes <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9981>10:37
mupPR snapcraft#3489 opened: errors: introduce details_from_called_process_error() helper <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3489>10:55
mupPR snapd#10076 closed: tests: fix snap-advise-command check for 429 <Simple 😃> <Test Robustness> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10076>11:37
mupPR snapd#10077 opened: o/configstate: fix panic with a sequence of config unset ops over same path <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10077>11:42
mvomborzecki: iirc we need to also have some code that keeps snap-confine apparmor profiles around during snapd refreshes, did I remember this correctly?11:44
mborzeckiyes11:44
mvomborzecki: what's the current thinking on this, do we have ideas already :) ?11:45
mborzeckimvo: yes, setup-profiles glob needs ot be altered such that the old profiles stay around and only get cleaned up when given revision of the snapd snap is being removed11:47
mupPR snapd#10078 opened: tests: handle "snap refresh" returning an empty reply gracefully <Created by mvo5> <https://github.com/snapcore/snapd/pull/10078>11:47
mvomborzecki: great, is that something you can work on? and something we could even cramp into 2.49.2?11:52
mborzeckiit's in my list11:53
mvomborzecki: \o/ thanks!11:53
jdstrandmvo: hey, I don't know it you saw, but I was able to commit to the snappy-debug tree we setup, but the uploads all failed: https://launchpad.net/~jdstrand/+snap/snappy-debug/+build/1347999 https://launchpad.net/~jdstrand/+snap/snappy-debug/+build/1348000 ("Cannot upload new revisions for name=snappy-debug"). Is this something you could look at, give to someone, tell me who to talk to? (I feel like maybe12:08
jdstrandI'm not a coillaborator?)12:08
jdstrandI have no visibility on it (https://dashboard.snapcraft.io/snaps/snappy-debug/ is 404)12:08
mborzeckimvo: pedronis: the caching does not work afaict12:17
mborzeckiand there's this warning in the task that restores the cache: `Warning: tunneling socket could not be established, statusCode=403`12:17
mborzeckitasks that run on github's infra ahve caching working correctly12:22
pedronismborzecki: it's a firewall issue?12:39
mborzeckiha https://github.com/actions/cache/issues/47812:40
mborzeckialthough the issue describes a close event12:41
mvojdstrand: let me chase this12:43
jdstrandmvo: thanks! it's fixed now :)12:46
mupPR snapd#10079 opened: api: provide meaningful error message on connect/disconnect for non-installed snap <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10079>12:58
ijohnsonthanks mvo for merging all those pr's of mine that had 2 +1s but were red for a long time13:33
mvoijohnson: sure thing!13:56
pstolowskicachio: there is a question re nested suites that maybe you can clarify in https://github.com/snapcore/snapd/pull/1006814:18
mupPR #10068: o/configstate: don't pass --root=/ when masking/unmasking/enabling/disabling services <Run nested> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10068>14:18
cachiopstolowski, let me take a look14:46
cachiopstolowski, done14:53
pstolowskicachio: thanks; does it make sense then to enable 20.04 for nested/core tests or are they bound to fail?15:06
cachiopstolowski, if you run the test for system 20.04 on suite nested/core15:07
mvopstolowski: https://github.com/snapcore/snapd/pull/10068/checks?check_run_id=2192201052 looks real15:07
mupPR #10068: o/configstate: don't pass --root=/ when masking/unmasking/enabling/disabling services <Run nested> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10068>15:07
cachiothe vm wont be a real uc2015:07
mvopstolowski: "2021-03-25T10:39:52.8546726Z - Run configure hook of "core" snap (run hook "configure": [disable rsyslog.service] failed with exit status 1: Failed to disable unit: Unit file rsyslog.service does not exist." - that's odd, your test does not touch this, does it?15:07
ijohnsoncachio: what do you mean?15:07
cachiobecause the vm won't have secure boot15:07
ijohnsonwell it's just not a secure boot + tpm uc20 vm15:08
mvomborzecki: is it okay to squash-merge https://github.com/snapcore/snapd/pull/10054 ?15:08
mupPR #10054: overlord/snapstate, wrappers: add dependency on usr-lib-snapd.mount for services on core with snapd snap <Squash-merge> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10054>15:08
cachioon nested/core15:09
cachioNESTED_ENABLE_TPM: '$(HOST: echo "${NESTED_ENABLE_TPM:-false}")'15:09
cachioNESTED_ENABLE_SECURE_BOOT: '$(HOST: echo "${NESTED_ENABLE_SECURE_BOOT:-false}")'15:09
cachioand in nested/core2015:09
cachioNESTED_ENABLE_TPM: '$(HOST: echo "${NESTED_ENABLE_TPM:-true}")'15:09
cachioNESTED_ENABLE_SECURE_BOOT: '$(HOST: echo "${NESTED_ENABLE_SECURE_BOOT:-true}")'15:09
cachiothis is the main dif15:09
pstolowskimvo: oh15:10
cachioijohnson, depends on the test, if it is ok to run the test with that configuration so we can run it in nested/core15:10
cachioif we need to make sure the test run with secboot and tpm so we need to run in nested/core2015:11
ijohnsoncachio: I guess we should think about unifying tests/nested/core and tests/nested/core20, and possibly making the default for tests/nested/core for uc20 to be w/o tpm and secboot, but allow specific tests to opt-in to secboot and tpm in that suite15:11
ijohnsonit would mean that if for example I go add a new uc specific test to tests/nested/core, it will run on an unencrypted uc20 VM, and if I wanted to also run it for uc20 with secboot and tpm, then I would create a variant of the test with env vars in the spread task.yaml15:12
ijohnsonwe would then have to filter out duplicated non-uc20 systems, since non-uc20 systems operate the same with and without secboot/tpm, but I think the gain of unifying those suites is that we can more easily get uc20 coverage by just adding a file to the tests/nested/core suite without needing to remember about tests/nested/core20 suite, or potentially worse just duplicating an entire task.yaml except for one line15:13
cachioijohnson, that makes sense15:13
pstolowskimvo: does rsyslog exist on core18?15:14
cachioijohnson, i'll try to implement that15:15
mvopstolowski: I think so, I can double check15:19
mvopstolowski: oh, looks I'm wrong15:20
mvopstolowski: seems like we don't15:20
pstolowskimvo: i think we're abusing rsyslog in gadget.defaults in the tests15:20
pstolowskimvo: and this triggers the problem. fwtw i think uc20 doesn't have rsyslog either15:21
mvopstolowski: yeah, that definitely does not has it15:21
mvopstolowski: meh, ok15:21
mvopstolowski: abuse sounds not great15:21
pstolowskimvo: unfortunately rsyslog was the only flag we could test, that's why (because ssh is problematic to test :/)15:22
mvopstolowski: I see15:22
mvopstolowski: could we use resolved now?15:22
pstolowskimvo: yes i think so15:22
pstolowskimvo: i'm on it15:22
mvo\o/15:23
* cachio lunch15:27
mupPR snapd#10080 opened: interfaces/u2f-devices: add HyperFIDO Pro (https://launchpad.net/bugs/1919268) <Created by oSoMoN> <https://github.com/snapcore/snapd/pull/10080>15:48
pstolowskimvo: ok the test passed with systemd-resolved; updated and pushed15:50
pstolowskimvo: so if anyone uses similar gadget defaults without reflection, this means problems after this PR15:55
mvopstolowski: I guess we could do a git grep for this pattern maybe?15:57
mvomborzecki: can I help in any way with the snap-confine profile thing? one more meeting then I have a bit of time I hope :)15:57
pstolowskimvo: i mostly worried about our users15:57
zygasnap confine profile magic? :-)15:57
zygawhat are you changing?15:58
mvopstolowski: oh, I see15:58
pstolowski*i'm15:58
ijohnsonpstolowski: what do you mean reflection for gadget defaults ?15:58
mborzeckimvo: let me know how bad it looks https://github.com/snapcore/snapd/compare/master...bboozzoo:bboozzoo/snapd-security-profiles-stay-around?expand=115:58
mborzeckisome tests are missing still15:58
pstolowskiijohnson: using service.rsyslog.disable=true in gadget defaults for early config on systems where it doesn't make sense because the unit doesn't exist15:59
ijohnsonoh so before using that would not break anything and now using that would break something ?15:59
mvomborzecki: does not look bad at all actually15:59
pstolowskiijohnson: which doesn't cause problems in early config, but strikes later15:59
ijohnsonah interesting15:59
mvopstolowski: right so if someone cargo culted a rsyslog setting that would now cause problems16:00
pstolowskiijohnson: yeah beacause we always go over all services on snap set16:00
ijohnsonI think it's unlikely it would happen for our users, but gadgets have a history of being cargo culted and doing very weird things16:00
pstolowskimvo: maybe it's 2.50 material then? i don't know16:01
pedronispstolowski: I think we discussed the idea of checking if a service exist at all at some point or use system exit codes (but doesn't changed between releases)16:18
pedroniss/doesn't/those/16:18
pstolowskipedronis: yes16:20
pedronismvo: #9999 needs a master merge and is also unblocked?16:20
mupPR #9999: snapstate: add "kernel-assets" to featureSet <â›” Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/9999>16:20
pedronispstolowski: I still think is the right path forward given that services are not the same across versions16:20
pstolowskipedronis: i could look at this as a prerequsite for existing PR16:30
cachiopedronis, is this the error you saw? https://paste.ubuntu.com/p/4vW7vqH6k4/16:35
cachiogoogle:ubuntu-20.04-64 ...# ls /var/lib/snapd16:36
cachiostate.json16:36
cachiothis is what I see16:36
pedroniscachio: yes, something like that16:36
pedronispstolowski: yes, we need to decide what to do exactly though, because the last time I'm not sure we reached a conclusion except that the error codes weren't useful16:37
pstolowskipedronis: yes, error codes were useless16:38
pstolowskipedronis: we would probably need a separate call to systemctl status16:38
pedronisyes16:45
pedronisI fear that's what we would need16:45
pedronispstolowski: I think #10077 is reasonable but I have a probably annoying question16:45
mupBug #10077: libforms1: new changes from Debian require merging <Ubuntu:Fix Released by cjwatson> <https://launchpad.net/bugs/10077>16:45
mupPR #10077: o/configstate: fix panic with a sequence of config unset ops over same path <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10077>16:45
pstolowskipedronis: thanks, i need to stare a bit a this16:48
pstolowski*at16:49
pstolowskiwhat are some really big snaps in the store? i need to test something16:49
ijohnsonpstolowski: try the 0ad snap it's pretty big our16:51
pedronispstolowski: some of the jetbrains snap are big16:51
ijohnson*iirc16:51
pstolowskiack, thanks16:51
=== ijohnson is now known as ijohnson|lunch
pstolowskiok, so snap abort correctly cancels the context while inside download task16:53
mborzeckimvo: wrapipng it up for today, pushed some tweaks https://github.com/snapcore/snapd/compare/master...bboozzoo:bboozzoo/snapd-security-profiles-stay-around happy to discuss tomorrow if the branch makes sense16:57
mvomborzecki: yeah, I will chat with pedronis if/how we could land this givne that he is off tomorrow17:00
zygaI had a look at the change and conceptually it looks good, I'm a bit puzzled though, was that profile removed from memory or is it only a problem if the file is gone from disk?17:06
zygaI'm asking because of a bug we keep propagating:17:06
zygahttps://github.com/snapcore/snapd/compare/master...bboozzoo:bboozzoo/snapd-security-profiles-stay-around#diff-48ad8c3c5d0a39f5ce40d31863a4ae42289a624cfcded61f571ce66fd984a729R58317:06
zygahere17:06
mvomborzecki: got a verbal okay from samuele to land without him (the current diff looks fine)17:06
zygathis is never doing anything, right?17:06
zygabecause apparmor unload program relies on the ability to parse the profile and find the profile names again17:07
zygaso we remove things from disk and apparmor just NOPs17:07
zygacc mborzecki pedronis ^17:07
pedronismborzecki: there's a typo: SecuityBackendDiscardingLate Security17:07
mvozyga: only gone from disk, we have a race when snapd is refreshing and there is a reboot in the middle17:08
zygaah17:08
zygathen that is good IMO17:08
zygaI'd drop a comment so that what I said about unload profiles doesn't get lost17:09
zygayeah, raciness on poweroff is very tricky17:09
=== ijohnson|lunch is now known as ijohnson
=== TooLmaN_ is now known as TooLmaN
=== pfsmorigo is now known as Guest8748
=== Ringtailed_Fox is now known as RingtailedFox
=== ogra_ is now known as Guest8511
=== urluck_ is now known as urluck
=== ba is now known as bandali
mupPR snapd#10081 opened: [RFC] interfaces, interfaces/apparmor, overlord/snapstate: late removal of snap-confine apparmor profiles <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10081>18:38
* cachio afk19:08
mupPR snapcraft#3490 opened: build(deps): bump pyyaml from 5.3 to 5.4 <dependencies> <python> <Created by dependabot[bot]> <https://github.com/snapcore/snapcraft/pull/3490>21:41
=== Eighth_Doctor is now known as Conan_Kudo
=== Conan_Kudo is now known as Eighth_Doctor
=== Eighth_Doctor is now known as Conan_Kudo
=== Conan_Kudo is now known as Eighth_Doctor

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!