=== Eighth_Doctor is now known as Conan_Kudo
=== Conan_Kudo is now known as Eighth_Doctor
=== JanC_ is now known as JanC
[07:14] <mborzecki> morning
[07:17] <zyga> mborzecki o/
[07:18] <zyga> mborzecki left a note on the snap-confine PR
[07:18] <mborzecki> zyga: hey
[08:03] <pstolowski> morning
[08:11] <mvo> good morning pstolowski and mborzecki
[08:11] <mborzecki> mvo: pstolowski hey
[08:26] <mvo> mborzecki: can I squash merge 10054 (the usr-lib-snapd.mount fix)?
[08:26] <mborzecki> mvo: i pushed a little tweak there, so we need to wait for spread to finish, but otherwise yes
[08:27] <mvo> mborzecki: cool
[08:27] <mvo> mborzecki: yeah, happy to wait
[08:32] <pstolowski> need 2nd review for https://github.com/snapcore/snapd/pull/10079
[08:32] <mup> PR #10079: api: provide meaningful error message on connect/disconnect for non-installed snap <Bug> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10079>
[08:36] <mup> PR snapd#10082 opened: github: try out golangci-lint <Simple 😃> <Skip spread> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10082>
[11:32] <mvo> mborzecki: is squash-merging 10081 okay?
[11:33] <mborzecki> mvo: yes
[11:36] <mup> PR snapd#10054 closed: overlord/snapstate, wrappers: add dependency on usr-lib-snapd.mount for services on core with snapd snap <Squash-merge> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10054>
[12:01] <mup> PR snapd#10083 opened: [RFC] systemd: enrich UnitStatus returned by systemd.Status() with Installed flag <Created by stolowski> <https://github.com/snapcore/snapd/pull/10083>
[12:03] <pstolowski> mvo, mborzecki ^ wdyt?
[12:08] <mvo> pstolowski: I like this, UnitFileState seems to be more predicatable than status and it's well documented in https://man7.org/linux/man-pages/man5/org.freedesktop.systemd1.5.html
[12:09] <mvo> pstolowski: but let's move this to 2.50, it seems to grow too much for 2.49, thanks for investigating and getting to the bottom of this though!
[12:10] <pstolowski> mvo: yeah, ok, i'd prefer not to rush it as well
[12:11] <mup> PR snapd#10084 opened: snap-seccomp: fix seccomp test on ppc64el <Created by mvo5> <https://github.com/snapcore/snapd/pull/10084>
[12:13] <mvo> ijohnson[m][m]: I will merge 10051 now but I think I won't squash because for 2.49 I will also need to collect all the prereqs from samuele so it needs to be a PR anyway, does that sound okay?
[12:16] <ijohnson> mvo that sounds good to me
[12:26] <mup> PR snapd#10085 opened:  cmd/snap-bootstrap/initramfs-mounts: move time forward using assertion times (2.49) <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10085>
[12:31] <mup> PR snapd#10065 closed: tests: reset the system while preparing the test suite <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10065>
[12:32] <mvo> ijohnson: I will force-merge 10051 after lunch, just running the nested 18.04 test here locally to double check. it fails in gce right now but it looks like a fluke
[12:33] <mvo> (and re-running the full thing for this seems wasteful)
[12:33] <ijohnson> Sure thanks for checking on that
[13:13] <mborzecki> hmm can't get annotations to work in https://github.com/snapcore/snapd/pull/10082
[13:13] <mup> PR #10082: github: try out golangci-lint <Simple 😃> <Skip spread> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10082>
[13:18] <mborzecki> haaa it works
[13:19] <ijohnson> woahhhhh that's super cool!
[13:23] <mborzecki> i'll make it non-fatal for now until we can tune it
[13:38] <zyga> mborzecki I second that - that's totally awesome
[13:46] <mvo> mborzecki: \o/ nice!
[13:52] <mup> PR snapd#10086 opened: tests: unifying the core20 nested suite with the core nested suite <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10086>
[14:12] <mup> PR snapd#10078 closed: tests: handle "snap refresh" returning an empty reply gracefully <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10078>
[14:37] <mup> PR snapd#10051 closed: cmd/snap-bootstrap/initramfs-mounts: move time forward using assertion times <Run nested> <Squash-merge> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10051>
[14:47] <mup> PR snapd#10081 closed: interfaces, interfaces/apparmor, overlord/snapstate: late removal of snap-confine apparmor profiles <Squash-merge> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10081>
[14:52] <mup> PR snapd#10084 closed: snap-seccomp: fix seccomp test on ppc64el <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10084>
[15:01] <mvo> ijohnson: I'm sitting on the fence a bit about 10085, it's 2k lines to backport everything we need to do the initramfs timetravel, I'm wondering if it's too risky for a .N release, wddyt?
[15:01] <ijohnson> hmm
[15:02] <ijohnson> mvo: let me take a look at the pr
[15:05]  * cachio lunch
[15:09] <ijohnson> mvo: well most of that pr is tests only change
[15:09] <ijohnson> the thing I would be most concerned about is the changes to seed, as they are extensive
[15:09] <ijohnson> the refactoring that pedronis did is difficult to reason about imho, so while it was approved, I guess I'm not sure how comfortable I am putting it into a .N release
[15:44] <mvo> mborzecki: I guess we can close 10056, 10066 now?
[15:45] <mborzecki> mvo: both shoudl be closed already
[15:46] <mvo> mborzecki: aha, great, soory, then the GH view I had confused me
[16:12] <mup> PR snapd#10087 opened: release: 2.49.2 <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10087>
=== ijohnson is now known as ijohnson|lunch
[17:25] <mvo> cachio: 2.49.2 is in core/beta (only ppc64el still uploading)
[17:25] <cachio> mvo, nice, thanks
[17:25] <cachio> I'll make sure all the tests are executed
[17:25] <mvo> cachio: if we could get it into candidate on monday that would be ideal
[17:25] <mvo> cachio: thanks!
[17:25] <mvo> cachio: snapd should also be ready soon (within the next 30min)
[17:25] <cachio> mvo, nice
[17:26] <cachio> mvo, ta
[17:26] <mvo> thank you!
[17:33] <mvo> cachio: snapd is also in beta
[17:43] <blackboxsw> Hey folks, question about expectations for installing confined snaps running on a Desktop LiveCD? Do we expect this to be working currently? https://forum.snapcraft.io/t/confined-snaps-dont-work-on-live-images-due-to-apparmor-path-mapping/3767/10
[17:44] <blackboxsw> I ask becaouse I get errors from snapd/snap-confine:error while laoding shared libraries: libudev.so.1: cannot open shared object file: No such file or directory)
[19:38]  * cachio afk
=== ijohnson|lunch is now known as ijohnson
[20:00] <ijohnson> blackboxsw: do you mean on an Ubuntu Desktop LiveCD ?
[20:01] <ijohnson> it should be supported, I know we have had issues with it before and i.e. overlayfs but last I tried it with 20.04 a few weeks ago it worked fine for me
[20:02] <blackboxsw> ijohnson: thanks. I was just running on xenial DesktopLiveCD trying to install canonical-livepatch for testing purposes. I'll try bionic and focal now
[20:02] <blackboxsw> likely something not available on Xenial maybe
[20:02] <ijohnson> hmm yeah dunno about xenial, but definitely should work on bionic and focal
[20:02] <blackboxsw> thx for the FYI, I can test the full install instead of livecd on xenial if needed
[20:03] <ijohnson> well snaps surely work on a fully installed system of xenial, we have many hundreds of test that run daily for this situation
[20:03] <ijohnson> we don't test live cd systems though
[20:03] <oerheks> live iso would have an too old snapd, xenial.
[20:03] <ijohnson> ah yeah that's a good point, probably need to update the snapd deb in the live cd after you've booted it
[20:04] <blackboxsw> ahh that's the ticket. yep I bet. will upgrade the deb there.
[21:18] <mup> PR snapd#10088 opened: o/configstate/configcore/picfg.go: use ubuntu-seed config.txt in uc20 run mode <Bug> <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10088>
[22:23] <mup> PR snapd#10089 opened: o/configstate/configcore: simple refactors in preparation for new function <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10089>