| mup | PR snapcraft#2941 closed: [WIP] extensions: add cleanup extension <Created by galgalesh> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2941> | 00:19 |
|---|---|---|
| mup | PR snapcraft#3461 closed: repo: account for arch & version when filtering stage packages <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3461> | 00:19 |
| mup | PR snapcraft#2826 closed: Copy npm and npx binaries in snap <Created by guilhem> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/2826> | 00:24 |
| === JanC_ is now known as JanC | ||
| mup | PR snapd#10099 opened: tests/main/snapd-snap: build the snapd snap on all platforms with lxd <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10099> | 04:50 |
| mup | PR snapd#9984 closed: boot/flags.go: add SetNextBootFlags, NextBootFlags for snapd_next_boot_flags bootenv <Simple 😃> <UC20> <⛔ Blocked> <Created by anonymouse64> <Closed by anonymouse64> <https://github.com/snapcore/snapd/pull/9984> | 04:55 |
| mborzecki | morning | 06:00 |
| pstolowski | morning | 07:00 |
| mborzecki | pstolowski: hey | 07:04 |
| mborzecki | is cla check back to working state again? | 07:10 |
| mvo | good morning pstolowski and mborzecki ! | 07:13 |
| mvo | mborzecki, pstolowski anything critical I missed while I was off? | 07:14 |
| mup | PR snapd#10100 opened: github: revert cla-check action <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10100> | 07:15 |
| mborzecki | mvo: hm not quite, aside from the cla action making LP database cry a little bit :) | 07:16 |
| pstolowski | mvo: not really, apart from that cla issue | 07:17 |
| mvo | mborzecki: haha, we can always revert that if it's a problem | 07:22 |
| mvo | (I assume we can :) ?) | 07:22 |
| zyga_ | hey | 07:26 |
| mborzecki | yeah, see #10100 | 07:26 |
| mup | Bug #10100: pgadmin3: new changes from Debian require merging <Ubuntu:Fix Released by cjwatson> <https://launchpad.net/bugs/10100> | 07:26 |
| mup | PR #10100: github: revert cla-check action <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10100> | 07:26 |
| === zyga_ is now known as zyga-fyke | ||
| zyga-fyke | hey mvo :) | 07:27 |
| mvo | good morning zyga-fyke | 07:28 |
| mvo | mborzecki: \o/ | 07:30 |
| zyga-fyke | mvo, all releases are late, including ours ;-) | 07:30 |
| zyga-fyke | arguably it's late because docs and website are not in place but it's late non the less | 07:31 |
| zyga-fyke | how are you guys doing? | 07:31 |
| mvo | mborzecki: did we talk to marcus (I think it was him who wrote it?) about it? | 07:31 |
| mvo | zyga-fyke: hello! | 07:31 |
| mborzecki | mvo: there was some investigation on internal mm, pstolowski knows the details, but iirc it hit some unoptimized database query in lp | 07:31 |
| pstolowski | mvo: https://bugs.launchpad.net/launchpad/+bug/1921727 | 07:32 |
| mup | Bug #1921727: Error 503 when trying to iterate over lp.people[team].participants <lp-registry> <oops> <timeout> <Launchpad itself:In Progress by cjwatson> <https://launchpad.net/bugs/1921727> | 07:32 |
| cjwatson | mborzecki,mvo: awaiting review of my fix for the query in question | 08:46 |
| mborzecki | cjwatson: thanks for the info! | 08:47 |
| mborzecki | (and the fix) | 08:47 |
| pstolowski | is pedronis off today? | 08:57 |
| mvo | pstolowski: he is here but had lot's of meetings so far | 09:05 |
| pstolowski | mvo: ah ok | 09:06 |
| mup | PR snapd#10093 closed: o/configstate/configcore/picfg.go: add hdmi_cvt support <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10093> | 09:40 |
| pedronis | #10077 needs a 2nd review | 09:52 |
| mup | Bug #10077: libforms1: new changes from Debian require merging <Ubuntu:Fix Released by cjwatson> <https://launchpad.net/bugs/10077> | 09:52 |
| mup | PR #10077: o/configstate: fix panic with a sequence of config unset ops over same path <Bug> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10077> | 09:52 |
| pstolowski | pedronis: hi, i have been pondering storing of refresh hints in the state; do you think storing snap.Infos will be too much? | 09:54 |
| pedronis | pstolowski: yes, also we don't support serialising them to JSON | 09:55 |
| pedronis | at least atm | 09:55 |
| pstolowski | pedronis: yes i know | 09:55 |
| pedronis | pstolowski: I think we need to store something like a partial SnapSetup maybe? | 10:00 |
| pstolowski | pedronis: I think SnapActionResult should remain untouched and still have snap.Info inside? | 10:07 |
| * pstolowski quick errand | 10:20 | |
| pedronis | pstolowski: yes, if we do changes they would be in snapstate, not store | 10:28 |
| pstolowski | ack | 11:17 |
| mup | PR snapd#10040 closed: daemon: switch api_test.go to daemon_test and various other cleanups <Cleanup :broom:> <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10040> | 11:26 |
| === pedronis_ is now known as pedronis | ||
| cachio | ijohnson, mborzecki hi | 12:28 |
| cachio | I see this error creating new images | 12:28 |
| cachio | + go get -u github.com/kardianos/govendor | 12:28 |
| cachio | go: unknown environment setting GO111MODULE=false | 12:28 |
| cachio | running the spread suite | 12:28 |
| cachio | it is a new thing | 12:29 |
| cachio | do you know if it is something that we changed? | 12:29 |
| mborzecki | hmm that should be set to "off" | 12:33 |
| mborzecki | cachio: we don't set it to false anywhere afaict | 12:34 |
| cachio | mmm | 12:34 |
| cachio | mborzecki, ok, because ubuntu failed with this | 12:35 |
| cachio | and also arch | 12:35 |
| cachio | and debian | 12:36 |
| mborzecki | cachio: which PR? | 12:36 |
| cachio | mborzecki, none | 12:37 |
| cachio | it is in the project that creates the images | 12:37 |
| cachio | all the iamges failed with the same error | 12:37 |
| cachio | after I create the images I run spread tests to check if the new image is ok | 12:38 |
| cachio | and those tests failed for all the systems | 12:38 |
| mborzecki | cachio: do you run the usual spread suite? | 12:38 |
| cachio | mborzecki, yes, using master | 12:39 |
| cachio | I'll generate a new image so I can see if there is a new dep which is causing this | 12:40 |
| cachio | does it make sense to you mborzecki ? | 12:40 |
| mborzecki | cachio: do you have full log? | 12:40 |
| cachio | mborzecki, https://pipelines.actions.githubusercontent.com/ANH3epfEq8kK29ooCw1oX3TaDZYrJJO2v99mFUMnzzJVA9pM4I/_apis/pipelines/1/runs/880/signedlogcontent/3?urlExpires=2021-03-31T12%3A42%3A04.1175091Z&urlSigningMethod=HMACV1&urlSignature=gobugoripjjOpyw9H0xAecsg1vxmrGH8%2FjWsO9usJt0%3D | 12:41 |
| mborzecki | cachio: hm url expired, which project executed that? | 12:43 |
| cachio | mborzecki, https://paste.ubuntu.com/p/45xF5mzPDT/ | 12:44 |
| cachio | mborzecki, spread-cron | 12:44 |
| mborzecki | cachio: hmm weird, as i wrote, we don't seem to be setting GO111MODULE=false anywhere, we do set it to `off` | 12:48 |
| cachio | mborzecki, yes, I saw the same | 12:48 |
| cachio | but it is failing in all the images | 12:48 |
| cachio | so, perhaps there is dependency which is doing that | 12:49 |
| mup | PR snapd#10086 closed: tests: unifying the core20 nested suite with the core nested suite <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10086> | 13:01 |
| mup | PR snapd#10092 closed: tests: uboot-unpacked-assets updated to reflect the real path used to find the kernel <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10092> | 13:01 |
| pedronis | ijohnson: should I force landing https://github.com/snapcore/snapd/pull/10089 ? | 13:35 |
| mup | PR #10089: o/configstate/configcore: simple refactors in preparation for new function <Simple 😃> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10089> | 13:35 |
| ijohnson | pedronis: yes sorry I asked you about that yesterday but you must have missed my message | 13:36 |
| ijohnson | pedronis: https://github.com/snapcore/snapd/pull/10073 too please | 13:36 |
| mup | PR #10073: o/devicestate/devicemgr: register install-device hook, run if present in install <Needs Samuele review> <Run nested> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10073> | 13:36 |
| ijohnson | all the failures on those two prs are unrelated | 13:36 |
| pedronis | ijohnson: had a short break, doing that now | 14:02 |
| ijohnson | thank you | 14:02 |
| pedronis | ijohnson: done | 14:04 |
| mup | PR snapd#10073 closed: o/devicestate/devicemgr: register install-device hook, run if present in install <Needs Samuele review> <Run nested> <UC20> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10073> | 14:06 |
| mup | PR snapd#10089 closed: o/configstate/configcore: simple refactors in preparation for new function <Simple 😃> <UC20> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10089> | 14:06 |
| mup | PR snapd#10101 opened: tests: add spread test for snap validate against store assertions <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10101> | 14:16 |
| pedronis | pstolowski: in all the red I missed that https://github.com/snapcore/snapd/pull/10083 has a real static check issue with formatting | 14:28 |
| mup | PR #10083: systemd: enrich UnitStatus returned by systemd.Status() with Installed flag <Created by stolowski> <https://github.com/snapcore/snapd/pull/10083> | 14:28 |
| pstolowski | pedronis: ah sorry, missed that yoo | 14:29 |
| pstolowski | *too | 14:29 |
| pstolowski | updated | 14:31 |
| pedronis | pstolowski: https://bugs.launchpad.net/snapd/+bug/1899992 is fix committed? it's in 2.49.2? | 14:35 |
| mup | Bug #1899992: refresh.timer=managed prevents setting other configurations, e.g. proxy.http <snapd:In Progress by stolowski> <https://launchpad.net/bugs/1899992> | 14:35 |
| pstolowski | pedronis: yes, it's in 2.49.2 | 14:39 |
| pedronis | pstolowski: thx, I updated the bug | 14:59 |
| pstolowski | ty | 14:59 |
| mup | PR snapd#10102 opened: daemon: introduce apiBaseSuite.(json|sync|async|error)Req (and some apiBaseSuite comsmetics) <Created by pedronis> <https://github.com/snapcore/snapd/pull/10102> | 15:36 |
| pedronis | pstolowski: mvo: another step of cleanups ^ | 15:39 |
| mvo | pedronis: nice, thank you! in a meeting | 15:39 |
| mvo | pedronis: will have a look after :) | 15:39 |
| pstolowski | pedronis: thanks | 15:40 |
| pedronis | ijohnson: what's the state of https://github.com/snapcore/snapd/pull/10088 vs https://github.com/snapcore/snapd/pull/9965 ? it sounds like we should just look at the latter? | 15:45 |
| mup | PR #10088: o/configstate/configcore/picfg.go: use ubuntu-seed config.txt in uc20 run mode <Bug> <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10088> | 15:45 |
| mup | PR #9965: sysconfig, o/configstate/configcore: first step to image build pi-config application <Bug> <UC20> <â›” Blocked> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/9965> | 15:45 |
| ijohnson | pedronis: sorry if I didn't make it clear enough but look at 10088 first | 15:46 |
| ijohnson | the changes in 9965 depend on 10088 now | 15:46 |
| pedronis | yes, but it also says the change are a bit broken | 15:46 |
| ijohnson | you could look at 9965 for the full picture but I'd rather land the smaller change first | 15:46 |
| pedronis | and it's 84 lines | 15:46 |
| ijohnson | I just meant by that that there is a subtle bug in the smaller PR that is fixed in the larger one | 15:47 |
| ijohnson | if you really want I can force repush everything to include the fix in the smaller one | 15:47 |
| ijohnson | pedronis: to be clear, the smaller PR fixes the verbatim bug that we write to the wrong file on uc20 run mode and during seeding | 15:48 |
| ijohnson | pedronis: the larger pr is the one that adds the new feature which pre-configures config.txt at image build time, which is not a bug per se, at least not one anybody has loudly complained about | 15:49 |
| pedronis | ijohnson: shouldn't we import boot to find the mode? | 15:49 |
| ijohnson | pedronis: do you want to leave a review instead? it may be easier to track your comments and my responses than over IRC | 15:50 |
| pedronis | sorry, I thought it would be an easy win but itsn't, I will do a proper review in the morning | 15:52 |
| ijohnson | ok, no rush thanks for taking a look | 15:52 |
| pedronis | anyway I left a comment with my question | 15:55 |
| === waveform_ is now known as waveform | ||
| * cachio lunch | 16:17 | |
| === ijohnson is now known as ijohnson|lunch | ||
| === mcphail9 is now known as mcphail | ||
| === ijohnson|lunch is now known as ijohnson | ||
| === jnsgruk01 is now known as jnsgruk | ||
| mup | PR snapd#10103 opened: boot: support read/writing boot-flags from userspace/initramfs <Needs Samuele review> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10103> | 21:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!