[15:28] <powersj> AnhVoMSFT, hi! I see 21.1 in proposed for all releases
[15:41] <Odd_Bloke> I believe Anh was using the proposed PPA, not -proposed: we've added "why didn't we upload to the PPA" to our retrospective list.
[15:41] <Odd_Bloke> (We clarified via email, apologies for not reflecting that here!)
[16:02] <powersj> ah! ok
[16:15] <hamalq> hi any feedback on https://github.com/canonical/cloud-init/pull/859 thanks
[16:17] <blackboxsw> falcojr: if you get a chance as you undig from holiday, would you be able to review #859 I know you had some thoughts on how that cloud-config should look to prefer shorter hostnames
[16:17] <hamalq> i got some feedback there am checking now
[16:18] <falcojr> sorry about that delay hamalq , I was out for the past few days
[16:19] <hamalq> falcojr: its fine thank u for the review
[16:20] <hamalq> if i understand the comments right i should add an option prefer_fqdn_over_hostname which by default should be true and if false use the hostname for rhel i will do the change now
[16:20] <blackboxsw> #startmeeting cloud-init bi-weekly office-hours
[16:20] <meetingology> Meeting started at 16:20:26 UTC.  The chair is blackboxsw.  Information about MeetBot at https://wiki.ubuntu.com/meetingology
[16:20] <meetingology> Available commands: action, commands, idea, info, link, nick
[16:21] <falcojr> I think by default it should use the current defaults of what's chosen...e.g., true for rhel and false for others
[16:22] <blackboxsw> Hi cloud-init! This marks another episode of cloud-init community office hours. This time is an opportunity to discuss any cloud-init questions, bugs or topics with cloud-init upstream developers. We try to ensure a couple of devs have eyes on this channel to field any questions/concerns folks may have.
[16:24] <Odd_Bloke> o/
[16:25] <blackboxsw> Recent happenings in cloud-init space are generally spent on the current SRU validation with Odd_Bloke and falcojr. It looks like we've cleared the last manual validation with that SRU and we will be waiting on a significant automated set of tests to pass before making this release public. https://discourse.ubuntu.com/t/cloud-init-status-04-06-2021/21691
[16:32] <blackboxsw> thanks falcojr and Odd_Bloke for reviews on https://github.com/canonical/cloud-init/pull/859
[16:36] <hamalq> i already did the change as the comment
[16:37] <hamalq> i dont think i can change cloudinit/distros/__init__.py  select_hostname though
[16:38] <falcojr> we can change it...we just need to make sure the functionality stays the same if the option isn't specified
[16:39] <hamalq> thats the point since the default for that option is true
[16:40] <hamalq> unless we make the default for it false for other distros
[16:41] <falcojr> yes, we would need to take it into account for all distros, and it would default to false for most
[16:42] <hamalq> +1
[16:47] <hamalq> i changed that now for distros and rhel
[17:15] <hamalq> i think i got the changes required https://github.com/canonical/cloud-init/pull/859
[17:36] <blackboxsw> thanks folks for attending the office hours. See you all in two weeks. Same time
[17:37] <blackboxsw> #endmeeting
[17:37] <meetingology> Meeting ended at 17:37:25 UTC.  Minutes at https://new.ubottu.com/meetingology/logs/cloud-init/2021/cloud-init.2021-04-06-16.20.moin.txt
[17:50] <hamalq> do i need to do more changes to get the https://github.com/canonical/cloud-init/pull/859 approved
[18:02] <blackboxsw> hamalq: minimally I'd like to see unit tests on this and it probably would be good to extend an integration test for this PR too. this comes from our code review process docs https://cloudinit.readthedocs.io/en/latest/topics/code_review.html#prerequisites-for-landing-pull-requests
[18:02] <blackboxsw> I'm not sure if you'd already added unit tests but not pushed? as the PR checkbox is set for "adding unit tests accordingly'
[18:03] <hamalq> i did not see the test for rhel can u please point me there ( am not so familiar with the code )
[18:11] <hamalq> i think i found it tests/unittests/test_handler/test_handler_set_hostname.py
[18:13] <blackboxsw> @hamalq added comments to your branch and pointers to the right unittest and integration test files
[18:14] <blackboxsw> thanks sorry, I figured it was better to put that on review
[18:14] <hamalq> ok thankd
[18:15] <blackboxsw> since there is "prior art" in both of those tests, I hope it is straightforward to add both unit tests and extend the exist integration test for this case. If you get stuck on anything we should be able to get you over the obstacle pretty fast. thanks again
[18:32] <hamalq> yeah the set hostname part should be easy
[18:33] <hamalq> but this test cloudinit/distros/tests/test_init.py is confusing
[18:59] <blackboxsw> hamalq, the test_init.py only covers _get_package_mirror_info currently, if you chose to extend tests there I'd expect to see a new class TestDistro which would contain a test that'd instantiate the distro class and exercise mydistro._select_hostname
[19:00] <blackboxsw> otherwise, you might just be able to continue to extend tests in set_hostname and it'd essentially meet the same coverage from a higher level up in the code
[19:00] <blackboxsw> your choise how you prefer to proceed
[19:02] <hamalq> set_hostname its then
[20:13] <Odd_Bloke> blackboxsw: Did you get started on an integration test for #721?  I'm looking at fixing the regression it caused, but don't want to regress the functionality itself.
[20:14] <blackboxsw> @Odd_Bloke I regret that I haven't yet. Still floating in a sea of UA
[20:14] <blackboxsw> I don't mind constructing that test now so that there's something to compare against tomorrow
[20:15] <Odd_Bloke> blackboxsw: That'd be great, if you can fit it in.
[20:15] <Odd_Bloke> (If not, no worries, I can put something together myself. :)
[20:15] <blackboxsw> yes I'd like to fit it in today Odd_Bloke. I need more integration test work anyway
[21:16] <hamalq> i added 2 unit test, 1 integration test update the doc ( am not good at documentation) https://github.com/canonical/cloud-init/pull/859
[23:34] <hamalq> can i get +1 on that change above ^^