[01:06] <mup> PR snapd#10114 closed: tests/lib/prepare-restore.sh: clean out snapd changes and snaps before purging <Test Robustness> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10114>
=== popey0 is now known as popey
[02:51] <mup> PR snapd#10061 closed: interfaces/pwm: add PWM interface <Needs Samuele review> <Created by woodrow-shen> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10061>
[05:38] <mborzecki> morning
[05:42] <mup> PR snapd#10103 closed: boot: support read/writing boot-flags from userspace/initramfs <Needs Samuele review> <UC20> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10103>
[07:02] <pstolowski> morning
[07:03] <mborzecki> pstolowski: hey
[07:03] <mborzecki> pstolowski: trivial PR to start your day with? 🙂 https://github.com/snapcore/snapd/pull/10121
[07:03] <mup> PR #10121: boot, cmd/snap: include extra cmdline args in debug boot-vars output <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10121>
[07:04] <pstolowski> +1
[07:07] <mup> PR snapd#10121 closed: boot, cmd/snap: include extra cmdline args in debug boot-vars output <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10121>
[07:07] <mborzecki> pstolowski: thanks!
[07:07] <pstolowski> yw
[07:32] <zyga> good morning
[08:40] <pstolowski> hey zyga !
[08:40] <zyga> pstolowski :-)
[09:19] <pstolowski> pedronis: hi, i've updated #10068
[09:19] <mup> Bug #10068: kbd-chooser: new changes from Debian require merging <kbd-chooser (Ubuntu):Fix Released by cjwatson> <https://launchpad.net/bugs/10068>
[09:19] <mup> PR #10068: o/configstate: don't pass --root=/ when masking/unmasking/enabling/disabling services <Run nested> <Squash-merge> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10068>
[09:19] <mvo> pstolowski: \o/
[09:20] <pstolowski> let's wait for spread test though ;)
[09:38] <pedronis> pstolowski: the good looks alright to me
[10:20] <pedronis> s/good/code/
[10:22] <mvo> yeah, looks good to me as well, thanks pstolowski
[10:25] <pstolowski> mvo, pedronis note i deliberately excluded ssh/consoleconf there
[10:58] <mup> PR snapd#10126 opened: daemon: make ucrednetGet() return a *ucrednet structure <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/10126>
[11:10] <pedronis> jamesh: ^ thanks
[11:19] <pedronis> pstolowski: I think core and core20 were unified on master now
[11:19] <pstolowski> pedronis: ah, missed that, checking
[11:20] <jamesh> pedronis: Just created https://github.com/snapcore/snapd/pull/10127 with the access checker implementations
[11:20] <mup> PR #10127: daemon: add new accessChecker implementations <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/10127>
[11:21] <pedronis> jamesh: thanks
[11:23] <mup> PR snapd#10127 opened: daemon: add new accessChecker implementations <Created by jhenstridge> <https://github.com/snapcore/snapd/pull/10127>
[11:28] <pstolowski> pedronis: hmm they were but i think spread.yaml wasn't updated for it (ubuntu-16.04-64, ubuntu-18.04-64 only for tests/nested/core/) and we aren't really running core20 nested tests now?
[11:29] <pedronis> :/
[11:29] <pedronis> pstolowski: please discuss this with Ian and Sergio
[11:29] <pstolowski> sure
[11:33] <mup> PR snapd#10116 closed: gadget: be more flexible with kernel content resolving <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10116>
[11:38] <mup> PR snapd#10117 closed: cmd/snap-bootstrap/initramfs-mounts: write active boot-flags to /run  <Run nested> <Simple 😃> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10117>
[11:40] <pstolowski> hmmm maybe it works, but then i'm confused
[11:41] <pstolowski> cachio: hey, isn't https://github.com/snapcore/snapd/pull/10086 missing 20.04 in systems: for nested/core ?
[11:41] <mup> PR #10086: tests: unifying the core20 nested suite with the core nested suite <Run nested> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10086>
[11:41] <cachio> pstolowski, checking
[11:42] <cachio> hi
[11:42] <cachio> pstolowski, yes
[11:42] <pstolowski> cachio: ok, i've a pr for that
[11:43] <cachio> pstolowski, nice catch
[11:43] <cachio> thnanks
[11:43] <pstolowski> cachio: however, i could still exeute google-nested:ubuntu-20.04-64:tests/nested/core/core20-basic and it works (?)
[11:46] <cachio> yes
[11:46] <cachio> even you can run a manual test in case the suite is marked as manual
[11:48] <mup> PR snapd#10128 opened: Add 20.04 to systems for nested/core <Run nested> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10128>
[12:04] <ijohnson> ooof good catch pstolowski
[12:07] <pedronis> pstolowski: I answered your question in https://github.com/snapcore/snapd/pull/10053
[12:07] <mup> PR #10053: o/snapstate: helper for getting snaps affected by refresh, define new hook <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10053>
[12:08] <pstolowski> thanks
[13:08] <mup> PR snapd#10129 opened:  boot: set extra kernel command line arguments when making a recovery system bootable <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10129>
[13:43] <mup> PR snapd#10068 closed: o/configstate: don't pass --root=/ when masking/unmasking/enabling/disabling services <Run nested> <Squash-merge> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10068>
[13:57] <mvo> ijohnson silly question, what's the thinking on https://github.com/snapcore/snapd/pull/10110 ? it's marked 2.50 but it's also blocked
[13:57] <mup> PR #10110: interfaces/builtin: introduce dsp-control interface <⛔ Blocked> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10110>
[13:57] <mvo> ijohnson do we need it for 2.50 still?
[13:58] <ijohnson> mvo: need to ask woodrow about that one, woodrow said it was needed soon for a delivery, but he tested the PR and said it worked for what woodrow has access to, but waiting for the customer to test the interface with their software (which woodrow doesn't have access to afaik) before we can merge it
[13:58] <ijohnson> I'll ping him now on MM, maybe he's still around today yet
[13:58] <mup> PR snapd#10003 closed: configstate: add a config option for systemd-resolved <Needs Samuele review> <Created by woodrow-shen> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10003>
[14:01] <ijohnson> mvo: well also the pr needs security review, so probably monday is soonest it could land in any case
[14:11] <mvo> ijohnson yeah, it's fine, I can review and we can cherry-pick it
[14:39] <mborzecki> ijohnson: i replied in https://github.com/snapcore/snapd/pull/10120/files#r610678787 does that make sense?
[14:39] <mup> PR #10120: boot: derive boot variables for kernel command lines <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10120>
[14:39] <ijohnson> mborzecki: I understand that, I guess I think it would be nice if we supported this as a feature generally, not just for secure boot
[14:40] <ijohnson> the issue being that if you want to tweak the kernel command line for pi for example, it's rather difficult to do by modifying our upstream gadget
[14:40] <mborzecki> ijohnson: yeah, afaiu this is/will be goal once we support the secure boot case fully
[14:40] <ijohnson> you have to un-mkimage the asset from flash-kernel PPA, then re-mkimage boot.scr
[14:42] <ijohnson> mborzecki: sure if the eventual goal is to support this generally for more bootloaders and we are just doing the minimal work for secure boot that's fine, but I just want to still keep more bootloaders as the eventual goal
[14:43] <ijohnson> maybe because I haven't seen the full code change but it feels like it shouldn't be a lot more work to enable it for other bootloaders, but again I haven't seen your full code
[15:12] <mvo> ijohnson: I removed blocked from 10110
[15:12] <mvo> ijohnson I think that is in line with what we discussed?
[15:12] <ijohnson> yes
[15:18] <mborzecki> ijohnson: btw #10129 is where that helper from boot is being used
[15:18] <mup> Bug #10129: shadow: new changes from Debian require merging <shadow (Ubuntu):Fix Released by mdz> <https://launchpad.net/bugs/10129>
[15:18] <mup> PR #10129:  boot: set extra kernel command line arguments when making a recovery system bootable <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10129>
[15:19] <ijohnson> mborzecki: ack will take a look
[15:19] <ijohnson> thanks
[15:21]  * cachio lunch
[15:26] <mborzecki> netplan test failed? https://paste.ubuntu.com/p/MTbDcbWxZN/ seems like after netplan apply connection to the spread node was lost
[15:42] <ijohnson> hmm that seems bad
[15:58] <mborzecki> ijohnson: at least some part of the configuration was applied
[16:09] <mup> PR snapd#10130 opened: boot: load bits of kernel command line from gadget snaps <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10130>
[16:15] <mborzecki> that's it, don't want to spam the snapd repo with more PRs at this point
[16:44] <mvo> can I get a +1 on 9999 so that I can land it on master? this way we can test kernel-dtb on edge end-to-end
[16:44] <mvo> (super trivial PR)
=== pedronis_ is now known as pedronis
[16:54] <pedronis> mvo: done
[16:54] <mup> PR snapd#10131 opened: tests: new os.paths tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10131>
[16:54] <mvo> pedronis: thanks!
[16:55] <mvo> cachio_: I branched 2.50 and triggered the 2.50~pre1 build in the beta/ channel
[16:55] <mvo> cachio_: I will also try to get core to better later tonight
[16:55] <mvo> cachio_: hopefully the various pi tests can run then
[16:58] <pedronis> ijohnson: I missed this,  boot-flags should probably live in /run/snapd not /run/snapd/snap-bootstrap
[16:59] <ijohnson> pedronis: ah okay, I thought since it's something that only snap-bootstrap writes to, that snap-bootstrap "owns" it and thus it should live under snap-bootstrap's dir
[16:59] <pedronis> ijohnson: it strange for boot to refer to dirs.SnapBootstrapRunDir
[17:00] <ijohnson> doesn't seem strange to me, but okay
=== ijohnson is now known as ijohnson|lunch
[18:04] <mup> PR snapd#9999 closed: snapstate: add "kernel-assets" to featureSet <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/9999>
[18:21] <pedronis> ijohnson|lunch: I'm working on changing that file location
[18:41] <ijohnson|lunch> pedronis: ack
=== ijohnson|lunch is now known as ijohnson
[18:55] <pedronis> ijohnson: did we possibly break something recently with core20, I have seen ubuntu-core-20 tests timing out in prepare in spread, and I'm seeing from a run started locally right now
[18:55] <ijohnson> pedronis: I haven't seen that
[18:55] <ijohnson> do you have any more logs other than it just times out ?
[18:55] <ijohnson> also normal uc20 spread tests or nested ?
[18:55] <pedronis> normal
[18:56] <pedronis> I'm trying to run google:ubuntu-core-20-64:tests/core/basic20
[18:56] <pedronis> and seems stuck on reboot
[18:57] <ijohnson> ok, I will try to reproduce
[18:57] <pedronis> might be the changes I did here, but I have a timeout today also in a different spread
[18:57] <pedronis> *have seen
[19:03] <pedronis> ijohnson: I proposed https://github.com/snapcore/snapd/pull/10132, as I said it got stuck on reboot so the test/code might be broken, though the changes are simple
[19:03] <mup> PR #10132: boot,tests: move where we write boot-flags one level up <Squash-merge> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10132>
[19:03] <ijohnson> pedronis: ack I will have a look
[19:04] <mup> PR snapd#10132 opened: boot,tests: move where we write boot-flags one level up <Squash-merge> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10132>
[19:09]  * cachio_ afk
[19:28] <ijohnson> pedronis: if you're still around I finished refactoring the dsp pr
[20:25] <ijohnson> also fwiw I have run uc20 on gce 3 times in a row without reproducing the prepare failure
[20:26] <ijohnson> well run google:ubuntu-core-20-64:tests/core/basic20 that is
[20:44] <mup> PR snapd#10133 opened: wrappers/services.go: introduce EnsureSnapServices() <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10133>