=== vrubiolo1 is now known as vrubiolo
[16:40]  * blackboxsw goes through https://github.com/canonical/cloud-init/pull/859 thx falcojr/hamalq in detail now thanks folks.
[16:45] <hamalq> +1
[16:45] <hamalq> :)
[16:56]  * blackboxsw hamalq: falcojr I think that is really clean and tidies things up more as it's explicit. I have a couple of minor doc comments that I'll wrap in in the next 20 mins as I test this. but otherwise I think it looks great.
[16:56] <hamalq> thanks
[16:57] <blackboxsw> and I love seeing us remove private methods/overrides btw
[16:58]  * blackboxsw hamalq: while you await my minor review can you update the PR description to better describe this generic prefer_fqdn_over_hostname switch given that it's more broad than RHEL only
[16:58]  * blackboxsw we will be using that example commit message description at the top of your PR when squash merging
[16:58] <blackboxsw> we will be using that example commit message description at the top of your PR when squash merging
[16:59] <hamalq> ok
[17:01] <blackboxsw>  I'm going to walk through what data was in distro._cfg  too just to confirm the set_option approach to see if it raises any concerns.
[17:02] <blackboxsw> like whether there is a possibility of merged cfg from disk here that would have provided this config visibility without the need for distro.set_option
[17:03]  * blackboxsw which I think I saw someone's comments earlier this week/last week about unavailability of that data
[17:12] <blackboxsw> hamalq: minor doc nit submitted on your branch. I'm testing now https://github.com/canonical/cloud-init/pull/859/files
[18:48] <blackboxsw> falcojr: in testing with a package built from 859  on lxc across upgrade + dirtty reboot I'm seeing cloud-init status --long fail with 'DataSourceNoCloud' object has no attribute 'vendordata2_raw'. I'm going to check daily PPA to confirm it's unrelated but wondering if you've seen this
[18:50] <falcojr> would that be this? https://bugs.launchpad.net/cloud-init/+bug/1922739
[18:50] <ubot5> Ubuntu bug 1922739 in cloud-init "AttributeError: 'DataSourceNoCloud' object has no attribute 'vendordata2_raw'" [Undecided,New]
[18:50] <falcojr> blackboxsw: ^
[18:51] <falcojr> blackboxsw: also, I missed kind of an important issue in the SRU... https://github.com/cloud-init/ubuntu-sru/pull/201 Can I get a quick review?
[18:51] <blackboxsw> and there's another vote for me not paying enough attention to daily triage. sorry about that
[18:52] <falcojr> that's why we all have our separate triage days...so we don't have to pay attention ;)
[19:00] <blackboxsw> ok I have a reproducer on xenial for that https://bugs.launchpad.net/cloud-init/+bug/1922739/comments/4
[19:00] <ubot5> Ubuntu bug 1922739 in cloud-init "AttributeError: 'DataSourceNoCloud' object has no attribute 'vendordata2_raw'" [Undecided,New]
[19:00] <blackboxsw> so daily builds show this issue after upgrade
[19:00] <blackboxsw> rather upgrades to daily builds show this issue
[19:04] <blackboxsw> falcojr: hamalq I'm out of the way on https://github.com/canonical/cloud-init/pull/859#pullrequestreview-637036841 and leave it to integration testing for the corner cases. thanks for the chance to look again
[19:07] <blackboxsw> minor doc nits from me that are easily fielded I think
[19:39] <hamalq> blackboxsw: anytthing needed from me ( sorry i went out for a while )
[19:40] <blackboxsw> hamalq: just a push with minor doc updates  https://github.com/canonical/cloud-init/pull/859#discussion_r614236688
[19:40] <blackboxsw> since they get rendered into https://cloudinit.readthedocs.io/en/latest/topics/modules.html#update-hostname
[19:44] <hamalq> blackboxsw: done
[20:37] <hamalq> blackboxsw: its ready to merge right
[20:54]  * blackboxsw hamalq: I think so, but I leave that to falcojr, he said he was going to check a couple things in integration test to be sure. I'll confirm tomorrow as I believe he is end-of-day today. if there is  anything blocking he'll respond on the PR
[20:55] <blackboxsw> for me it's +1 so I won't gate it landing.
[21:21] <hamalq> thanks
[22:46] <pythag0re> Hello,
[22:48] <pythag0re> I have a problem with m DataSource. /usr/lib/cloud-init/ds-identify --force finds out properly and creates the properly list within the file /run/cloud-init/cloud.cfg but when I run cloud-init init the datasource is never invoked. In the logs, I only see Loaded datasource DataSourceNone - DataSourceNone. I'm not running the cloud-init on any cloud-providers
[22:49] <pythag0re> any idea on what I could do / look so that it is invoked?