[01:23] <StupidDanbo> I got it working. Thanks.
[01:24] <mup> PR snapd#10151 opened: wrappers/services.go: refactor helper lambda function to separate function <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10151>
[02:24] <mup> PR snapd#10152 opened:  quota: new package for managing resource groups  <Needs Samuele review> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10152>
[02:40] <mup> PR snapd#10153 opened: [RFC] wrappers, quota: implement quota groups slice generation <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10153>
[05:51] <mborzecki> morning
[07:01] <pstolowski> morning
[07:06] <mborzecki> pstolowski: hey
[07:30] <mborzecki> hmm hmm dropped console=ttyS0 from cmdline.full and spent a while wondering why my qemu serial is so silent
[07:35] <mup> PR snapd#10154 opened: cmd/snap, boot: add snapd_full_cmdline_args to dumped boot vars <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10154>
[07:39] <zyga> mborzecki uh oh
[07:40] <zyga> mborzecki approved
[08:21] <mborzecki> thx
[09:11] <mup> PR snapd#10151 closed: wrappers/services.go: refactor helper lambda function to separate function <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10151>
[09:16] <mup> PR snapd#10154 closed: cmd/snap, boot: add snapd_full_cmdline_args to dumped boot vars <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10154>
[09:22] <ogra> zyga, omg, krakow is attacked by the french ?!?! https://www.todayonline.com/world/is-it-bird-is-it-iguana-no-its-croissant
[09:26] <mup> PR snapd#10155 opened: [RFC] o/snapstate: handle refresh hints <Refresh control> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10155>
[09:32] <zyga> ogra I'm wearing a krakow t-shirt today ;-)
[09:32] <ogra> does it have a croissant on it ?
[09:32] <zyga> ogra only if we have some left upstairs
[09:33] <zyga> (I'm afraid not)
[09:35] <mborzecki> and runing a spread test with cmdline.full & secure boot
[09:46] <mborzecki> hm when running nested tests we compress the images using xz -k0 <image-path>
[09:46] <mborzecki> wonder if using bzip/gz/zstd would speed this up a bit
[09:47] <mborzecki> also when we repack the kernel snap, we use xz again, we could use zstd there right?
[09:48] <mborzecki> duh, s/zstd/lzo/ for the snap
[09:51] <mborzecki> huh, how is that possible? ` Mount snap "snapd" (11588) (snap is unusable due to missing files; contact developer)`
[09:51] <mvo> mborzecki: gzip is probably fastest
[09:51] <mvo> mborzecki: uh, I never saw this message
[09:51] <mborzecki> mvo: that's from Adio's log
[09:53] <mvo> mborzecki: there should be more details from snap.ValidateContainer for this error
[09:54] <mvo> mborzecki: I have a meeting in 5 unfortunately, what PR fails like this?
[09:55] <mborzecki> mvo: that's not from a PR
[09:56] <mborzecki> Adio: can you `snap changes` and paste the output to some pastebin?
[09:58] <mvo> mborzecki: aha, sorry, missed that because I joined late
[10:02] <mborzecki> Adio: can you collec the output of `snap tasks 6` ?
[10:03] <pstolowski> pedronis: hi, i've proposed #10155 for early feedback re the direction taken
[10:03] <mup> Bug #10155: System reboots after halt <linux-source-2.6.15 (Ubuntu):Fix Released by fabbione> <https://launchpad.net/bugs/10155>
[10:03] <mup> PR #10155: [RFC] o/snapstate: handle refresh hints <Refresh control> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10155>
[10:04] <mborzecki> Adio: hm interesting, can you collect the journal? `sudo journalctl -u snapd --since 15:36`
[10:11] <mborzecki> thanks
[10:11] <mborzecki> Adio: does /snap/snapd exist in your system? if so what does /snap/snapd/current point to (`ls -l /snap/snapd` will show that)
[10:16] <pedronis> pstolowski: I'll try to look at it after lunch, I have few older PRs still in my review queue
[10:17] <pedronis> pstolowski: thanks
[10:17] <mborzecki> hm no clue what's happening, it's as if the snapd snap file is corrupted? but that would probably give a different error
[10:17] <pstolowski> pedronis: sure. as i said naming TBD, tests are missing and existing tests will fail atm
[10:29] <mborzecki> Adio: can you try running `snap install --beta snapd` ?
[10:29] <mborzecki> Adio: what system is it anwyay? what does `snap version` show?
[10:55] <mborzecki> Adio: hm probably something changed in unsquashfs, what's the old and the new version?
[11:23] <mborzecki> Adio: thanks, does the new version even work at all? can you try `unsquashfs -l /var/lib/snapd/snaps/snapd_<some-rev>.snap`?
[11:51] <mup> PR snapd#10156 opened: boot, bootloader, bootloader/assets: support for full command line override from gadget <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10156>
[11:56] <cachio_> mborzecki, hi
[11:56] <mborzecki> cachio_: hey
[11:56] <cachio_> any idea if this is a new error? https://github.com/snapcore/snapd/pull/10135#issuecomment-819955829
[11:56] <mup> PR #10135: tests/lib/nested: proper status return for tpm/secure boot checks <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10135>
[11:57] <cachio_> it is failing because of memory problems
[11:57] <cachio_> this is the only test failing
[12:00] <mborzecki> cachio_: not really, that's the minimal test in https://github.com/snapcore/snapd/pull/10135 which means we were not executing that test with secure boot enabled, and maybe it jsut doesn't work with 384MB of ram
[12:00] <mup> PR #10135: tests/lib/nested: proper status return for tpm/secure boot checks <Run nested> <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10135>
[12:00] <mborzecki> mvo: ^^ that's probably interesting to note too
[12:01] <mvo> mborzecki: in a meeting will have a look
[12:01] <mborzecki> let me add that to the standup notes so that we don't forget
[12:03] <cachio_> mborzecki, but we were not using secure boot during the last 20 days
[12:04] <cachio_> after we merged core and core20 suites
[12:04] <cachio_> before we were using it
[12:05] <cachio_> not sure if any change we did lastly could affect that test
[12:05] <mborzecki> cachio_: afaiu the change in 10135 and your last commit there, make it used by default now on ubuntu-20.04
[12:06] <cachio_> mborzecki, you are  right
[12:06] <cachio_> manual tests were not using sec boot
[12:07] <cachio_> mborzecki, should that test run with sec boot?
[12:07] <cachio_> or it is ok to run without?
[12:11] <cachio_> mborzecki, I can add environment:
[12:11] <cachio_>     NESTED_ENABLE_TPM: false
[12:11] <cachio_>     NESTED_ENABLE_SECURE_BOOT: false
[12:11] <cachio_> to the test
[12:11] <mborzecki> cachio_: that's a good question and the answer depends on what we promise ;), let's discuss it during the standup
[12:11] <cachio_> mborzecki, sure
[12:55] <pedronis> pstolowski: thanks for https://github.com/snapcore/snapd/pull/10155 , left a bunch of comments and some worries, let me know
[12:55] <mup> PR #10155: [RFC] o/snapstate: handle refresh hints <Refresh control> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10155>
[14:12] <cachio_> mborzecki, I have tested minimal smoke with 512MB and works
[14:12] <mborzecki> cachio_: with secure boot enabled right?
[14:12] <cachio_> yes
[14:13] <mborzecki> cachio_: can you also try to run it with 384MB like before, but with disabled tpm/secure boot?
[14:13] <cachio_> sure
[14:13] <mborzecki> eventually maybe we should keep both variants of the test
[14:13] <mborzecki> mvo: ^^
[14:14] <mvo> mborzecki: +1 (but in a meeting right now)
[14:19] <ijohnson> pedronis: sorry I think I forgot to look at the frankfurt notes to see that it was decided to _not_ allow having different quota groups for services in a single snap, that does simplify things I suppose, but to be clear that's the implementation we want for now ?
[14:19] <ijohnson> to have a single group for all services in a snap ?
[14:20] <pedronis> yes
[14:20] <ijohnson> that does go a bit against our recommendation that we give to customers to bundle services into a single snap, since now all the services in a single snap would be subject to the same resource quota
[14:21] <cachio_> mborzecki, you mean to run with 384 and not secboot and with 512 and secboot right?
[14:21] <mborzecki> cachio_: yeah
[14:21] <cachio_> mborzecki, I can try that
[14:24] <pedronis> ijohnson: I was not even aware of this reccommendation
[14:24] <pedronis> is that just because then it's easier to make them talk to each other?
[14:25] <ijohnson> pedronis yes, at least that's what was the recommendation when I was on the field team
[14:25] <ijohnson> The other reason is due to refreshes etc and keeping different services in sync
[14:27] <pedronis> either way, we can't start doing services as first step, it gets pretty convoluted quickly state wise
[14:29] <ijohnson> ok, I thought it was fairly straight forward to just put a quota on an appinfo like I showed, but as mentioned I have not finished plumbing everything together
[14:29] <pedronis> ijohnson: but we don't really keep app infos around like that
[14:29] <pedronis> that's why as I said there's need some thinking about what we actually stick into the state
[14:30] <ijohnson> oh I see, I didn't realize we don't serialize app-infos like that
[14:30] <pedronis> ijohnson: SnapState doesn't contain a snap.Info nor snap.AppInfos
[14:30] <pedronis> we read them always from disk combined with SideInfo data from SnapState
[14:31] <ijohnson> mmm right
[14:31] <pedronis> so not even clear that putting the group in snap.Info is useful or confusing
[14:32] <ijohnson> Okay, I'll have a look today
[14:32] <pedronis> at the wrappers level it could come via SnapServicesOptions
[14:32] <pedronis> but not sure
[14:33] <pedronis> there is more than one way to do this, but ultimately we need to keep what we did/need to do in state
[14:33] <ijohnson> Right
[14:46] <mborzecki> pedronis: ijohnson: i've updated #10148
[14:46] <mup> Bug #10148: xfree86: new changes from Debian require merging <Ubuntu:Invalid by fabbione> <https://launchpad.net/bugs/10148>
[14:46] <mup> PR #10148: overlord/devicestate, overlord/snapstate: add task for updating kernel command lines from gadget <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10148>
[14:53] <ijohnson> ack
[15:29] <pedronis> mborzecki: I re-reviewed it, I'm looking at the full one next. OTOH that one probably can use as many eyes as possible
[15:29] <pedronis> I mean the task one
[15:30] <mborzecki> pedronis: understood, thanks for the review
[15:57] <mup> PR snapd#10157 opened: o/snapstate: remove unused DeviceCtx argument of ensureInstallPreconditions <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10157>
[15:59]  * cachio_ lunch
[16:20] <zyga> mborzecki around?
[16:20] <pedronis> I reviewed https://github.com/snapcore/snapd/pull/10156 thanks
[16:20] <mup> PR #10156: boot, bootloader, bootloader/assets: support for full command line override from gadget <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10156>
[16:32] <mup> PR snapd#10158 opened: packaging: build without dwarf debugging data <Created by zyga> <https://github.com/snapcore/snapd/pull/10158>
[18:17] <mup> PR snapd#10135 closed: tests/lib/nested: proper status return for tpm/secure boot checks <Run nested> <Simple 😃> <Created by bboozzoo> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10135>
[18:28]  * cachio_ afk
[19:10] <mup> PR snapcraft#3503 opened: deb: do not filter python3 packages on core20 <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3503>
[19:37] <mup> PR snapd#10159 opened: secboot: use secboot.{ActivateVolumeWithKeyData,SnapModelChecker} <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10159>
[23:15] <mup> PR snapcraft#3495 closed: conda v2 plugin: support for more architectures <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3495>