| lubot | [telegram] <RikMills> @mitya57 Does the setting of qvariant autoconversion to False make sense here: | 08:42 |
|---|---|---|
| lubot | [telegram] <RikMills> https://git.launchpad.net/ubiquity/commit/?id=0ffb72be73e22d201e40e153eea0c678d70a4532 | 08:42 |
| lubot | [telegram] <mitya57> @RikMills It matches sip4's sip.setapi('QVariant', 1) behavior: | 09:50 |
| lubot | [telegram] <mitya57> https://www.riverbankcomputing.com/static/Docs/PyQt5/pyqt_qvariant.html | 09:50 |
| lubot | [telegram] <mitya57> So that commit makes sense to me. | 09:50 |
| lubot | [telegram] <RikMills> Hmmm. So why does the installer now get those TypeError: unhashable type: 'QVariant' crash when it didn't used to | 10:51 |
| lubot | [telegram] <mitya57> Are these the same errors we discussed in February, or new ones? (re @RikMills: Hmmm. So why does the installer now get those TypeError: unhashable type: 'QVariant' crash when it didn't used to) | 14:29 |
| lubot | [telegram] <mitya57> And does anything work if you remove sip.enableautoconversion call? | 14:30 |
| lubot | [telegram] <RikMills> Yes, the same errors. And yes, everything works if you set that to True, or remove it altogether | 14:31 |
| lubot | [telegram] <mitya57> Then maybe just remove all those calls. | 14:32 |
| lubot | [telegram] <mitya57> And revert additions of .toString() if they were made | 14:32 |
| lubot | [telegram] <mitya57> These ones (re @lubuntu_bot: (irc) <mitya57> So something like "ssid = ssid.toString()" should fix it, but maybe similar changes are needed in other parts of the code.) | 14:33 |
| lubot | [telegram] <RikMills> That is what I just did. | 14:33 |
| lubot | [telegram] <RikMills> https://code.launchpad.net/~rikmills/ubiquity/+git/ubiquity/+merge/401307 | 14:34 |
| lubot | [telegram] <mitya57> OK | 14:34 |
| lubot | [telegram] <RikMills> Thanks for the help :) | 14:35 |
| lubot | [telegram] <mitya57> No problems. I hope it won't become worse than it was, as we have quite little time before release | 14:35 |
| lubot | [telegram] <RikMills> I did 5 installs of different test cases, trying to hit as many changes in the UI as I could to see if other parts become crashy. So far, I could not break anything | 14:37 |
| lubot | [telegram] <RikMills> release-team say that if uploaded today, it can be reverted on Monday if it went bad | 14:38 |
| lubot | [telegram] <mitya57> Great. Thanks for working on it! | 14:38 |
| lubot | [telegram] <RikMills> fingers crossed 🤞 | 14:39 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!