[06:05] morning === jwheare_ is now known as jwheare [06:57] morning [06:59] good morning :-) [06:59] pstolowski: zyga: morning guys [07:01] I've spent some time last night booting a raspberry pi without an SD card or any other storage attached [07:02] it's actually pretty easy but I need to tweak one thing to move the idea from an older pi I had on hand to a pi4 [07:15] mvo: morning [07:17] hey mvo [07:18] hey mborzecki and zyga ! [07:18] is it just me or did the "indicator" color change in GH that a PR has new comments or other activity? [07:19] there are three new themes [07:20] maybe sometihng is wrong on my system but with the default (light) I can't really see which PR has changes anymore in the /pulls overview page [07:25] mvo: where's that indicator? in notifications? [07:27] mborzecki: it used to be a little colored strip/bar next to each PR line, left of the checkbox, iirc some blueish color if there were new comments on the pr [07:28] and I don't see this anymore [07:28] and wonder what happend [07:29] I don't even know what it's called :/ [07:31] mborzecki: it seems we can land 10170 once the error is updated, is that right? [07:32] yes [07:32] mvo: i'm slowly going through #10164, will update 10170 next [07:32] Bug #10164: Wrong shortcut path [07:32] PR #10164: o/servicestate/servicemgr.go: add ensure loop for snap service units [07:32] mborzecki: \o/ no worries, just wanted to check [08:10] PR core20#102 opened: hooks: add mDNS hostname resolution support [09:24] mvo: thanks for looking at refreh-control; if you have time then https://github.com/snapcore/snapd/pull/10053 needs 2nd review [09:24] PR #10053: o/snapstate: helper for getting snaps affected by refresh, define new hook [09:56] pstolowski: sure, let me look [09:57] ty [10:00] mvo: can you land https://github.com/snapcore/snapd/pull/10170 ? [10:00] PR #10170: gadget: multi line support in gadget's cmdline file [10:00] the spread failures are unrelated to the change [10:11] mborzecki: sure [10:11] PR snapd#10170 closed: gadget: multi line support in gadget's cmdline file [10:11] mborzecki: heh, too late :) [10:11] mvo: pedronis: thanks [10:51] PR snapd#10176 closed: wrappers: support in EnsureSnapServices a callback to observe changes [11:04] quick errand, back in 30 === sil2100_ is now known as sil2100 [11:28] re [11:43] as a side note, compressing images with xz takes almost 2 minutes, since those are built as sparse files, the actual size is 199MB, but compressed with xz is 195MB :/ [11:56] PR snapd#10178 opened: tests/lib/nested: do not compress images, return early when restored from pristine image === JanC is now known as Guest65907 === JanC_ is now known as JanC [12:43] pedronis: fwiw, I addressed feedback for hooks v2 pr in 10168, hope I did not overlook anything there [12:44] mvo: I made more comments [12:44] I think [12:44] I asked also a question in a PM [12:46] pedronis: \o/ thanks, looking [12:47] pstolowski: 10167 has a gofmt error [12:47] pedronis: pm on mattermost or irc? I don't see this one right now [12:47] mvo: oh, fixing, thanks [12:47] mvo: mm [13:42] PR snapd#10053 closed: o/snapstate: helper for getting snaps affected by refresh, define new hook [14:26] PR snapcraft#3507 opened: storeapi: add classes for validation sets [14:33] mborzecki, hi, could you please take a quick look to #10137 [14:33] Bug #10137: ted: new changes from Debian require merging [14:33] PR #10137: tests: update os.query check to match new bullseye codename used on sid images [15:09] pstolowski: I reviewed https://github.com/snapcore/snapd/pull/10169 hope the comments make some sense [15:09] PR #10169: o/snapstate: helper for creating gate-auto-refresh hooks [15:10] pedronis: thanks, looking [15:13] mborzecki: pstolowski: https://github.com/snapcore/snapd/pull/10122 needs a 2nd review, the changes are the last 3 commits, they are all test changes [15:13] PR #10122: daemon: refine access testing [15:15] pedronis: register for gate-auto-refresh already landed although it uses the generic handler [15:15] pstolowski: we'll have to change that [15:16] I think [15:17] the spec has precise details what to do on errors [15:18] pedronis: indeed! i missed that. i'd address this in a followup though [15:18] that's fine [15:32] PR snapd#10137 closed: tests: update os.query check to match new bullseye codename used on sid images [15:34] mborzecki: thanks [15:35] mborzecki, hey, any idea if it is a problem related to a new version of glibc, https://paste.ubuntu.com/p/mHpktWNVzj/ ? [15:36] it is happening in the new image of centos8 [15:39] $ systemctl show --property=KernelTimestamp [15:39] KernelTimestamp=Thu 1970-01-01 00:00:00 UTC [15:39] pedronis: so yeah as expected on the pi getting the boot time will not be super useful [15:47] PR snapd#10174 closed: boot: split out a helper for making recovery system bootable [15:54] hmm though `uptime -s` is returning something sensible, I suppose I can just use that instead [16:48] * cachio__ lunch [17:37] PR snapcraft#3507 closed: storeapi: add classes for validation sets [19:32] cachio__: do you know where the source for test-snapd-curl is ? [19:47] PR snapcraft#3508 opened: storeapi: add binding for validations-sets === ogra_ is now known as Guest66031 === ogra_ is now known as Guest75940