| mborzecki | morning | 05:56 |
|---|---|---|
| pstolowski | morning | 07:09 |
| mborzecki | pstolowski: hey | 07:12 |
| mborzecki | pstolowski: any prs that need reviews? | 07:14 |
| pstolowski | mborzecki: hey, #10169 please | 07:15 |
| mup | Bug #10169: typo in gucharmap's About <gucharmap (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10169> | 07:15 |
| mup | PR #10169: o/snapstate: helper for creating gate-auto-refresh hooks <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10169> | 07:15 |
| mborzecki | pstolowski: will do | 07:15 |
| pstolowski | ty | 07:15 |
| mvo | pedronis: I think we can merge 9043 and also 10122, yes? both got enough reviews | 07:32 |
| mvo | hey zyga, good morning! | 07:32 |
| pedronis | mvo: yes, we just need to decide when is a good time | 07:32 |
| zyga | good morning guys :) | 07:32 |
| * zyga is setting up a 2nd display | 07:33 | |
| pstolowski | hey zyga! | 07:35 |
| === alan_g_ is now known as alan_g | ||
| mborzecki | hm bootloadertest zoo, need a mix of TrustedAssets and RecoveryAware bootloaders | 08:33 |
| pedronis | mborzecki: hi, you said we need to chat about something today? | 08:55 |
| mborzecki | pedronis: it's fine for now, i think i've figured out how to make use of seedtest.SeedSnaps properly so that assertions seem to match the files, i may have some questions when i do unasserted snaps, but i'll ping you then | 08:56 |
| pedronis | ok, good | 08:57 |
| pedronis | thx | 08:57 |
| mborzecki | pedronis: thanks for asking :) | 08:58 |
| mup | PR snapcraft#3509 opened: extensions: don't expose host system fontconfig cache <Created by jhenstridge> <https://github.com/snapcore/snapcraft/pull/3509> | 09:17 |
| mup | PR snapd#10179 opened: bootloader/bootloadertest: provide interface implementation as mixins, provide a mock for recovery-aware-trusted-asses bootloader <Simple đ> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10179> | 09:30 |
| mborzecki | pedronis: adding one more to bootloadertest zoo, hopefully it's a bit cleaner now ^^ | 09:31 |
| mborzecki | mvo: can you use your powers and land https://github.com/snapcore/snapd/pull/10178 ? | 09:34 |
| mup | PR #10178: tests/lib/nested: do not compress images, return early when restored from pristine image <Run nested> <Simple đ> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10178> | 09:34 |
| pedronis | mborzecki: done | 09:59 |
| mup | PR snapd#10178 closed: tests/lib/nested: do not compress images, return early when restored from pristine image <Run nested> <Simple đ> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10178> | 10:00 |
| mborzecki | pedronis: thanks | 10:01 |
| mvo | mborzecki: sure | 10:20 |
| mvo | heh, too late again! | 10:20 |
| * mvo hugs mborzecki and pedronis | 10:20 | |
| mborzecki | hmmm testutil.FileEquals behaves silly, returns that files are not equal when they seem to be, at least sha3sum indicates so | 10:35 |
| mborzecki | uhh nvm | 10:36 |
| mup | PR snapd#10180 opened: testutil: support reference files in FileEquals checker <Simple đ> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10180> | 11:05 |
| mup | PR snapcraft#3508 closed: storeapi: add binding for validations-sets <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3508> | 12:03 |
| === zyga_ is now known as zyga | ||
| * cachio__ afk | 12:15 | |
| mup | PR snapd#10181 opened: overlord/devicestate: add helper for creating recovery systems at runtime <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10181> | 12:35 |
| mup | PR snapd#10182 opened: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10182> | 12:46 |
| pedronis | mborzecki: I made a suggestions in https://github.com/snapcore/snapd/pull/10180 | 13:27 |
| mup | PR #10180: testutil: support reference files in FileEquals checker <Simple đ> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10180> | 13:27 |
| mborzecki | pedronis: thanks | 13:30 |
| mup | PR snapd#10179 closed: bootloader/bootloadertest: provide interface implementation as mixins, provide a mock for recovery-aware-trusted-asses bootloader <Simple đ> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10179> | 13:51 |
| ijohnson | hmm does google:ubuntu-18.04-64:tests/main/prepare-image-uboot-uc20 need to be updated now that the pi kernel dtb things are landing ? | 13:52 |
| ijohnson | https://pastebin.ubuntu.com/p/Td3GsfTpWY/ | 13:52 |
| mvo | ijohnson: yes, we need a matching kernel in edge | 13:53 |
| ijohnson | mvo: so we don't yet have a matching kernel in edge yet ? | 13:53 |
| mvo | ijohnson: correct | 13:53 |
| mvo | ijohnson: once we have this will work, I can force merge until this is fixed | 13:54 |
| mvo | ijohnson: in a meeting so a bit terse | 13:54 |
| ijohnson | no worries, thanks for responding clarifying đ | 13:54 |
| mvo | ijohnson: I asked the kernel team fwiw, so hopefully soon | 13:55 |
| ijohnson | nice | 13:56 |
| ijohnson | mvo: pedronis : so can we land https://github.com/snapcore/snapd/pull/10164 ? the only thing from mvo there is to add some whitespace and the only failure there is for the prepare-image-uboot-uc20 test so I think it is ready to go (and remember it needs to be squash merged) | 14:05 |
| mup | PR #10164: o/servicestate/servicemgr.go: add ensure loop for snap service units <Bug> <Squash-merge> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10164> | 14:05 |
| mvo | ijohnson: yeah, ignore the whitespace, happy to land it if pedronis agrees | 14:08 |
| ijohnson | great, yeah it sounded like it was ready from our conversation in the SU, but I will let pedronis confirm before moving ahead | 14:08 |
| mborzecki | hmm need a fresh mind to look at luks2 in secboot again | 14:12 |
| mvo | mborzecki: look at my fde PR instead then ;) | 14:12 |
| mvo | mborzecki: 10168 ;) | 14:12 |
| pedronis | ijohnson: mvo: I can merge it in a little bit | 14:13 |
| mborzecki | mvo: 10168? ah ok, i was keeping tack of the changes and with the last bit of cleanup from pedronis it lgtm | 14:13 |
| ijohnson | great thank you pedronis ! | 14:13 |
| mvo | mborzecki: yeah, I think it "just" needs a +1 from you, then I have another look and then I can do the next round | 14:14 |
| mborzecki | still, wonder if that large disclaimer in fde-setup-hook is enough of a discouragement ;) | 14:15 |
| mborzecki | mvo: already gave my +1 | 14:16 |
| mvo | mborzecki: do you have ideas what else we could do? | 14:16 |
| mvo | mborzecki: great! | 14:16 |
| mvo | mborzecki: thanks, sorry, only have 10% of my brain, in a meeting | 14:16 |
| pedronis | pstolowski: I commented on https://github.com/snapcore/snapd/pull/10172 | 14:30 |
| mup | PR #10172: o/hookstate: add "refresh" command to snapctl (hidden, not complete yet) <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10172> | 14:30 |
| pedronis | thx | 14:30 |
| pstolowski | pedronis: thanls | 14:33 |
| pstolowski | *thanks | 14:33 |
| pedronis | ijohnson: done, also thanks for answer my question about console-conf-start | 14:33 |
| pedronis | *answering | 14:33 |
| ijohnson | great, I will push the spread tests to your branch then | 14:33 |
| ijohnson | thanks pedronis ! | 14:33 |
| mborzecki | yay | 14:33 |
| mup | PR snapd#10164 closed: o/servicestate/servicemgr.go: add ensure loop for snap service units <Bug> <Squash-merge> <Created by anonymouse64> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10164> | 14:36 |
| mvo | I cherry pick now | 14:36 |
| mup | PR snapd#10183 opened: wrappers/services.go: introduce EnsureSnapServices() (2.50) <Created by mvo5> <https://github.com/snapcore/snapd/pull/10183> | 14:41 |
| ijohnson | hmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmmm | 14:42 |
| * ijohnson < https://matrix.org/_matrix/media/r0/download/matrix.org/FQMnxJdobWFarBmfhEbwCBGr/message.txt > | 14:42 | |
| * ijohnson < https://matrix.org/_matrix/media/r0/download/matrix.org/vmTtqgwMlScKbbIARMYtUfEo/message.txt > | 14:42 | |
| ijohnson | gah formatting | 14:42 |
| ijohnson | https://pastebin.ubuntu.com/p/nrfz3XrznS/ | 14:42 |
| ijohnson | this is erm also not good | 14:42 |
| ijohnson | if the refresh from 2.49.2 -> 2.50 fails, we might not be able to successfully revert :-/ | 14:43 |
| ijohnson | because now reverting snapd depends on successfully stopping the things which depend on usr-lib-snapd.mount .... which is now all snap services âšī¸ | 14:43 |
| mup | PR snapd#10184 opened: tests: moving the snaps which are not locally built to the store directory <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10184> | 14:46 |
| pstolowski | pedronis: updated 10172 | 14:46 |
| pedronis | degville: hi, could you give a look at the new help in https://github.com/snapcore/snapd/pull/10172 | 14:48 |
| mup | PR #10172: o/hookstate: add "refresh" command to snapctl (hidden, not complete yet) <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10172> | 14:48 |
| * cachio__ lunch | 14:49 | |
| ijohnson | pedronis: thoughts on ^ ? | 14:52 |
| pedronis | ijohnson: can you tell me more? | 14:55 |
| ijohnson | pedronis: I don't that there's anything we can do about it, but while working more on the spread tests, I noticed that due to the Requires=usr-lib-snapd.mount dependency, when we try to revert snapd, it will fail to revert if the services can't be stopped as part of `systemctl stop usr-lib-snapd.mount` | 14:55 |
| pedronis | but 2.50 puts Wants, not requires, is this a different revert? | 14:56 |
| ijohnson | pedronis: right what I'm saying is that right now if a user has 2.49.2 installed they can't revert snapd if they have services which fail to stop properly | 14:57 |
| ijohnson | and also that if we have issues with the refresh from 2.49.2 -> 2.50, and specifically we have to revert _before_ we have updated the service unit dependencies, then reverting snapd will fail | 14:58 |
| pedronis | I agree, but unless we replace 2.49.2 and the units in the world by other means I'm not sure there is much we can do about that | 14:58 |
| ijohnson | yes I know there's not much we can do about it | 14:58 |
| ijohnson | I just wanted to raise it as an additional risk we have with the 2.49.2 -> 2.50 rollout | 14:59 |
| pedronis | mborzecki: I looked at https://github.com/snapcore/snapd/pull/10181, it looks reasonable, this is for the capture runtime case right? not remodel? | 15:04 |
| mup | PR #10181: overlord/devicestate: add helper for creating recovery systems at runtime <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10181> | 15:04 |
| pedronis | mborzecki: some comments | 15:04 |
| degville | pedronis: looking now! | 15:08 |
| pedronis | ijohnson: anyway it shows that this idea of calling something early in the new snapd before doing more of snap linking would be good | 15:09 |
| ijohnson | yes, agreed | 15:10 |
| pstolowski | mvo: hey, could you land #10167 and #10169? there are some unrelated failures (e.g. uboot and grub on 18.04) | 15:53 |
| mup | Bug #10167: Should it be deprecated??? <trashapplet (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10167> | 15:53 |
| mup | PR #10167: o/snapstate: store refresh-candidates in the state <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10167> | 15:53 |
| mup | Bug #10169: typo in gucharmap's About <gucharmap (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10169> | 15:53 |
| mup | PR #10169: o/snapstate: helper for creating gate-auto-refresh hooks <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10169> | 15:53 |
| mvo | ijohnson: I played a bit with "snap revert snapd" and at least it seems working ok under most situations | 16:16 |
| mborzecki | pedronis: thank you, it should work eventually for both cases with some tweaking | 16:16 |
| mborzecki | right now it works with runtime case though | 16:16 |
| ijohnson | mvo: did you try with Requires=usr-lib-snapd.mount and a unit which fails to be stopped ? | 16:16 |
| mup | PR snapd#10167 closed: o/snapstate: store refresh-candidates in the state <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10167> | 16:16 |
| mup | PR snapd#10169 closed: o/snapstate: helper for creating gate-auto-refresh hooks <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10169> | 16:16 |
| ijohnson | if so maybe my failure here is from something else | 16:16 |
| mvo | ijohnson: I did not had a unit that fails to get stopped, let me try this again, I used test-snapd-service which iirc has no unit that is trying hard to not get stopped | 16:31 |
| mvo | ijohnson: I'm sure it's real it just not super common it seems | 16:31 |
| ijohnson | mvo: yes that is the specific case where a snap service refuses to stop in time, i.e. with a stop-command that just does `sleep infinity` | 16:32 |
| mvo | sil2100: congrats for the release \o/ | 17:21 |
| ogra | happy hippo to everyone ! | 17:32 |
| === popey8 is now known as popey | ||
| === the-mentor36 is now known as the-mentor3 | ||
| mup | PR snapcraft#3510 opened: cli: introduce list-validation-sets <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3510> | 18:08 |
| mup | PR snapcraft#3509 closed: extensions: don't expose host system fontconfig cache <Created by jhenstridge> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3509> | 18:28 |
| === tomreyn_ is now known as tomreyn | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!