| mup | PR snapcraft#3510 closed: cli: introduce list-validation-sets <Created by sergiusens> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3510> | 01:03 |
|---|---|---|
| mup | PR snapd#10168 closed: many: refactor to kernel/fde and allow `fde-setup initial-setup` to return json <Run nested> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10168> | 05:18 |
| mborzecki | morning | 05:44 |
| pstolowski | morning | 07:06 |
| mborzecki | pstolowski: hey | 07:13 |
| mborzecki | pstolowski: can you take a quick look at something? | 07:15 |
| pstolowski | mborzecki: sure | 07:15 |
| mborzecki | pstolowski: in interfaces/udev/backend.go ther's Remove() whcih gets called when we remove snap rules | 07:15 |
| mborzecki | pstolowski: it calles b.reloadRules(nil) | 07:15 |
| mborzecki | pstolowski: if you follow that, then if I'm reading this right, we will not trigger any of the input subsystem events? | 07:16 |
| pstolowski | mborzecki: looking | 07:16 |
| pstolowski | mborzecki: except for input/joystick which for some reason have special treatment | 07:18 |
| pstolowski | mborzecki: at the bottom, outside of main loop | 07:19 |
| pstolowski | mborzecki: but yeah, seems fishy | 07:19 |
| mborzecki | pstolowski: i'm looking at #9960, and disconnecting device-buttons clearly does not remove the tag, i had to call `udevadm trigger` myself | 07:20 |
| mup | PR #9960: tests: update permission denied message for test-snapd-event on ubuntu 2104 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/9960> | 07:20 |
| mborzecki | and then we have that code which triggers with nomatch-input ;) | 07:21 |
| pstolowski | mborzecki: too many FIXMEs in that function :/ | 07:27 |
| mborzecki | pstolowski: uhh yeah, udev is problematic iirc | 07:28 |
| mborzecki | and with systemd changes in 247 it's a bit better but versions before that are broken afaiu | 07:28 |
| pstolowski | also reload-rules we do had side effects afair | 07:28 |
| mborzecki | hope it's not something we want to block 2.50 on again :/ | 07:29 |
| pstolowski | mborzecki: maybe we should try to improve this selectively based on a known good version of systemd and keep it the old way on old systems | 07:31 |
| mborzecki | ehh, systemd version into system-key? :) | 07:35 |
| mborzecki | pstolowski: look at the log from debug shell: https://paste.ubuntu.com/p/Twx8wxchsr/ only after a manual udev trigger the rule gets removed from CURRENT_TAGS | 07:36 |
| pstolowski | mborzecki: mhm | 07:40 |
| mborzecki | mvo: hey | 07:41 |
| mvo | hey mborzecki | 07:45 |
| pstolowski | mborzecki: this isnt' a regression though? | 07:51 |
| mborzecki | pstolowski: yes, i think it is | 07:52 |
| mborzecki | pff | 07:52 |
| mborzecki | w8, it isn't | 07:52 |
| pstolowski | so maybe not a blocker... | 07:55 |
| zyga | o/ | 07:59 |
| zyga | good morning guys | 07:59 |
| pstolowski | degville: hi, thanks for the corrections for snapctl help text, i've applied your suggestions | 08:36 |
| degville | pstolowski: great, thank you! They were only minor points really. | 08:37 |
| pstolowski | pedronis: hi, i've rebased and updated #10182 | 09:00 |
| mup | Bug #10182: Can not logout of gnome when xcompmgr is running <gnome-panel (Ubuntu):Invalid by fabbione> <https://launchpad.net/bugs/10182> | 09:00 |
| mup | PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10182> | 09:00 |
| pedronis | pstolowski: thx, it's in my queue but there's a couple of things before it | 09:00 |
| pstolowski | (and also #10172) | 09:00 |
| mup | Bug #10172: Ubuntu About icon's been scaled up blur <gnome-panel (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10172> | 09:00 |
| mup | PR #10172: o/hookstate: add "refresh" command to snapctl (hidden, not complete yet) <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10172> | 09:00 |
| mup | PR snapd#10180 closed: testutil: support referencing files in FileEquals checker <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10180> | 09:09 |
| pedronis | I updated https://github.com/snapcore/snapd/pull/10163 it needs a 2nd review | 09:30 |
| mup | PR #10163: o/configstate/configcore/vitality: fix RequireMountedSnapdSnap bug <Bug> <Squash-merge> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10163> | 09:30 |
| mborzecki | unit tests getting stuck on master for anyone? | 10:13 |
| mup | PR snapd#10113 closed: systemd: wait for zfs mounts <Bug> <Run nested> <Squash-merge> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10113> | 10:14 |
| mup | PR snapd#10185 opened: overlord/devicestate: keep track of tried recovery system <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10185> | 10:14 |
| mvo | mborzecki: I had issues with secboot tests because systemd-run --user would get stuck | 10:14 |
| mvo | can I get a review for #10145 please? | 10:14 |
| mup | Bug #10145: wxwindows2.4: new changes from Debian require merging <Ubuntu:Fix Released by cjwatson> <https://launchpad.net/bugs/10145> | 10:14 |
| mup | PR #10145: snapstate: add "kernel-assets" to featureSet (2.50) <â›” Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10145> | 10:14 |
| mborzecki | ... obtained []string = []string{"enable", "var-lib-snapd-snap-snapd-x1.mount"} | 10:15 |
| mborzecki | ... expected []string = []string{"enable", "snap-snapd-x1.mount"} | 10:15 |
| mborzecki | looks like some missing os release mocking | 10:15 |
| mvo | mborzecki: does not ring any bells | 10:28 |
| mborzecki | mvo: looks like services ensure tests, we missed that they don't mock os-release to ubuntu, and classic isn't mocked to false | 10:28 |
| mvo | mborzecki: nice catch | 10:33 |
| mborzecki | mvo: pedronis: https://github.com/snapcore/snapd/pull/10186 | 10:42 |
| mup | PR #10186: overlord: properly mock usr-lib-snapd tests to mimic an Ubuntu Core system <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10186> | 10:42 |
| mup | PR snapd#10186 opened: overlord: properly mock usr-lib-snapd tests to mimic an Ubuntu Core system <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10186> | 10:44 |
| mborzecki | mvo: also we need that for 2.50, as unit tests run on the build infra for some distros, and those get stuck | 10:44 |
| mvo | mborzecki: thanks! | 10:46 |
| mvo | mborzecki: did I read this correctly that we skpped parts of this fix in the test because it was not run on core? | 10:51 |
| mborzecki | mvo: yeah, the service units that we mock look like the ones on core, but we did not mock the rest of the system to look like core | 10:52 |
| mvo | mborzecki: yeah, nice catch | 10:53 |
| mborzecki | that's why the test was missing restart of usr-lib-snapd.mount too | 10:53 |
| mup | PR snapd#10155 closed: [RFC] o/snapstate: handle refresh hints <Refresh control> <Skip spread> <Created by stolowski> <Closed by stolowski> <https://github.com/snapcore/snapd/pull/10155> | 10:54 |
| mup | PR snapd#10187 opened: o/hookstate, o/snapstate: print revision, version, channel with snapctl --pending <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10187> | 10:54 |
| pedronis | mborzecki: where does that fail? | 10:59 |
| mborzecki | pedronis: failed on arch, where i have /var/lib/snapd/snap, so i started to investigate and noticed there's no restart of usr-lib-snapd.mount, which only appeared once i mocked a non classic system | 11:00 |
| mborzecki | pedronis: afaiu the test was halfway right as the mocked service unit had usr-lib-snapd.mount | 11:01 |
| pedronis | mborzecki: in theory all the tests there needs some of this no? | 11:05 |
| pedronis | ah, this is the managers tests | 11:05 |
| pedronis | I confused them with the unit tests in servicestate | 11:06 |
| pedronis | mborzecki: why do we need the booloader, because of boot ok? | 11:07 |
| pedronis | or something else? | 11:08 |
| mborzecki | pedronis: yes, hmm maybe should have mocked that boot ok ran :/ | 11:08 |
| mborzecki | or not, forgot that helper is only in devicestate tests | 11:11 |
| pstolowski | cachio__: hey, did you find anything about google:ubuntu-18.04-64:tests/main/prepare-image-uboot-uc20 failures yesterday? | 11:34 |
| * pstolowski lunch | 11:38 | |
| pedronis | mborzecki: is https://github.com/snapcore/snapd/pull/10185 part of your big branch? or something else | 12:03 |
| mup | PR #10185: overlord/devicestate: keep track of tried recovery system <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10185> | 12:03 |
| mborzecki | pedronis: yes, i've split it out since it's a small bit | 12:07 |
| mup | PR core20#101 closed: ci: add a Github Actions port of the Travis workflow <Created by jhenstridge> <Merged by xnox> <https://github.com/snapcore/core20/pull/101> | 12:08 |
| cachio__ | pstolowski, we need a new kernel in edge | 12:08 |
| cachio__ | hi | 12:08 |
| mborzecki | pedronis: thta's the bit that records in the state that we tried something and clears bootenv | 12:08 |
| === cachio__ is now known as cachio | ||
| cachio | pstolowski, untils the kernel snap is not uploaded this test will fail | 12:08 |
| pedronis | mborzecki: ok | 12:09 |
| pstolowski | mvo: can you land https://github.com/snapcore/snapd/pull/10172 manually as well? 18.04 test is broken | 12:53 |
| mup | PR #10172: o/hookstate: add "refresh" command to snapctl (hidden, not complete yet) <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10172> | 12:53 |
| mvo | pstolowski: sure, landing now | 12:57 |
| pstolowski | \o/ | 12:59 |
| mup | PR snapcraft#3511 opened: add V2 Ruby plugin <Created by paddor> <https://github.com/snapcore/snapcraft/pull/3511> | 12:59 |
| mup | PR snapd#10172 closed: o/hookstate: add "refresh" command to snapctl (hidden, not complete yet) <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10172> | 13:00 |
| mup | PR snapd#10188 opened: tests: moving to tests directories snaps built locally - part 1 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10188> | 13:05 |
| ijohnson | mvo: note that we want https://github.com/snapcore/snapd/pull/10163 for 2.50 too | 13:41 |
| mup | PR #10163: o/configstate/configcore/vitality: fix RequireMountedSnapdSnap bug <Bug> <Squash-merge> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10163> | 13:41 |
| === alan_g_ is now known as alan_g | ||
| mup | PR snapd#10189 opened: many: hide EncryptionKey size and refactors for fde hook v2 next steps <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10189> | 14:20 |
| pedronis | mvo: mborzecki ^ | 14:21 |
| cachio | mvo, is it possible to add this one to 2.50 https://github.com/snapcore/snapd/pull/10190 ? | 14:51 |
| mup | PR #10190: tests: adding debug info for create user tests <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10190> | 14:51 |
| mup | PR snapd#10190 opened: tests: adding debug info for create user tests <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10190> | 14:55 |
| mvo | cachio: sure | 15:04 |
| mvo | cachio: make sure to tag it as 2.50 | 15:04 |
| cachio | mvo, it is tagged | 15:06 |
| mvo | ta | 15:06 |
| mvo | review for 10145 would be great | 15:28 |
| mvo | ijohnson: does 10183 look complete now? | 15:29 |
| ijohnson | let me look | 15:34 |
| ijohnson | mvo: I don't think so, you seem to have included more patches but not the right ones, let me comment | 15:58 |
| ijohnson | to be clear, I think the commits you cherry-picked are ones we want for 2.50 anyways, but not the one I was referring to | 15:59 |
| mvo | ijohnson: uh, thanks, that is unfortunate, I will double check | 16:01 |
| ijohnson | sorry yeah there's been a lot of things that need to go into 2.50 to make the bug fully fixed | 16:04 |
| mup | PR snapd#10190 closed: tests: adding debug info for create user tests <Simple 😃> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10190> | 16:45 |
| * cachio -> app doctor | 16:51 | |
| === pedronis_ is now known as pedronis | ||
| pedronis | mvo: should we merge https://github.com/snapcore/snapd/pull/10189 ? | 16:59 |
| mup | PR #10189: many: hide EncryptionKey size and refactors for fde hook v2 next steps <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10189> | 16:59 |
| mvo | pedronis: yes | 17:00 |
| mvo | pedronis: let me do this | 17:00 |
| * ijohnson lunches | 17:00 | |
| mup | PR snapd#10189 closed: many: hide EncryptionKey size and refactors for fde hook v2 next steps <Run nested> <UC20> <Created by pedronis> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10189> | 17:00 |
| pedronis | thanks | 17:01 |
| mup | PR snapd#10186 closed: overlord: properly mock usr-lib-snapd tests to mimic an Ubuntu Core system <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10186> | 17:51 |
| mup | PR snapd#10163 closed: o/configstate/configcore/vitality: fix RequireMountedSnapdSnap bug <Bug> <Squash-merge> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10163> | 17:56 |
| mup | PR snapd#10191 opened: o/servicestate/servicemgr.go: add ensure loop for snap service units (2.50) <Created by mvo5> <https://github.com/snapcore/snapd/pull/10191> | 18:01 |
| mup | PR snapd#10192 opened: o/configstate/configcore/vitality: fix RequireMountedSnapdSnap bug (2.50) <Created by mvo5> <https://github.com/snapcore/snapd/pull/10192> | 18:06 |
| mup | PR snapd#10193 opened: many: move responsibilities down seboot -> kernel/fde and boot -> secboot <Run nested> <UC20> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10193> | 18:16 |
| mup | PR snapcraft#3512 opened: cli: introduce edit-validation-sets <Created by sergiusens> <https://github.com/snapcore/snapcraft/pull/3512> | 19:19 |
| === Eighth_Doctor is now known as Conan_Kudo | ||
| === Conan_Kudo is now known as Eighth_Doctor | ||
| === hggdh is now known as hggdh-msft | ||
| === hggdh-msft is now known as hggdh | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!