| mborzecki | morning | 06:10 |
|---|---|---|
| zyga | good morning | 06:33 |
| mborzecki | zyga: hey | 06:41 |
| zyga | :-) | 06:41 |
| zyga | an easier day today | 06:41 |
| zyga | only training today and tomorrow | 06:41 |
| pstolowski | morning | 07:04 |
| mborzecki | pstolowski: hey | 07:20 |
| mborzecki | pstolowski: any PRs i should look at? | 07:22 |
| mborzecki | mvo: restarted the github jobs in https://github.com/snapcore/snapd/pull/10207 unit tests failed on gpg (again) | 07:23 |
| mup | PR #10207: vendor: bump github.com/canonical/go-tpm2 revision <Created by mvo5> <https://github.com/snapcore/snapd/pull/10207> | 07:23 |
| pstolowski | mborzecki: hey, https://github.com/snapcore/snapd/pull/10205 should be straightforward | 07:25 |
| mup | PR #10205: cmd/snap, client: snap remove-quota command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10205> | 07:25 |
| mborzecki | pstolowski: ha ok, i'm already looking at it ;) | 07:25 |
| pstolowski | thanks! | 07:26 |
| mborzecki | pstolowski: +1 | 07:32 |
| pstolowski | ty! | 07:32 |
| mborzecki | pstolowski: #10208 is waiting for #10204? | 07:33 |
| mup | Bug #10208: Needs rebuild with new libneon <openoffice.org (Ubuntu):Invalid by doko> <openoffice.org (Debian):Fix Released> <https://launchpad.net/bugs/10208> | 07:33 |
| mup | PR #10208: daemon: implement REST API for quota groups (create / list / get) <quota> <⛔ Blocked> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10208> | 07:33 |
| mup | Bug #10204: Add new launcher to desktop won't take effect after a restart <nautilus (Ubuntu):Fix Released by seb128> <https://launchpad.net/bugs/10204> | 07:33 |
| mup | PR #10204: o/servicestate/quota_control.go: introduce basic group manipulation methods <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10204> | 07:33 |
| pstolowski | mborzecki: yes | 07:34 |
| pstolowski | mborzecki: but also needs reworking a bit | 07:34 |
| mborzecki | ah. ok, so i'll skip it for now | 07:34 |
| pstolowski | mborzecki: so don't review it (but 10204 should be ready for review) | 07:34 |
| mborzecki | ok | 07:35 |
| mvo | pstolowski: keep me update when there is anything new to review or if I can help in any other way. I look at 10204 in the meantime | 07:42 |
| mvo | pstolowski: and good morning :) | 07:42 |
| pstolowski | mvo: will do, thanks | 07:44 |
| mup | PR snapcraft#3516 closed: github: update workflows that to use pull_request_target <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3516> | 08:07 |
| pstolowski | mvo: next up for review - https://github.com/snapcore/snapd/pull/10210 - last commit is the new code | 08:41 |
| mup | PR #10210: cmd/snap, client: snap quotas command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10210> | 08:41 |
| mup | PR snapd#10210 opened: cmd/snap, client: snap quotas command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10210> | 08:41 |
| mup | PR snapd#10211 opened: o/servicestate/quota_control.go: introduce (very) basic group manipulation methods <quota> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10211> | 09:21 |
| pedronis | mborzecki: hi, could you review https://github.com/snapcore/snapd/pull/10203 | 09:34 |
| mup | PR #10203: image,c/snap: implement prepare-image --customize <Created by pedronis> <https://github.com/snapcore/snapd/pull/10203> | 09:34 |
| pedronis | pstolowski: https://github.com/snapcore/snapd/pull/10210 and https://github.com/snapcore/snapd/pull/10205 are ready for review? | 09:38 |
| mup | PR #10210: cmd/snap, client: snap quotas command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10210> | 09:38 |
| mup | PR #10205: cmd/snap, client: snap remove-quota command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10205> | 09:38 |
| pstolowski | pedronis: yes. remove is first. quotas command is just last commit on top of remove | 09:38 |
| pedronis | thx | 09:39 |
| === alan_g_ is now known as alan_g | ||
| mup | PR core20#102 closed: hooks: add mDNS hostname resolution support <Blocked> <Created by jhenstridge> <Merged by xnox> <https://github.com/snapcore/core20/pull/102> | 09:57 |
| pstolowski | mvo: can you merge https://github.com/snapcore/snapd/pull/10205 (unrelated failures)? | 10:25 |
| mup | PR #10205: cmd/snap, client: snap remove-quota command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10205> | 10:25 |
| mvo | pstolowski: sure | 10:37 |
| mup | PR snapd#10205 closed: cmd/snap, client: snap remove-quota command <quota> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10205> | 10:41 |
| pstolowski | pedronis: i've rebased #10210 | 10:43 |
| mup | PR #10210: cmd/snap, client: snap quotas command <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10210> | 10:43 |
| mup | Bug #10210: Second head doesn't work with Mobility Radeon 9600 M10 <xorg (Ubuntu):Invalid by daniels> <https://launchpad.net/bugs/10210> | 10:43 |
| mvo | mborzecki: when you have some spare cycles, could you please check 10203? | 10:52 |
| mborzecki | mvo: sure, i'll take a look now | 10:53 |
| * pstolowski lunch | 11:04 | |
| mborzecki | pstolowski: is the quota groups tree depth limited to 2? | 11:29 |
| mborzecki | iow just groups & subgroups right? | 11:30 |
| pedronis | mborzecki: no | 11:42 |
| pedronis | you can have any depth (we should have a limit and the system probably has, but is not 2) | 11:43 |
| clmsy | hi everyone, i have a quick question. in the latest ubuntu core 20 image that i prepared, no matter what i do. cloud-init never runs on boot. | 11:58 |
| clmsy | i placed it as cloud-init.yaml and cloud.conf but whenever i boot into core20, i get the generic network setup and ubuntu login ncurses ui | 11:59 |
| mup | PR snapd#10212 opened: network-setup-control: whitelist netplan generator (LP: #1926442) <Created by slyon> <https://github.com/snapcore/snapd/pull/10212> | 12:06 |
| pstolowski | mborzecki: the cli receives complete hierarchy but flattened, in case the question was triggered by snap quotas pr ;) | 12:17 |
| mborzecki | pstolowski: yeah, i was slightly confused by the presentation | 12:18 |
| pedronis | clmsy: did it work before? depending on the grade of the model you use you might have to enable cloud-init explicitly. for security reasons some ways to drive cloud-init are not supported for the signed/secure grade of models | 12:20 |
| mborzecki | pedronis: do you think we should fail early if the recovery system directory already exists? | 12:46 |
| pedronis | mborzecki: yes | 12:48 |
| mborzecki | pedronis: ok, i'll add a check to seedwriter then | 12:49 |
| pedronis | degville: thanks for your input in https://github.com/snapcore/snapd/pull/10196 , I had to counterpropose something though because as you said something wasn't clear, can you look there again | 12:49 |
| mup | PR #10196: o/devicestate,o/hookstate/ctlcmd: introduce SystemModeInfo methods and snapctl system-mode <Created by pedronis> <https://github.com/snapcore/snapd/pull/10196> | 12:49 |
| pedronis | degville: here: https://github.com/snapcore/snapd/pull/10196#discussion_r623016946 | 12:49 |
| degville | pedronis: thank you! I'll take a look! | 12:59 |
| === mup_ is now known as mup | ||
| === mup_ is now known as mup | ||
| mborzecki | pedronis: i've updated #10181, there's a bunch of seedwriter error code paths that aren't test but afaiu, those are only triggered if operations are called in the wrong order | 13:55 |
| mup | Bug #10181: Usability: Cursor notifications doesn't work <Ubuntu:Invalid by seb128> <https://launchpad.net/bugs/10181> | 13:55 |
| mup | PR #10181: overlord/devicestate: add helper for creating recovery systems at runtime <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10181> | 13:55 |
| pedronis | mborzecki: thx | 13:55 |
| pedronis | degville: I pushed my changes there, for expedience, but it means you double check if I applied your other suggestions properly | 13:56 |
| pedronis | *you can | 13:56 |
| degville | pedronis: yes, absolutely - thanks for letting me know. | 13:56 |
| degville | pedronis: just looked and it all looks good! thank you! | 13:58 |
| pedronis | thx | 13:58 |
| pstolowski | re | 14:09 |
| ijohnson | pedronis: in https://github.com/snapcore/snapd/pull/10211#discussion_r622952750, to be clear, you mean if we try to update the memory limit for a sub-group to be greater than the limit allowed by the parent group ? | 14:21 |
| mup | PR #10211: o/servicestate/quota_control.go: introduce (very) basic group manipulation methods <quota> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10211> | 14:21 |
| pedronis | ijohnson: yes | 14:21 |
| ijohnson | ok, thanks for clarifying | 14:22 |
| pedronis | ijohnson: I tried to answer some of your questions there | 14:33 |
| ijohnson | ok, thanks that makes more sense now | 14:34 |
| pedronis | ijohnson: sorry, two of my comments were more statement than feedback asking for a change, though they might mean that we need a comment nearby | 14:35 |
| dot-tobias | hi all | 14:37 |
| dot-tobias | In case someone has time to look at a few (ok, quite a few) questions regarding first-boot / seeding UX, I just opened https://forum.snapcraft.io/t/first-boot-device-initialization-ux/24152 – thankful for helpful comments | 14:41 |
| ijohnson | hi dot-tobias we are on a tight deadline at the moment, so it will be a few days before anyone can devote a lot of attention (well myself at least) to the post, but I have got it in my backlog to look at when I have more time | 14:43 |
| pedronis | dot-tobias: what ijohnson said, but a short thing: detect from within a snap if the seeding process is still running?, yes we are adding something like that atm | 14:44 |
| pstolowski | mvo, pedronis i've updated and unblocked #10208 (it's going to fail now due to missing servicestate methods) | 14:44 |
| mup | Bug #10208: Needs rebuild with new libneon <openoffice.org (Ubuntu):Invalid by doko> <openoffice.org (Debian):Fix Released> <https://launchpad.net/bugs/10208> | 14:44 |
| mup | PR #10208: daemon: implement REST API for quota groups (create / list / get) <Skip spread> <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10208> | 14:44 |
| ijohnson | nice thanks pstolowski | 14:45 |
| pstolowski | ijohnson: btw i'll work on a spread test for cli | 14:46 |
| ijohnson | awesome thank you! | 14:46 |
| dot-tobias | ijohnson, pedronis: Thanks for the quick feedback, and I hope you don't need to pull too many night shifts for this deadline 😊 Great to hear that seeding detection is already underway! | 14:46 |
| doko | bad mup for highlighting noise | 14:47 |
| mvo | pstolowski: \o/ thank you | 14:57 |
| mup | PR snapd#10213 opened: tests: basic spread test for snap quota commands <Skip spread> <quota> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10213> | 15:32 |
| ijohnson | pedronis: the PR is updated now with more tests and checks and the things you mentioned | 16:14 |
| pedronis | ijohnson: thanks, I'll look at it in a bit | 16:15 |
| pstolowski | ijohnson: which one, 10211 ? | 16:20 |
| ijohnson | pstolowski: #10211 | 16:21 |
| mup | Bug #10211: nautilus crash when writing on smbfs <nautilus (Ubuntu):Invalid by seb128> <https://launchpad.net/bugs/10211> | 16:21 |
| mup | PR #10211: o/servicestate/quota_control.go: introduce (very) basic group manipulation methods <quota> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10211> | 16:21 |
| pstolowski | thx | 16:21 |
| mvo | pstolowski: let me know if you can update your pr or if it's getting too late, I can help and pickup things if needed | 16:21 |
| mvo | pstolowski: but hopefully very straightforward :) | 16:21 |
| pstolowski | mvo: will do it | 16:21 |
| mvo | thanks | 16:22 |
| pstolowski | done | 16:25 |
| pstolowski | mvo, ijohnson i though we wanted to leave UpdateQuota out for the first iteration? | 16:47 |
| pstolowski | *thought | 16:47 |
| mvo | pstolowski: we will | 16:48 |
| mvo | pstolowski: it will be a followup, just ignore it for now | 16:48 |
| ijohnson | my understanding was it will be left out of the daemon | 16:48 |
| pstolowski | ok, got confused reviewing the PR | 16:48 |
| ijohnson | mvo: oh should I have removed servicestate.UpdateQuota entirely? | 16:48 |
| * ijohnson is very confused again | 16:48 | |
| mvo | ijohnson: no I think it's fine | 16:53 |
| mvo | ijohnson: unless I'm confused | 16:53 |
| mvo | ijohnson: I just wanted to unexport it | 16:53 |
| ijohnson | ahhhhhhhhhhhhhhhhhh | 16:53 |
| mvo | ijohnson: but we can do that in a followup, I think/hope this in the current form is uncontroverial | 16:54 |
| ijohnson | mvo: you mean UpdateQuotas note the s | 16:54 |
| mvo | ijohnson: oh, sorry, yes | 16:54 |
| mvo | ijohnson: I think | 16:54 |
| ijohnson | I thought you were talking about UpdateQuota (note the no s) | 16:54 |
| ijohnson | ok, I think we are in alignment, UpdateQuota (which will be patchQuotas in the future) will be in the PR as-is, and we will un-export that function in the followup | 16:55 |
| mvo | ijohnson: sorry, my bad | 16:55 |
| mvo | ijohnson: PatchQuotaState was hte one I had in mind | 16:55 |
| mvo | ijohnson: yeah :) looks like we are aligned | 16:55 |
| ijohnson | the full thing, servicestate.UpdateQuota(st *state.State, name string, updateOpts QuotaGroupUpdate) will stay as-is in the PR | 16:55 |
| mvo | ijohnson: yes, I think so | 16:56 |
| ijohnson | great yeah we're good then | 16:56 |
| mup | PR snapd#10204 closed: o/servicestate/quota_control.go: introduce basic group manipulation methods <quota> <⛔ Blocked> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10204> | 18:02 |
| mup | PR snapd#10211 closed: o/servicestate/quota_control.go: introduce (very) basic group manipulation methods <quota> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10211> | 18:03 |
| mup | PR snapd#10214 opened: features,servicestate: add experimental.quota-control flag <quota> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10214> | 18:38 |
| === JanC is now known as Guest66672 | ||
| === JanC_ is now known as JanC | ||
| mup | PR snapd#10196 closed: o/devicestate,o/hookstate/ctlcmd: introduce SystemModeInfo methods and snapctl system-mode <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10196> | 20:53 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!