| === hjensas|afk is now known as hjensas | ||
| minimal | looking at the code for cc_disk_setup I see a reference to "remove" inside the "layout" section (link 807) but don't see that documented anywhere | 16:14 |
|---|---|---|
| rharper | if there is any doc for that, likley in the template docstring at the top ; possibly in docs/examples stuff ... | 16:18 |
| minimal | rharper: don't see it mentioned in either examples or at top of file | 16:28 |
| minimal | it seems to be complementary/conflicting functionality to "overwrite" boolean | 16:31 |
| rharper | it looks to be separate ... please clear this disk;.... that is all | 16:34 |
| rharper | I can see some use for that | 16:35 |
| minimal | yeah, just wondering as its undocumented and no examples mention it whether anyone's actually using it. | 16:42 |
| minimal | "remove: true" seems to wipe fs/partition signatures and zaps partitioning labels, whereas "overwrite: true" will overwrite any existing partitions/filesystems | 16:45 |
| minimal | not sure exactly what would happen (and in which order) if you set both "overwrite: true" and "remove: true" | 16:47 |
| rharper | I think it wouldn't do anything other than wipe everything; | 17:01 |
| rharper | the bad combination is remove: true and fs_setup: stuff ... | 17:02 |
| rharper | it's worth documenting and having examples; we could drop it; but I do think "please wipe this disk" is a useful feature in disk_setup | 17:03 |
| minimal | rharper: yeah, i'm doing some tests here with a VM to understand how it works and then i'll raise a PR to document it | 17:09 |
| rharper | minimal: cool, sounds good | 17:41 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!