| mborzecki | morning | 06:06 |
|---|---|---|
| mardy | 'morning! | 06:11 |
| mborzecki | mardy: heya | 06:12 |
| mardy | about https://forum.snapcraft.io/t/glaxnimate-snap-error/24313: is libstdc++ something that people should ship in their snap packages, or should it use the one from the system? | 06:12 |
| mborzecki | mardy: afaict libstdc++ is in core20/18/core so part of the base | 06:13 |
| mborzecki | and GLIBCXX_3.4.26 symbol version appears in the binary, so maybe some configuration/environment problem? | 06:15 |
| mborzecki | but only in libstdc++ from core20, so maybe a wrong base? (or kf5 uses core18 still) | 06:16 |
| mborzecki | wouldn't be suprised if it's a binary the built on 20.04 host and just dropped into a snap | 06:17 |
| mborzecki | s/suprised/surprised/ | 06:17 |
| pstolowski | morning | 07:03 |
| mvo | good morning pstolowski | 07:05 |
| mup | PR snapd#10259 closed: interfaces/dbus: allow claiming 'well-known' D-Bus names with a wildcard suffix <Created by oSoMoN> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10259> | 07:06 |
| mborzecki | mvo: hey | 07:14 |
| mborzecki | pstolowski: and hello there too | 07:14 |
| mvo | mborzecki: good morning! | 07:21 |
| mborzecki | hmm https://github.com/snapcore/snapd/pull/10241 is right now at 50MB, but some tests still fail, i've just merged master and will let it run, then we can maybe bump it to 60MB if still needed | 07:22 |
| mup | PR #10241: tests: set memory limit for snapd <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10241> | 07:22 |
| mborzecki | i guess we could run tar pipeline for snapshots, apparmor_parser and maybe something else in a separate scope but that's like accountants cooking the books tbh | 07:23 |
| mborzecki | anyways, still think that having an idea of an upper limit of memory requirement during the tests is useful | 07:24 |
| zyga | good morning guys | 07:45 |
| zyga | mvo spring is finally here :) | 07:45 |
| zyga | every morning is a joy :) | 07:45 |
| mardy | I have a layout rule like this: /usr/share: | 07:50 |
| mardy | symlink: $SNAP/usr/share/ | 07:50 |
| mardy | but then snapcraft fails with this error: error: cannot pack "/root/prime": cannot validate snap "libinput-tool": layout "/usr/share" uses invalid symlink old name "/snap/libinput-tool/unset/usr/share/": must be absolute and clean | 07:50 |
| mardy | sounds like $SNAP is not being expanded, but why? | 07:51 |
| zyga | it's weird that there's 'unset' there as well | 07:51 |
| zyga | but it's a snapcraft side logic, I don't know what's going on there | 07:52 |
| mardy | oh, changing /usr/share/ to /usr/share/libinput makes it work | 07:58 |
| zyga | good morning pedronis | 08:06 |
| oSoMoN | mvo, good morning, and thanks for merging PR 10259 ! | 08:12 |
| mup | PR #10259: interfaces/dbus: allow claiming 'well-known' D-Bus names with a wildcard suffix <Created by oSoMoN> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10259> | 08:12 |
| mvo | oSoMoN: thank you! I cherry picked it for 2.50, it will be part of 2.50.1 which we plan to release in ~2 weeks | 08:13 |
| oSoMoN | mvo, that's awesome, people at Mozilla will be happy to know that | 08:24 |
| sil2100 | mvo: will look at the armhf pi-gadget soon! | 08:48 |
| mvo | sil2100: I think waveform did some work there already | 08:53 |
| sil2100 | yay | 08:55 |
| sil2100 | mvo: promoted the latest edge armhf snaps to beta now | 09:03 |
| mvo | sil2100: \o/ | 09:09 |
| rZr | sil2100, yes thanks I confirm this problem is gone | 09:34 |
| rZr | the most difficult part for me is to find my usb/uart cable | 09:34 |
| mvo | rZr: thanks for confirming | 09:39 |
| rZr | yw | 09:40 |
| zyga | woot | 10:05 |
| zyga | mvo is that what I think it is?! :) | 10:05 |
| mvo | zyga: dtbs from the kernel - finally! | 10:24 |
| zyga | mvo that's amazing | 10:24 |
| zyga | thank you for carrying that torch all the way | 10:25 |
| mvo | zyga: :) thanks, appreciated. took a while but finally here | 10:32 |
| mardy | The manual tests with libinput show that this interface is kind of working, so reviews are welcome :-) https://github.com/snapcore/snapd/pull/10251 | 10:38 |
| mup | PR #10251: interfaces/builtin: introduce raw-input interface <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/10251> | 10:38 |
| pedronis | pstolowski: hi, is https://github.com/snapcore/snapd/pull/10182 read for re-reviews? | 10:53 |
| mup | PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10182> | 10:53 |
| pstolowski | pedronis: yes | 10:53 |
| pedronis | pstolowski: thx, re-queued | 10:53 |
| pstolowski | ty | 10:53 |
| * ogra gives mardy a hug, i'm waiting for such an interface since ages 🙂 | 11:02 | |
| mup | PR snapd#10260 opened: secboot: switch encryption key size to 32 byte (thanks to Chris) <Needs Samuele review> <Run nested> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10260> | 11:36 |
| pedronis | ijohnson: hi, I reviewed a couple of your PRs, there are questions in both | 12:16 |
| pedronis | ijohnson: cachio: what's the state https://github.com/snapcore/snapd/pull/10165 ? does it just need a force merge or it's blocked on something else | 12:18 |
| mup | PR #10165: tests: add tests about services vs snapd refreshes <Run nested> <Squash-merge> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10165> | 12:18 |
| cachio | pedronis, the code has the +2 | 12:22 |
| cachio | let me check the tests which failed | 12:22 |
| cachio | pedronis, the test failure in core18 seems to be unrelated | 12:26 |
| cachio | it is hte only one blocking | 12:26 |
| cachio | we can either re-run or force merge | 12:27 |
| cachio | pedronis, | 12:27 |
| pedronis | let's see what ijohnson says | 12:48 |
| ijohnson | pedronis for 10165, it's ready to land there is just that issue we found where sometimes the test fails because it installs the wrong snapd snap, I think it may actually be related to the PR mvo opened on Friday about the .local-install bug | 12:53 |
| mup | PR snapd#10261 opened: o/snapstate: refresh control - autorefresh phase2 <Needs Samuele review> <Refresh control> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10261> | 12:57 |
| ijohnson | @mvo I'm probably gonna be 2-3 minutes late to SU, sorry about that a bit of a late start for me today | 12:58 |
| pedronis | mborzecki: I reviewed https://github.com/snapcore/snapd/pull/10252 | 14:11 |
| mup | PR #10252: boot: reseal given keys when the respective boot chain has changed <Needs Samuele review> <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10252> | 14:11 |
| * cachio afk | 14:20 | |
| mardy | I'm on the linter again :-) So, this line (https://github.com/snapcore/snapd/blob/master/interfaces/builtin/i2c_test.go#L70) is unused; should I just remove it, or is it waiting for a test to be written? | 14:46 |
| mardy | BTW, most of those members only get assigned to, otherwise they seem unused | 14:47 |
| ijohnson | mardy: probably either cargo culted from other tests or was at one point part of a test which then got refactored etc | 14:47 |
| ijohnson | mardy: probably not too hard to write a unit test to check for that case if you want to try, otherwise it can probably be deleted, I think we have pretty good coverage elsewhere in the codebase about that specific issue (an interface trying to be used as a different type of interface) | 14:49 |
| mardy | pstolowski: it looks like the commit which made it obsolete is yours (https://github.com/snapcore/snapd/commit/1cf702d11819b148d228baff341c89f9cd50471b#diff-ddce5b424337522fb4e0230136dfebdede5de499d5761678ec63df822f63259a) | 14:50 |
| ijohnson | interestingly though it doesn't even appear to be used in that commit :-) | 14:51 |
| pstolowski | oh wow, 2017 | 14:53 |
| pstolowski | sorry, i don't remember what was it about ;) | 14:53 |
| pstolowski | probably interface hooks work or something related, there were massive changes | 14:53 |
| mardy | pstolowski: no worries, I was just checking in case you would say "oh, that line is super-important, we absolutely need a test with it" :-) | 14:53 |
| pstolowski | mardy: so is socket AF_NETLINK and network netlink raw, actually needed in raw-input interface? | 15:28 |
| pedronis | pstolowski: I suspect so to talk with udev, we have the same in raw-usb | 15:33 |
| pedronis | pstolowski: I reviewed https://github.com/snapcore/snapd/pull/10182 and https://github.com/snapcore/snapd/pull/10187, they look good in itself but I have some more general questions/comments. Let me know if you have questions for me | 15:34 |
| mup | PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10182> | 15:34 |
| mup | PR #10187: o/hookstate, o/snapstate: print revision, version, channel with snapctl --pending <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10187> | 15:34 |
| pstolowski | i see | 15:34 |
| pedronis | s/itself/themselves/ | 15:34 |
| pedronis | mvo: there seem to be real spread failures in https://github.com/snapcore/snapd/pull/10260, maybe some of the spread tests need changes too? | 15:36 |
| mup | PR #10260: secboot: switch encryption key size to 32 byte (thanks to Chris) <Needs Samuele review> <Run nested> <Squash-merge> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10260> | 15:36 |
| mvo | pedronis: yeah, I'm looking at those right now, thanks | 15:37 |
| pstolowski | pedronis: thanks for the reviews | 15:55 |
| mup | PR snapcraft#3520 opened: package-repositories: remove experimental flag <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3520> | 16:00 |
| ijohnson | pedronis: one question https://github.com/snapcore/snapd/pull/10217#discussion_r630319089 | 16:04 |
| mup | PR #10217: o/servicestate: restart slices + services on modifications <Needs Samuele review> <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10217> | 16:04 |
| pedronis | mborzecki: I have a question in https://github.com/snapcore/snapd/pull/10253 | 16:06 |
| mup | PR #10253: boot: helpers for manipulating current and good recovery systems list <Run nested> <â›” Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10253> | 16:06 |
| pedronis | ijohnson: I answered | 16:08 |
| ijohnson | pedronis: thanks I will take your suggestion | 16:09 |
| ijohnson | ugh why is systemd so hard | 16:48 |
| * ijohnson lunches | 16:48 | |
| ogra | ijohnson, because it replaced upstart which was so wobbly ... 🙂 | 18:05 |
| mup | PR snapd#10262 opened: tests/nested/manual: add test for install-device + snapctl reboot <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10262> | 22:28 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!