[06:32] <mborzecki> morning
[06:41] <mardy> hI!
[06:55] <mborzecki> mardy: heya, i see you pushed some tests to raw-input, let me look at those
[06:58] <mardy> mborzecki: I mostly copied them from those for the joystic interface, but please don't tell anyone ;-)
[06:59] <mborzecki> that's fair, there are some repeated patterns in the tests
[07:05] <pstolowski> morning
[07:08] <mborzecki> pstolowski: hey
[07:10] <mborzecki> mardy: btw. there's a spread-shellcheck tool, which is a tiny wrapper around shellcheck that takes a spread.yaml|task.yaml file, extracts the bits that execute under shell and feeds them to shellcheck
[07:37] <mborzecki> mardy: https://github.com/snapcore/snapd/pull/10251#issuecomment-840380873
[07:37] <mup> PR #10251: interfaces/builtin: introduce raw-input interface <Needs security review> <Created by mardy> <https://github.com/snapcore/snapd/pull/10251>
[07:53] <mardy> mborzecki: thanks, will fix
[08:49] <mardy> mborzecki: it's still failing, but this time I don't think that the failure is due to my changes: https://github.com/snapcore/snapd/pull/10251/checks?check_run_id=2573757599
[08:49] <mup> PR #10251: interfaces/builtin: introduce raw-input interface <Needs security review> <Created by mardy> <https://github.com/snapcore/snapd/pull/10251>
[08:49] <mardy> mborzecki: is that kind of failure familiar to you?
[08:53] <mborzecki> looking
[08:54] <mborzecki> mardy: ah yes, the mystery gpg problem, we've been hitting it randomly, but so far the source of the problem has not been identified, we suspect that it had something to do with running out of entropy
[08:55] <mborzecki> mardy: then pedronis suspected there may be something in the go stdlib implementation of gpg
[09:11] <pstolowski> mardy: all tests passing is unfortunately very rare :/ due to the number of tests and systems (some of which constantly move), and external factors (store or gce hiccups etc)
[09:25] <mborzecki> meh cherry-picking the whole kernel command line branches into 2.50
[09:25] <mborzecki> seems like we missed it, or decided to push it to 2.51 (which i don't recall, but that wouldn't be the first time my memory is bad)
[09:34] <mardy> pstolowski: hi! The Status() method in systemd/systemd.go, is it the one you said I should avoid using?
[09:36] <mardy> pstolowski: the getUnitStatus() is private; I'll make it public as QueryUnitStatus()
[09:36] <pstolowski> mardy: no, feel free to use it if it's usable (I was talking about getUnitStatus but Status() uses it)
[09:38] <mardy> ah, ok
[09:41] <mardy> pstolowski: I will apply the same logic to both "restart" and "reload" operations, right? Or should only "restart" be affected by my changes?
[09:46] <pstolowski> mardy: i think both should have same logic
[10:10] <mup> PR snapd#10265 opened: many: backport kernel command line for 2.50 <Run nested> <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10265>
[10:56] <pstolowski> #10182 and #10187 for refresh control need 2nd reviews
[10:56] <mup> Bug #10182: Can not logout of gnome when xcompmgr is running <gnome-panel (Ubuntu):Invalid by fabbione> <https://launchpad.net/bugs/10182>
[10:56] <mup> PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10182>
[10:56] <mup> Bug #10187: debconf fails to install <debconf (Ubuntu):Fix Released> <debconf (Debian):Fix Released> <https://launchpad.net/bugs/10187>
[10:56] <mup> PR #10187: o/hookstate, o/snapstate: print revision, version, channel with snapctl --pending <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10187>
[11:28] <mardy> pstolowski: is there a snap command to disable a service, or should I use systemctl (the context is the spread tests)?
[11:29] <jamesh> mardy: snap stop
[11:30] <jamesh> "snap stop --disable", even
[11:30] <pstolowski> yep
[11:31] <jamesh> it doesn't maintain any extra state outside of systemd though, so using systemctl on a snap service shouldn't break anything
[11:41] <mardy> thanks! But I don't want to stop the service, so I guess I'll use systemctl
[11:55] <mup> PR snapd#10266 opened: wrappers/services.go: do not restart disabled or inactive services <Created by mardy> <https://github.com/snapcore/snapd/pull/10266>
[12:31] <mardy> The unit tests are failing in my branch: https://github.com/snapcore/snapd/pull/10266/checks?check_run_id=2575132725
[12:31] <mup> PR #10266: wrappers/services.go: do not restart disabled or inactive services <Created by mardy> <https://github.com/snapcore/snapd/pull/10266>
[12:31] <mardy> I've added some debug info, and I see that the systemctl command being run is: show --property=Id,ActiveState,UnitFileState,Type snap.test-snap.foo.service snap.test-snap.bar.service snap.test-snap.abc.service
[12:31] <mardy> the output is: [65 99 116 105 118 101 83 116 97 116 101 61 105 110 97 99 116 105 118 101 10]
[12:32] <mardy> and the error generated by snapd is: cannot get unit "" status: missing Id, UnitFileState in ‘systemctl show’ output
[12:33] <pstolowski> mardy: have you mocked snapctl?
[12:33] <pstolowski> mardy: sorry, systemctl
[12:33] <mardy> pstolowski: no, but I didn't touch these tests
[12:33] <mardy> so I don't get why they are failing now
[12:35] <pstolowski> mardy: you changed RestartServices impl to get statuses, you now need to update all existing tests that use restart to mock systemctl accordingly
[12:36] <cachio> mborzecki, hi
[12:36] <cachio> mborzecki, I see https://paste.ubuntu.com/p/VyRynqBcfW/
[12:36] <mborzecki> cachio: let me see
[12:36] <cachio> when running tests on fedora 34
[12:36] <pstolowski> mardy: because the existing mock doesn't expect extra systemctl callsą
[12:36] <cachio> it is getting stuck on reset
[12:37] <cachio> mborzecki, this is an example https://paste.ubuntu.com/p/s8nGk8vKnr/
[12:44] <cachio> mborzecki, I have a debug session open
[12:44] <cachio> if you want to take a look
[12:44] <mborzecki> cachio: yeah, send me the ip and password
[13:20] <mup> PR snapd#10267 opened: snap-bootstrap: start drafting run-cloudimg mode <Created by xnox> <https://github.com/snapcore/snapd/pull/10267>
[13:27] <mborzecki> cachio: hm no idea yet
[13:27] <mborzecki> cachio: is it reproducible after this test?
[13:27] <cachio> if you run few tests it is reproducible 100%
[13:28] <cachio> mborzecki, this is the log for that machine https://paste.ubuntu.com/p/nMgJPm8JJG/
[13:29] <mborzecki> hmm w8, so that's diferent
[13:35] <mborzecki> cachio: hm not sure what's happening, so snapd is started and is active, but that nc command sometimes get stuck (i could reproduce it a couple of times), it gets the response from snapd but then hangs
[13:36] <cachio> mborzecki, weird
[13:36] <cachio> nc is hanging :)
[13:37] <mborzecki> cachio: fwiw, this is the backtrace: https://paste.ubuntu.com/p/Bz4ssw8cJ2/
[13:38] <mborzecki> it's waiting on poll, i suspect the connection shoudl be closed next, but isn't
[13:39] <mborzecki> hm maybe it's something systemd related ? or new go idk
[13:40] <cachio> perhaps we can use
[13:40] <cachio> -w timeout	Timeout for connects and final net reads
[13:41] <cachio> as a workaround
[13:42] <mborzecki> cachio: can't reproduce it anymore
[13:42] <mborzecki> heh
[13:42] <mborzecki> looks like a race
[13:45] <mborzecki> cachio: this is enough to trigger it sometimes `systemctl stop snapd snapd.socket;systemctl start snapd.socket; sleep 0.1; printf 'GET / HTTP/1.0\r\n\r\n' | nc -U  /run/snapd.socket`
[13:45] <cachio> for some systems we use -q 1
[13:46] <mborzecki> and i can reproduce it locally too
[13:47] <mborzecki> cachio: yeah, that seems to work, can you try to push a patch?
[13:47] <mborzecki> works even locally
[13:48] <mborzecki> cachio: the failure with selinux denials, do you know which test was it?
[13:48] <cachio> I thinks yes
[13:49] <cachio> mborzecki, I mean, I'll create a patch
[13:50] <cachio> mborzecki, denials are for google:fedora-34-64 .../tests/regression/lp-1852361
[13:50] <mborzecki> hm so layouts
[14:00] <mborzecki> cachio: hm i think i'm confused, we do not fail a test when there's selinux denials (or just fail a few chosen tests)
[14:13] <cachio> mborzecki, don't know
[14:14] <mborzecki> cachio: do you have a full log of the failure?
[14:14] <mborzecki> cachio: we do list it as part of the debug section, but the failure was something else afaict
[14:16] <cachio> I have this log
[14:16] <cachio> https://paste.ubuntu.com/p/K6rYDrVDym/
[14:16] <cachio> mborzecki, this is the only one
[14:17] <cachio> mborzecki, about nc, using the -w param it is working very well
[14:17] <mborzecki> cachio: this one failed on the nc problem too
[14:17] <mborzecki> cachio: i think we want -q rather than -w
[14:18] <cachio> mborzecki, -q is not available on fedora
[14:21] <cachio> mborzecki, I just pushed the change for nc
[14:21] <cachio> let's see the errors now
[14:28] <pstolowski> i tried to reproduce https://forum.snapcraft.io/t/snap-refresh-broken-when-output-is-piped/24385/2 but couldn't
[14:30] <mborzecki> pstolowski: fwiw, i can't reproduce it either
[14:31] <pstolowski> mborzecki: nice... maybe was a red herring, temporary store hiccup
[14:31] <mborzecki> ah right, we saw something like this didn't we?
[14:31] <pstolowski> sure
[15:52]  * cachio_ lunch
[16:23] <mup> PR snapcraft#3521 opened: build providers: set hostname for lxd <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3521>
[17:13] <mup> PR snapcraft#3522 opened: python v2 plugin: update pip properly <Created by MrCarroll> <https://github.com/snapcore/snapcraft/pull/3522>