| mborzecki | morning | 06:11 |
|---|---|---|
| mardy | hi! | 06:19 |
| mborzecki | mardy: hey | 06:20 |
| mborzecki | mardy: anything i can help you with today? :) | 06:20 |
| mardy | mborzecki: yeah, I'm about to push a fix for the unit tests, but I can't really say that I like how the code in that commit looks like :-) But I'll ping you soon | 06:24 |
| mborzecki | mardy: https://github.com/snapcore/snapd/pull/10266 to this pr? | 06:25 |
| mup | PR #10266: wrappers/services.go: do not restart disabled or inactive services <Created by mardy> <https://github.com/snapcore/snapd/pull/10266> | 06:25 |
| mardy | mborzecki: yes, please see the last commit I just pushed | 06:28 |
| mborzecki | mardy: hmm, fwiw there's `systemctl try-restart` which seems to be doing what we want, but i'm not sure how far back it is supported (eg. on 14.04?) | 06:30 |
| mborzecki | mardy: posted some comments in the PR | 06:59 |
| pstolowski | morning | 07:08 |
| mardy | pstolowski: hi! | 07:08 |
| mardy | mborzecki: thanks, I applied some changes, and added a couple of questions to your comments :-) | 07:08 |
| mborzecki | pstolowski: hey | 07:16 |
| mborzecki | mardy: yeah, sorry missed that, perhaps adding a little comment in the test would be helpful so that we don't have to wonder for too long when one revisits the test in a longer while | 07:16 |
| thresh | hi. I'm having "Unexpected error when obtaining your account information" when trying to snapcraft login via my CI pipelines, any idea what that means? | 08:09 |
| pstolowski | thresh: temporary store issues maybe (looks ok right now per https://status.snapcraft.io)? or is it a permanent failure? | 08:12 |
| thresh | pstolowski, looks like it's been happening consistently for a few days now. I guess it's time to refresh the tokens... | 08:14 |
| pstolowski | thresh: i see, or ask on the forum | 08:15 |
| thresh | indeed, it was probably an expired login information | 08:26 |
| pstolowski | ok, good you sorted that out | 08:26 |
| mborzecki | more selinux fun, ehh | 09:13 |
| mborzecki | heh, filed https://bugzilla.redhat.com/show_bug.cgi?id=1960576 | 09:36 |
| mborzecki | looks like we shoudl tweak the tests a bit to make it less painful | 09:36 |
| pstolowski | mborzecki: nice bug report / analysis | 09:43 |
| zyga | igor's LAS talk is coming up soon on https://www.youtube.com/watch?v=iJeANBfLVHQ | 10:28 |
| zyga | mborzecki zbyszek replied quickly | 10:30 |
| mborzecki | zyga: yeah, sounds like a weekend project for me ;) | 10:36 |
| zyga | mborzecki s/weekend/workday/ but yeah : | 10:36 |
| mborzecki | zyga: not sure about workday, the snapd todo queue is long | 10:37 |
| mborzecki | mardy: btw. we try not to force push to a branch once there have been some comments added to already present code | 10:43 |
| mborzecki | mardy: also that means for branches taking a while to land, merging master into the branch is preferred to rebasing (unless nobody reviewed it yet, then rebase is ok) | 10:45 |
| mborzecki | github made some improvemens to the ui for presenting diffs when rebase occured, but it's still not quite there yet | 10:45 |
| mardy | mborzecki: ah, I see. I was using gitlab before, and there things work quite nicely | 10:47 |
| mborzecki | yeah, gitlab has it's own set of ui quirks ;) | 10:49 |
| pstolowski | mardy: you'll need to run gofmt -w -s .. over the files you touched in your snap restart PR; the catch though is you need to use gofmt from go-1.10 (because this is the version we use in our tests, newer version may produce different formatting) | 10:59 |
| zyga | Igor is live now | 11:01 |
| zyga | at https://www.youtube.com/watch?v=iJeANBfLVHQ | 11:01 |
| mborzecki | zyga: cool, thanks for the link | 11:03 |
| pstolowski | mardy: a few comments to your PR | 11:20 |
| mardy | pstolowski: thanks! Is there a way to locally run the code formatter on the spread tests? | 11:30 |
| mborzecki | mardy: which formatter? gofmt? | 11:30 |
| mborzecki | mardy: if it's about go code formatting, you can just run gofmt commnad (or gofmt -w <file> which will reformat and write the file) | 11:32 |
| mborzecki | mardy: if you're using emacs then you can use hooks 😛 no clue about other editors though | 11:33 |
| mborzecki | s/editors/operating systems with text editing capabilities/ | 11:33 |
| mardy | mborzecki: no, I was wondering about bash formatting (the spread tests) | 11:44 |
| mborzecki | ah, then we have no rules, i know there are some tools but haven't tried anything | 11:45 |
| zyga | there's shfmt but I haven't used it myself | 11:45 |
| mardy | mborzecki: it's about https://github.com/snapcore/snapd/pull/10266#discussion_r632443590 | 11:46 |
| mup | PR #10266: wrappers/services.go: do not restart disabled or inactive services <Created by mardy> <https://github.com/snapcore/snapd/pull/10266> | 11:46 |
| mardy | mborzecki: will I be able to squash the commits before the merge? Just trying to understand how I should format the fixup commits now | 12:04 |
| mborzecki | mardy: i see, you can run spread-shellcheck tests/main/services-restart and it will do the right checks | 12:05 |
| mardy | ah, but I don't have my spread account yet | 12:08 |
| pstolowski | mardy: yes, you can git rebase -i master at any time (and force-push), or squash-merge when merging | 12:13 |
| pstolowski | but we generally only squash-merge when needed for easy cherry picking | 12:14 |
| mborzecki | mardy: do no't need spread account for that, spread-shellcheck is just a thin wrapper around shellcheck that extract the 'shell' bits from spread task definitions and feeds them to shellcheck to verify correctness | 12:16 |
| mardy | mborzecki: where do I find it? | 12:19 |
| mborzecki | mardy: it's at the root of snapd tree | 12:19 |
| mborzecki | mardy: https://github.com/snapcore/snapd/blob/master/spread-shellcheck | 12:20 |
| mborzecki | mardy: then run `./spread-shellcheck tests/main/services-restart` | 12:20 |
| mardy | oh :-) I ran a `git grep` and didn't find anything! With git sometimes I forget that I can just run `ls` :-) | 12:28 |
| mup | PR snapcraft#3523 opened: autotools v2 plugin: adding cross compilation support <Created by kubiko> <https://github.com/snapcore/snapcraft/pull/3523> | 12:34 |
| === Eighth_Doctor is now known as Conan_Kudo | ||
| === Conan_Kudo is now known as Eighth_Doctor | ||
| pstolowski | mborzecki: do you know any reason we don't fail unit tests if dbus-launch is missing? seems a bit risky, we wouldn't even notice | 13:18 |
| mborzecki | pstolowski: hm the packaging runs unit tests (not our but downstream) and dbus-launch may not be there (or be runnable) | 13:20 |
| mborzecki | at least the packaging for EPEL7 or amazon linux may be tricky in that regard | 13:20 |
| pstolowski | right | 13:21 |
| mborzecki | cachio_: can you check whether there are any images avialble for opensuse 15.3? | 13:48 |
| mborzecki | the release is due in june, it'd be great to have it part of the spread suite by that time | 13:50 |
| cachio_ | mborzecki, let me check | 13:50 |
| mborzecki | hmm hmm we set snap-setup on 2 tasks during install, but the first one is prerequisites | 13:52 |
| cachio_ | mborzecki, there are images for 15.1 and 15.2 | 13:52 |
| mborzecki | cachio_: ah ok, thanks for checking! | 13:52 |
| cachio_ | also no images here https://download.opensuse.org/repositories/Cloud:/Images:/ | 13:53 |
| cachio_ | mborzecki, as debian 9 is required | 15:32 |
| cachio_ | it is not possible to merge the fedora-34 pr | 15:33 |
| cachio_ | we need mvo | 15:33 |
| cachio_ | to remove debian-9 as required | 15:33 |
| cachio_ | or perhaps force marge it | 15:33 |
| cachio_ | mborzecki, could you please +1 to #10249 | 17:14 |
| mup | PR #10249: tests: adding support for fedora-34 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10249> | 17:14 |
| mup | Bug #10249: gpm: FTBFS in sarge: Documentation fails to build because of mismatched parentheses <gpm (Ubuntu):Fix Released> <gpm (Debian):Fix Released> <https://launchpad.net/bugs/10249> | 17:14 |
| * cachio_ afk | 20:15 | |
| === RzR is now known as rZr | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!