| mborzecki | morning | 05:13 |
|---|---|---|
| mup | PR snapd#10270 closed: tests: update mount-ns test to support changes in the distro <⚠ Critical> <Created by sergiocazzolato> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10270> | 05:35 |
| mup | PR snapd#10217 closed: o/servicestate: restart slices + services on modifications <Needs Samuele review> <Squash-merge> <quota> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10217> | 06:11 |
| mborzecki | mvo: hey | 06:17 |
| mborzecki | mvo: can you take a look at https://github.com/snapcore/snapd/pull/10269 ? | 06:17 |
| mup | PR #10269: overlord: unit test tweaks, use well known snap IDs, setup snap declarations for most common snaps <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10269> | 06:17 |
| mvo | mborzecki: sure, looking | 06:28 |
| mborzecki | thanks! | 06:30 |
| mup | PR snapd#10262 closed: tests/nested/manual: add test for install-device + snapctl reboot <Run nested> <Test Robustness> <UC20> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10262> | 06:41 |
| mup | PR snapd#10265 closed: many: backport kernel command line for 2.50 <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10265> | 06:51 |
| mborzecki | yay | 06:51 |
| mvo | mborzecki: thank you so much for this one! | 06:53 |
| mborzecki | mvo: yw, thanks for landing it! | 06:53 |
| mup | PR snapd#10269 closed: overlord: unit test tweaks, use well known snap IDs, setup snap declarations for most common snaps <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10269> | 06:56 |
| mborzecki | interesting, some smappy posts in the forum about *coin created by newly set up accounts | 07:04 |
| mborzecki | heh `Err http://us-east1.gce.archive.ubuntu.com/ubuntu xenial InRelease` getting 503 | 07:06 |
| pstolowski | morning | 07:08 |
| mvo | good morning pstolowski | 07:08 |
| mvo | mborzecki: meh, let's hope the 503 go away again | 07:09 |
| mborzecki | mvo: https://github.com/snapcore/snapd/pull/10187 can be merged | 07:14 |
| mup | PR #10187: o/hookstate, o/snapstate: print revision, version, channel with snapctl --pending <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10187> | 07:14 |
| mborzecki | pstolowski: hey | 07:14 |
| mvo | mborzecki: on it | 07:15 |
| mborzecki | thanks! | 07:15 |
| mup | PR snapd#10187 closed: o/hookstate, o/snapstate: print revision, version, channel with snapctl --pending <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10187> | 07:21 |
| * pstolowski note to self, struct fields need to be exported for DeepEquals to do the right thing, otherwise the error is very confusing such as ["snap-c"]["snap-a"].firstHeld.ext: 0 != 63756237600 for time.Time fields | 07:21 | |
| pstolowski | mborzecki: thanks for the review of snapctl change | 07:27 |
| pstolowski | i've de-conflicted #10182 | 07:27 |
| mup | PR #10182: o/snapstate: autorefresh phase1 for refresh-control <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10182> | 07:27 |
| mup | Bug #10182: Can not logout of gnome when xcompmgr is running <gnome-panel (Ubuntu):Invalid by fabbione> <https://launchpad.net/bugs/10182> | 07:27 |
| zyga | o/ | 07:32 |
| mborzecki | re | 09:03 |
| mup | PR snapd#10253 closed: boot: helpers for manipulating current and good recovery systems list <Run nested> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10253> | 10:01 |
| jamesh | testing dbus stuff would be a lot easier if we had /usr/bin/gdbus in one of the bases... | 11:08 |
| jamesh | (well, it would mean not needing to upload test snaps to the store) | 11:09 |
| mvo | jamesh: how big is it? if it's small enough it might be a reasonable ask | 11:12 |
| jamesh | mvo: 51K on amd64 -- it's library dependencies (glib+friends) are already there | 11:13 |
| jamesh | mvo: I' an API that dbus-send can't handle | 11:13 |
| jamesh | I've been trying to test an API dbus-send can't handle | 11:14 |
| mvo | jamesh: 51k sounds fine to me | 11:14 |
| jamesh | okay. I might roll a PR for that then. It's part of libglib2.0-bin, which contains a few other utilities. Not sure if it is worth trying to strip them out or not | 11:18 |
| mup | PR snapd#10272 opened: o/hookstate: print pending info (ready, inhibited or none) <Needs Samuele review> <Refresh control> <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10272> | 11:32 |
| ijohnson | @jamesh fwiw I have wanted gdbus on uc before numerous times, so if it's really only 51k, +1 from me | 11:35 |
| jamesh | ijohnson: okay. I'll go ahead and make a PR to see what the actual damage is | 11:35 |
| ijohnson | Nice thanks | 11:36 |
| pedronis | mborzecki: I commented on https://github.com/snapcore/snapd/pull/10220 | 12:21 |
| mup | PR #10220: seed/seedwriter: fail early when system seed directory exists <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10220> | 12:21 |
| mborzecki | pedronis: thanks, that should be easy | 12:21 |
| pedronis | ijohnson: hi, what's the status of https://github.com/snapcore/snapd/pull/10218 ? does it need a master merge? | 12:23 |
| mup | PR #10218: o/servicestate: add RemoveSnapFromQuota <quota> <⛔ Blocked> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10218> | 12:23 |
| ijohnson | pedronis yes, if you haven't started reviewing it, I will just force push a rebate | 12:25 |
| ijohnson | *rebase | 12:26 |
| pedronis | ijohnson: I haven't | 12:26 |
| ijohnson | Okay, I will update that in a little bit | 12:26 |
| pedronis | mvo: I commented on https://github.com/snapcore/snapd/pull/10264, lots of questions | 12:48 |
| mup | PR #10264: config: add "virtual" config via config.RegisterVirtualConfig <Created by mvo5> <https://github.com/snapcore/snapd/pull/10264> | 12:48 |
| pedronis | pstolowski: I made a comment about an issue we have in https://github.com/snapcore/snapd/pull/10272 | 12:57 |
| mup | PR #10272: o/hookstate: print pending info (ready, inhibited or none) <Needs Samuele review> <Refresh control> <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10272> | 12:57 |
| ijohnson | pedronis: 10218 is ready now | 12:59 |
| pedronis | ijohnson: thx, I'll look at later today | 13:00 |
| pedronis | *at it | 13:00 |
| pstolowski | pedronis: thanks, i need to ponder, that would be a general issue we have right? | 13:13 |
| pedronis | pstolowski: yes, we need to move / or duplicate that call into the new task I think | 13:29 |
| bandali | hi pedronis, would you be able to help with a ManualReviewPending item on snapcraft.io? (for the newly submitted jami-gnome snap) | 13:32 |
| pedronis | bandali: you should post something under store-requests on the forum | 13:37 |
| bandali | ah okay will do, thanks | 13:43 |
| mup | PR core20#103 opened: hooks: add libglib2.0-bin for the "gdbus" utility <Created by jhenstridge> <https://github.com/snapcore/core20/pull/103> | 14:23 |
| pstolowski | pedronis: ok, i'd address it in a separate PR if that sounds reasonable? | 14:24 |
| pedronis | pstolowski: it's reasonable but we should probably talk about it because of the issue also what to do with the corresponding lock, I think the spec mentions that briefly | 14:30 |
| pstolowski | pedronis: yes i saw that sentence in the spec but i'd think the lock will be managed/relevant elsewhere and not in snapctl (but maybe not) | 14:34 |
| pedronis | pstolowski: well, we need to keep the lock to have consistent value for pending | 14:34 |
| pedronis | I think | 14:34 |
| pedronis | that's why this intersects | 14:34 |
| pedronis | mborzecki: detail to fix in https://github.com/snapcore/snapd/pull/10220 | 14:36 |
| mup | PR #10220: seed/seedwriter: fail early when system seed directory exists <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10220> | 14:36 |
| mup | PR snapcraft#3524 opened: ua manager: install ubuntu-advantage-tools as needed (CRAFT-67) <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3524> | 14:41 |
| mardy | mmm... can someone help me understand this error? https://github.com/snapcore/snapd/pull/10266/checks?check_run_id=2611334119 | 14:43 |
| mup | PR #10266: wrappers/services.go: do not restart disabled or inactive services <Needs Samuele review> <Created by mardy> <https://github.com/snapcore/snapd/pull/10266> | 14:43 |
| mardy | "wrappers/services_test.go:3369:14: github.com/snapcore/snapd/systemd.ServiceState composite literal uses unkeyed fields | 14:43 |
| mardy | " | 14:43 |
| mardy | (that's a struct I added) | 14:43 |
| mborzecki | pedronis: that should be addressed now | 14:44 |
| pstolowski | mardy: yeah, you need to type field names when instantiating the struct, e.g. {Foo: value1, Bar: value2} | 14:44 |
| mborzecki | mardy: a mix of fields with keys and not? | 14:44 |
| mardy | pstolowski, mborzecki: thanks, fixed! But it's weird, I don't think it was giving me this error in the previous iterations of the branch | 14:53 |
| pstolowski | mardy: hmm weird | 14:57 |
| ijohnson | mardy: are you embedding structs? sometimes you need to do that if you are embedding one struct in another and you try to initialize an instance of the outer struct using only fields from the inner struct | 15:03 |
| mup | PR snapd#10271 closed: tests: simplify the tests.cleanup tool <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10271> | 16:03 |
| pedronis | ijohnson: I commented on https://github.com/snapcore/snapd/pull/10218 | 16:08 |
| mup | PR #10218: o/servicestate: add RemoveSnapFromQuota <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10218> | 16:08 |
| ijohnson | pedronis: thanks looking now | 16:12 |
| mup | PR snapd#10273 opened: c/snap: more precise message for ErrorKindSystemRestart op != reboot <Created by pedronis> <https://github.com/snapcore/snapd/pull/10273> | 16:33 |
| mup | PR snapcraft#3519 closed: requirements: correct setup.py install_requires and add tooling to freeze reqs <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3519> | 18:06 |
| mup | PR snapcraft#3522 closed: python v2 plugin: update pip properly <Created by MrCarroll> <Closed by MrCarroll> <https://github.com/snapcore/snapcraft/pull/3522> | 18:51 |
| * cachio_ afk/me afk | 20:05 | |
| cachio_ | rotundo82 | 20:05 |
| mup | PR snapd#10274 opened: cmd/snap: include locale when linting description being lower case <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10274> | 21:09 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!