[06:01] <mardy> 'morning
[06:05] <mborzecki> morning
[06:05] <mborzecki> hm did we miss https://github.com/snapcore/snapd/commit/c2479d7bdd76aad9fcc5b5247e7fbc86cba596aa when preparing 2.50?
[06:07] <mborzecki> hmmm not, idk why `git (branch|tag) --contains` is confused then
[06:40] <mardy> mborzecki:the commit hash in the 2.50 release branch is different, maybe it was cherry-picked or rebased
[07:12] <pstolowski> morning
[07:13] <mborzecki> pstolowski: hey, got any PRs that need reviews?
[07:17] <pstolowski> mborzecki: hey, #10261 needs reviews
[07:17] <mup> PR #10261: o/snapstate: refresh control - autorefresh phase2 <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10261>
[07:17] <mup> Bug #10261: Fails to start if ipv6 disabled <postfix (Ubuntu):Fix Released by lamont> <https://launchpad.net/bugs/10261>
[07:17] <mborzecki> ack
[08:16] <mborzecki> pstolowski: can you take a look at https://github.com/snapcore/snapd/pull/10277 ? should be fairly simple
[08:16] <mup> PR #10277: overlord/devicesate: observe snap writes when creating recovery systems <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10277>
[08:16] <pstolowski> mborzecki: sure
[08:21] <mborzecki> thanks!
[09:41] <mardy> pstolowski: hi! Here's the first draft: https://github.com/snapcore/snapd/pull/10282 But I expect that it can be vastly improved :-)
[09:41] <mup> PR #10282: WIP: overlord/servicestate: omit service list if only snap given <Created by mardy> <https://github.com/snapcore/snapd/pull/10282>
[09:41] <mup> PR snapd#10282 opened: WIP: overlord/servicestate: omit service list if only snap given <Created by mardy> <https://github.com/snapcore/snapd/pull/10282>
[09:44] <pstolowski> mardy: ok, thanks!
[11:11] <Mirv> zyga_: can you just double confirm you're you also at Libera where I registered #snappy (as the only op) and gave you founder rights?
[11:33] <pedronis> pstolowski: https://github.com/snapcore/snapd/pull/10218 needs a 2nd review
[11:33] <mup> PR #10218: o/servicestate: add RemoveSnapFromQuota <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10218>
[11:34] <pstolowski> pedronis: will do
[11:37] <mup> PR snapd#10277 closed: overlord/devicesate: observe snap writes when creating recovery systems <Simple 😃> <Created by bboozzoo> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10277>
[11:40] <pedronis> pstolowski: thx
[11:47] <mup> PR snapd#8532 closed: tests: install new snapd deb into preseed image <Created by jhenstridge> <Closed by pedronis> <https://github.com/snapcore/snapd/pull/8532>
[12:17] <mup> PR snapd#10283 opened: tests: change machine type used for nested tests <Run nested> <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10283>
[12:29] <mborzecki> by the time seeded is true, there should be some sort of model set already right?
[12:42] <mardy> how do I run all snapd unit tests (for all packages)?
[12:43] <pedronis> mardy: go test ./... for example
[12:44] <pedronis> mborzecki: yes
[12:45] <mardy> pedronis: thanks!
[12:49] <mborzecki> hm our tests seem to be doing funny things then, seeded is often set to true, but there's no device model in the sate
[12:51] <pedronis> mborzecki: yes, our test cheat sometimes, I wouldn't define it funny
[12:51] <pedronis> mborzecki: what are you trying to do?
[12:52] <mup> PR snapd#10284 opened: o/snapstate: introduce minimalInstallInfo interface <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10284>
[12:53] <mborzecki> pedronis: i've tweaked the code do this: https://paste.ubuntu.com/p/mynTh9wqZr/
[12:54] <mborzecki> but the tests frequently set seeded = true, but there's no model assertion in state
[12:54] <mborzecki> maybe i should just leave explicit comments in both places instead
[12:54] <pedronis> mborzecki: yea, that change is reasonable but the tests won't be happy
[12:56] <mborzecki> mhm, i think i'll go with the comment for now
[12:56] <mborzecki> and leave a todo about tests
[13:00] <pedronis> maybe I have an idea but it's probably something to do in its own PR
[13:48] <rZr> ijohnson, thx a lot for kernel update @ https://forum.snapcraft.io/t/built-uc20-rasperry-pi-image-hangs-on-boot/23891/28?u=rzr
[13:48] <rZr> ogra, ++
[13:48] <rZr> I checked it
[13:49] <rZr> I was tracking for a tag in https://git.launchpad.net/~canonical-kernel-snaps/+git/kernel-snaps-uc20/log/?h=pi
[13:49] <rZr> but it's somewhere else right ?
[13:49] <ogra> yeah the kernel snaps are full of black magic nowadays 🙂
[13:50] <rZr> if it works :)
[14:17] <mup> PR snapd#10275 closed:  overlord/devicestate: comment why explicit system mode check is needed in ensuring tried recovery systems <Simple 😃> <Skip spread> <Squash-merge> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10275>
[14:34] <mup> PR snapcraft#3526 opened: project: validate snapcraft yaml before using it (CRAFT-55) <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3526>
[14:35] <ijohnson> rZr: great, I'm happy to hear that it finally works for you, sorry it took so long for this bugfix to make its way through the pipeline, the initrd for uc20 is one of the toughest things to get changes landed into
[14:36] <ogra> we should improve that 😉
[14:37] <ijohnson> we should but it's hard and requires improvements to the process of building the kernel snaps
[14:37] <ogra> well, afaik that is still using an awful hack i created in 2016 ...
[14:38] <ogra> so yes, that definitely needs improvement too
[14:38] <ogra> i wish kernel snaps wold just use ther snapcraft.yaml and be done ... but sadly someone introduced secureboot in UC20 as a default 😛
[14:39] <ijohnson> you really should start charging somebody royalties for all your hacks that end up staying around forever 😀
[14:39] <ogra> well, duct tape and strings hold the world together 🙂
[14:48] <mup> PR snapd#10285 opened: interfaces/serial-port: add Qualcomm serial port devices to allowed list <Created by tsunghanliu> <https://github.com/snapcore/snapd/pull/10285>
[14:54] <mup> PR snapcraft#3525 closed: dotnet plugin: use https for release metadata url <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3525>
[15:06] <ijohnson> mardy: thanks for the review, I addressed your comments in my python PR 😀
[15:47] <rZr> ijohnson, no problem I planned to rebuild everything from scratch but you saved my time
[15:51] <pstolowski> ijohnson: a few comments to #10218
[15:51] <mup> Bug #10218: after mounting second disk at /home, gnome login fails <gnome-session (Ubuntu):Invalid by seb128> <https://launchpad.net/bugs/10218>
[15:51] <mup> PR #10218: o/servicestate: add RemoveSnapFromQuota <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10218>
[16:16] <ijohnson> thanks pstolowski I'll have a look later today
[16:28] <mup> PR snapd#10278 closed: o/hookstate/ctlcmd: allow system-mode for non-root <Created by pedronis> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10278>
[17:08] <pedronis> pstolowski: some comments in https://github.com/snapcore/snapd/pull/10284, let's chat tomorrow
[17:08] <mup> PR #10284: o/snapstate: introduce minimalInstallInfo interface <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10284>
[17:10] <cachio> ijohnson, hey
[17:10] <cachio> I see this error on uc18
[17:10] <cachio> https://paste.ubuntu.com/p/r7pYnNhrhr/
[17:10] <cachio> this is on beta validation
[17:10] <cachio> it is failing on many tests what is weird
[17:10] <cachio> doesn't seem to be something random
[17:14] <cachio> it is just happening in pi3 o far
[17:38] <mup> PR snapd#10286 opened: tests: moving to tests directories snaps built locally - part 2 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10286>
[17:49] <mborzecki> pedronis: thanks for the review, i'll extend the test to simulate reboots like we do in boot
[17:53] <ogra> mv
[17:53] <ogra> bah
[18:20] <mup> PR snapcraft#3520 closed: package-repositories: remove experimental flag <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3520>
[18:25] <mup> PR snapcraft#3523 closed: autotools v2 plugin: adding cross compilation support <Created by kubiko> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3523>
[18:45] <mup> PR snapcraft#3494 closed: tests: use candidate for autopkgtests <do-not-merge> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3494>
[18:45] <mup> PR snapcraft#3513 closed: tests: stub job to get autokpgtest for edge <do-not-merge> <Created by sergiusens> <Closed by sergiusens> <https://github.com/snapcore/snapcraft/pull/3513>
[18:45] <mup> PR snapcraft#3521 closed: build providers: set hostname for lxd <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3521>
[19:50] <mup> PR snapcraft#3524 closed: ua manager: install ubuntu-advantage-tools as needed (CRAFT-67) <Created by cjp256> <Closed by cjp256> <https://github.com/snapcore/snapcraft/pull/3524>
[19:50] <mup> PR snapcraft#3527 opened: ua manager: install ubuntu-advantage-tools as needed (CRAFT-67) <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3527>
[20:27] <ijohnson> cachio: hey so for 10283, do you mean that the execution time with n2 is 80% of the execution time of n1 for the same set of tests ?
[20:27] <ijohnson> since the cost is 2% more, so it sounds like it makes sense, but I just wanted to make sure I am understanding the math correctly
[20:55] <cachio> ijohnson, I compared full executions
[20:55] <cachio> for uc16 42m -> ~30m
[20:55] <cachio> for uc18 42m -> ~35m
[20:55] <cachio> for uc20 62m -> ~56m
[20:56] <ijohnson> nice
[20:56] <cachio> this is a comparison for the full suite
[20:56] <ijohnson> ok, makes sense +1 on the PR from me
[20:57] <cachio> ijohnson, nice
[20:57] <cachio> ijohnson, could you please take quick look to #10276
[20:57] <mup> Bug #10276: gnome-common: automake-1.4 does not suppor --copy --force options <gnome-common (Ubuntu):Fix Released> <gnome-common (Debian):Fix Released> <https://launchpad.net/bugs/10276>
[20:57] <mup> PR #10276: tests: remove tests.cleanup prepare from nested test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10276>
[21:01] <ijohnson> cachio: +1 but one typo there
[21:33] <cachio> ijohnson, thanks
[21:34] <cachio> I'll fix it