| mup | PR snapd#10287 opened: tests/main/snap-quota-groups: add functional spread test for quota groups <Test Robustness> <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10287> | 01:20 |
|---|---|---|
| mup | PR snapd#10288 opened: tests/nested: add test for gadget default config values being available early <Bug> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10288> | 01:20 |
| mup | PR snapd#10289 opened: Introduce acrn interface for launching virtual machines on ACRN <Created by ttzeng> <https://github.com/snapcore/snapd/pull/10289> | 04:35 |
| mborzecki | morning | 06:06 |
| mborzecki | hmm hmm | 07:04 |
| mborzecki | trying to find a smart way of intercepting a panic from a goroutine executing the taskrunner | 07:04 |
| pstolowski | morning | 07:07 |
| mborzecki | pstolowski: hey | 07:12 |
| === pedronis_ is now known as pedronis | ||
| pedronis | pstolowski: hi, I'm working on suggestions for https://github.com/snapcore/snapd/pull/10284 | 08:11 |
| mup | PR #10284: o/snapstate: introduce minimalInstallInfo interface <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10284> | 08:11 |
| pstolowski | pedronis: ok, i've been working on them as well... although tbh i got stuck at earlyChecks for a while | 08:12 |
| pedronis | pstolowski: sorry | 08:13 |
| pstolowski | pedronis: np, i made just a few changes but i'm not too far | 08:13 |
| pstolowski | pedronis: if you have a clear idea how to refactor this then maybe it's easier than iterating over this in a review; thanks for tackling it | 08:15 |
| pedronis | pstolowski: something like this seems to work: https://paste.ubuntu.com/p/4pGXkdJTB8/ | 08:51 |
| pedronis | I don't know if it makes sense for what you need later, but it seems ok | 08:52 |
| mborzecki | pedronis: i've updated https://github.com/snapcore/snapd/pull/10254 the reboot test is kind of a hack but it works | 08:54 |
| mup | PR #10254: overlord/devicestate: tasks for creating recovery systems at runtime <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10254> | 08:54 |
| mborzecki | anyways, i should probably look into conflict checks right now | 08:56 |
| pstolowski | pedronis: looks good at a glance, not quite sure about readyUpdateInfo yet, i need to apply this on top of phase2 PR to check | 09:00 |
| pedronis | mborzecki: thx | 09:04 |
| pedronis | pstolowski: ok, let me know, there might be something cleaner that we can do but we need to see how the whole thing work. one cleaner thing could be to unify the thin wrapper struct and the params function | 09:33 |
| pedronis | this was the most mechanical refactor | 09:34 |
| pstolowski | itm | 09:35 |
| mborzecki | pstolowski: can you check something for me? | 11:21 |
| mborzecki | pstolowski: `cd overlord/devicestate && go test -check.f deviceMgrRemodelSuite.TestReregRemodelClashAnyChange` | 11:22 |
| mborzecki | does it panic? | 11:22 |
| pstolowski | one sec | 11:23 |
| pstolowski | mborzecki: yes, invalid memory address or nil pointer dereference | 11:27 |
| mborzecki | pstolowski: thanks for double checking :) | 11:28 |
| pstolowski | yw | 11:29 |
| mup | PR snapd#10290 opened: o/snapstate: add helpers for setting and querying holding time for snaps <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10290> | 11:47 |
| pstolowski | pedronis: i proposed ^, going to look at integrating your changes next | 11:48 |
| pedronis | pstolowski: thx | 11:48 |
| mup | PR snapd#10291 opened: overlord/snapstate, overlord/devicestate: exclude change conflict check <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10291> | 11:57 |
| pedronis | pstolowski: I have quite a few meetings this afternoon so I probably won't get to the new PR today | 12:03 |
| mup | PR snapd#10235 closed: asserts: fix errors reported by linter <Needs Samuele review> <Created by mardy> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10235> | 12:07 |
| pstolowski | np | 12:18 |
| pedronis | mborzecki: I re-reviewed https://github.com/snapcore/snapd/pull/10254, thanks, some errors needs tweaks | 12:34 |
| mup | PR #10254: overlord/devicestate: tasks for creating recovery systems at runtime <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10254> | 12:34 |
| mborzecki | pedronis: thank you, in the meantimve i've opened #10291 with the conflict checks, but there's no rush, i understand your review queue is already long | 12:34 |
| mup | Bug #10291: c_rehash uses /usr/local/bin/perl (Re: ca-certificates) <openssl (Ubuntu):Fix Released> <openssl (Debian):Fix Released> <https://launchpad.net/bugs/10291> | 12:34 |
| mup | PR #10291: overlord/snapstate, overlord/devicestate: exclude change conflict check <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10291> | 12:34 |
| pedronis | mborzecki: not super long but I have mostly meetings after the standup | 12:35 |
| mardy | pstolowski: and how is your review queue? :-) I radically modified https://github.com/snapcore/snapd/pull/10282 | 12:35 |
| mup | PR #10282: services: remember if actiong on the entire snap <Created by mardy> <https://github.com/snapcore/snapd/pull/10282> | 12:35 |
| pstolowski | mardy: yeah i should get to it today, thanks & sorry | 12:36 |
| pstolowski | pedronis: applied your changes on top of autorefresh phase2, all fine, thank you | 13:48 |
| pstolowski | ijohnson: i think you forgot to push the "break" change to #10218 | 14:37 |
| mup | PR #10218: o/servicestate: add RemoveSnapFromQuota <quota> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10218> | 14:37 |
| mup | Bug #10218: after mounting second disk at /home, gnome login fails <gnome-session (Ubuntu):Invalid by seb128> <https://launchpad.net/bugs/10218> | 14:37 |
| ijohnson | pstolowski: yeah sorry let me push that now | 15:05 |
| ijohnson | done | 15:07 |
| ijohnson | pstolowski: also with your other suggestion, I think you are right and it is simpler, I hadn't considered putting the ensure and patchQuota calls inside the loop | 15:14 |
| pedronis | pstolowski: thx, I'll look at everything on Tue | 15:43 |
| mup | PR snapd#10234 closed: cmd/snap-update-ns: fix linter errors <Created by mardy> <Merged by pedronis> <https://github.com/snapcore/snapd/pull/10234> | 15:43 |
| pstolowski | ijohnson: great | 15:45 |
| mvo | mardy: anything left in 10251? it seems it got a +1 from pedronis and security reviewed it too. can I merge it or is anything left there? | 15:46 |
| pedronis | mvo: it can be merged, a follow-up for raw-usb to make them more consistent would be good, but that's a follow-up | 15:48 |
| mvo | ta! | 15:53 |
| mup | PR snapd#10276 closed: tests: remove tests.cleanup prepare from nested test <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10276> | 16:43 |
| mup | PR snapd#10251 closed: interfaces/builtin: introduce raw-input interface <Needs Samuele review> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10251> | 17:33 |
| mup | PR snapd#10280 closed: packaging: merge 2.50.1 changelog back <Skip spread> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10280> | 17:33 |
| mvo | ijohnson: any concerns if I merge 10218? has two +1 and looks ince | 17:46 |
| mvo | nice | 17:46 |
| ogra | phew | 17:46 |
| * ogra is bombed by spam bots | 17:46 | |
| mvo | ogra: where? | 17:47 |
| ogra | in PMs | 17:48 |
| ogra | one every 5min or so ... | 17:49 |
| ogra | the decay of freenode 😞 | 17:49 |
| mup | PR snapd#10285 closed: interfaces/serial-port: add Qualcomm serial port devices to allowed list <Created by tsunghanliu> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10285> | 17:58 |
| mvo | ijohnson: also did you had a chance to address the feedback in 10274? | 18:05 |
| mup | PR snapd#10218 closed: o/servicestate: add RemoveSnapFromQuota <quota> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10218> | 18:08 |
| ijohnson | mvo I can quickly when I'm back from lunch | 18:09 |
| mvo | ijohnson: no rush, I will call it a day soon but wanted to get our pr count a bit down before the weekend :) | 18:13 |
| ijohnson | I'm back now, let me quickly make the change maciej requested | 18:13 |
| mvo | ijohnson: \o/ thank you | 18:17 |
| * cachio afk | 19:04 | |
| mup | PR snapd#10274 closed: cmd/snap: include locale when linting description being lower case <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10274> | 20:04 |
| mup | PR snapd#10283 closed: tests: change machine type used for nested tests <Run nested> <Simple 😃> <Created by sergiocazzolato> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10283> | 22:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!