| mborzecki | morning | 05:56 |
|---|---|---|
| mardy | mborzecki: hi! | 06:01 |
| mborzecki | mardy: heya | 06:01 |
| mborzecki | mvo: hey | 06:14 |
| mvo | good morning mborzecki ! | 06:17 |
| zyga-mbp | good morning :) | 06:53 |
| mvo | good morning zyga-mbp | 06:54 |
| zyga-mbp | mvo how are you doing? :) | 06:54 |
| mborzecki | mvo: can you land https://github.com/snapcore/snapd/pull/10162 ? | 06:59 |
| zyga-mbp | mborzecki oh I wish this was a part of spreadw | 07:01 |
| zyga-mbp | but I don't think yaml.v3 does ordering | 07:01 |
| mvo | mborzecki: sure | 07:02 |
| mborzecki | mvo: thank you | 07:04 |
| mborzecki | mvo: now that we have 2.51 we should be able to land https://github.com/snapcore/snapd/pull/9897 ? | 07:08 |
| mborzecki | mvo: and this one too: https://github.com/snapcore/snapd/pull/10139 | 07:08 |
| mvo | mborzecki: \o/ | 07:10 |
| mvo | mborzecki: will do | 07:10 |
| pstolowski | morning | 07:12 |
| zyga-mbp | hey pstolowski | 07:15 |
| mvo | good morning pstolowski | 07:21 |
| jamesh | mvo: I noticed you retargetted https://github.com/snapcore/snapd/pull/10046 right after reviewing it. Do we not want to enable dbus-activation for 2.51 now? | 07:30 |
| jamesh | ah. 2.51 is already tagged | 07:33 |
| mvo | jamesh: I tagged it to ensure it is part of the release, it has two +1 so I think we can land it or does it need samueles input at this point? | 07:34 |
| jamesh | mvo: I think it had the 2.51 tag before, but maybe I was imagining that. | 07:36 |
| mvo | jamesh: I don't see it being tagged for 2.51 in the history but maybe I'm not fully awake :) | 07:36 |
| mvo | jamesh: do you think it needs samueles input or can I merge it? | 07:36 |
| jamesh | mvo: probably my mistake then. I remember talking about wanting to delay it until after 2.50+patch releases, but maybe we never added a milestone. | 07:37 |
| jamesh | mvo: from my last chat with pedronis, he was happy to see it land. | 07:37 |
| mvo | jamesh: excellent, landed 10046 | 07:38 |
| jamesh | yay! | 07:39 |
| mvo | thank you jamesh ! | 07:39 |
| jamesh | mvo: it's a long time coming. The first bit of code for this feature comes from a PR you filed in January 2017: https://github.com/snapcore/snapd/pull/2592 | 07:41 |
| mvo | jamesh: \o/ woah, already this long? crazy! good that it landed, thanks so much for pushing it through | 07:43 |
| pedronis | jamesh: hi, I merged desktop-launch, so now we can do follow up for the small details and also what we discussed about not changing libraries | 07:50 |
| jamesh | pedronis: just saw the email. Thanks! | 07:50 |
| mborzecki | uhh influx of spam in the forum | 07:52 |
| pedronis | pstolowski: hi, should I put https://github.com/snapcore/snapd/pull/10290 back into my review queue? | 07:53 |
| pstolowski | pedronis: hi, maybe not yet, i'll try to address the problem with not respecting firstHeld (= allowing to abuse postponement time) mentioned in the standup | 07:54 |
| pedronis | mborzecki: hi, we should merge master again into https://github.com/snapcore/snapd/pull/9647 and remove blocked, right? as we are not testing fedora32 anymore | 07:54 |
| pedronis | pstolowski: ok | 07:54 |
| pstolowski | pedronis: pedronis but phase2 is ready for re-review | 07:54 |
| pedronis | pstolowski: it's in my queue, I will get to it today | 07:55 |
| mborzecki | pedronis: yeah, i can do it it jamesh doesn't mind | 07:55 |
| jamesh | mborzecki: I don't mind. | 07:56 |
| pstolowski | i'll also address various naming/comments suggestions from mardy (thanks!) | 07:56 |
| pedronis | mborzecki: should I merge https://github.com/snapcore/snapd/pull/10307 ? | 07:56 |
| pedronis | mardy: hi, is https://github.com/snapcore/snapd/pull/10282 ready for re-reviews? | 07:58 |
| mardy | pedronis: yes, I might add some spread test, but what is in there can already be reviewed | 08:15 |
| amurray | mborzecki: do we have a process of how we normally deal with spammers? I notice I can opt to delete the posts individually OR keep them hidden OR suspend the user OR silence the user OR delete the user and all their posts - but am not sure what the usual next step would be (i'm erring on the latter to just kill it all but don't want to deviate too far from the normal) | 08:15 |
| pedronis | mardy: thx, I'm putting it into my queue | 08:16 |
| pedronis | mvo: pstolowski: jamesh: mborzecki: I started with the PR to change how we do responses in daemon: https://github.com/snapcore/snapd/pull/10325 | 08:17 |
| * jamesh looks | 08:18 | |
| pedronis | *PRs | 08:19 |
| mborzecki | amurray: i don't think so, i usually just hide their posts, but i don't remove the accounts in case it was hijacked or sth (unless that's blatantly obvious that it's a spammer's account) | 08:20 |
| pstolowski | pedronis: nice, thanks, will look at it | 08:20 |
| ogra | jamesh, hrm ... with your mdns commit you add an "avahi-daemon" fake package with a version: 1000 ... that ends up breaking any parsing of the dpkg.list file that the core snaps include (i.e. checking for source packages the core snap was built from) | 08:54 |
| jamesh | ogra: the intent was to be able to install the NSS module without avahi-daemon (plus deps) without leaving apt in a broken state. If you've got a better idea for how to achieve that, I'd be happy to change it. | 08:57 |
| ogra | jamesh, i totalyl get the intent from looking at the code ... but i think we need to filter out the line from dpkg.list somehow | 08:57 |
| pedronis | mborzecki: mvo: we broke master apparently with the ~/snap perm PR, because of the new check about order | 09:03 |
| pedronis | of stanzas in spread test | 09:04 |
| mvo | pedronis: uh, ok | 09:04 |
| mvo | sorry for that | 09:04 |
| mborzecki | jamesh: had to twaek the unit tests a bit in your PR, looks like we landed things in master that assumed /snap/bin always | 09:08 |
| mborzecki | i'm seriously thinking we should run unit tests at least on one system that doesn't use /snap | 09:09 |
| mborzecki | tbh i can open a separate PR with a fix for the tests | 09:10 |
| pedronis | one needs python3-yamlordereddictloader for run-checks --static but except the workflows is not mentioned anywhere :/ | 09:12 |
| mborzecki | and https://github.com/snapcore/snapd/pull/9647 should be updated now | 09:14 |
| mborzecki | pedronis: yeah, that's a change from cachio with a checker for task.yaml format | 09:14 |
| mborzecki | pedronis: do you have a log of the spread test maybe? | 09:18 |
| pedronis | mborzecki: I made a fix, hopefully, https://github.com/snapcore/snapd/pull/10327 | 09:18 |
| mborzecki | hm conflict checks actually broke something | 09:27 |
| mborzecki | wonder if it's conflicting with device initialization maybe | 09:28 |
| pedronis | mborzecki: where? the PR has 3 failing spread tests | 09:29 |
| pedronis | ah, but they are real, I see | 09:30 |
| mborzecki | pedronis: https://github.com/snapcore/snapd/pull/10291/checks?check_run_id=2708413514 | 09:30 |
| mborzecki | yeah, there's a change to obtain that initializes a device and gets a serial, i wonder if that may be conflicting | 09:30 |
| pedronis | mborzecki: maybe you should add more to the errors, the kind of change we are conflicting with | 09:31 |
| mardy | who wants to review a simple one? https://github.com/snapcore/snapd/pull/10328 | 09:39 |
| mborzecki | is copying & pasting code from diff on github broken for anyone too? | 09:43 |
| mborzecki | looks like ff copied the actual html tags | 09:43 |
| mborzecki | mardy: added some comments | 09:45 |
| mborzecki | pedronis: looks like it's conflicting with become-operational after all, the change is failing and gets readded | 09:50 |
| pedronis | mborzecki: we should chat about this because there is probably something to change in those tests | 09:59 |
| mborzecki | pedronis: the test is using fakestore, maybe it's missing some api bits, otoh should one be allowed to remode if device has no serial? | 10:00 |
| pedronis | mborzecki: exactly, that's the question | 10:00 |
| pedronis | mborzecki: can we chat before the standup? | 10:42 |
| mborzecki | pedronis: sure, let ma add something | 10:42 |
| pedronis | thx | 10:42 |
| mborzecki | pedronis: do you prefer right before the standup or somethign earlier? | 10:42 |
| pedronis | mborzecki: I have lunch now, so not ealier than 13:45 | 10:43 |
| mborzecki | pedronis: ok, i've added soemthing at 1430 | 10:43 |
| mborzecki | i'm trying to figure out what exactly is missing here: https://paste.ubuntu.com/p/5n4Jt9hWDy/ | 10:44 |
| mborzecki | assertions seem to be in place | 10:44 |
| mborzecki | mvo: pedronis: i think it's ok to land https://github.com/snapcore/snapd/pull/10327 | 10:50 |
| mborzecki | will also unblock other prs | 10:50 |
| mvo | mborzecki: sure, on it | 10:52 |
| mborzecki | thanks! | 10:54 |
| mborzecki | mardy: there's a failure in the ci https://github.com/snapcore/snapd/pull/10328/checks?check_run_id=2710182455 | 11:21 |
| mvo | ijohnson: hey, good morning. just a quick heads up, I pushed some compat tweaks to 10287 (the quota functional test) including adding a memorylimit compat setting for older systemd | 11:24 |
| ogra | jamesh, FYI https://github.com/snapcore/core20/issues/104 | 11:25 |
| ijohnson | Hey mvo, thanks for that it was on my to-do list but I got held up being confused by systemd reporting that a non existent service was using 16 exbibytes of RAM | 11:25 |
| mvo | ijohnson: yeah, saw that on your notes and no worries, happy to help | 11:26 |
| mvo | ijohnson: feels good to write a few lines of code :) | 11:26 |
| ijohnson | :-D | 11:26 |
| mborzecki | mardy: hmm github picked up your other email address? https://github.com/snapcore/snapd/runs/2710223222?check_suite_focus=true | 11:30 |
| pstolowski | pedronis: https://github.com/snapcore/snapd/pull/10290 is ready for re-review | 11:36 |
| pedronis | pstolowski: thx, it's on my queue | 11:39 |
| mardy | mborzecki: ouch, I'll amend the commits | 11:45 |
| mborzecki | funny how fedpkg new-sources always fails with 'empty reply from the server' the first time i run it | 11:51 |
| pedronis | mborzecki: did you see my question before, should I land 10307 ? | 12:06 |
| mborzecki | pedronis: yes, please land it | 12:07 |
| mborzecki | pstolowski: can you take a look at https://github.com/snapcore/snapd/pull/10326 ? | 12:16 |
| pstolowski | yep | 12:16 |
| mborzecki | thanks | 12:21 |
| mborzecki | 69 prs | 12:21 |
| === pfsmorigo_ is now known as pfsmorigo | ||
| mardy | need some help with go: suddenly I'm getting errors like: netutil/activation.go:29:2: cannot find package "github.com/coreos/go-systemd/activation" in any of: | 13:37 |
| mardy | /home/mardy/go/src/github.com/snapcore/snapd/vendor/github.com/coreos/go-systemd/activation (vendor tree) | 13:37 |
| mardy | /usr/lib/go-1.13/src/github.com/coreos/go-systemd/activation (from $GOROOT) | 13:37 |
| mardy | /home/mardy/go/src/github.com/coreos/go-systemd/activation (from $GOPATH) | 13:37 |
| ijohnson | mardy, you may need to run `./get-deps.sh` to update the dependencies again | 13:41 |
| mardy | ijohnson: oh, that helped, thanks :-) | 13:42 |
| ijohnson | np | 13:42 |
| mborzecki | pedronis: jamesh: afaict the godbus package in sid is missing compatibility bits for GOPATH | 13:47 |
| jamesh | mborzecki: I never got any response to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=974892 | 13:48 |
| mborzecki | fedora has a compat package that provides a symlink | 13:48 |
| mborzecki | jamesh: hm, looks like we need to hld the update for now, we'll get around to fixing the modules support sometime | 13:49 |
| mborzecki | hopefully before go 1.17 | 13:49 |
| jamesh | mborzecki: is Debian still insisting on packaged depenencies for apps using Go modules? | 13:50 |
| jamesh | i.e. is this a problem that will solve itself once we transition off of the classic Go build process? | 13:51 |
| mborzecki | jamesh: someone closer to downstream will probably know, mwhudson maybe | 13:52 |
| === leosilva is now known as leosilva1 | ||
| === leosilva1 is now known as leosilva2 | ||
| === leosilva2 is now known as leosilva_ | ||
| === leosilva_ is now known as leosilva__ | ||
| === leosilva__ is now known as leosilva3 | ||
| === leosilva3 is now known as leosilva4 | ||
| === leosilva4 is now known as leosilva5 | ||
| === leosilva5 is now known as leosilva6 | ||
| === leosilva6 is now known as leosilva666 | ||
| === leosilva666 is now known as leosilva7 | ||
| === leosilva7 is now known as leosilva8 | ||
| === leosilva8 is now known as leosilva9 | ||
| === leosilva9 is now known as leosilva | ||
| pedronis | mardy_2nd: I commented on https://github.com/snapcore/snapd/pull/10282 | 15:20 |
| pstolowski | ijohnson: maybe mvo could merge https://github.com/snapcore/snapd/pull/10316 so you could rebase the followup? | 15:23 |
| ijohnson | pstolowski: I think we need to sort out what to do for other distros like amazon-linux and centos first, hopefully by my EOD I have it all sorted out | 15:24 |
| pstolowski | ijohnson: ah, i forgot, right | 15:25 |
| mvo | ijohnson: please check 10287 too so that we don't duplicate efforts | 15:25 |
| ijohnson | mvo: I saw you pushed something there just a few minutes ago, do you have more work on top of that that hasn't been pushed ? | 15:26 |
| mvo | ijohnson: just this, *hopefully* this fixes the failures, at least my local qemu spread is happy now | 15:26 |
| ijohnson | mvo: ack I will keep an eye on it then and integrate those changes into 10316 too | 15:27 |
| mvo | +1 | 15:27 |
| ijohnson | thanks mvo | 15:28 |
| * cachio afk | 16:10 | |
| pedronis | pstolowski: I re-reviewed https://github.com/snapcore/snapd/pull/10290, thanks for the changes | 16:12 |
| pstolowski | pedronis: ty! | 16:15 |
| ijohnson | cachio: some shellcheck errors in #9615 | 16:55 |
| cachio | ijohnson, hi, I'll update they today | 16:56 |
| ijohnson | thanks | 16:57 |
| cachio | thanks to you | 16:57 |
| pedronis | ijohnson: I did a pass on https://github.com/snapcore/snapd/pull/10323 | 17:00 |
| ijohnson | thanks, I will respond to a couple questions and then break for lunch | 17:01 |
| === alan_g_ is now known as alan_g | ||
| * ijohnson lunches | 17:08 | |
| === ijohnson is now known as ijohnson|lunch | ||
| === ijohnson|lunch is now known as ijohnson | ||
| * cachio afk | 20:44 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!