| pstolowski | morning | 07:08 |
|---|---|---|
| mardy | pstolowski: hi! | 07:22 |
| === rzr is now known as RzR | ||
| zyga-mbp | good morning | 08:01 |
| pstolowski | hey zyga-mbp | 08:01 |
| pedronis | pstolowski: hi, should I re-review https://github.com/snapcore/snapd/pull/10290 ? | 08:11 |
| pstolowski | pedronis: hi, yes please, thank you! | 08:12 |
| pedronis | pstolowski: he needs a master merge again, https://github.com/snapcore/snapd/pull/10290, the diff is strange/large again | 12:02 |
| mardy | pstolowski: go formatting is a bit weird, now after adding the comment it looks like you need to reindent the field type | 12:15 |
| pstolowski | pedronis: sorry, done now | 12:28 |
| pstolowski | mardy: yeah, that happens... done | 12:32 |
| pedronis | pstolowski: https://github.com/snapcore/snapd/pull/10282 needs a 2nd review, so that mardy can then get back to the original PR I suppose | 13:31 |
| pstolowski | pedronis: sure, will do | 13:32 |
| pedronis | thx | 13:32 |
| * cachio afk | 14:32 | |
| pedronis | pstolowski: I reviewed 10290 | 14:35 |
| pstolowski | pedronis: thanks! | 14:36 |
| pstolowski | pedronis: re your comment, are you suggesting to change the function to 'func maxAllowedPostponement(gatingSnap, affectedSnap string, buffer time.Duration) time.Duration {' ? | 15:00 |
| pedronis | or maxPostment time.Duration | 15:01 |
| pedronis | maxPostponement | 15:01 |
| pstolowski | pedronis: ah | 15:01 |
| ijohnson | pedronis: mvo: so I'm pretty much blocked on quota stuff now waiting for reviews (I opened a few more PR's just this morning) and I think the path forward now should be much less fraught with peril than previously - should I start looking at cloud-init stuff with that LP bug that TPE filed ? | 15:19 |
| ijohnson | I can also do reviews, not sure if there is anything in particular that I should focus on for reviews | 15:20 |
| pedronis | ijohnson: Pawel's https://github.com/snapcore/snapd/pull/10290 need reviews, but starting on cloud-init next step seems also good | 15:25 |
| ijohnson | pedronis: ok sure I will give that a review in my afternoon then | 15:25 |
| pstolowski | thanks ijohnson | 15:47 |
| pstolowski | ijohnson: btw there is a spec associated with https://github.com/snapcore/snapd/pull/10290, let me know if you would like to take a look at it to make things more clear | 16:09 |
| ijohnson | pstolowski: oh hey yes please I would love to take a look at the spec :-) | 16:09 |
| ijohnson | thanks | 16:09 |
| ijohnson | is there a reason the spec wasn't mentioned in the PR description ? | 16:10 |
| pstolowski | ijohnson: yes. i really don't trust google ;) | 16:10 |
| ijohnson | haha okay then | 16:11 |
| ijohnson | thanks for sharing it | 16:11 |
| pstolowski | yw | 16:13 |
| mvo | ijohnson: sorry, had a crazy day today, will try to do a bit of reviewing after dinner and in my morning | 16:47 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!