[07:08] <pstolowski> morning
[07:22] <mardy> pstolowski: hi!
=== rzr is now known as RzR
[08:01] <zyga-mbp> good morning 
[08:01] <pstolowski> hey zyga-mbp 
[08:11] <pedronis> pstolowski: hi, should I re-review https://github.com/snapcore/snapd/pull/10290 ?
[08:12] <pstolowski> pedronis: hi, yes please, thank you!
[12:02] <pedronis> pstolowski: he needs a master merge again, https://github.com/snapcore/snapd/pull/10290, the diff is strange/large again
[12:15] <mardy> pstolowski: go formatting is a bit weird, now after adding the comment it looks like you need to reindent the field type
[12:28] <pstolowski> pedronis: sorry, done now
[12:32] <pstolowski> mardy: yeah, that happens... done
[13:31] <pedronis> pstolowski: https://github.com/snapcore/snapd/pull/10282 needs a 2nd review, so that mardy can then get back to the original PR I suppose
[13:32] <pstolowski> pedronis: sure, will do
[13:32] <pedronis> thx
[14:32]  * cachio afk
[14:35] <pedronis> pstolowski: I reviewed 10290
[14:36] <pstolowski> pedronis: thanks!
[15:00] <pstolowski> pedronis: re your comment, are you suggesting to change the function to 'func maxAllowedPostponement(gatingSnap, affectedSnap string, buffer time.Duration) time.Duration {' ?
[15:01] <pedronis> or maxPostment time.Duration
[15:01] <pedronis> maxPostponement
[15:01] <pstolowski> pedronis: ah
[15:19] <ijohnson> pedronis: mvo: so I'm pretty much blocked on quota stuff now waiting for reviews (I opened a few more PR's just this morning) and I think the path forward now should be much less fraught with peril than previously - should I start looking at cloud-init stuff with that LP bug that TPE filed ?
[15:20] <ijohnson> I can also do reviews, not sure if there is anything in particular that I should focus on for reviews
[15:25] <pedronis> ijohnson: Pawel's https://github.com/snapcore/snapd/pull/10290 need reviews, but starting on cloud-init next step seems also good
[15:25] <ijohnson> pedronis: ok sure I will give that a review in my afternoon then
[15:47] <pstolowski> thanks ijohnson 
[16:09] <pstolowski> ijohnson: btw there is a spec associated with https://github.com/snapcore/snapd/pull/10290, let me know if you would like to take a look at it to make things more clear
[16:09] <ijohnson> pstolowski: oh hey yes please I would love to take a look at the spec :-)
[16:09] <ijohnson> thanks
[16:10] <ijohnson> is there a reason the spec wasn't mentioned in the PR description ?
[16:10] <pstolowski> ijohnson: yes. i really don't trust google ;)
[16:11] <ijohnson> haha okay then
[16:11] <ijohnson> thanks for sharing it
[16:13] <pstolowski> yw
[16:47] <mvo> ijohnson: sorry, had a crazy day today, will try to do a bit of reviewing after dinner and in my morning