[05:17] <mborzecki> morning
[05:35] <mardy> hi!
[05:45] <mborzecki> mardy: heya
[07:09] <pstolowski> morning
[07:15] <zyga> good morning
[07:19] <mvo> good morning pstolowski and zyga 
[07:19] <zyga> mvo, I've sent some fixes for spread
[07:19] <zyga> mvo, mainly go vet stuff for now
[07:19] <mvo> zyga: yeah, just vaw it
[07:19] <mvo> saw
[07:20] <zyga> mvo, https://github.com/snapcore/spread/pull/117 is a real tiny bug
[07:20] <zyga> mvo, some more in humbox
[07:20] <zyga> mvo, all of this is from go vet reporting things
[07:21] <mvo> zyga: looking
[07:21] <zyga> mvo, I've also started looking at what it takes to fix https://github.com/snapcore/spread/issues/119
[07:22] <zyga> mvo, I'll try to enable travis-ci.com on my fork first
[07:22] <mvo> zyga: we have https://github.com/snapcore/spread/pull/107 that would also work, yes?
[07:23] <mvo> zyga: or is there a reason to stay with travis?
[07:23] <zyga> ah, I missed that, yes
[07:24] <zyga> mvo, older but relevant fix is also here https://github.com/snapcore/spread/pull/111
[07:24] <mvo> zyga: looking
[07:25] <mborzecki> mvo: zyga: pstolowski: morning guys
[07:25] <zyga> mborzecki, hey :)
[07:26]  * zyga is still sick, so so-so morning ;)
[07:27] <mvo> mborzecki: good morning
[07:27] <mvo> zyga: uh, get well!
[07:27] <mardy> mvo: I added a new section with some ideas in the mount-control document, it would be nice if you had a look
[07:28] <mardy> oh, and hi mvo, zyga, pstolowski :-)
[07:29] <zyga> hey mardy 
[07:34] <mvo> good morning mardy ! let me check
[07:35] <mvo> zyga: I think I will mark a bunch of yours as "ready" and see if I can have another review meeting with gustavo
[07:35] <mvo> mardy: this is the "Suggestion for generating mount units" section ?
[07:38] <mardy> mvo: yes
[07:40] <zyga> mvo, thank you!
[07:46] <mardy> mvo: BTW, I think that the failures in https://github.com/snapcore/snapd/pull/10375 are not due to my changes (maybe you can double-check), so please consider whether you should use your magic powers on it
[07:47] <mvo> mardy: sure, looking
[07:48] <mardy> mvo: but if you merge, please squash :-)
[07:49] <mvo> mardy: the 14.04 test failure is real, there is no systemd-run on 14.04 so the fake store setup will not work, I think it's okay to exclude 14.04
[07:50] <mvo> mardy: i.e. just something like "systems: [-ubuntu-14.04-*]
[07:50] <mvo> mardy: but let me look at the others too
[07:51] <mvo> mardy: I can also do this if you want
[07:54] <mvo> mardy: the debian-10 failure also looks real, I don't remember the detail here though, i.e. where/why we check for the right libseccomp
[07:55] <mvo> mardy: and on all of the cores I think theere is a failure in "userdel -f snap_microk8s" - I think "userdel --extrausers -f snap_microk8s" is needed here
[07:56] <mardy> mvo: let me have a look
[08:06] <mborzecki> mvo: can you take a look at https://github.com/snapcore/snapd/pull/10481 ?
[08:15] <mvo> mborzecki: added it to my list :)
[08:15] <mvo> mborzecki: not sure if I manage before lunch though :/
[08:19] <mborzecki> mvo: sure
[08:19] <mborzecki> thanks!
[09:41] <mborzecki> mvo: pstolowski: also a very simple PR https://github.com/snapcore/snapd/pull/10489
[09:43] <pstolowski> sure
[10:21] <mardy_2nd> sorry if I missed this, but are the spread failures on tests/main/refresh-delta known issues?
[10:32] <mvo> mardy: I don't think they are
[10:32] <mvo> mardy: but the 14.04 test is still unhappy :)
[10:35] <mvo> mardy: it looks like deltas were pruned this morning by the store
[10:35] <mvo> mardy: let's see if they come back
[10:41] <mvo> mardy: maybe you can push the fix for ubuntu-14.04 (just exclude it)
[10:41] <mvo> mardy: and then we will see if the store auto-regenerates the relevant deltas
[10:47] <mvo> mardy: just talked to the store and the failure to get the deltas is being investigated (and it seems also understood)
[12:28] <mborzecki> mardy: i think you reviewed the other s-c PR, can you take a look at https://github.com/snapcore/snapd/pull/10492 ?
[12:57] <mardy> mborzecki: will continue right after the standup
[13:54] <mborzecki> deltas aren't available? i see a bunch of refresh-delta tests failing across all systems
[13:57] <mvo> mborzecki: they should be back
[14:24] <pedronis> ijohnson[m]: I reviewed https://github.com/snapcore/snapd/pull/10488 it needs some more work I think
[15:02] <mborzecki> pedronis: pushed a tweak to https://github.com/snapcore/snapd/pull/10469
[15:02] <mborzecki> and thanks for the review!
[15:07] <pedronis> mborzecki: are there real failures in https://github.com/snapcore/snapd/pull/10481 ?
[15:09] <mborzecki> pedronis: you mean the cloud config tests? they all seem to fail on acking the snap declarations signed by developer 1
[15:11] <pedronis> mborzecki: are you saying they fail on master too?
[15:12] <mborzecki> hm let's see if i can find a branch that fails that way too
[15:13] <mborzecki> if not i'll investigate, but it's unclear how snap ack can be influenced by those changes in boot
[15:22] <mardy> how do the files /var/lib/snapd/apparmor/profiles/snap-update-ns.* contribute to the apparmor profile? In other words, when are these rules loaded?
[15:26] <pstolowski> mardy: snap-confine runs snap-update-ns before running snap app, see also the description at the top of every snap-update-ns.* profile (Description: Allows snap-update-ns ....)
[15:29] <pstolowski> mardy: also look at the comments about snap-update-ns in snap-confine.c 
[15:29] <mardy> pstolowski: mmm... so, this is the profile under which snap-update-ns will be run for the specific snap, and has little (if not nothing) to do with the profile of the snap itself?
[15:39] <pstolowski> mardy: yes i think so, its only use is to set up mount namespaces, maybe mborzecki can confirm
[16:03] <mvo> zyga: can you please review spread#116? would love to mark it "ready" for gustavo but for that it needs at least one +1
[16:06] <zyga> mvo, looking
[16:06] <zyga> mvo, and *thank you* for asking :)
[16:14] <zyga> done
[16:15] <zyga> mvo, thank you for pushing tests on some of the refactors and fixes
[16:16] <zyga> mvo, I have some tests lined up but mainly for the all-new exporter logic
[16:16] <zyga> mvo, make sure to review https://github.com/snapcore/spread/pulls as it's one of the more serious problems reported by vet 
[16:28]  * cachio lunch
[17:13] <pstolowski> cachio: i've addressed your comments https://github.com/snapcore/snapd/pull/10476, please take another look
[17:15] <cachio> pstolowski, sure
[17:15] <cachio> thanks
[17:19] <cachio> pstolowski, hey
[17:19] <cachio> why are you locating tests/lib/snaps/store/test-snapd-refresh-control-provider.v1/build-aux/snap/snapcraft.yaml there?
[17:19] <cachio> and not in the base directory of the snap?
[17:21] <pstolowski> cachio: i think build-aux is a newer approach
[17:21] <pstolowski> cachio: not strictly necessary
[17:21] <cachio> I use to locate it in tests/lib/snaps/store/test-snapd-refresh-control-provider.v1/snapcraft.yaml
[17:22] <cachio> if it works it is ok
[17:22] <pstolowski> yes it works
[17:22] <pstolowski> cachio: see https://snapcraft.io/docs/release-notes-snapcraft-3-3
[17:22] <pstolowski> i've re-built all 4 snaps with snapcraft and re-uploaded them to the store
[17:23] <cachio> nice, so you can choose among the baswe dir and build-aux
[17:23] <cachio> makes sense
[17:24] <pstolowski> cachio: it's useful to keep main directory cleaner, of course not a problem here
[17:24] <cachio> pstolowski, right
[17:26] <cachio> pstolowski, just remember to ask store team to move the snaps to test-snaps-canonical user
[17:26] <pstolowski> cachio: ah, can they do this?
[17:26] <cachio> yes
[17:26] <pstolowski> nice
[17:26] <cachio> all the test snaps need to be reasigned
[17:27] <cachio> you will remain as a collaborator of the snap
[17:30] <pstolowski> cachio: cool. i'll talk to them tomorrow
[17:30] <pstolowski> thanks
[17:31] <cachio> pstolowski, also you need to set them as unlisted
[17:39] <pstolowski> cachio: can i do this myself?
[17:41] <cachio> in the store page, you go to edit -> settingd
[17:41] <cachio> settings
[17:41] <cachio> there you can set it as unlister
[17:41] <cachio> but I see there are tons of snaps not properly configured
[17:41] <pstolowski> cachio: ah, nice, thanks
[17:43] <pstolowski> ok, done
[17:43] <pstolowski> and eod, cu
[17:49] <cachio> ijohnson[m], hey, when you have a bit of time, could you please check https://github.com/snapcore/snapd/pull/10409
[17:49] <cachio> I need to validate the idea because I changed a lot the PR
[17:52] <ijohnson[m]> cachio sure I've got it on my queue now
[17:55] <cachio> tx
[18:57] <mborzecki> ah pedronis is gone already
[18:58] <mborzecki> ijohnson: fyi: https://paste.ubuntu.com/p/Dcfqhy2vwK/ something is broken in nested tests on master
[18:58] <ijohnson[m]> bboozzoo: hmm
[18:58] <ijohnson[m]> I'll take a look, thanks for the pointer
[19:03] <mborzecki> ijohnson: if you don't find anything obvious, i'll try to poke at it tomorrow morning
[19:03] <ijohnson[m]> bboozzoo: ack, I seem to recall seeing some changes to the fakestore stuff recently, perhaps we broke it without running the nested tests
[19:03] <mborzecki> ijohnson: possible, we don't run them too often, not sure if they even get run when merging to master
[19:04] <mborzecki> anyways, i'm off 😉 shouldn't even be at the keyboard right now
[19:04] <ijohnson[m]> 🙂 ttyl
[19:29] <cachio> mborzecki, hey
[19:29] <cachio> https://paste.ubuntu.com/p/9phCDkgqMM/
[19:29] <cachio> it is related to refresh-delta test which fails currently
[19:30] <cachio> it says not updates available but the snap is refreshed
[19:30] <cachio> is anyone takins a look to that one currently?
[19:31] <cachio> ijohnson[m], ~
[19:32] <ijohnson[m]> cachio: that's from the refresh-delta test ?
[19:32] <cachio> from refresh-delta-from-core
[19:33] <cachio> both are failing
[19:33] <cachio> same error I think
[19:34] <cachio> ijohnson[m], i have an instance open now
[19:36] <ijohnson[m]> cachio: what is the full failure output  from spread ? 
[19:37] <cachio> ijohnson[m], https://paste.ubuntu.com/p/KVHFY74dTT/
[19:39] <ijohnson[m]> cachio: is the `journalctl: unrecognized option '--sync'` error relevant at all ? or is that harmless
[19:40] <cachio> it is harmless
[19:40] <cachio> ijohnson[m], it should be
[19:42] <cachio> it is weird because the log says it cannot refresh the snap
[19:42] <ijohnson[m]> hmm
[19:43] <cachio> ijohnson[m], https://paste.ubuntu.com/p/wpqgRCN2ZM/
[19:44] <cachio> this is the part of the journal log which is doing the refresh
[19:44] <ijohnson[m]> cachio: can you run on this instance `journalctl --no-pager -u snapd` ? the output you pasted is cut off
[19:45] <cachio> ijohnson[m], https://paste.ubuntu.com/p/9gJ5PwHN9G/
[19:49] <ijohnson[m]> cachio: yeah the store is still not returning deltas correctly, can you ping someone in the store channel about this?
[19:49] <ijohnson[m]> mvo pinged them this morning and they said it was fixed, but it seems it is still not fixed
[19:49] <cachio> sure
[19:49] <cachio> ijohnson[m], thanks
[19:51] <ijohnson[m]> np