| mborzecki | morning | 03:58 |
|---|---|---|
| mborzecki | hmmm `Skipping non-snapd systemd unit snap.lxd.workaround.service` in postrm-purge breaks the test, however where does the unit come from? | 04:31 |
| mborzecki | pstolowski: hey | 06:06 |
| pstolowski | hey mborzecki | 06:06 |
| mborzecki | pstolowski: tests are failing 😕 there's a weird thing in postrm-purge and user session socket is flaky but sergio opened https://github.com/snapcore/snapd/pull/10556 for this | 06:07 |
| pstolowski | mborzecki: oh.. the revert of services change landed, related? | 06:10 |
| mborzecki | pstolowski: would that create snap.lxd.workaround.service file? | 06:10 |
| pstolowski | mborzecki: no | 06:12 |
| pstolowski | mborzecki: google:ubuntu-20.04-64:tests/main/snap-services passed for me | 06:29 |
| pstolowski | or do i need to run both in sequence? | 06:29 |
| mborzecki | pstolowski: nah, i don' think there's anything related to snap services | 06:29 |
| mvo | pstolowski: looks like there is one comment for 10551, are you on it or should I add the todo? I'm keen to land this so that I can branch 2.52 :) | 08:22 |
| pstolowski | mvo: the TODO from Samuele? i'll add in a sec | 08:23 |
| pstolowski | mvo: updated | 08:28 |
| mvo | pstolowski: ta! | 08:37 |
| mborzecki | meh, i can't get batch delete from bpf map to work, funny that deleting elements one by one works though | 09:46 |
| ijohnson[m] | morning folks | 11:30 |
| pstolowski | morning ijohnson[m] | 11:30 |
| ijohnson[m] | hey pstolowski | 11:31 |
| mborzecki | ijohnson: hey | 11:31 |
| ijohnson[m] | I am hopeful with slightly less meetings today I can get my review finished for the auto-refresh gating hook thing | 11:31 |
| ijohnson[m] | hey bboozzoo | 11:31 |
| ijohnson[m] | how has this week been for y'all | 11:31 |
| mborzecki | ijohnson: rather silent, some tests are failing again, the postrm-purge is in particular interesting, as there's a transient systemd unit for which it isn't clear where it comes from | 11:37 |
| ijohnson[m] | bboozzoo: is it one our transiennt units we create to run snap apps/hooks ? | 11:38 |
| ijohnson[m] | I saw an update yesterday to this bug where it was fixed by a systemd patch someone has | 11:38 |
| mborzecki | ijohnson: it's called snap.lxd.workaround.service and it executes /bin/true ;) | 11:38 |
| mborzecki | ijohnson: https://paste.ubuntu.com/p/z32jQzcDn6/ | 11:38 |
| ijohnson[m] | this one | 11:39 |
| ijohnson[m] | https://bugs.launchpad.net/snapd/+bug/1928806 | 11:39 |
| ijohnson[m] | bboozzoo: ah yeah that does look just like the sort of transient scope that is left around in the bug ^ | 11:39 |
| mborzecki | ijohnson: but those are clearly scopes, probably from runs of kubectl | 11:41 |
| ijohnson[m] | I assume lxd runs this somehow as well | 11:41 |
| mborzecki | this one looks like it was added on purpose, with Deletegate=yes and RemainAfterExit | 11:41 |
| ijohnson[m] | oh I missed the `RemainAfterExit=yes` | 11:42 |
| ijohnson[m] | hmm | 11:42 |
| pstolowski | i'm slightly worried by snap-services test failures, a bit odd it started around landing the changes around this area, but then it doesn't fail everywhere | 11:43 |
| ijohnson[m] | pstolowski: do you have logs for an example failure ? | 11:44 |
| pstolowski | ijohnson[m]: yes, e.g. https://github.com/snapcore/snapd/pull/10551/checks?check_run_id=3142648936 (it was failing on master already, so it's not specific to this PR) | 11:45 |
| mborzecki | hm i think i know the culprit now | 11:45 |
| pstolowski | ijohnson[m]: there is a PR from cachio for this: https://github.com/snapcore/snapd/pull/10556 | 11:45 |
| ijohnson[m] | ah right that issue | 11:46 |
| ijohnson[m] | yeah I think that's been around for a few weeks | 11:46 |
| pstolowski | ah ok, i didn't see it.. good (sort of) | 11:47 |
| mborzecki | ok, i've updaed my standup notes and i'm wrapping it up for the week, got some driving to do | 11:55 |
| ijohnson[m] | bboozzoo: have a nice weekend, you're back on Tuesday ? | 11:55 |
| mborzecki | ijohnson: thanks, yes back on tue | 11:56 |
| ijohnson[m] | nice, see you then | 11:56 |
| pstolowski | mborzecki: have fun! | 11:57 |
| === dob1_ is now known as dob1 | ||
| * cachio_ afk | 17:51 | |
| === zyga__ is now known as zyg | ||
| === zyg is now known as zyga | ||
| === clobrano1 is now known as clobrano | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!