=== benj_9 is now known as benj_
=== cyberpear_ is now known as cyberpear
[02:26] <blackboxsw> akutz: falcojr landed https://github.com/canonical/cloud-init/pull/953 I'll talk to falcojr to see if we can't attempt to produce a release for testing in Impish (Ubuntu 21.10) images. Initial feature freeze for Ubuntu Impish actually comes up in a week I think.
[02:26] <ubottu> Pull 953 in canonical/cloud-init "Datasource for VMware" [Merged]
=== paride6 is now known as paride
=== arif-ali_ is now known as arif-ali
[14:15] <akutz> blackboxsw falcojr: Thank you both! If we can get this in 21.10, that would be amazing! Do you think it will at least be part of the next CI release?
[14:17] <falcojr> we need to figure out the netifaces dependency thing first, but yes...it should go into the next release and be backported to supported releases back to 18.04
[14:17] <falcojr> *supported Ubuntu releases
[15:19] <akutz> falcojr Ack. Please see https://github.com/canonical/cloud-init/pull/965
[15:19] <ubottu> Pull 965 in canonical/cloud-init "Change netifaces dependency to 0.10.4" [Open]
[15:19] <akutz> falcojr I'd rather stay on netifaces 0.10.9, but on the chance we need to flip to 0.10.4, here's a PR to do that with testing to verify it satisfies the most common use case.
[15:35] <akutz> is anyone else unable to push to their own GH remotes?
[15:36] <akutz> Yup, GH is experiencing issues https://www.githubstatus.com
[15:39] <akutz> falcojr GH's issues are preventing me from updating the above PR. I added a test to verify two network interfaces work as well.
[15:40] <falcojr> yeah, I'm having github issues too
[15:43] <falcojr> akutz: "but on the chance we need to flip to 0.10.4, here's a PR to do that". It sounds like you don't want to have to use this PR. Do we have a better alternative? 
[15:44] <akutz> I mean, I'd almost always rather use the latest version. On the offchance we need to stick to 0.10.4 for CVE issues as noted in the DS PR comments, I wanted to have some level of confidence of what moving to 0.10.4 would mean.
[15:46] <akutz> falcojr: In other words, I wanted to have options. Now, true, it probably does not help my case to go with 0.10.9, but at the same time, if someone asked me could I say that 0.10.4 *wouldn't* work, then no, I would not have been able to truthfully state that. Based on the changelog there are possible issues people will encounter in the edgier edge cases, but still, having DS VMware in >=18.04 with netifaces 0.10.4 is better than not having the DS at
[15:46] <akutz>  all :)
[15:49] <falcojr> it's less about CVE issues specifically and more just what packages are supported where
[15:50] <akutz> Fair. In which case I would think pip would be a sensible approach?
[15:52] <falcojr> if we're talking about Ubuntu specifically, no, we use the dependencies packaged in the release
[15:52] <falcojr> so in focal and above, we'll get 0.10.9, and on below we'll get 0.10.4
[15:52] <akutz> Ack. Which brings us back to the PR.
[15:53] <akutz> I was confused when you asked me if I had an alternative. I do not. I just meant "if we need to flip to 0.10.4" in so far as to get VMware into older Ubuntu distros at all. 
[15:53] <akutz> Anyway, once GH is back from the brink the PR will be updated.
[15:53] <falcojr> yeah, I can't even see the PR currently
[16:00] <akutz> Ugh
[16:00] <akutz> The diff is just the version change in requirements.txt. Here's the patch notes https://gist.github.com/akutz/c1ae7a64ee1bf7503e723e7332063d20
[16:51] <akutz> falcojr: Looks like the PR is now updated correctly
[19:29] <falcojr> akutz: "GH's issues are preventing me from updating the above PR. I added a test to verify two network interfaces work as well." As part of this PR? I still just see the version diff in requirements.txt
[19:29] <akutz> The tests are in the patch notes
[19:29] <akutz> Sorry I wasn't clear
[19:30] <falcojr> ahh, gotcha. Thanks
[19:30] <akutz> I just wanted to validate for my own sanity that both of the common use cases were covered with 0.10.4.
[19:32] <falcojr> are you wanting that entire test procedure to be part of the commit message?
[19:34] <akutz> I tend to draft thorough patch notes. If you want, I can move that out of the patch notes and into the PR's testing section.
[19:40] <akutz> falcojr: Updated the PR with the updated patch notes with the testing notes moved to the PR description's testing section.
[20:10] <akutz> Thanks falcojr!
[20:10] <falcojr> just merged :)
[20:15] <akutz> So I thought you already *had* merged it because I cannot read. I saw the notification via e-mail about something merging and main. Then when I went to tell my team that the PR wasn't actually merged, you merged it :)
[20:15] <falcojr> we're a mess of confusion here :D
[20:21] <akutz> Nah, y'all have been immensely helpful. I just have issues reading e-mail apparently.
[20:26] <akutz> falcojr: So, now I want more of course :) I think blackboxsw mentioned Ubuntu code freeze might be coming up? Do you or he foresee any challenge to making this DS part of Cloud-Init 21.3 and including it in the next Ubuntu release or older releases >=18.04? I'm not asking for a firm commitment, just whether you see any immutable blockers. Thanks!
[20:37] <falcojr> we should be good now. Everything is there to make it into the upstream release and we'll do an upload into impish before the code freeze. That reminds me that we need a small packaging change for this. That's something me and blackboxsw will handle though
[20:58] <akutz> Nice, thank you!!!