/srv/irclogs.ubuntu.com/2021/08/13/#snappy.txt

zygagood morning07:12
mardyzyga: hi! Long time no see :-)07:22
zygahey mardy :)07:22
zygaI'm back in my office _finally_07:23
zygaafter nearly two weeks of summer holidays and travel and working from weird places07:23
mardyuh, summer holidays, that must have been horrible! ;-)07:26
zygamardy, yes when it's not for you but for your family ;)07:28
zygaand you work from the back seat07:28
mardyhehe :-)07:41
zygamardy, over the years I've been following my family, working, wherever they go 07:42
mardynext year hopefully you'll have accumulated some holidays of your own07:47
mardycan someone please confirm, that calling i18n.G() from inside snapd does not make much sense (and we should use it on the clients only)? Or does i18n.G() have some way to know the locale of the client, and does the right thing even when run from inside snapd?08:20
zygamardy, I think it still makes sense, it's likely that the system wide locale is consistent and the messages are useful in general08:34
zygaI recognize the general issue though08:34
mardyzyga: I see, that's also true. But you do agree that the solution suggested here is better? https://github.com/snapcore/snapd/pull/10606#discussion_r68785729808:50
mupPR #10606: o/hookstate/ctlcmd: unify the error message when context is missing <Simple 😃> <Created by mardy> <https://github.com/snapcore/snapd/pull/10606>08:50
mardybut it's far from being trivial to implement08:52
zyga_mardy, yes this is true10:13
zyga_mardy, it's the good old API problem10:13
zyga_and "error codes"10:14
=== zyga_ is now known as zyga
mupPR snapd#10613 opened: interfaces/builtin/firewall_control: allow ufw accesses <Created by mardy> <https://github.com/snapcore/snapd/pull/10613>11:33
mupPR core18#180 opened: Generate dpkg.yaml <Created by ilasc> <https://github.com/snapcore/core18/pull/180>13:08
mupPR snapd#10614 opened: tests: new function to detect installed packages <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10614>13:28
mardyis snapd or snapcraft treating iptables in some special way? I'm trying to modify this snap to use ufw instead, but it's never found: https://github.com/snapcore/snapd/blob/master/tests/main/interfaces-firewall-control/firewall-control-consumer/meta/snap.yaml14:37
mardyin the host system it's in /usr/sbin/ufw (iptables is in the same dir)14:37
ijohnson[m]mardy: what do you mean ? like ufw is not found inside the snap?14:37
mardyfrom inside the snap, "which iptables" gives /sbin/iptables14:37
mardyijohnson[m]: exactly, iptables is found, ufw is not14:37
ijohnson[m]mardy: hmm is ufw in the base snap? 14:38
mardyijohnson[m]: ah, it's not in ls /snap/core/current/sbin/ at least (whereas iptables is there)14:39
mardyijohnson[m]: ah, is this the issue we were discussing with the microk8s guys, when you said that they need to ship the binary themselves?14:40
ijohnson[m]mardy: which base snap are you using ?14:43
ijohnson[m]though interestingly core20 only has `/snap/core20/current/etc/ufw` in it, no actual ufw binary14:43
ijohnson[m]I seem to recall jdstrand saying something about ufw in core20 / focal ... I don't remember what though :-)14:43
ijohnson[m]mardy: anyways in the sort term the right thing is probably the same as what we discussed yes, just ship ufw in your snap instead of trying to consume from the base snap14:44
mardyijohnson[m]: I can I check? I'm acually playing in the spread image google:ubuntu-20.04-6414:44
jdstrandI needed to make changes to ufw so the snap could be made to work with core2014:44
ijohnson[m]mardy: what's the snap.yaml14:44
ijohnson[m]oh hi jdstrand !14:44
jdstrand/etc/ufw in the core20 snap would be a mistake in the core20 snap14:44
jdstrandhi!14:44
mardyhi :-)14:45
mardyijohnson[m]: the snap.yaml is https://github.com/snapcore/snapd/blob/master/tests/main/interfaces-firewall-control/firewall-control-consumer/meta/snap.yaml14:45
jdstrandfyi, I gave a detailed response just now: https://github.com/snapcore/snapd/pull/10613#pullrequestreview-72968908814:45
mupPR #10613: interfaces/builtin/firewall_control: allow ufw accesses <Created by mardy> <https://github.com/snapcore/snapd/pull/10613>14:45
ijohnson[m]jdstrand: so what changes to ufw need to be made to work in a core20 based snap?14:45
ijohnson[m]thanks jdstrand  for that!14:46
ijohnson[m]mardy: so since that snap.yaml does not have a `base` it is implicity using `core` as it's base, i.e. 16.0414:47
mardyjdstrand: just read your response; thanks a lot! It's indeed way more trivial than I though. But it seems you are also implying that the whole firewall-control interface we have now is not such a good idea, as it's very iptables specific (and should be called iptables-control, probably)14:50
mardys/trivial/conplex/ :-D14:50
jdstrandijohnson[m]: I made those changes already to the ufw snap and it is all upstream in master and the edge snap. *but* see my comment. note, I'm heading into a meeting and can't discuss this, but I hope I laid out enough info for you14:50
mardy"complex", oh, what's wrong with me :-)14:50
jdstrandmardy: it is, though nftables should be supported imo14:51
ijohnson[m]jdstrand: that all makes sense, thanks for sharing!14:52
jdstrandmardy: an argument could be made to allow cli utilities that use ipc. firewalld might fit into that. note, firewall-control is ancient and one of the first so we didn't yet have our experience with interfaces14:52
ijohnson[m]mardy: maybe you could relay this over to the k8s folks to see what they think? honestly I don't know in what way microk8s is driving firewall things14:52
jdstrandmardy: the thing is, none of these firewall programs are ubiquitous, except iptables (and nftables, sorta, but you gotta be careful which to choose (see ufw and lxd for how they decide)14:53
jdstrandwhich suggests to me that separate, specific -control interfaces are likely appropriate14:54
jdstrandmardy: though, even though firewall-control is ancient, we did think through it14:54
jdstrandmardy: network-control is to network-manager as firewall-control would be to {ufw,firewalld,shorewall,etc}-control14:55
jdstrandok, gotta run! :)14:55
jdstrandfwiw, I suggest 'a' or if that proves difficult, 'b'14:56
jdstrandI haven't tried 'a', it might be a little finicky14:57
jdstrands/finicky/fiddly/14:57
mupPR snapd#10615 opened: Revert "cgroup-support: allow to hide cgroupv2 warning via ENV" <Created by slyon> <https://github.com/snapcore/snapd/pull/10615>14:59
mupPR snapd#10612 closed: tests: fix core-early-config test to use tests.nested tool <Run nested> <Created by sergiocazzolato> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10612>15:49
ijohnson[m]is the forum down for anybody else? forum.snapcraft.io is not responding to pings for me16:57
* cachio afk17:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!