[06:08] <mborzecki> morning
[06:50] <mvo> good morning mborzecki and welcome back :)
[06:51] <mborzecki> bit quiet today
[07:01] <pstolowski> morning
[07:04] <mborzecki> pstolowski: hey
[07:22] <mardy> mborzecki, pstolowski, mvo: hi :-)
[07:53] <mvo> good morning pstolowski - welcome back
[07:53] <mvo> and good moring mardy 
[07:54] <pstolowski> :)
[08:00] <mborzecki> mvo: hey
[08:05] <mborzecki> mvo: when do you think we'll do 2.52? i need to add the zsh completion file to the fedora package (apparently it wasn't included), but i'm ok to postpone that for a bit if .52 is happening soon
[08:07] <mvo> mborzecki: once we get 2.51.5 out which is hopefully in a week 
[08:08] <mborzecki> mvo: cool, i'll wait with updating the package then
[08:11] <mvo> mborzecki: ta
[09:33] <mborzecki> mvo: if we do 51.5 would it be ok to include https://github.com/snapcore/snapd/pull/10567 ?
[09:33] <mup> PR #10567: snap/squashfs: handle squashfs-tools 4.5+ <⚠ Critical> <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10567>
[09:35] <mborzecki> mvo: and should i prepare a PR with that for .52 or will you be merging master to the release branch?
[09:55] <mvo> mborzecki: +1
[09:55] <mvo> mborzecki: I can cherry pick this into both .51 and .52
[09:55] <mborzecki> mvo: that'd be great, thanks!
[09:55] <mvo> mborzecki: please add the 2.51 milestong
[09:56] <mborzecki> mvo: added
[10:24] <mborzecki> mvo: fixes for coverity: https://github.com/snapcore/snapd/pull/10616
[10:24] <mup> PR #10616: cmd/libsnap-confine-private: fix coverity issues in tests, tweak uses of g_assert() <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10616>
[10:24] <mup> PR snapd#10616 opened: cmd/libsnap-confine-private: fix coverity issues in tests, tweak uses of g_assert() <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10616>
[10:39] <mup> PR snapd#10617 opened: cmd/snap: add Size column to refresh --list <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10617>
[10:45]  * pstolowski lunch
[10:49] <mup> PR snapd#10618 opened: clang-format: stop breaking my includes <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10618>
[11:34] <mup> PR snapd#10515 closed: o/snapstate: allow auto-refresh limited to snaps affected by a specific gating snap <Complex> <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10515>
[11:38] <mvo> pstolowski: AIUI 10563 is also ready to merge, yes? once tests are run of course?
[11:39] <pstolowski> \o/
[11:39] <pstolowski> mvo: yes
[11:49] <mup> PR snapd#10618 closed: clang-format: stop breaking my includes <Simple 😃> <Skip spread> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10618>
[11:59] <mup> PR snapd#10563 closed: o/assertstate: implement ValidationSetAssertionForEnforce helper <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10563>
[12:00] <pstolowski> mvo: thank you!
[12:01] <mvo> pstolowski: thank you for updating them, iirc some of them had conflicts etc
[12:03] <pstolowski> yes
[12:03] <pstolowski> confclits are the worst after 2 weeks of brain reset ;)
[12:19] <mardy> Please help me understand if this is a snapd or snapcraft limitation: https://github.com/snapcore/snapd/pull/10613#issuecomment-898696832
[12:19] <mup> PR #10613: interfaces/builtin/firewall_control: allow ufw accesses <⛔ Blocked> <Needs security review> <Created by mardy> <https://github.com/snapcore/snapd/pull/10613>
[12:19] <mardy> when adding a layout entry for /run/ufw.lock, snapcract complains:
[12:19] <mardy> error: cannot pack "/root/prime": cannot validate snap "microk8s": layout "/run/ufw.lock" defines a new top-level directory "/run"
[12:20] <mardy> is it because /run is a special case and layouts for it are not intended to be created?
[12:39] <mup> PR core20#108 opened: Generate dpkg.yaml file <Created by ilasc> <https://github.com/snapcore/core20/pull/108>
[12:41] <ack> hi, snapcraft question, does defining "environment" entries globally also apply them to hooks, or just to all apps?
[12:41] <ack> (wondering if I can drop some uses of "passthrough" to pass environment to hooks)
[12:49] <ijohnson[m]> @ack, you can use environment directly with hooks, but snapcraft in stable doesn't understand that, so instead use passthrough for hooks
[12:50] <ack> ijohnson[m], yes, that's what I'm using right now, was just wondering if using a top-level "environment" declaration would work for both apps and hooks (as I have the same env for both cases)
[12:51] <ijohnson[m]> @ack ah I dunno about a global one, I'd have to look at the snap.yaml schema 
[12:51] <ijohnson[m]> I can look after my meeting
[12:52] <ack> ijohnson[m], thanks. I just found out about it by looking at the snapcraft json schema
[12:52] <ack> didn't know about the global one
[12:56] <ijohnson[m]> ack: ah yes so environment is something that is understood globally for snap.yaml too, so that should work to define it at a top level too
[12:56] <ack> ijohnson[m], for hooks as well, right?
[12:58] <ijohnson[m]> ack: yes it should IIUC
[12:58] <ack> ijohnson[m], great, thanks for checking
[12:59] <ijohnson[m]> mardy: re: /run for layout, that is to prevent trespassing with the host namespace / policy because we don't want folks to be able to layout something on top of /run/snapd.sock, etc. 
[13:04] <jdstrand> amurray: hi! fyi, someone may want to look at the updated coverity report for snap-confine
[15:21] <mvo> jdstrand: a whole bunch is fixed by https://github.com/snapcore/snapd/pull/10616 already but afaik some is still pending
[15:21] <mup> PR #10616: cmd/libsnap-confine-private: fix coverity issues in tests, tweak uses of g_assert() <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10616>
[16:00] <mup> PR snapd#10619 opened: secboot: use half the mem for KDF in AddRecoveryKey <Created by mvo5> <https://github.com/snapcore/snapd/pull/10619>
[16:21] <ijohnson[m]> mvo: FYI I need to cherry-pick https://github.com/snapcore/snapd/pull/10497 too for 2.51.5 because of the store.sh changes, but that PR is simple and cherry-picks cleanly
[16:21] <mup> PR #10497: tests: ack assertions by default, add --noack option <Run nested> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10497>
[17:10] <ijohnson[m]> mvo: ugh actually I need to modify the test too, `tests.nested exec` is not yet a thing in 2.51 :-(
[17:10] <mup> PR snapd#10608 closed:  o/devicestate/handlers_install.go: add workaround to create dirs for install <⚠ Critical> <Squash-merge> <UC20> <Run nested> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10608>
[20:06] <mup> PR snapd#10620 opened: release: 2.51.5 <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10620>
[23:41] <amurray> jdstrand: yup most of the issues were in the tests so I thought they were not so relevant but I am glad to see mborzecki has already submitted a fix