[02:47] <mup> PR snapd#10620 closed: release: 2.51.5 <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10620>
[03:32] <mup> PR snapd#10621 opened: packaging: changelog for 2.51.5 to master <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10621>
=== bigpod9 is now known as bigpod
[05:50] <mborzecki> morning
[06:03] <pstolowski> morning
[06:07] <mardy> 'morning all!
[06:24] <mborzecki> pstolowski: mardy: heya
[06:32] <mvo> good morning mborzecki, pstolowski and mardy 
[06:33] <mup> PR snapd#10622 opened: many: merge release/2.51 change to release/2.52 <Created by mvo5> <https://github.com/snapcore/snapd/pull/10622>
[06:33] <mvo> mborzecki: I guess 10577 is ready to merge, yes?
[06:33] <mborzecki> mvo: i'm looking at one more tweak, i'll let you know when it's ready
[06:35] <mvo> mborzecki: but 10616 is ready?
[06:36] <mborzecki> mvo: yup
[06:37] <mborzecki> mvo: thanks for landing it!
[06:38] <mup> PR snapd#10616 closed: cmd/libsnap-confine-private: fix coverity issues in tests, tweak uses of g_assert() <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10616>
[06:51] <mborzecki> mvo: on second thought, I think that https://github.com/snapcore/snapd/pull/10577 is a go too. there's one issue that amurray raised which I think is ok, but there will be more things to consider when I open a PR with device cgroup v2 so maybe at that time the usage scenario will be clearer
[06:51] <mup> PR #10577: cmd/snap-device-helper: reimplement snap-device-helper <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10577>
[06:58] <mup> PR snapd#10623 opened: usersession/agent: refactor common JSON validation into own function <Created by mardy> <https://github.com/snapcore/snapd/pull/10623>
[07:06] <mup> PR core#121 opened: Generate the dpkg.yaml file <Created by ilasc> <https://github.com/snapcore/core/pull/121>
[07:29] <mardy> mmm... could this error (https://paste.ubuntu.com/p/t4PjhyFz5D/) be due to my changes (https://github.com/snapcore/snapd/pull/10623)? I can't seem to reproduce it locally
[07:29] <mup> PR #10623: usersession/agent: refactor common JSON validation into own function <Created by mardy> <https://github.com/snapcore/snapd/pull/10623>
[07:32] <mborzecki> anyone has a raspberry pi up and running?
[07:38] <mvo> mborzecki: o/
[07:40] <mborzecki> mvo: can you do `find /sys/devices/platform -ls` for me?
[07:40] <mborzecki> mvo: i think we have a bug in apparmor rules in the raw-usb interface 
[07:42] <mvo> mborzecki: https://paste.ubuntu.com/p/YPQcg5qrVh/
[07:42] <mvo> mborzecki: 3k lines
[07:43] <mborzecki> mvo: this is pi 3?
[07:43] <mup> PR snapd#10624 opened: interfaces/builtin/raw_usb: fix platform typo, fix access to usb devices accessible through platform <Simple 😃> <Needs security review> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10624>
[07:43] <mvo> mborzecki: yes
[07:43] <mborzecki> mvo: you don't have a pi4 that's up and runnig by any chance too?
[07:43] <mvo> mborzecki: unfortuantely no, I guess I should order one but never got around
[07:44] <mborzecki> mvo: i've pushed a fix in #10624
[07:44] <mup> Bug #10624: grub: new changes from Debian require merging <grub (Ubuntu):Fix Released by cjwatson> <https://launchpad.net/bugs/10624>
[07:44] <mup> PR #10624: interfaces/builtin/raw_usb: fix platform typo, fix access to usb devices accessible through platform <Simple 😃> <Needs security review> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10624>
[07:44] <mvo> mborzecki: ta!
[07:55] <mborzecki> added a security review label, although it's quite simple so not sure we need to involve the security team
[08:33] <mup> PR snapd#10625 opened: cmd/snap: print logs in local timezone <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10625>
[08:47] <mborzecki> mvo: we can land https://github.com/snapcore/snapd/pull/10577
[08:47] <mup> PR #10577: cmd/snap-device-helper: reimplement snap-device-helper <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10577>
[09:12] <mardy> we have some XDG portals stuff in cmd/snap/cmd_run.go and usersession/xdgopenproxy/portal_launcher.go; I'm planning to add more, so maybe we should move all of these into a new module (desktop/portals/). Any objections or better suggestions?
[09:13] <mup> PR snapd#10626 opened: Refresh control/pending from snap <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10626>
[09:23] <mborzecki> mardy: usersession/desktop maybe?
[09:24] <mborzecki> ah w8, we already have desktop package, so yeah desktop/portals sounds ok to me
[09:27] <zyga-mbp> good morning
[09:27] <zyga-mbp> back from all that travel (for now at least)
[09:27] <zyga-mbp> how have you been guys?
[09:28] <mup> PR snapd#10627 opened: o/snapstate: remove commented out code <Simple 😃> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10627>
[09:29] <zyga-mbp> pstolowski approved
[09:29] <zyga-mbp> the little I can do :)
[09:33] <pstolowski> zyga-mbp: hey zyga! thanks :)
[09:33] <zyga-mbp> pleasure :)
[09:40] <mvo> mborzecki: looking - in a meeting but will land 
[09:40] <mvo> mborzecki: done, thank you
[09:42] <mborzecki> mvo: thanks!
[09:43] <mup> PR snapd#10577 closed: cmd/snap-device-helper: reimplement snap-device-helper <cgroupv2> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10577>
[09:50] <zyga-mbp> hey mvo 
[09:53] <mvo> hey zyga-mbp ! nice to see you
[10:03] <mup> PR snapd#10627 closed: o/snapstate: remove commented out code <Simple 😃> <Skip spread> <Created by stolowski> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10627>
[10:09] <pstolowski> miguelpires: hey, nice job with these little bug fixies! 
[10:20] <miguelpires> Thank you! =)
[10:25] <pstolowski> miguelpires: btw, please update the bug to 'in progress' when the PR is up (and link to the PR from the bug report), then to commited and eventually released (when we release new snapd version that includes it); i tend to forget these things from time to time myself ;)
[10:28] <mup> PR snapd#10624 closed: interfaces/builtin/raw_usb: fix platform typo, fix access to usb devices accessible through platform <Simple 😃> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10624>
[10:40] <miguelpires> pstolowski will do, thanks for the heads up! =)
[11:03] <mup> PR snapd#10628 opened: usersession/xdgopenproxy: move PortalLauncher class to own package <Created by mardy> <https://github.com/snapcore/snapd/pull/10628>
[11:04] <mardy> mborzecki: I created https://github.com/snapcore/snapd/pull/10628 where I'm moving only one part (usersession/xdgopenproxy/portal_launcher.go); I think I'll move the parts in cmd/snap/cmd_run.go in another PR, to make reviewing easier
[11:04] <mup> PR #10628: usersession/xdgopenproxy: move PortalLauncher class to own package <Created by mardy> <https://github.com/snapcore/snapd/pull/10628>
[12:05] <ijohnson[m]> mvo: morning, do you think we need security review for https://github.com/snapcore/snapd/pull/10589 ?
[12:05] <mup> PR #10589: cgroup-support: allow to hide cgroupv2 warning via ENV <Simple 😃> <Needs security review> <cgroupv2> <Created by slyon> <https://github.com/snapcore/snapd/pull/10589>
[12:06] <zyga> hey ijohnson[m] :)
[12:06] <zyga> long time no see
[12:06] <zyga> back from holidays
[12:06] <ijohnson[m]> hi zyga 
[12:06] <ijohnson[m]> enjoy your holiday break? was it really hot wherever you were in Europe (I assume?)
[12:07] <zyga> I did!
[12:07] <zyga> weather was mixed
[12:07] <zyga> it was 14C in the morning today
[12:07] <zyga> we had hot days but nothing crazy up here
[12:08] <zyga> 27C was really hot a few days ago
[12:08] <ijohnson[m]> good, I read that it has been really hot in most parts of Europe lately but that is a pretty geographically broad statement :-)
[12:08] <zyga> it's 18C now, I think the heat moved further south now
[12:08] <ijohnson[m]> I was on vacation in Seattle when there was a "heat dome" there and it was super hot like 35-40 C pretty much the entire time I was there
[12:09] <zyga> I read the news, it's a bit scary how quickly it showed up and how long that stayed
[12:09] <ijohnson[m]> ironically, Seattle is famous for rain and cool temps, and there wasn't a single drop of rain the entire week I was there and it was so hot. Still was a great trip though, got to go to a bunch of national parks and do hiking
[12:10] <zyga> that's lovely
[12:10] <zyga> we stayed north-west for some time, countryside, goats, slow life
[12:10] <ijohnson[m]> It is a really beautiful place if you like mountains and the ocean :-D
[12:11] <zyga> Pawel went south to the mountains
[12:11] <zyga> and I went north to the sea :)
[12:11] <ijohnson[m]> nice
[12:19] <mup> PR snapd#10607 closed: o/snapstate: install snap after prereq snaps are done installing <Needs Samuele review> <Created by MiguelPires> <Closed by MiguelPires> <https://github.com/snapcore/snapd/pull/10607>
[12:35] <mvo> ijohnson[m]: probably not IMO
[12:35] <ijohnson[m]> mvo: ack should we land it then? it would help the folks transition systemd for impish apparently
[12:46] <mborzecki> cachio: hi, around?
[12:46] <cachio> hi
[12:46] <cachio> mborzecki, yes
[12:46] <mborzecki> cachio: we'll need a special 21.10 image, with cgroup v2 enabled
[12:46] <cachio> ok
[12:47] <cachio> mborzecki, the idea is to test that image regularly?
[12:47] <cachio> or you need that just to try it
[12:47] <mborzecki> cachio: this is exactly like the current 21.10 image we have, but inside /etc/default/grub we'll need to have `GRUB_CMDLINE_LINUX="systemd.unified_cgroup_hierarchy=1"`, once that's added you can run grub-mkconfig -o /boot/grub/grub.cfg and after a reboot that systemd... bit should be present in the kernel command line
[12:48] <mborzecki> cachio: that's something we need for testing with device cgroup v2 before it becomes part of the daily impish images
[12:48] <zyga> mborzecki is there a copr for latest snapd in fedora?
[12:48] <zyga> or something I can get from bodhi?
[12:48] <zyga> happy to provide feedback from my system
[12:48] <mborzecki> cachio: i took the current daily impish image, did that modification and the system booted fine, hopefully it'll be the same case for the images that we have in the CI
[12:49] <cachio> mborzecki, for 21.10 we use the images published by ubuntu-cloud
[12:49] <cachio> I don't update that image
[12:50] <cachio> If I enable cgroups 2 I'll need to update that image everyday
[12:50] <cachio> I can do that
[12:50] <mborzecki> zyga: hm? you can just grab the repo, run `cd packages && ./pack-source 2.51.5`, copy the artifacts to ~/rpmbuild/SOURCES and run rpmbuild manually
[12:50] <cachio> I can create a cron job to update the image daily
[12:50] <mborzecki> cachio: that's fine, we can update it occasionally
[12:50] <zyga> mborzecki mmm, perhaps that's the way
[12:50]  * zyga is just pretty lazy lately but that's no excuse
[12:52] <mborzecki> zyga: anything in particular you need from the latest version that's not in 2.51?
[12:52] <zyga> I want to check if anything change in lxd support
[12:52] <zyga> one sec
[12:53] <zyga> right, I'm on 2.51-1 now
[12:53] <mborzecki> (2.52 hasn't been released yet and afair all changes in point releasese were for core)
[12:53] <zyga> I'm mainly after v2 support
[12:56] <cachio> mborzecki, when you have time, could you please take a look to #10443 which I updated
[12:56] <mup> Bug #10443: X pointer persistent in middle of screen on login <xfree86 (Ubuntu):Invalid by daniels> <https://launchpad.net/bugs/10443>
[12:56] <mup> PR #10443: tests: check files and dirs are cleaned for each test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10443>
[12:57] <mborzecki> cachio: sure will do
[12:57] <cachio> tx
[13:27] <mborzecki> cachio: /proc/cmdline shoudl contain that systemd. bit that you add to the config
[13:54] <jawn-smith> Can I get a bump on PR #10592 when someone has a chance? If it needs anything else I'm happy to update it.
[13:54] <mup> Bug #10592: EOG is freezed on slow resizing <eog (Ubuntu):Invalid by seb128> <https://launchpad.net/bugs/10592>
[13:54] <mup> PR #10592: gadget: Export mkfs functions for use in ubuntu-image <Created by GlenPickle> <https://github.com/snapcore/snapd/pull/10592>
[14:01] <mborzecki> damn, that wtf moment and weak symbols, a binary built on xenial behaves differntly than one built on focal
[14:10] <zyga> mborzecki !
[14:13] <mborzecki> zyga: if you're interested https://github.com/snapcore/snapd/pull/10540#issuecomment-900277133 and the next comment
[14:13] <mup> PR #10540: cmd/snap-confine: handle CURRENT_TAGS on systems that support it <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10540>
[14:17] <pedronis> miguelpires: I re-reviewed https://github.com/snapcore/snapd/pull/10584, lgtm but it needs a master merge and then a fix. Maybe it's a good idea if pstolowski looks at it as well after, as it has bits that he worked on/will use
[14:17] <mup> PR #10584: o/assertstate: fix missing 'scheduled' header when auto refreshing assertions <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10584>
[14:21] <miguelpires> pedronis: ok, I'll fix that and then ping pstolowski for a review. Thanks
[14:22] <pstolowski> sure
[14:23] <ijohnson[m]> pedronis: do you have strong opinions on moving the Mkfs functions from gadget/internal to gadget so they are usable from outside of snapd? it's for the ubuntu-image rewrite, see https://github.com/snapcore/snapd/pull/10592
[14:23] <mup> PR #10592: gadget: Export mkfs functions for use in ubuntu-image <Created by GlenPickle> <https://github.com/snapcore/snapd/pull/10592>
[14:25] <pedronis> ijohnson[m]: except for using gadget/quantity which really needs to move, it seems they don't use gadget bits? so they could move even somewhere more generic?
[14:27] <ijohnson[m]> pedronis: yes
[14:27] <ijohnson[m]> pedronis: I suppose it could become something in osutil/mkfs/foo.go ?
[14:27] <pedronis> yes
[14:28] <ijohnson[m]> but then the names become duplicative like mkfs.MkfsFat32()
[14:28] <ijohnson[m]> but I suppose that's okay
[14:28] <pedronis> it's ok, the other option is mkfs.MakeFat32
[14:28] <ijohnson[m]> ack, I will ask them to move the functions and rename them in that PR then
[14:39] <mup> PR snapd#10529 closed: devicestate: add `snap debug timings --ensure=install-system` <Run nested> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10529>
[14:39] <mup> PR snapd#10629 opened: build-aux: build with go-1.13 in the snapcraft build too <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10629>
[14:44] <mup> PR snapd#10630 opened: o/snapstate: update default provider if missing required content <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10630>
[15:14] <ijohnson[m]> mvo: one issue with https://github.com/snapcore/snapd/pull/10622
[15:14] <mup> PR #10622: many: merge release/2.51 change to release/2.52 <Created by mvo5> <https://github.com/snapcore/snapd/pull/10622>
[15:15] <mvo> ijohnson[m]: thanks, I have a look (in a meeting right now)
[15:15] <ijohnson[m]> no worries should be simple
[15:15] <mardy> what can I have forgotten to do, if `go test` does not find my tests? (it prints: "ok   github.com/snapcore/snapd/desktop/portal 0.003s [no tests to run]")
[15:16] <ijohnson[m]> mardy: did you register the suite with `var _ = Suite(&fooSuite{})` ? 
[15:17] <ijohnson[m]> mardy: also this bit:
[15:17] <ijohnson[m]> / Hook up check.v1 into the "go test" runner
[15:17] <ijohnson[m]> func Test(t *testing.T) { TestingT(t) }
[15:19] <mardy> ijohnson[m]: oh, I was missing the second one
[15:22] <mardy> thanks, that indeed helped
[15:22] <ijohnson[m]> nice
[15:43] <jawn-smith> PR:#10592 updated, thanks for the feedback!
[15:43] <mup> Bug #10592: EOG is freezed on slow resizing <eog (Ubuntu):Invalid by seb128> <https://launchpad.net/bugs/10592>
[15:43] <mup> PR #10592: gadget: Export mkfs functions for use in ubuntu-image <Created by GlenPickle> <https://github.com/snapcore/snapd/pull/10592>
[15:49] <mup> PR snapd#10597 closed: config: rename "virtual" config to "external" config <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10597>
[16:38] <mvo> ijohnson[m]: thanks for your comments in 10622 - you rock!
[16:41] <ijohnson[m]> haha well I introduced the confusion to begin with so it's only fair if I can help :-)
[16:49] <mup> PR snapd#10629 closed: build-aux: build with go-1.13 in the snapcraft build too <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10629>
=== alan_g__ is now known as alan_g
=== bigpod9 is now known as bigpod
[17:49] <jawn-smith> Is flakiness with some of the spread tests expected? I had a few fail, including a couple required ones: ubuntu-18.04-32 and ubuntu-core-20-64
[18:00] <mup> PR snapd#10621 closed: packaging: changelog for 2.51.5 to master <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10621>
[18:05] <mup> PR snapd#10625 closed: cmd/snap: print logs in local timezone <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10625>
[18:05] <ijohnson[m]> jawn-smith yeah sometimes the tests can be flaky, I'll have a look this afternoon I'd be very surprised if it was legitimately caused by your or 
[18:05] <ijohnson[m]> *your PR
[18:06] <jawn-smith> great, thanks ijohnson[m]!