| mardy | mborzecki: hi! Where is the source code that you are using for testing the library symbols in https://github.com/snapcore/snapd/pull/10540? | 05:17 |
|---|---|---|
| mup | PR #10540: cmd/snap-confine: handle CURRENT_TAGS on systems that support it <⛔ Blocked> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10540> | 05:17 |
| mborzecki | mardy: https://paste.ubuntu.com/p/stbjYyJSSf/ this is the code I was using, `gcc main.c $(pkg-config --cflags --libs libudev)` | 05:18 |
| mardy | would using dlsym(RTLD_DEFAULT, "udev_device_has_current_tag") change anything? | 05:23 |
| mborzecki | mardy: that would be like the first version i proposed, just without dlopen() | 05:59 |
| mborzecki | the idea behind using a weak symbol was that we would not have to do any of that explicitly | 05:59 |
| mardy | mborzecki: well, it's just a function call :-) | 06:03 |
| mardy | I guess it should be pretty fast, since it doesn't have to load anything | 06:04 |
| mborzecki | mardy: yeah, though i'd like ld.so to do the heavy lifting for us, since it's already doing this anyway :) | 06:09 |
| pstolowski | morning | 06:13 |
| mborzecki | pstolowski: hey | 06:23 |
| mborzecki | mardy: i'm wondering if there's maybe some additional attribute needed to make it work with a binary built on 16.04 | 06:26 |
| jamesh | mardy: I've provided some feedback on https://github.com/snapcore/snapd/pull/10628 | 06:44 |
| mup | PR #10628: usersession/xdgopenproxy: move PortalLauncher class to own package <Created by mardy> <https://github.com/snapcore/snapd/pull/10628> | 06:44 |
| mup | PR snapd#10631 opened: cmd/libsnap-confine-private: fix issues identified by coverity <Needs security review> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10631> | 08:02 |
| zyga-mbp | mborzecki +1 | 08:21 |
| zyga-mbp | mwhudson are you planing to promote go 1.17 to latest/stable? | 08:22 |
| pstolowski | mborzecki: can you take a look at https://github.com/snapcore/snapd/pull/10528 , should be relatively simple | 09:33 |
| mup | PR #10528: o/hookstate: allow snapctl refresh --proceed from snaps <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10528> | 09:33 |
| mup | PR snapd#10632 opened: spread: temporarily fix the ownership of /home/ubuntu/.ssh on 21.10 <Simple 😃> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10632> | 09:52 |
| mup | PR snapd#10633 opened: tests: spread test for snapctl refresh --pending/--proceed from the snap <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10633> | 09:52 |
| mwhudson | zyga-mbp: i do that on .1 | 09:55 |
| zyga-mbp | ah, I see | 10:00 |
| zyga-mbp | thank you :) | 10:00 |
| * pstolowski lunch | 10:10 | |
| mup | PR snapd#10634 opened: many: move to go modules gradeually <Created by mvo5> <https://github.com/snapcore/snapd/pull/10634> | 10:52 |
| mvo | woah, is it just me or if GH showing a merge button even if required tests did *not* run? | 11:02 |
| mup | PR snapd#10631 closed: cmd/libsnap-confine-private: fix issues identified by coverity <Needs security review> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10631> | 11:02 |
| mvo | aha, nevermind, looked at the wrong PR, all good | 11:05 |
| mardy | mborzecki: the reason for your suggestion, is it code readability, or is there something else? https://github.com/snapcore/snapd/pull/10623#pullrequestreview-731865699 | 11:29 |
| mup | PR #10623: usersession/agent: refactor common JSON validation into own function <Created by mardy> <https://github.com/snapcore/snapd/pull/10623> | 11:29 |
| mborzecki | mardy: just readability | 11:29 |
| mardy | mborzecki: thanks, applied | 11:30 |
| mup | PR snapd#10528 closed: o/hookstate: allow snapctl refresh --proceed from snaps <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10528> | 12:33 |
| mup | PR snapd#10635 opened: tests: update systems for sru validation <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10635> | 12:48 |
| mup | PR snapd#10622 closed: many: merge release/2.51 change to release/2.52 <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10622> | 13:43 |
| mup | PR snapd#10623 closed: usersession/agent: refactor common JSON validation into own function <Created by mardy> <Merged by mardy> <https://github.com/snapcore/snapd/pull/10623> | 13:58 |
| mup | PR snapd#10636 opened: interfaces, o/snapstate: introduce DisruptiveForPlugOnRefresh flag <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10636> | 14:53 |
| mardy | it would be nice if https://github.com/snapcore/snapd/pull/8926 got another review from more experienced team members :-) | 15:08 |
| mup | PR #8926: interfaces: add microstack-support interface <:birthday:> <Needs security review> <Created by dshcherb> <https://github.com/snapcore/snapd/pull/8926> | 15:08 |
| ijohnson[m] | mardy: it's on my queue, haven't gotten it to it yet though | 15:19 |
| mup | PR snapd#10594 closed: bootloader: fix double extract of the kernel assets <⛔ Blocked> <Needs Samuele review> <Run nested> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10594> | 16:23 |
| mup | PR snapd#10611 closed: gadget,secboot: add support to specify KDF options in the gadget <⛔ Blocked> <:rocket: bootspeed> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10611> | 16:23 |
| mup | PR snapd#10637 opened: tests: remove the test user just when it was installed on create-user-2 test <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10637> | 18:19 |
| mup | PR snapd#10638 opened: tests: stop the service when is active in test interfaces-firewall-control test <Simple 😃> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10638> | 19:24 |
| mup | PR snapd#10639 opened: vendor.c: new vendor.c subdir <Created by mvo5> <https://github.com/snapcore/snapd/pull/10639> | 19:29 |
| * cachio_ afk | 20:45 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!