| mardy | jamesh: Hi! Did you see my comment in https://github.com/snapcore/snapd/pull/10628? | 04:46 |
|---|---|---|
| mup | PR #10628: usersession/xdgopenproxy: move PortalLauncher class to own package <Created by mardy> <https://github.com/snapcore/snapd/pull/10628> | 04:46 |
| mborzecki | morning | 05:05 |
| mardy | mborzecki: hi! | 05:06 |
| mborzecki | mardy: hey | 05:06 |
| mardy | mborzecki: do you happen to know if we have (either in our testutil package, or in some standard go package) an equivalent of https://doc.qt.io/qt-5.12/qtemporarydir.html? | 05:10 |
| mborzecki | mardy: ioutil.TempDir? | 05:11 |
| mborzecki | mardy: https://pkg.go.dev/io/ioutil?utm_source=godoc#TempDir | 05:11 |
| mardy | mborzecki: thanks! That, plus a "defer RemoveAll()" should work | 05:12 |
| mborzecki | yup | 05:12 |
| pstolowski | morning | 06:30 |
| mardy | pstolowski: hi! | 06:32 |
| mborzecki | pstolowski: heya | 06:36 |
| zyga | good morning | 07:00 |
| pstolowski | hey zyga | 07:01 |
| mardy | zyga: hi! | 07:03 |
| zyga | hey guys :) | 07:18 |
| zyga | happy TGIF | 07:18 |
| mborzecki | errand, back in 1h | 07:24 |
| zyga | hey mvo | 07:58 |
| zyga | how are you doing? | 07:58 |
| mup | PR snapd#10653 opened: Mount control interface, step 1 <Created by mardy> <https://github.com/snapcore/snapd/pull/10653> | 08:31 |
| mborzecki | re | 08:39 |
| mborzecki | hm mvo isn't around? | 08:45 |
| mborzecki | oh well | 08:45 |
| mborzecki | duh, why systemd reloads its bpf programs on reload? | 08:47 |
| zyga | mborzecki, probably for the same reason we reload apparmor | 08:48 |
| zyga | easier to reload than to detect | 08:48 |
| mvo | mborzecki: I should be back | 08:56 |
| mborzecki | mvo: yup 😉 | 08:56 |
| mup | PR snapd#10641 closed: packaging: remove TEST_GITHUB_AUTOPKGTEST support <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10641> | 09:01 |
| mup | PR snapd#10650 closed: packaging: merge 2.51.6 changelog back to master <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10650> | 09:01 |
| mup | PR snapd#10651 closed: packaging: merge 2.51.6 changelog back to 2.52 <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10651> | 09:01 |
| mborzecki | mvo: pstolowski https://github.com/snapcore/snapd/pull/10640 moved the headers around | 10:24 |
| mup | PR #10640: cmd, packaging: import BPF headers from kernel, detect whether host headers are usable <Simple 😃> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10640> | 10:25 |
| mup | PR snapd#10638 closed: tests: stop the service when is active in test interfaces-firewall-control test <Simple 😃> <Created by sergiocazzolato> <Merged by stolowski> <https://github.com/snapcore/snapd/pull/10638> | 10:26 |
| pstolowski | mborzecki: thanks, lgtm; on a second though i wonder about 'bpf/vendor' vs 'vendor/bpf' ;) ? vendor/foo might make more sense if we introduce something else later? | 10:29 |
| pstolowski | *thought | 10:29 |
| mborzecki | pstolowski: there's 2 set of heders, one is bpf-insn.h which we'll need always (located under libsnap-confine-private/bpf/) and then the headers copied from the kernel which are added if host headers are too old (those are under libsnap-confine-private/bpf/vendor and need to keep the linux/bpf.h structure such that #includes don't get too complicated) | 10:31 |
| mborzecki | otoh, none of that probably matters too much ;) | 10:31 |
| pstolowski | mborzecki: i see; yeah that's fine | 10:34 |
| pstolowski | mardy: #10653 probably needs a title update | 10:37 |
| mup | Bug #10653: Users should be in "dip" group by default <shadow (Ubuntu):Fix Released by pitti> <https://launchpad.net/bugs/10653> | 10:37 |
| mup | PR #10653: mount-control: step 1 <Created by mardy> <https://github.com/snapcore/snapd/pull/10653> | 10:37 |
| mup | PR snapd#10654 opened: secboot: remove duplicate import <Created by xnox> <https://github.com/snapcore/snapd/pull/10654> | 10:46 |
| pstolowski | i'm looking at https://github.com/snapcore/snapd/pull/10652 and wondering about udevadm trigger/settle there, looks like something we do in the udev backend, so not sure why the test does it | 10:47 |
| mup | PR #10652: tests: fix timing issue on security-dev-input-event-denied test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10652> | 10:47 |
| pstolowski | (it's also about pre-existing test code, not just the changes from Sergio) | 10:48 |
| mup | PR snapd#10655 opened: secboot: remove unnecessary import of github.com/snapcore/secboot <Simple 😃> <Skip spread> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10655> | 10:51 |
| mborzecki | trivial fix ^^ | 10:51 |
| mup | PR snapd#10655 closed: secboot: remove unnecessary import of github.com/snapcore/secboot <Simple 😃> <Skip spread> <Created by bboozzoo> <Closed by bboozzoo> <https://github.com/snapcore/snapd/pull/10655> | 11:11 |
| mborzecki | meh, so i can't write a reasonable test that verified that cgroups are enforced because on distros where cgroups v2 is used, udev TAGS are sticky :/ | 12:01 |
| mup | PR snapd#10654 closed: secboot: remove duplicate import <Simple 😃> <Skip spread> <Created by xnox> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10654> | 12:16 |
| mup | PR snapd#10648 closed: .github/workflows: add codedov again <Simple 😃> <Skip spread> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10648> | 12:41 |
| mup | PR snapd#10635 closed: tests: update systems for sru validation <Simple 😃> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10635> | 12:46 |
| pstolowski | miguelpires: commented on snap remove PR | 14:30 |
| zyga | miguelpires, hello :) | 14:39 |
| * zyga just says hi | 14:39 | |
| zyga | I'm a former developer, not active anymore but I love to stick around | 14:39 |
| miguelpires | zyga hi! Nice to meet you. I know, I've seen your name on a lot of the documentation I've been reading (thanks btw!) =) | 14:50 |
| zyga | miguelpires, cool, my knowledge is super rusty now but I try to help from time to time | 14:51 |
| miguelpires | zyga that's very cool :) | 15:15 |
| mardy | ijohnson[m]: it's strange that the coverage report keeps reporting that 2% drop, even after it was merged to master: https://github.com/snapcore/snapd/pull/10628 | 15:24 |
| mup | PR #10628: usersession/xdgopenproxy: move PortalLauncher class to own package <Created by mardy> <https://github.com/snapcore/snapd/pull/10628> | 15:24 |
| mardy | I assume that the coverage report for new PRs should be compared to the current master | 15:25 |
| ijohnson[m] | @mardy hmm I actually think I setup the action wrong so it only runs on prs not on master too | 15:28 |
| ijohnson[m] | Hmm let me think on this | 15:28 |
| mup | PR snapd#10656 opened: snapstate: add compat code that injects missing asset update tasks <Created by mvo5> <https://github.com/snapcore/snapd/pull/10656> | 15:47 |
| dust | tiled: This application failed to start because it could not find or load the Qt platform plugin "wayland-egl" | 17:42 |
| mup | PR snapcraft#3570 opened: ROS V2 plugins: resolve conditional dependencies <Created by artivis> <https://github.com/snapcore/snapcraft/pull/3570> | 18:59 |
| mup | PR snapd#10652 closed: tests: fix timing issue on security-dev-input-event-denied test <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10652> | 19:33 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!