| mup | PR snapd#10670 opened: tests: new snapd-state tool <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10670> | 03:21 |
|---|---|---|
| mborzecki | morning | 05:48 |
| mup | PR snapd#10667 closed: cmd/snap-seccomp/syscalls: update syscalls list to libseccomp v2.2.0-428-g5c22d4b <⚠ Critical> <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10667> | 06:17 |
| zyga | good morning | 06:19 |
| mborzecki | zyga: hey | 06:20 |
| zyga | mborzecki, commute to the office today | 06:21 |
| zyga | that was ... new | 06:21 |
| zyga | I guess it's only nice because there's hardly anyone going now | 06:21 |
| zyga | but the subway and bus was nearly empty | 06:21 |
| mardy | good morning mborzecki, zyga | 06:21 |
| mborzecki | zyga: if the weather wasn't so bad you could ride your bike | 06:21 |
| mborzecki | mardy: hey | 06:21 |
| zyga | hey mardy :) | 06:22 |
| zyga | mborzecki, it's raining :D | 06:22 |
| zyga | I have a three hop connection | 06:22 |
| zyga | two subway lines and a bus line | 06:22 |
| mborzecki | zyga: same here, been raining all of yday and today | 06:22 |
| zyga | I want to use my bike instead of the initial bus ride as there's a park 'n' ride place there | 06:22 |
| zyga | but I'm not really going to work from the office | 06:22 |
| zyga | this is just a novely thing for me :P | 06:23 |
| zyga | 15 years at home you know | 06:23 |
| pstolowski | morning | 06:33 |
| mardy | pstolowski: hi! | 06:36 |
| zyga | hey pstolowski :) | 06:42 |
| zyga | good morning mvo | 06:46 |
| mvo | good morning zyga ! | 07:07 |
| mvo | mborzecki: looks like we got new syscalls, are you on this already, if not I can do a quick PR | 07:08 |
| mborzecki | mvo: landed https://github.com/snapcore/snapd/pull/10667 this morning | 07:10 |
| mup | PR #10667: cmd/snap-seccomp/syscalls: update syscalls list to libseccomp v2.2.0-428-g5c22d4b <⚠ Critical> <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10667> | 07:10 |
| mvo | mborzecki: \o/ | 07:10 |
| mup | PR snapd#10668 closed: i18n/xgettext-go: preserve already escaped quotes <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10668> | 07:12 |
| mborzecki | pstolowski: hey, about https://github.com/snapcore/snapd/pull/10669#discussion_r694565845 i don't think a confined app can run sudo actually | 07:14 |
| mup | PR #10669: o/hookstate/ctlcmd: correct err message if missing root <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10669> | 07:14 |
| pstolowski | mborzecki: it can't, but the user can sudo <app>, no? | 07:15 |
| mup | PR snapd#10662 closed: .github/workflows/test.yaml: test github.events key <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10662> | 07:17 |
| mup | PR snapd#10664 closed: tests: set to 10 minutes the kill timeout for tests failing on slow boards <Simple 😃> <Created by sergiocazzolato> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10664> | 07:17 |
| mborzecki | pstolowski: and then some app/script runs snapctl? yeah that's possible | 07:19 |
| mardy | I'm a bit slow, can someone help me understand the logic in https://github.com/snapcore/snapd/pull/10662#discussion_r693939865 ? | 07:20 |
| mup | PR #10662: .github/workflows/test.yaml: test github.events key <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10662> | 07:20 |
| mardy | it seems to me that if the event is "push", then no jobs will be run at all | 07:20 |
| mardy | if: ${{ github.event_name != 'push' && github.ref != 'refs/heads/master' }} | 07:21 |
| mardy | the first condition will be false, right? | 07:21 |
| zyga | mardy, drop the $ | 07:23 |
| zyga | if has a special context already | 07:23 |
| zyga | IIRC | 07:23 |
| mardy | zyga: yes, it seems that it's not needed (https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif) but I'm referring to the logic itself | 07:24 |
| * zyga just noticed the ${{ had a knee-jerk reaction | 07:24 | |
| mardy | I added a comment, I think that the && should be a || | 07:26 |
| * zyga is preparing a release and needs to package his software for poky | 07:29 | |
| zyga | current status: melting work laptop with building linux, gcc and more | 07:29 |
| mvo | mardy: oh, maybe I did not look closely enough, let's wait for ian and then check this again | 07:32 |
| mardy | changing topic, do I understand it correctly that the XXX in the comments is a synonym for TODO? | 07:38 |
| mup | PR snapd#10589 closed: cgroup-support: allow to hide cgroupv2 warning via ENV <Simple 😃> <cgroupv2> <Created by slyon> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10589> | 07:42 |
| mup | PR snapd#10592 closed: gadget: Export mkfs functions for use in ubuntu-image <Created by GlenPickle> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10592> | 07:42 |
| mup | PR snapd#10588 closed: sysconfig/cloudinit.go: add functions for filtering cloud-init config <Simple 😃> <UC20> <Skip spread> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10588> | 07:52 |
| mardy | by the way, assuming that I addressed jamesh remarks correctly, this could also benefit from a review: https://github.com/snapcore/snapd/pull/10628 | 08:01 |
| mup | PR #10628: usersession/xdgopenproxy: move PortalLauncher class to own package <Squash-merge> <Created by mardy> <https://github.com/snapcore/snapd/pull/10628> | 08:01 |
| mvo | mardy: yeah, that's my understanding. I use "XXX" for a TODO that is slightly more prsssing or ugly and a "TODO" for something that is nice but maybe this subtlety is just me. plus I'm probably inconsistent :) | 08:20 |
| mvo | mardy: in 10628 I clicked on jamesh for a re-review | 08:20 |
| jamesh | mardy: having a second look. | 08:20 |
| mardy | jamesh, mvo: thanks | 08:23 |
| mvo | \o/ | 08:24 |
| mup | PR snapd#10671 opened: o/assertstate,snapstate: refresh validation set assertions with snap declarations <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10671> | 08:27 |
| pstolowski | mardy: small remark re capitalization in https://github.com/snapcore/snapd/pull/10606 ; i think pedronis was also suggesting an error message starting with lowercase | 08:38 |
| mup | PR #10606: o/hookstate/ctlcmd: unify the error message when context is missing <Squash-merge> <Simple 😃> <Created by mardy> <https://github.com/snapcore/snapd/pull/10606> | 08:38 |
| mborzecki | mardy: i've updated https://github.com/snapcore/snapd/pull/10658 if you want to take a look (cc @mv | 08:51 |
| mup | PR #10658: cmd/libsnap-confine-private: add BPF support helpers <Needs security review> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10658> | 08:51 |
| mborzecki | errand, back in 30 | 08:53 |
| mardy | mborzecki: I resolved my comments in your PR, otherwise I've already approved it yesterday | 09:01 |
| mardy | pstolowski: snap assertions and declarations, are they two orthogonal concepts, or are declarations a subset (or special type) of assertions? | 09:22 |
| mborzecki | re | 09:22 |
| mborzecki | mardy: thanks! | 09:22 |
| pstolowski | mardy: snap declaration is an assertion specific to snaps | 09:23 |
| mardy | pstolowski: thanks | 09:23 |
| mardy | mvo: if I may suggest another convention, I'd go for "TODO" (do it when we have time) and "FIXME" (this is more urgent, but we don't have time or all the prerequisites right now); at least I'm always a bit puzzled when I see XXX :-) | 09:31 |
| mvo | mardy: heh, yeah, the xXX is not super clear | 10:09 |
| mvo | if someone could do a second review of 10639, that would be lovely. it is green(!) | 10:11 |
| pstolowski | fwtw I consider XXX as something not super clear (not clear if it's a problem, or not clear what to do/if anything) and use it as such ;) | 10:44 |
| pstolowski | i've another larg'ish PR to propose but i suppose i should wait for pedronis to re-review some of my current PRs, so the queue shrinks ;) | 10:46 |
| * pstolowski lunch | 10:48 | |
| mborzecki | mvo: https://github.com/snapcore/snapd/pull/10639#pullrequestreview-737108508 | 11:26 |
| mup | PR #10639: c-vendor.c: new c-vendor subdir <Created by mvo5> <https://github.com/snapcore/snapd/pull/10639> | 11:26 |
| mup | PR snapd#10656 closed: snapstate: add compat code that injects missing asset update tasks <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10656> | 11:33 |
| mup | PR snapd#10672 opened: store: make sure expectedZeroFields in tests gets updated <Skip spread> <Created by pedronis> <https://github.com/snapcore/snapd/pull/10672> | 12:33 |
| mup | PR snapd#10659 closed: store: deal correctly with "assumes" from the store raw yaml <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10659> | 12:48 |
| mup | PR snapd#10673 opened: Bugfix/codecov io logic <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10673> | 12:53 |
| mup | PR snapd#10660 closed: overlord: add manager test for "assumes" checking <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10660> | 13:28 |
| mup | PR snapd#10672 closed: store: make sure expectedZeroFields in tests gets updated <Skip spread> <Created by pedronis> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10672> | 13:48 |
| === pedronis_ is now known as pedronis | ||
| pedronis | pstolowski: I had a question in https://github.com/snapcore/snapd/pull/10626 which doesn't seem to have been answered | 14:15 |
| mup | PR #10626: o/hookstate: support snapctl refresh --pending from snap <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10626> | 14:15 |
| pstolowski | pedronis: sorry, missed that one, checking | 14:18 |
| === sarnold_ is now known as sarnold | ||
| pstolowski | pedronis: answered | 14:33 |
| pedronis | pstolowski: thx, couple more questions | 14:44 |
| pedronis | pstolowski: your validation set refresh assertion PR will conflict with the PR by Miguel I asked you to review, so we should probably start there | 14:47 |
| pedronis | pstolowski: https://github.com/snapcore/snapd/pull/10584 needs your review and then your PR needs to be a bit different, because the things you are unifying can't be unified the same way | 14:48 |
| mup | PR #10584: o/assertstate: fix missing 'scheduled' header when auto refreshing assertions <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10584> | 14:48 |
| pedronis | pstolowski: did you see this question https://github.com/snapcore/snapd/pull/10626#discussion_r694917652 ? | 14:52 |
| mup | PR #10626: o/hookstate: support snapctl refresh --pending from snap <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10626> | 14:52 |
| pstolowski | pedronis: yes, i was just replying | 14:54 |
| pedronis | ah sorry | 14:54 |
| pstolowski | pedronis: ah, i missed ping from miguelpires on that, will review | 14:56 |
| pstolowski | right, will need auto and no-auto refresh of asserts | 14:58 |
| * cachio_ afk | 15:01 | |
| pedronis | ijohnson[m]: what do you think about this: https://github.com/snapcore/snapd/pull/10626#discussion_r694917652 ? | 15:06 |
| mup | PR #10626: o/hookstate: support snapctl refresh --pending from snap <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10626> | 15:06 |
| pedronis | ijohnson[m]: sorry, wrong paste | 15:06 |
| pedronis | ijohnson[m]: I meant this https://github.com/snapcore/snapd/pull/10617#discussion_r694942476 | 15:06 |
| mup | PR #10617: cmd/snap: add Size column to refresh --list <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10617> | 15:06 |
| pstolowski | miguelpires, pedronis: one question to #10584 | 15:10 |
| mup | Bug #10584: sungem module causes oops on XServe G5 <linux-source-2.6.15 (Ubuntu):Fix Released by ben-collins> <https://launchpad.net/bugs/10584> | 15:10 |
| mup | PR #10584: o/assertstate: fix missing 'scheduled' header when auto refreshing assertions <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10584> | 15:10 |
| mup | PR snapd#10639 closed: c-vendor.c: new c-vendor subdir <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10639> | 15:33 |
| mvo | pedronis: I updated 10666 | 15:45 |
| pedronis | miguelpires: I answered in #10584 (sorry I missed this doing the last quick review) | 17:45 |
| mup | Bug #10584: sungem module causes oops on XServe G5 <linux-source-2.6.15 (Ubuntu):Fix Released by ben-collins> <https://launchpad.net/bugs/10584> | 17:45 |
| mup | PR #10584: o/assertstate: fix missing 'scheduled' header when auto refreshing assertions <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10584> | 17:45 |
| mup | PR snapd#10674 opened: sysconfig/cloudinit: fix bug around error state of cloud-init <Simple 😃> <Bug> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10674> | 19:34 |
| * Ringtailed_Fox would like to try porting snapd to mageia linux so he can use snaps on it... what needs to be done? | 23:46 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!