| mup | PR snapd#10677 closed: snapstate: fix misleading `assumes` error message <Simple 😃> <Skip spread> <Created by mvo5> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10677> | 02:50 |
|---|---|---|
| mborzecki | morning | 05:34 |
| mardy | mborzecki: hi! | 05:38 |
| mborzecki | mardy: heya | 05:39 |
| pstolowski | morning | 06:28 |
| mardy | pstolowski: hi! | 06:33 |
| mborzecki | pstolowski: hey | 06:37 |
| mup | PR snapd#10682 opened: many: shellcheck fixes <âš Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10682> | 07:30 |
| pstolowski | mvo: hi, quick question there ^ | 07:31 |
| pstolowski | mvo: btw can you land https://github.com/snapcore/snapd/pull/10617 ? | 07:32 |
| mup | PR #10617: cmd/snap: add Size column to refresh --list <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10617> | 07:32 |
| mup | PR snapd#10683 opened: interfaces/dsp: add /dev/ambad into dsp interface <Created by woodrow-shen> <https://github.com/snapcore/snapd/pull/10683> | 09:51 |
| mborzecki | mvo: when you're around, can you take a look at https://github.com/snapcore/snapd/pull/10158 ? | 09:53 |
| mup | PR #10158: packaging: build without dwarf debugging data <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/10158> | 09:53 |
| mborzecki | i think it's ok to land it, there's an observable gain when building the package manually, however we need to investigate why this doesn't translate to size change in the snapd snap artifact produced by github workflow | 09:53 |
| mardy | golang question: I want to mock this function: https://github.com/mardy/snapd/blob/mount-control-1/wrappers/services.go#L1661 | 10:15 |
| mardy | but I cannot, because the "interacter" type is private: "cannot use f (type func(snap.PlaceInfo, string, Interacter) error) as type func(snap.PlaceInfo, string, wrappers.interacter) error in assignment" | 10:16 |
| pstolowski | mardy: yeah you cannot reference a private symbol from another package. try to define a type alias in export_test.go, i.e. type Interacter = interacter | 10:25 |
| pstolowski | mardy: that should work as long as it's the test for the given package (but not from other packages). in the test you will need to reference the exported type with wrappers.Interacter | 10:28 |
| mardy | pstolowski: it's a test in another package :-( | 10:45 |
| pstolowski | mardy: ok, and you're defining a MockRemoveUnitFiles function in services.go for other packages to use in their tests? | 10:47 |
| mardy | pstolowski: yes, this is what I'm trying to do: https://github.com/mardy/snapd/commit/0370da64344e69d645b8c7b0114b7a13e9ffd9cc | 10:50 |
| zyga-mbp | good morning | 10:52 |
| * zyga-mbp is pretty tired/sleepy today | 10:52 | |
| pstolowski | mardy: ah so it's a bit different than what i imagined. but nvm.. i'm afraid you will need to make Interacter exported in wrappers | 10:55 |
| pstolowski | hey zyga-mbp | 10:56 |
| zyga-mbp | hey | 10:57 |
| zyga-mbp | today I slept for 10 hours :P | 10:57 |
| mardy | pstolowski: yep, I thought of doing the same, but wanted to ask if there was a better way. Anyway, thanks! | 10:57 |
| zyga-mbp | playing with rpi and my scope to do some experiments | 10:57 |
| mardy | zyga-mbp: hi! | 10:58 |
| zyga-mbp | but man I feel tired somehow | 10:58 |
| zyga-mbp | probably the wether | 10:58 |
| zyga-mbp | hey mardy :) | 10:58 |
| pstolowski | mardy: alternatively, inside snapstate/backend wrap the actual call to wrappers inside a small function that takes/passes progress bar to wrappers, and mock that function instead in your tests, but i'm not sure it's the best | 10:59 |
| mvo | mborzecki: will look now | 11:02 |
| mup | PR snapd#10158 closed: packaging: build without dwarf debugging data <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10158> | 11:06 |
| zyga-mbp | woot | 11:08 |
| zyga-mbp | thank you for merging mvo | 11:08 |
| zyga-mbp | mvo: I _really_ wonder if upx would make more difference on top of this | 11:08 |
| mvo | zyga-mbp: on the snap not much but probably in a package | 11:11 |
| zyga-mbp | mvo given upx makes page sharing harder, I would not upx snapd but I would compress snap, snap-seccomp and other short-lived tools | 11:13 |
| mvo | zyga-mbp: intressting idea | 11:15 |
| zyga-mbp | mvo try upx --brute on snap | 11:15 |
| mborzecki | zyga-mbp: hm not entirely convinced, this will impact ram use, so negative impact on systems where there already is some pressure and then lower end cpus will lead to longer start times because the snap command is in the critical chain :/ | 11:17 |
| zyga-mbp | mborzecki ram usage of _snap_ is minimal | 11:18 |
| zyga-mbp | it will take exactly the amount used by snap today | 11:18 |
| mborzecki | zyga-mbp: can upx selectively unpack relevant pages only? | 11:18 |
| zyga-mbp | IIRC no, it unpacks to tmp or to temporary memory | 11:18 |
| zyga-mbp | I think your earlier idea to combine binaries was better | 11:19 |
| zyga-mbp | but it's harder with more and more things added to snapd | 11:19 |
| zyga-mbp | mborzecki snap-seccomp is another easy target though | 11:19 |
| zyga-mbp | it's not a critical chain app | 11:19 |
| zyga-mbp | all the initrd programs are in the same pool | 11:19 |
| mborzecki | zyga-mbp: we had a system where there was little memory and things were being pushed in and out of the cache, even running `snap` binary was a challenge :P | 11:20 |
| zyga-mbp | mborzecki I recall but TBH that's a lost cause IMO | 11:20 |
| zyga-mbp | go 1.17 is nice, it makes a small difference in the right direction | 11:20 |
| mborzecki | zyga-mbp: yeah, maybe, me and ondra ended up with a shell script to replace /usr/bin/snap | 11:21 |
| cachio_ | pstolowski, hi | 11:32 |
| cachio_ | I left you a comment https://github.com/snapcore/snapd/pull/10443#discussion_r696542490 | 11:32 |
| mup | PR #10443: tests: check files and dirs are cleaned for each test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10443> | 11:32 |
| cachio_ | pstolowski, does it make sense? | 11:33 |
| pstolowski | cachio_: replied | 11:46 |
| pstolowski | the test situation today is really grim :( | 11:53 |
| cachio_ | pstolowski, finally what is working well is [ -z "$(cat /tmp/fs-diff)" ] | 12:13 |
| cachio_ | other solutions have provlems | 12:13 |
| pstolowski | cachio_: find -empty is wrong as well i guess? | 12:13 |
| cachio_ | I think sol | 12:14 |
| cachio_ | let me recheck | 12:14 |
| pstolowski | i played a bit locally and it seems to be the same as using -s | 12:15 |
| cachio_ | yes | 12:17 |
| cachio_ | both work bad | 12:17 |
| cachio_ | for this scenario | 12:17 |
| cachio_ | the only way to make it work well was doing | 12:17 |
| cachio_ | if [ ! -z "$(cat /tmp/fs-diff)" ]; then | 12:17 |
| cachio_ | pstolowski, thanks for the revie | 12:18 |
| cachio_ | w | 12:18 |
| cachio_ | I'll push the fix now | 12:18 |
| pstolowski | cachio_: nice | 12:22 |
| cachio_ | pstolowski, about the tests, I see more frequent errors related to uc20 failed to reboot | 12:22 |
| cachio_ | kill-timeouts | 12:23 |
| pstolowski | cachio_: one more comment to the PR | 12:25 |
| cachio_ | pstolowski, thanks | 12:42 |
| mup | PR core20#105 closed: hooks: enable systemd-time-wait-sync.service <Created by mvo5> <Merged by xnox> <https://github.com/snapcore/core20/pull/105> | 12:42 |
| mup | PR core20#106 closed: Add motd and issue to writable /etc files <Created by snowsky> <Merged by xnox> <https://github.com/snapcore/core20/pull/106> | 12:42 |
| pstolowski | cachio_: +1. i think this should be squash-merged | 12:45 |
| mup | PR core18#174 closed: Resurrect bash-completion <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core18/pull/174> | 12:55 |
| cachio_ | pstolowski, thanks | 12:56 |
| mup | PR snapd#10617 closed: cmd/snap: add Size column to refresh --list <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10617> | 13:11 |
| mup | PR snapd#10682 closed: many: shellcheck fixes <âš Critical> <Squash-merge> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10682> | 13:36 |
| mup | PR snapd#10684 opened: many: shellcheck fixes <Created by mvo5> <https://github.com/snapcore/snapd/pull/10684> | 13:42 |
| === not_phunyguy is now known as phunyguy | ||
| mup | PR snapcraft#3573 opened: snaps: eliminate extra call to query snap info <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3573> | 15:22 |
| mup | PR snapcraft#3574 opened: lint: disable new shellcheck warnings <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3574> | 15:37 |
| mup | PR snapd#10666 closed: snapstate: abort kernel refresh if no gadget update can be found <âš Critical> <Squash-merge> <cherry-picked> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10666> | 16:12 |
| * cachio_ luncj | 16:21 | |
| * cachio_ lunch | 16:21 | |
| mup | PR snapd#10685 opened: many: fix run-checks gofmt check <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10685> | 17:27 |
| mup | PR snapd#10686 opened: many: remove unused/dead code <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10686> | 17:32 |
| mup | PR snapcraft#3574 closed: lint: disable new shellcheck warnings (CRAFT-482) <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3574> | 18:07 |
| mup | PR snapd#10687 opened: tests: use "shellcheck" snap in `go` unit test <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10687> | 19:13 |
| === mup_ is now known as mup | ||
| mup | PR snapcraft#3573 closed: snaps: eliminate extra call to query snap info (CRAFT-479) <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3573> | 21:07 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!