mupPR snapd#10677 closed: snapstate: fix misleading `assumes` error message <Simple 😃> <Skip spread> <Created by mvo5> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10677>02:50
mardymborzecki: hi!05:38
mborzeckimardy: heya05:39
mardypstolowski: hi!06:33
mborzeckipstolowski: hey06:37
mupPR snapd#10682 opened: many: shellcheck fixes <⚠ Critical> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10682>07:30
pstolowskimvo: hi, quick question there ^07:31
pstolowskimvo: btw can you land https://github.com/snapcore/snapd/pull/10617 ?07:32
mupPR #10617: cmd/snap: add Size column to refresh --list <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10617>07:32
mupPR snapd#10683 opened: interfaces/dsp: add /dev/ambad into dsp interface <Created by woodrow-shen> <https://github.com/snapcore/snapd/pull/10683>09:51
mborzeckimvo: when you're around, can you take a look at https://github.com/snapcore/snapd/pull/10158 ?09:53
mupPR #10158: packaging: build without dwarf debugging data <Simple 😃> <Created by zyga> <https://github.com/snapcore/snapd/pull/10158>09:53
mborzeckii think it's ok to land it, there's an observable gain when building the package manually, however we need to investigate why this doesn't translate to size change in the snapd snap artifact produced by github workflow09:53
mardygolang question: I want to mock this function: https://github.com/mardy/snapd/blob/mount-control-1/wrappers/services.go#L166110:15
mardybut I cannot, because the "interacter" type is private: "cannot use f (type func(snap.PlaceInfo, string, Interacter) error) as type func(snap.PlaceInfo, string, wrappers.interacter) error in assignment"10:16
pstolowskimardy: yeah you cannot reference a private symbol from another package. try to define a type alias in export_test.go, i.e. type Interacter = interacter10:25
pstolowskimardy: that should work as long as it's the test for the given package (but not from other packages). in the test you will need to reference the exported type with wrappers.Interacter10:28
mardypstolowski: it's a test in another package :-(10:45
pstolowskimardy: ok, and you're defining a MockRemoveUnitFiles function in services.go for other packages to use in their tests?10:47
mardypstolowski: yes, this is what I'm trying to do: https://github.com/mardy/snapd/commit/0370da64344e69d645b8c7b0114b7a13e9ffd9cc10:50
zyga-mbpgood morning10:52
* zyga-mbp is pretty tired/sleepy today10:52
pstolowskimardy: ah so it's a bit different than what i imagined. but nvm.. i'm afraid you will need to make Interacter exported in wrappers10:55
pstolowskihey zyga-mbp 10:56
zyga-mbptoday I slept for 10 hours :P10:57
mardypstolowski: yep, I thought of doing the same, but wanted to ask if there was a better way. Anyway, thanks!10:57
zyga-mbpplaying with rpi and my scope to do some experiments 10:57
mardyzyga-mbp: hi!10:58
zyga-mbpbut man I feel tired somehow10:58
zyga-mbpprobably the wether 10:58
zyga-mbphey mardy :)10:58
pstolowskimardy: alternatively, inside snapstate/backend wrap the actual call to wrappers inside a small function that takes/passes progress bar to wrappers, and mock that function instead in your tests, but i'm not sure it's the best10:59
mvomborzecki: will look now11:02
mupPR snapd#10158 closed: packaging: build without dwarf debugging data <Simple 😃> <Created by zyga> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10158>11:06
zyga-mbpthank you for merging mvo 11:08
zyga-mbpmvo: I _really_ wonder if upx would make more difference on top of this11:08
mvozyga-mbp: on the snap not much but probably in a package11:11
zyga-mbpmvo given upx makes page sharing harder, I would not upx snapd but I would compress snap, snap-seccomp and other short-lived tools11:13
mvozyga-mbp: intressting idea11:15
zyga-mbpmvo try upx --brute on snap11:15
mborzeckizyga-mbp: hm not entirely convinced, this will impact ram use, so negative impact on systems where there already is some pressure and then lower end cpus will lead to longer start times because the snap command is in the critical chain :/11:17
zyga-mbpmborzecki ram usage of _snap_ is minimal11:18
zyga-mbpit will take exactly the amount used by snap today 11:18
mborzeckizyga-mbp: can upx selectively unpack relevant pages only? 11:18
zyga-mbpIIRC no, it unpacks to tmp or to temporary memory11:18
zyga-mbpI think your earlier idea to combine binaries was better11:19
zyga-mbpbut it's harder with more and more things added to snapd11:19
zyga-mbpmborzecki snap-seccomp is another easy target though11:19
zyga-mbpit's not a critical chain app11:19
zyga-mbpall the initrd programs are in the same pool11:19
mborzeckizyga-mbp: we had a system where there was little memory and things were being pushed in and out of the cache, even running `snap` binary was a challenge :P11:20
zyga-mbpmborzecki I recall but TBH that's a lost cause IMO11:20
zyga-mbpgo 1.17 is nice, it makes a small difference in the right direction11:20
mborzeckizyga-mbp: yeah, maybe, me and ondra ended up with a shell script to replace /usr/bin/snap11:21
cachio_pstolowski, hi11:32
cachio_I left you a comment https://github.com/snapcore/snapd/pull/10443#discussion_r69654249011:32
mupPR #10443: tests: check files and dirs are cleaned for each test <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10443>11:32
cachio_pstolowski, does it make sense?11:33
pstolowskicachio_: replied11:46
pstolowskithe test situation today is really grim :(11:53
cachio_pstolowski, finally what is working well is [ -z "$(cat /tmp/fs-diff)" ]12:13
cachio_other solutions have provlems12:13
pstolowskicachio_: find -empty is wrong as well i guess?12:13
cachio_I think sol12:14
cachio_let me recheck12:14
pstolowskii played a bit locally and it seems to be the same as using -s12:15
cachio_both work bad12:17
cachio_for this scenario12:17
cachio_the only way to make it work well was doing 12:17
cachio_if [ ! -z "$(cat /tmp/fs-diff)" ]; then12:17
cachio_pstolowski, thanks for the revie12:18
cachio_I'll push the fix now12:18
pstolowskicachio_: nice12:22
cachio_pstolowski, about the tests, I see more frequent errors related to uc20 failed to reboot12:22
pstolowskicachio_: one more comment to the PR12:25
cachio_pstolowski, thanks12:42
mupPR core20#105 closed: hooks: enable systemd-time-wait-sync.service <Created by mvo5> <Merged by xnox> <https://github.com/snapcore/core20/pull/105>12:42
mupPR core20#106 closed: Add motd and issue to writable /etc files <Created by snowsky> <Merged by xnox> <https://github.com/snapcore/core20/pull/106>12:42
pstolowskicachio_: +1. i think this should be squash-merged12:45
mupPR core18#174 closed: Resurrect bash-completion <Created by xnox> <Merged by xnox> <https://github.com/snapcore/core18/pull/174>12:55
cachio_pstolowski, thanks12:56
mupPR snapd#10617 closed: cmd/snap: add Size column to refresh --list <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10617>13:11
mupPR snapd#10682 closed: many: shellcheck fixes <⚠ Critical> <Squash-merge> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10682>13:36
mupPR snapd#10684 opened: many: shellcheck fixes <Created by mvo5> <https://github.com/snapcore/snapd/pull/10684>13:42
=== not_phunyguy is now known as phunyguy
mupPR snapcraft#3573 opened: snaps: eliminate extra call to query snap info <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3573>15:22
mupPR snapcraft#3574 opened: lint: disable new shellcheck warnings <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3574>15:37
mupPR snapd#10666 closed: snapstate: abort kernel refresh if no gadget update can be found <⚠ Critical> <Squash-merge> <cherry-picked> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10666>16:12
* cachio_ luncj16:21
* cachio_ lunch16:21
mupPR snapd#10685 opened: many: fix run-checks gofmt check  <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10685>17:27
mupPR snapd#10686 opened: many: remove unused/dead code <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10686>17:32
mupPR snapcraft#3574 closed: lint: disable new shellcheck warnings (CRAFT-482) <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3574>18:07
mupPR snapd#10687 opened: tests: use "shellcheck" snap in `go` unit test <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10687>19:13
=== mup_ is now known as mup
mupPR snapcraft#3573 closed: snaps: eliminate extra call to query snap info (CRAFT-479) <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3573>21:07

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!