| mborzecki | morning | 05:08 |
|---|---|---|
| mardy | good morning! | 05:12 |
| mborzecki | errand, back in 1h or so | 05:50 |
| mardy | oh, that means that my main internet connection should be back :-) | 06:16 |
| === mardy_2nd is now known as mardy | ||
| pstolowski | morning | 06:27 |
| mup | PR snapd#10684 closed: many: shellcheck fixes (2.51) <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10684> | 06:34 |
| mardy | pstolowski: hi! | 06:49 |
| mardy | jamesh: hi! Is there a way to know if a dbus.BusObject is valid? | 07:13 |
| jamesh | mardy: which aspects of it? | 07:18 |
| jamesh | it's essentially just a reference to a bus name and object path to use in method calls | 07:18 |
| jamesh | in general it is probably best to try and make the method call and check for errors | 07:19 |
| jamesh | Alternatively, calling the bus's StartServiceByName method could be appropriate: that will succeed if someone has already registered the name, or it was possible to activate a service that registers the name | 07:25 |
| mardy | jamesh: ah, right, I actually only need to check if it has been initialized. So I guess that checking that Path() returns a non null string is OK | 07:26 |
| jamesh | mardy: in what situations would you not know if a dbus.BusObject is valid in that sense? | 07:37 |
| jamesh | mardy: note that there is basically zero overhead to call conn.Object(name, path) | 07:38 |
| mborzecki | re | 07:39 |
| zyga | good morning :) | 07:44 |
| zyga | jamesh, mardy: conn.Object is entirely local, it's just a struct | 07:45 |
| * zyga uses dbus for sysota and had a look at the implementation more than once | 07:45 | |
| mardy | zyga, jamesh: yes, I realized that now. And I only need to know if the object has been inizialized, so looking at the Path() is enough | 08:29 |
| jamesh | mardy: my point was more that you may as well either (a) create a new Object whenever you need one, or (b) create them when you create/set the connection | 08:32 |
| jamesh | mardy: note that the Object struct includes a reference to the connection, so you definitely don't want to be holding on to an object for longer than the connection too. | 08:33 |
| mardy | good point | 08:37 |
| mborzecki | mvo: can you land https://github.com/snapcore/snapd/pull/10658 ? | 08:43 |
| mup | PR #10658: cmd/libsnap-confine-private: add BPF support helpers <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10658> | 08:43 |
| mborzecki | mvo: this one is ready too: https://github.com/snapcore/snapd/pull/10681 | 08:43 |
| mup | PR #10681: interfaces/hardware-observe: add some dmi properties <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10681> | 08:43 |
| mvo | mborzecki: sure | 08:49 |
| mup | PR snapd#10658 closed: cmd/libsnap-confine-private: add BPF support helpers <cgroupv2> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10658> | 08:50 |
| mup | PR snapd#10681 closed: interfaces/hardware-observe: add some dmi properties <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10681> | 08:50 |
| mup | PR snapd#10688 opened: configcore: add read-only netplan support <Created by mvo5> <https://github.com/snapcore/snapd/pull/10688> | 09:00 |
| mborzecki | mvo: thanks! | 09:03 |
| pstolowski | is pedronis off today? | 09:10 |
| mvo | pstolowski: I don't think so, probably just not on irc yet :) | 09:16 |
| pstolowski | allright | 09:16 |
| zyga | hey mvo :) | 09:16 |
| zyga | TGIF :) | 09:17 |
| zyga | any hockey on the horizon? | 09:17 |
| ogra | might need a loong stick ! | 09:17 |
| ogra | TGIF 😉 | 09:17 |
| mvo | hey zyga! yes, hockey tonight, super happy abou tit | 09:23 |
| zyga | mvo, nice :) | 09:23 |
| zyga | mvo, we're re-painting the kitchen this weekend | 09:23 |
| zyga | overdue and needed before some furniture moves in | 09:23 |
| mvo | zyga woah, nice! | 09:23 |
| mup | PR snapd#10687 closed: tests: use "shellcheck" snap in `go` unit test <Test Robustness> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10687> | 10:45 |
| mup | PR snapd#10689 opened: tests: disable `SC2039` in `snapctl-hooks` configure hook <Simple 😃> <Test Robustness> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10689> | 10:50 |
| mup | PR snapd#10686 closed: many: remove unused/dead code <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10686> | 10:55 |
| mup | PR snapd#10606 closed: o/hookstate/ctlcmd: unify the error message when context is missing <Squash-merge> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10606> | 11:00 |
| mup | PR snapd#10626 closed: o/hookstate: support snapctl refresh --pending from snap <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10626> | 11:00 |
| pstolowski | yay! | 11:02 |
| mup | PR snapd#10605 closed: many: do not re-check snaps on disk during uc20 install <â›” Blocked> <:rocket: bootspeed> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10605> | 11:10 |
| pstolowski | cachio_: hi, please see https://github.com/snapcore/snapd/pull/10633#issuecomment-907129209 | 11:43 |
| mup | PR #10633: tests: spread test for snapctl refresh --pending/--proceed from the snap <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10633> | 11:43 |
| cachio_ | pstolowski, sure, I'll take a look now | 11:44 |
| cachio_ | pstolowski, it is ok to land your pr, I'll update mine after the test is merged | 11:45 |
| pstolowski | cachio_: great, ty | 11:45 |
| cachio_ | yaw | 11:45 |
| mup | PR snapd#10690 opened: tests: split test tools - part 1 <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10690> | 11:45 |
| mup | PR snapcraft#3575 opened: check source-subdir for package.json if specified <Created by debdutdeb> <https://github.com/snapcore/snapcraft/pull/3575> | 12:03 |
| mup | PR snapd#10443 closed: tests: check files and dirs are cleaned for each test <Squash-merge> <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10443> | 12:21 |
| mup | PR snapd#10552 closed: tests: new spread log parser <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10552> | 12:21 |
| mup | PR snapd#10689 closed: tests: disable `SC2039` in `snapctl-hooks` configure hook <Simple 😃> <Test Robustness> <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10689> | 12:36 |
| mup | PR snapd#10691 opened: tests: cherry-pick shellcheck fix `bd730fd4` from #10443 (2.51) <Simple 😃> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10691> | 12:41 |
| cachio_ | mborzecki, hi, I see images in gce for opensuse 15.3 | 14:17 |
| cachio_ | should we remove 15.1 and add 15.2? | 14:17 |
| cachio_ | I mean 15.3 | 14:17 |
| mborzecki | cachio_: yeah, that'd be great | 14:26 |
| cachio_ | mborzecki, nice | 14:27 |
| mborzecki | cachio_: thank you! | 14:27 |
| mvo | 10524 needs a second review, should be simple :) | 15:09 |
| mvo | and 10691 a first review (but also very simple) | 15:10 |
| mup | PR snapd#10683 closed: interfaces/dsp: add /dev/ambad into dsp interface <Created by woodrow-shen> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10683> | 15:11 |
| mup | PR snapd#10586 closed: interfaces/interfaces/ion-memory-control: add: add interface for ion buf <Squash-merge> <Needs Samuele review> <cherry-picked> <Created by kubiko> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10586> | 15:16 |
| ijohnson[m] | mvo: sorry 10524 has unhappy lxd tests | 15:30 |
| mvo | ijohnson[m]: thanks, looks like I need to debug this, that is strange, I guess something for monday :/ I suspect it's a universe/main build mismatch | 15:32 |
| ijohnson[m] | yeah seems something specific to lxd's environment | 15:32 |
| mup | PR snapcraft#3569 closed: extensions: preload bindtextdomain from content snap if it exists <Created by kenvandine> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3569> | 15:39 |
| mvo | ijohnson[m]: once 10691 got a :+1: I think we can do a .7 | 15:45 |
| mvo | ijohnson[m]: unfortuantely I need to leave now for hockey but I can help when I'm back if needed, otherwise I will things in your good hands if that is okay | 15:46 |
| mup | PR snapd#10636 closed: interfaces, o/snapstate: introduce AffectsPlugOnRefresh flag <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10636> | 15:46 |
| mup | PR snapd#10674 closed: sysconfig/cloudinit: fix bug around error state of cloud-init <Simple 😃> <Bug> <Run nested> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10674> | 15:46 |
| ijohnson[m] | mvo: sounds good I just +1d that pr | 15:46 |
| ijohnson[m] | mvo: also thanks for the merge ^ | 15:46 |
| mvo | ijohnson[m]: thanks, merged it and also cherry-picked https://github.com/snapcore/snapd/pull/10667 | 15:50 |
| mup | PR #10667: cmd/snap-seccomp/syscalls: update syscalls list to libseccomp v2.2.0-428-g5c22d4b <⚠Critical> <Simple 😃> <Created by bboozzoo> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10667> | 15:50 |
| mvo | ijohnson[m]: release should be good now! | 15:50 |
| ijohnson[m] | nice, mvo do you think we should also cherry-pick https://github.com/snapcore/snapd/pull/10579? | 15:50 |
| mup | PR #10579: tests/main/snapd-snap: install 4.x snapcraft to build the snapd snap <⚠Critical> <Simple 😃> <Created by anonymouse64> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10579> | 15:50 |
| ijohnson[m] | i see that test fail on release/2.51 and it is very small | 15:50 |
| mvo | ijohnson[m]: yes! | 15:51 |
| ijohnson[m] | ack, I can take care of that one for you | 15:51 |
| mup | PR snapd#10691 closed: tests: cherry-pick shellcheck fix `bd730fd4` from #10443 (2.51) <Simple 😃> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10691> | 15:51 |
| mvo | ijohnson[m]: cool, thanks | 15:51 |
| mup | PR snapd#10692 opened: tests: remove opensuse-15.1 and add opensuse-15.3 from spread runs <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10692> | 15:56 |
| mup | PR snapd#10693 opened: release: 2.51.7 <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10693> | 20:37 |
| * cachio_ afk | 20:42 | |
| mup | Bug #1941926 opened: Service values are translated (so you can't use them in scripts) <Snappy:New> <https://launchpad.net/bugs/1941926> | 22:09 |
| mup | PR snapd#10693 closed: release: 2.51.7 <Simple 😃> <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10693> | 22:32 |
| mup | PR snapd#10694 opened: packaging: update master changelog for 2.51.7 <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10694> | 23:07 |
| mup | PR snapd#10695 opened: packaging: update 2.52 changelog with 2.51.7 <Simple 😃> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10695> | 23:07 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!