[00:08] <mup> PR snapcraft#3570 closed: ROS V2 plugins: resolve conditional dependencies <Created by artivis> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3570>
[01:31] <h1pot> whenever i invoke snap, i'm getting main.go:176: description of prepare-image's "<target-dir>" is lowercase in locale "pt_BR": "o directório de destino"
[05:34] <mborzecki> morning
[05:47] <mardy> mborzecki, miguelpires: hi!
[05:48] <miguelpires> hi mardy :)
[05:49] <mardy> golang question of the day: when importing a package, will the whole package be included in the final binary, or only those parts which are actually used?
[05:53] <mborzecki> mardy: if you're thinking about lto, then go compiler isn't that smart afaik
[06:24] <miguelpires> Good morning mvo. Can you merge https://github.com/snapcore/snapd/pull/10685 please?
[06:24] <mup> PR #10685: many: fix run-checks gofmt check  <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10685>
[06:30] <mup> PR snapd#10696 closed: many: move to yaml.v3 <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10696>
[06:32] <pstolowski> morning
[06:33] <mardy> 'morning pstolowski, mvo 
[06:34] <mvo> good morning miguelpires, sure, happy to do that
[06:35] <mvo> miguelpires: it's early for you, isn't it :) ?
[06:35] <mvo> good morning pstolowski 
[06:35] <mvo> and good morning mardy too :)
[06:36] <mardy> mborzecki: I'm not sure how the LTO idea translates to golang, but let me ask a more concrete question: I've added a method here: https://github.com/mardy/snapd/blob/access-portal/usersession/client/client.go#L297-L332
[06:37] <mardy> one possibility is to have this method be called by a separate process, not snapd itself
[06:38] <mardy> now, it would be a bit unlucky if this process, which does not need to know anything about systemd services and other snapd features, had to carry in its binary the code for serviceControlCall() and all of its depending bits
[06:39] <mardy> (though, as a matter of fact, it seems that this particular package does not have many deps in systemd, so in this case it might be quite an acceptable situation)
[06:40] <mardy> s/systemd/snapd/
[06:40] <mup> PR snapd#10685 closed: many: fix run-checks gofmt check  <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10685>
[06:40] <mup> PR snapd#10698 opened: wrappers: fix a bunch of duplicated service definitions in tests <Simple 😃> <Skip spread> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10698>
[06:41] <mborzecki> miguelpires: mvo: pstolowski: hey
[06:42] <mvo> hey mborzecki 
[06:42] <mborzecki> mardy: i suppose easiest solution is to build a minimal program and inspect what symbols show up inside, otoh if it's that minimal than runtime and net/http will take up most of the size, + that magical line/symbol lookup table that go generates, i would not expect anything smaller than 3-4MB really :P
[06:43] <miguelpires> @mvo a bit, I look like =.= 
[06:43] <miguelpires> hi mborzecki
[06:48] <mborzecki> mvo: https://github.com/snapcore/snapd/pull/10634 looks mostly happy
[06:48] <mup> PR #10634: many: move to go modules gradually  <⛔ Blocked> <Created by mvo5> <https://github.com/snapcore/snapd/pull/10634>
[06:51] <mborzecki> mvo: shall we dropped the blocked label then? :)
[06:52] <mvo> mborzecki: \o/ !!! yes
[06:52] <mvo> miguelpires: haha
[07:17] <zyga-mbp> good morning :)
[07:18] <zyga-mbp> hey mardy, mborzecki, mvo and miguelpires :)
[07:19] <pstolowski> hey zyga-mbp 
[07:25] <mborzecki> meh, the remodel code for generating tasks is pretty hairy now
[07:25] <mvo> good morning zyga-mbp 
[07:39] <sil2100> Hello snapd! 
[07:39] <sil2100> So I wanted to finally release snapd 2.51.1 into -updates for all the stable series
[07:39] <sil2100> Sadly, focal constantly FTBFS on riscv64
[07:39] <sil2100> https://launchpad.net/ubuntu/+source/snapd/2.51.1+20.04/+build/21701922
[07:39] <sil2100> I think I already retried the build like 3 times
[07:46] <pstolowski> sil2100: hi, looks like a flaky test (managers_test.go:3522: mgrsSuite.TestUpdateManyWithAutoconnect - "Settle is not converging"), i'll see if I can find something or reproduce locally in a moment
[08:00] <mup> PR snapd#10699 opened: daemon: allow enabling enforce mode <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10699>
[08:10] <mborzecki> heh and that case of new kernel or base being already installed during remodel was compeltely untested, fun
[08:12] <pstolowski> it seems 3s settle timeout in this test (scaled to 18s on riscv64) may not be enough (a few lines down we've another settle but with much greater timeout  - 6*45s on riscv64)
[08:14] <pstolowski> i can bump it, but 2.51.1 is only tagged (not branched, but we have 2.51 branch covering up to .7), so not sure what to patch for?
[08:14] <pstolowski> mvo ^ ?
[08:16] <mvo> pstolowski: in a meeting, sry, will get back to you 
[08:23] <mborzecki> pstolowski: hm i see all tags up to 2.51.7?
[08:24] <mvo> mborzecki: could you please set "security-high" on 10661 once the feedback from alberto/ian is adressed? I would love to get it (more) ready :)
[08:25] <mborzecki> mvo: will do, wanted to finish the uc20 remodel since it's very close now
[08:30] <pstolowski> mborzecki: yes, tags are there, but can a branch target a tag?
[08:33] <mvo> mborzecki: totally fine, sorry for being pushy
[08:36] <pstolowski> it doesn't seem possible to target a tag with a PR (which makes sense), so i guess we would need a proper 2.51.1 branch 
[08:41] <mvo> pstolowski: let's talk in some minutes, I need a bit more context I think
[08:45] <mup> PR snapd#10700 opened: tests: use host-scaled timeout to avoid riscv64 test failure <Simple 😃> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10700>
[08:46] <pstolowski> mvo: we need this tweak ^ (here: for master), but for 2.51.1 which FTBFS on riscv64 now, see above what sil2100 reported
[08:50] <mup> PR snapd#10701 opened: many: remove unused parameters <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10701>
[08:51] <mvo> pstolowski: I see, I can handle this, no worries, we will do a 2.51.1+20.04ubuntu1 or something equally nice outside for the git repo by just applying the patch
[08:52] <pstolowski> ok, great
[09:29] <mardy> stgraber: I'm getting this error when running `snapcraft --use-lxd`: An error occurred with the instance when trying to launch with 'LXD': Failed creating instance from image: Failed to run: zfs clone lxd/images/e076b3174006b985a6298feb03d74f565be43d1f3df21b530a31c8372f6c27be@readonly lxd/containers/snapcraft-snapd: cannot create 'lxd/containers/snapcraft-snapd': dataset already exists.
[09:53] <mardy> removing (with --purge) the lxd snap and reinstalling it helped
[10:23] <sil2100> pstolowski: thanks!
[10:24] <sil2100> In the meantime I'll try rebuilding the existing package again, maybe the flacky test will pass this time - since I'd like to unblock snapd releases ASAP
[10:29] <pstolowski> sil2100: i hope my fix solves it. the 3s timeout we had was very aggressive for riscv64, in other places it was 270s (!) with a comment saying that riscv64 builder is 5x slower than armhf
[10:44] <mborzecki> hmm gcc -fanalyzer does not like g_assert_nonull() and concludes it will not stop the program execution
[10:49] <mborzecki> and clang-analyzer isn't coping with the cleanup attribute too well? eh
[11:04] <sil2100> pstolowski: wow, 3s? Yeah, that sounds like a bad idea for riscv64 machines that are generally quite slow
[11:11] <mup> PR snapd#10702 opened: interfaces: introduce snap-refresh-control interface <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10702>
[11:18] <pstolowski> woah, i didn't know we have "Missing high-level test for interface 'snap-refresh-control'. Please add to: ..." test check
[11:19] <pstolowski> nice touch
[11:49] <mup> PR snapcraft#3577 opened: cli: add experimental --offline option (CRAFT-480) <Created by cjp256> <https://github.com/snapcore/snapcraft/pull/3577>
[12:12] <mardy> what do you think of this way of mocking systemd? https://github.com/mardy/snapd/commit/0a524128abd3021f98e6ed1a66d1e1ecd26f0ea0
[12:26] <mup> PR snapd#10703 opened:  tests/main/security-device-cgroups-strict-enforced: demonstrate device cgroup being enforced <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10703>
[12:42] <mardy> feedback very welcome: https://github.com/snapcore/snapd/pull/10704
[12:42] <mup> PR #10704: systemd: add fake type for easier mocking of systemd functions <Created by mardy> <https://github.com/snapcore/snapd/pull/10704>
[12:46] <mup> PR snapd#10704 opened: systemd: add fake type for easier mocking of systemd functions <Created by mardy> <https://github.com/snapcore/snapd/pull/10704>
[13:09] <mvo> PR 10634 now needs reviews, it seems to be ready finally
[13:09] <mup> PR #10634: many: move to go modules gradually  <Created by mvo5> <https://github.com/snapcore/snapd/pull/10634>
[13:18] <ares1925> hi
[13:19] <ares1925> i am trying to setup up can adapter mcp2518fd on spi6
[13:19] <ares1925> so i wrote an overlay for it
[13:19] <ares1925> but i cant find what the issue is in this
[13:19] <ares1925>  * Device tree overlay for mcp251x/mcp2518fd on spi0.0
[13:19] <ares1925>  */
[13:19] <ares1925>     compatible = "brcm,bcm2835", "brcm,bcm2836", "brcm,bcm2708", "brcm,bcm2709";
[13:19] <ares1925>     /* disable spi-dev for spi3.0 */
[13:19] <ares1925>     fragment@0{
[13:19] <ares1925> 	target = <&spidev3>;
[13:19] <ares1925> 	__overlay__ {
[13:19] <ares1925> 	    status = "disabled";
[13:19] <ares1925> 	};
[13:19] <ares1925>     };
[13:19] <ares1925>     /* the interrupt pin of the can-controller */
[13:19] <ares1925>     fragment@2 {
[13:19] <ares1925>         target = <&gpio>;
[13:19] <ares1925>         __overlay__ {
[13:19] <ares1925>             can_int_pins: can_int_pins {
[13:19] <ares1925>                 brcm,pins = <6>;
[13:19] <ares1925>                 brcm,function = <0>; /* input */
[13:19] <ares1925>             };
[13:19] <ares1925> 	    spi6_pins: spi6_pins {
[13:19] <ares1925> 			brcm,pins = <19 20 21>;
[13:20] <ares1925>         target = <&spi6>;
[13:20] <ares1925>         __overlay__ {
[13:20] <ares1925>             /* needed to avoid dtc warning */
[13:20] <ares1925>             #address-cells = <1>;
[13:20] <ares1925>             #size-cells = <0>;
[13:20] <ares1925> 	    cs-gpios = <&gpio 18 1>;
[13:20] <ares1925>  	    status = "okay";
[13:20] <ares1925>             can0: can@0 {
[13:20] <ares1925>                 reg = <0>;
[13:20] <ares1925>                 pinctrl-names = "default";
[13:20] <ares1925>          	pinctrl-0 = <&spi6_pins &spi6_cs_pins>;
[13:20] <ares1925>                 compatible = "microchip,mcp2518fd";
[13:20] <ares1925>                 spi-max-frequency = <20000000>;
[13:20] <ares1925>                 interrupt-parent = <&gpio>;
[13:20] <ares1925>                 interrupts = <6 8>; /* IRQ_TYPE_LEVEL_LOW */
[13:20] <ares1925>                 clocks = <&mcp2518fd_osc>;
[13:20] <ares1925>             };
[13:20] <ares1925> 	};
[13:22] <ares1925> later i want to set it up for ucore too, so first i am trying it on ubuntu server
[13:56] <mup> PR snapd#10698 closed: wrappers: fix a bunch of duplicated service definitions in tests <Simple 😃> <Skip spread> <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10698>
[13:56] <mup> PR snapd#10700 closed: tests: use host-scaled timeout to avoid riscv64 test failure <Simple 😃> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10700>
[13:56] <pstolowski> ares1925: this is a very detailed and low level question that you should probably ask elsewhere (i'm not sure how is it related to snapd and snaps but if you think it is, you may try to ask on the forum along with some more context). also, please don't paste huge snippets like this on irc, use pastebin.ubuntu.com and post links instead
[14:01] <ares1925> ohk sorry
[14:20] <mborzecki> hm so the spread test is happy on a remodel branch commit just before i merged master :/
[14:20] <mborzecki> and master passed too
[14:21] <mup> PR snapd#8926 closed: interfaces: add microstack-support interface <Squash-merge> <:birthday:> <Created by dshcherb> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/8926>
[14:51] <mup> PR snapd#10705 opened: tests: add minimal smoke test for microstack <Created by mvo5> <https://github.com/snapcore/snapd/pull/10705>
[14:55]  * mvo switches network, bbiab
[16:16] <mup> PR snapd#10524 closed: packaging: add libfuse3-dev build dependency <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10524>
[18:02] <mup> PR snapd#10706 opened: tests: clean up test tools <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10706>
[18:25] <mup> PR snapcraft#3566 closed: ROS 2 plugins v2 misc fixes <Created by artivis> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3566>
[19:35] <mup> PR snapcraft#3577 closed: cli: add experimental --offline option (CRAFT-480) <Created by cjp256> <Merged by sergiusens> <https://github.com/snapcore/snapcraft/pull/3577>