[05:08] <mborzecki> morning
[05:50] <mardy> mborzecki, zyga-mbp: hi!
[05:51] <zyga-mbp> good morning, happy Friday and apparently, happy first day of pretty cold mornings :E
[05:51] <zyga-mbp> I was just outside and I can smell the cold again
[05:53] <mborzecki> mardy: zyga-mbp hey
[05:53] <mborzecki> yeah, it is cold in the morning
[05:54] <mborzecki> not really amused about that :/
[05:55] <zyga-mbp> mborzecki yeah, sucky year
[06:03] <pstolowski> morning
[06:05] <mardy> 'morning pstolowski 
[06:05] <mardy> finally someone not complaining about the cold! Must be pretty warm in there ;-)
[06:05] <zyga-mbp> good morning pstolowski :)
[06:06] <mborzecki> pstolowski: hey
[06:08] <mborzecki> another nested test is broken? https://paste.ubuntu.com/p/QYyCqMMQD3/
[06:10] <mborzecki> hmm looking at the test, afaiu it's not possible to for it to pass at this point
[06:18] <mardy> btw, it's still not clear to me the difference between nested tests and normal tests
[06:23] <pstolowski> mardy: in nested tests we create a VM and control it from the test, do checks with nested_exec (which executes ssh -c ... against that vm)
[06:24] <pstolowski> mardy: we use that for tests that wouldn't be possible the normal way; nested have a separate test suite as they need different setup and more powerful hosts to run VM inside
[06:32] <zyga-mbp> mardy in the nested case the system allocated by spread runs another system inside, with a lot more control over what that looks like exactly
[06:32] <zyga-mbp> mardy importantly nested lets you play with TPMs
[06:32] <zyga-mbp> nowadays perhaps more, I'm out of touch
[06:34] <pstolowski> yeah we use them to also test things like seeding a new image and booting it, or simulating usb device plugging/unplugging for hotplug
[06:34] <pstolowski> s/seeding/preseeding/
[06:40] <mborzecki> a trivial fix in https://github.com/snapcore/snapd/pull/10727
[06:40] <mup> PR #10727: tests/nested/core/extra-snaps-assertions: fix the match pattern <Simple 😃> <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10727>
[06:42] <mup> PR snapd#10727 opened: tests/nested/core/extra-snaps-assertions: fix the match pattern <Simple 😃> <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10727>
[07:06] <pstolowski> where do we update base declaration for new interfaces? a snap using the new snap-refresh-control interface is rejected by the store
[07:07] <mvo> pstolowski: can you request manual rview?
[07:07] <mvo> pstolowski: otherwise I think ian can help (I think I can also in theory but I'm a bit reluctant)
[07:07] <pstolowski> mvo: not for this rejection it seems
[07:10] <mvo> pstolowski: what is the snap called?
[07:10] <mvo>  test-snapd-refresh-control ?
[07:10] <pstolowski> mvo: yes
[07:11] <mvo> amurray: is the reject "
[07:11] <mvo> interface 'snap-refresh-control' not found in base declaration declaration-snap-v2_plug_known (snap-refresh-control, snap-refresh-control)
[07:11] <mvo> " and "
[07:11] <mvo> unknown interface 'snap-refresh-control' lint-snap-v2_plugs (snap-refresh-control, snap-refresh-control)
[07:11] <mvo> " something you can help pstolowski  with ? for the test-snapd-refresh-control snap?
[07:12] <pstolowski> amurray: it's for the new interface we landed in snapd recently. https://github.com/snapcore/snapd/pull/10702
[07:12] <mup> PR #10702: interfaces: introduce snap-refresh-control interface <Needs Samuele review> <Refresh control> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10702>
[07:14] <pstolowski> (it's an interface with no actual permissions, so wasn't tagged for you to review)
[07:16] <mborzecki> mvo: hi, can you land https://github.com/snapcore/snapd/pull/10722 ?
[07:16] <mup> PR #10722: tests/nested/manual/refresh-revert-fundamentals: fix variable use <Simple 😃> <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10722>
[07:42] <amurray> mvo pstolowski: hey, yep sure I can help - review-tools needs to be updated to know about this interface... I've just manually approved it for now
[07:43] <zyga-mbp> hey amurray :)
[07:43] <amurray> hey zyga-mbp :)
[07:48] <pstolowski> amurray: awesome, thank you!
[07:49] <mvo> thanks amurray !
[07:57] <pstolowski> mvo:  do you know the PR# that reverted time sync change?
[07:58] <mborzecki> mv
[07:58] <mborzecki> mvo: can you take a look at https://github.com/snapcore/snapd/pull/10661 ?
[07:58] <mup> PR #10661: cmd/libsnap-confine-private: device cgroup v2 support <Complex> <Security-High> <Needs security review> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10661>
[07:58] <mborzecki> it's probab a bit more complex than the usual stuff, but it'd be great to have another review form our team before amurray does a pass
[07:59] <mborzecki> also it's better if more people are even remotely familiar with this stuff, you know, bus factor and all
[07:59] <zyga-mbp> mborzecki I'll have a look as well
[07:59] <zyga-mbp> but please allow for one day over weekend
[08:00] <zyga-mbp> so that I really read and look at the details
[08:00] <zyga-mbp> it's not something I can promise today
[08:00] <amurray> mborzecki: I was looking at that a bit earlier today :) - sorry I haven't had time yet to really dig into it - I want to give it a decent look to make sure I understand the BPF filter etc too
[08:00] <amurray> hopefully early/mid next week though I should get to it proper
[08:02] <mborzecki> amurray: that's great, let me know if you have any questions or would like to discuss the PR
[08:04] <amurray> mvo pstolowski: I have granted the snap declaration for use of snap-refresh-control to test-snapd-refresh-control - and once https://code.launchpad.net/~alexmurray/review-tools/+git/review-tools/+merge/408065 lands and review-tools on the store is updated then it should pass review automatically
[08:05]  * amurray is reminded again how getting some CI setup to warn on missing snapd interfaces in review-tools would be very useful...
[08:06] <pstolowski> amurray: thank you!
[08:11] <amurray> pstolowski: should snap-refresh-control be auto-connected as well for test-snapd-refresh-control?
[08:17] <pstolowski> amurray: no, it's fine as is
[08:21] <amurray> ok no worries
[08:23] <mborzecki> mvo: can you land https://github.com/snapcore/snapd/pull/10727 ?
[08:23] <mup> PR #10727: tests/nested/core/extra-snaps-assertions: fix the match pattern <Simple 😃> <Run nested> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10727>
[08:29] <mvo> mborzecki: sure, let me do that
[08:32] <mup> PR snapd#10727 closed: tests/nested/core/extra-snaps-assertions: fix the match pattern <Simple 😃> <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10727>
[08:48] <pstolowski> https://github.com/snapcore/snapd/pull/10725 is now ready for review and should pass with the updated test-snap-refresh-control snaps in the store
[08:48] <mup> PR #10725: o/hookstate: require snap-refresh-control interface for snapctl refresh --proceed <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10725>
[08:53] <mup> PR snapd#10728 opened: ifacestate: undo repository connection if doConnect fails <Created by mvo5> <https://github.com/snapcore/snapd/pull/10728>
[08:54] <pstolowski> mvo:  do you know the PR# that reverted time sync change?
[09:01] <mvo> pstolowski: #110 iirc
[09:01] <mup> PR #110: introduce AccountKey, support decoding it and validation <Created by pedronis> <Merged by chipaca> <https://github.com/snapcore/snapd/pull/110>
[09:18] <mvo> pstolowski: https://github.com/snapcore/core20/pull/110 to be precise
[09:18] <mup> PR core20#110: hooks: revert PR#105 - it seems to  <Created by mvo5> <Merged by xnox> <https://github.com/snapcore/core20/pull/110>
[10:13] <mborzecki> hm wonder why `mknod /dev/fb0 c 29 0` sometimes fails with EPERM
[10:24] <zyga-mbp> mborzecki sometimes?
[10:24] <zyga-mbp> is that in CI?
[10:24] <mborzecki> zyga-mbp: yeah
[10:24] <zyga-mbp> hmm, that's weird
[10:24] <zyga-mbp> does sleep 5 help?
[10:29] <zyga-mbp> I wonder if you are racing with something like udev
[10:38] <mborzecki> zyga-mbp: it's mknod, so the error may come from devtmpfs, but why? it's not like it's checking for actual device support, I can mknod /dev/nvidiactl with the right major:minor and it does not error even though i don't have nvidia card
[10:38] <zyga-mbp> hmm
[10:38] <zyga-mbp> I'd look at the source at this stage
[10:41] <mborzecki> zyga-mbp: i'll probably will, but remodel first, our code for generating tasks for remodel is real hairy :/
[10:41]  * zyga-mbp hugs mborzecki 
[10:41] <zyga-mbp> better put off the yak shaving for spring 
[11:48] <mup> PR snapd#10729 opened: codecov: fix files pathnames <Created by mardy> <https://github.com/snapcore/snapd/pull/10729>
[12:16] <mardy> here's a super-easy one to review ^ :-)
[13:23] <zyga-mbp> mardy approved
[13:34] <mborzecki> mardy: fyi there's a 'skip spread' label that you can add to a PR so that spread tests will not be executed
[13:35] <mborzecki> miguelpires: ^^ also :)
[13:47] <miguelpires> thanks :)
[14:05] <mardy> mborzecki: ah, right, but I guess it's too late now
[14:29] <mup> PR snapd#10726 closed: systemd: add mock systemd helper <Squash-merge> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10726>
[14:29] <mup> PR snapd#10729 closed: codecov: fix files pathnames <Simple 😃> <Created by mardy> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10729>
[15:54] <mup> PR snapd#10730 opened: strutil: add Intersection() <Simple 😃> <UC20> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10730>
[15:59] <mup> PR snapd#10731 opened: sysconfig/cloudinit: add cloudDatasourcesInUseForDir <Needs Samuele review> <UC20> <Skip spread> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10731>
[16:19] <mup> PR snapd#10732 opened: tests/lib/nested.sh: split out additional helper for adding files to VM imgs <Simple 😃> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10732>
[16:28] <mup> PR core20#112 closed: doc: add instructions on enabling bootcharts <Created by alfonsosanchezbeato> <Merged by alfonsosanchezbeato> <https://github.com/snapcore/core20/pull/112>
[16:37] <LedHed> good morning,  I'm new to Ubuntu Core, wondering how I can check if Full Disk Encryption is enabled?  I ran: snap model --verbose and the grade came back as "signed".  My understanding is that "signed" means Encrypted (if its on supported hardware) and unencrypted otherwise.  How can I confirm whether the device has 'hardware support'?
[16:38] <LedHed> Or even better would be a command to show the FDE status?
[16:57] <ijohnson[m]> LedHed: one easy way to check if you have a shell on the device is to do `ls /dev/disk/by-partlabel/ | grep enc` if that shows you some files then your device is encrypted successfully
[16:57] <ijohnson[m]> but yeah we really have been meaning to add some command to check this easily but haven't done it quite yet
[17:20] <LedHed> ijohnson[m], thanks that worked.  Or at lease I think it did,  no files returned so safe to assume no encryption.
[17:21] <LedHed> Is there a way to enable encryption for unsupported hardware? maybe by creating a custom image or hardware assertion?
[17:22] <LedHed> The hardware appears to have everything necessary to be supported,  Secure Boot, and TPM
[18:39] <mup> PR snapd#10670 closed: tests:  new snapd-state tool <Created by sergiocazzolato> <Merged by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10670>
[19:24] <mup> PR snapd#10580 closed: interface/builtin: add qualcomm-ipc-router interface for AF_QIPCRTR socket protocol <Squash-merge> <Needs Samuele review> <Created by tsunghanliu> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10580>
[19:24] <mup> PR snapd#10723 closed: o/ifacestate: special-case system-files and force refreshing its static attributes <Squash-merge> <Bug> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10723>
[19:29] <mup> PR snapd#10721 closed: interface/builtin: add qualcomm-ipc-router interface for AF_QIPCRTR socket protocol (2.52) <Created by mvo5> <Closed by mvo5> <https://github.com/snapcore/snapd/pull/10721>
[19:29] <mup> PR snapd#10733 opened: interface/builtin: add qualcomm-ipc-router interface for AF_QIPCRTR socket protocol (2.52) <Created by mvo5> <https://github.com/snapcore/snapd/pull/10733>
[19:52] <ijohnson[m]> hey cachio (or cachio_ ) have you seen this before ? https://pastebin.ubuntu.com/p/GMpz86YFFp/
[19:53] <cachio> ijohnson[m], yes, I think maciej fixed it
[19:53] <ijohnson[m]> or this one: https://pastebin.ubuntu.com/p/FCtxpq8Xbd/ ?
[19:54] <ijohnson[m]> cachio: nice
[19:54] <cachio> there was a pr for that 
[19:54] <ijohnson[m]> I think the second one has something to do with not stopping fakedevicesvc in some other test
[19:54] <cachio> it should be on master
[19:54] <ijohnson[m]> hmm, I saw it here on master: https://github.com/snapcore/snapd/pull/10732
[19:54] <mup> PR #10732: tests/lib/nested.sh: split out additional helper for adding files to VM imgs <Simple 😃> <Run nested> <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10732>
[20:55] <mup> PR snapd#10733 closed: interface/builtin: add qualcomm-ipc-router interface for AF_QIPCRTR socket protocol (2.52) <Created by mvo5> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10733>
[21:10] <mup> PR snapd#10734 opened: release: 2.52 <Created by anonymouse64> <https://github.com/snapcore/snapd/pull/10734>
[23:15] <mup> PR snapd#10734 closed: release: 2.52 <Created by anonymouse64> <Merged by anonymouse64> <https://github.com/snapcore/snapd/pull/10734>