[05:59] <mborzecki> morning
[06:01] <mardy> mborzecki: 'morning!
[06:02] <mborzecki> mardy: heya
[06:27] <pstolowski> morning
[06:27] <mborzecki> pstolowski: hey
[06:27] <mardy> pstolowski: hi!
[06:28] <mborzecki> pstolowski: another school day and I already hate it ;)
[06:33] <pstolowski> mborzecki: haha
[06:41]  * mardy going to be afk for 45 mins or so
[06:43] <zyga-mbp> good morning guys!
[06:43] <zyga-mbp> mborzecki oh, what's going on?
[06:49] <mup> PR snapd#10730 closed: strutil: add Intersection() <Simple 😃> <UC20> <Skip spread> <Created by anonymouse64> <Merged by bboozzoo> <https://github.com/snapcore/snapd/pull/10730>
[07:14] <mup> PR snapd#10722 closed: tests/nested/manual/refresh-revert-fundamentals: fix variable use <Simple 😃> <Run nested> <Created by bboozzoo> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10722>
[07:44] <mup> PR snapd#10243 closed: tests: failure of prereqs on content interface doesn't prevent install <Skip spread> <Created by stolowski> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10243>
[07:47] <sil2100> mvo, pstolowski: hey guys! Is there any progress in the snapd riscv64 build failure on focal?
[07:50] <pstolowski> sil2100: hi, there was one bump-timeout tweak (i think you saw that PR last week). the 2nd issue of test exceeding 10m (causing panic from go test) is unclear, is that one reproducible?
[08:06] <mvo> sil2100, pstolowski we could as a temporary workaround simply disable unit tests on riscv for this one upload
[08:10] <sil2100> mvo, pstolowski: yeah, or like skipping the ones that time-out/flaky-fail for one upload - since I just wouldn't want to suddenly drop this arch
[08:15] <mborzecki> hm snap keys suite keeps failing on obs due to gpg, we also see it occasionally on github
[08:16] <pstolowski> sil2100: i can prepare a PR to skip them, let's hope it doesn't fail on another test after that ;)
[08:37] <pstolowski> sil2100, mvo : https://github.com/snapcore/snapd/pull/10736 should do it
[08:37] <mup> PR #10736: tests: skip overlord tests on riscv64 due to timeouts <Created by stolowski> <https://github.com/snapcore/snapd/pull/10736>
[08:38] <mvo> pstolowski: nice
[08:39] <mup> PR snapd#10736 opened: tests: skip overlord tests on riscv64 due to timeouts <Created by stolowski> <https://github.com/snapcore/snapd/pull/10736>
[08:52] <mborzecki> zyga-mbp: trivial update https://build.opensuse.org/request/show/917012
[09:03] <mborzecki> mvo: hi, do you think you could take a look at https://github.com/snapcore/snapd/pull/10661 ?
[09:03] <mup> PR #10661: cmd/libsnap-confine-private: device cgroup v2 support <Complex> <Security-High> <Needs security review> <cgroupv2> <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10661>
[09:03] <zyga-mbp> mborzecki looking
[09:04] <zyga-mbp> mborzecki done
[09:04] <zyga-mbp> mborzecki I failed to do the review over weekend, a bit too much stuff with the kitchen
[09:04] <zyga-mbp> mborzecki I can look in the evening today
[09:07] <mborzecki> zyga-mbp: that's fine, youre under no obligation to look at it 😉 it's already very courteous of you to take a look at some of the PRs anyway
[09:07] <zyga-mbp> mborzecki that's one very close to heart and I really want to dig into iot
[09:07] <zyga-mbp> into it*
[09:11] <mborzecki> zyga-mbp: i guess iot is close to your heart too ;)
[09:11] <zyga-mbp> hehe
[09:11] <zyga-mbp> yes
[10:14] <mup> PR snapd#10737 opened: o/snapstate: validation sets enforcing on update <Needs Samuele review> <validation-sets :white_check_mark:> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10737>
[10:57] <mborzecki> crappy fault injection in snapd: https://paste.ubuntu.com/p/QBw4wzY9KS/
[10:58] <mborzecki> a fun feature, one can inject faults per specific snap name
[11:04] <pstolowski> mborzecki: nice! how does it work?
[11:05] <mborzecki> pstolowski: you set SNAPPY_TESTING=1 (as done in the tests) and then SNAPD_FAULT_INJECT=<tag>:<kind>[,<tag>:<kind>]
[11:05] <mborzecki> kind is 'panic' (which calls panic()) or 'reboot' which does echo b > /proc/sysrq-trigger
[11:06] <zyga-mbp> mborzecki nice
[11:06] <zyga-mbp> mborzecki how about error?
[11:06] <mborzecki> tag is free form, in the code you only place a call osutil.MaybeInjectFault("link-snap")
[11:06] <zyga-mbp> that might help with testing undo
[11:06] <mborzecki> hm worth trying, tbh only have panic and reboot right now, that's for the extreme scenarios
[11:07] <zyga-mbp> it might replace the special hacks done in unit tests as well
[11:07] <mborzecki> and right before a fault is injected, thre's a stamp file left under /var/lib/snapd/fault/<tag>:<kind>
[11:07] <zyga-mbp> with snap names that encode failure
[11:09] <mborzecki> zyga-mbp: yeah, the tag is free form text so you can add osutil.MaybeInjectFault(fmt.Sprintf("link-snap@%s", snapName)) and then SNAPD_FAULT_INJECT=link-snap@hello-world:reboot :P
[12:17] <pstolowski> mborzecki: wdyt about https://github.com/snapcore/snapd/pull/10736#discussion_r702724230 ? i'm mostly thinking about making it as easy as possible for the builders right now, so sil2100 doesn't have to introduce flags elsewhere
[12:17] <mup> PR #10736: tests: skip overlord tests on riscv64 due to timeouts <Simple 😃> <Skip spread> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10736>
[12:20] <mup> PR snapd#10738 opened: [RFC] o/hookstate/ctlcmd: Implement snapctl refresh --show-inhibit-lock command <Needs Samuele review> <Refresh control> <Created by stolowski> <https://github.com/snapcore/snapd/pull/10738>
[12:25] <mup> PR snapd#10739 opened: mount-control: step 2 <Created by mardy> <https://github.com/snapcore/snapd/pull/10739>
[12:35] <mup> PR snapd#10740 opened: osutil: helper for injecting run time faults in snapd  <Created by bboozzoo> <https://github.com/snapcore/snapd/pull/10740>
[12:50] <mvo> mborzecki: I need to look at your cgroups v2 yes, will see if I can do it this afternoon, I spend a bit of time this morning to get netplan ready :/
[13:49] <miguelpires> mvo, can you merge https://github.com/snapcore/snapd/pull/10701 please?
[13:49] <mup> PR #10701: many: remove unused parameters <Needs Samuele review> <Created by MiguelPires> <https://github.com/snapcore/snapd/pull/10701>
[13:55] <mvo> miguelpires: sure
[14:00] <mup> PR snapd#10701 closed: many: remove unused parameters <Needs Samuele review> <Created by MiguelPires> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10701>
[16:15] <mup> PR snapd#10741 opened: interfaces/block-devices: support to access the state of block devices <Created by woodrow-shen> <https://github.com/snapcore/snapd/pull/10741>
[18:36] <mup> PR snapd#10728 closed: ifacestate: undo repository connection if doConnect fails <Created by mvo5> <Merged by mvo5> <https://github.com/snapcore/snapd/pull/10728>
[19:26] <mup> PR snapd#10742 opened: tests: update nested tool - part1 <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10742>
[21:46] <mup> PR snapd#10743 opened: tests: fix fakedevicesvc service already exists <Run nested> <Created by sergiocazzolato> <https://github.com/snapcore/snapd/pull/10743>
[22:38] <hiparco> kdenlive snap is unusable on my machine once I can't really render any video
[22:40] <hiparco> running with snap run kdenlive, it states a missing library